D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Btw., have you perhaps played a bit with the https://phabricator.kde.org/D12295 patch? No, but noticed it sometime in the past > If you use it, could you try that patch, too? Will try it REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. I am a bit confused which questions still need answers ;=) What I think about the current state of the patch: I am fine with it, beside that I think having the dictionary picker per default there takes to much space and one should have some "show XXX" in

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48237. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - All in one diff - Rebased on master - Removed test plan - Will update Summary/Title before you commit

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48236. loh.tar edited the summary of this revision. loh.tar added a comment. - Only show lineColLabel context menu when click on it and not somewhere on the bar As "usual" without all other patches. > No idea how the spell-checking code handles

D16643: Correct the accept flag of the event object on DragMove

trmdi edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17812: Clean up tests build system

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17812 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17730: [WIP] Review KateStatusBar (based on D17729)

zetazeta added a comment. I don't know if it should be done in this revision but... I find it annoying that the status bar imposes a limit on the minimum width of the window. Let's say that I want a really small (20 chars width) instance of kwrite for note taking always on top - it

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 26 Dec 2018 21:54:56 + Build duration: 6 min 23 sec and counting BUILD ARTIFACTS

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. Btw., I have not played with the latest patch yet, but for the binary compatibility stuff: Nothing outside the KTextEditor:: namespace needs to be binary compatible. We don't install headers for these classes, they are just exported for the unit tests.

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Makes sense, will push that after you fix the documentation for the other patch, thanks! REPOSITORY R39 KTextEditor BRANCH fix-ontheflycheck-backgroundchecker REVISION DETAIL

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

cullmann added a comment. I think the idea makes sense, thought I have no idea if the change in the updateView part is correct ;=) Others? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg Cc: cullmann, kwrite-devel,

D17128: DocumentPrivate: Remove comment mark when joining lines

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. As said above, I think some "smart wrap" option and that can be used for it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 26 Dec 2018 21:22:59 + Build duration: 31 min and counting BUILD ARTIFACTS

D17609: KTextEditor: Add action for static word wrap

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3a7a2d1ca986: KTextEditor: Add action for static word wrap (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17609: KTextEditor: Add action for static word wrap

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Why not ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: cullmann, abetts, kwrite-devel,

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

cullmann added a comment. I have no issues with freeing Fx keys. But perhaps we should think about that then in a more extended way: Do we really need Fx shortcuts at all for showing the left border stuff? People can add them and actually I would assume you once configure that and be

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

cullmann added a comment. Last commit was for https://phabricator.kde.org/D17567 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17733 To: loh.tar, #ktexteditor, #vdg, ngraham Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. In D17730#381237 , @loh.tar wrote: > > My main intent is to add somehow a spell check button/hint > > Here a snapshot how it looks currently > F6503235: 1545570321.png >

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2c70c2184d70: ViewPrivate: Dont hide Clear Dictionary Ranges action (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17629: Add method to BackgroundChecker to add word to session

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The old API is lacking docs, too, but could we have some doxygen comment for this with some @since version, too? Thanks. REPOSITORY R246 Sonnet REVISION DETAIL

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

cullmann added a comment. Btw., have you perhaps played a bit with the https://phabricator.kde.org/D12295 patch? I tried it once and it did behave ok, but I don'T use that feature that often. If you use it, could you try that patch, too? REPOSITORY R39 KTextEditor REVISION DETAIL

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5dde33b16bca: KateStatusBar: Reformatted by astyle command to follow coding style (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I am fine with that. Actually, if there is a astyle commandline that enforces the right style, could you paste it here? I am in favor of some script that runs that over the repo and

D17812: Clean up tests build system

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY No need to search for ECM here again, and nothing in here needs Qt5::Test either. REPOSITORY R289 KNotifications

D17808: Don't force Phonon on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:4b551eb9d5ee: Dont force Phonon on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17808?vs=48219=48226 REVISION DETAIL

D17802: Hide API documentation of internal classes

dhaumann added a comment. Another solution is to mark the class @internal. It is still visible then on api.kde.org, though. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17802 To: vkrause, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham,

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. A lot of folks are probably out on vacation, BTW. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. What will happen if @bruns doesn't want to reply here anymore? I've updated the patch, can you review it ? @broulik REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: anthonyfieroni,

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/1/ Project: kf5-qt5 AndroidQt5.11 Date of build: Wed, 26 Dec 2018 14:18:32 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated 15

D17808: Don't force Phonon on Android

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17808 To: vkrause, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17808: Don't force Phonon on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The only notification backend that really makes sense on Android is using the native notification system, not our own

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48218. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. arc diff verbatim REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48217=48218 BRANCH addWordToSession REVISION DETAIL

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48217. ahmadsamir added a comment. Fix commit message REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=47683=48217 BRANCH addWordToSession REVISION DETAIL https://phabricator.kde.org/D17629 AFFECTED

D17802: Hide API documentation of internal classes

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e3d07cec0b6f: Hide API documentation of internal classes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17802?vs=48202=48216

D17802: Hide API documentation of internal classes

vkrause added a comment. This is about classes like https://api.kde.org/frameworks/knotifications/html/classNotifyByPopupGrowl.html. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17802 To: vkrause, dhaumann Cc: dhaumann,

D17802: Hide API documentation of internal classes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. A bit more verbose description on why this patch is needed and a link to the generated page on api.kde.org would be useful :) PS: KTextEditor also shows hundreds of classes that