D17816: Initial support for xattrs on kio copy/move

cochise updated this revision to Diff 48384. cochise added a comment. As using qDebug supressed the error, I changed to qCWarning and managed to track the memory corruption. On my system, after getting the list of keys on source file, the local variable holding this file path gets corrupted.

D17817: Build without D-Bus on Android

bcooksley added a comment. Android CI builds are only enabled for the following repositories: - "frameworks/extra-cmake-modules" - "frameworks/karchive" - "frameworks/attica" - "frameworks/breeze-icons" - "frameworks/kcodecs" - "frameworks/kconfig" - "frameworks/k

D17851: Add Android notification backend

apol added a comment. This looks really cool! I'd say let's get this in and we can iterate from here if needed. Maybe it would be useful to have builds of a test application? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17851 To: vkrause Cc: apol, nic

D17856: Fix a regression introduced in 6a1852

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH fixutf8 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17856 To: vandenoever, dfaure, arichardson, apol, aacid, ngraham Cc: kde-frameworks-devel, michaelh, ngr

D17855: Don't rely on the Plasma workspace integration on Android

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17855 To: vkrause, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17817: Build without D-Bus on Android

apol added a comment. In D17817#383403 , @vkrause wrote: > In D17817#383354 , @dhaumann wrote: > > > +1, although it will likely break quickly since this branch is not tested via CI. Then again, thi

D17816: Initial support for xattrs on kio copy/move

cochise updated this revision to Diff 48380. cochise added a comment. Refactored to a function, works on all use cases. Data corruption remains Summary: Found the place to put the call for files and directories on copyjob.cpp. Reverted almost all changes in file_unix, except a fix for

D17863: Add ecm_check_linker_flags function

tcberner added a comment. See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner created this revision. tcberner added reviewers: FreeBSD, dfaure, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY kstars appends '-Wl,-z,nodump' to the

D17730: [WIP] Review KateStatusBar

cullmann added a comment. Ok, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48374. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix remaining signal/slot, Thanks for the hint! :-) > Beside that, I tried the patch, the status bar looks nice ;=) :-) > I would have no issue

D17851: Add Android notification backend

nicolasfella added a comment. By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require adding the appropriate jar to the build. REPOSITORY R289 KNotifications REVISION DETA

D17623: Add YaST and new preference icons

ngraham added a comment. Found one more issue: By creating a new version of `preferences-system` that looks different from the existing version, System Settings gets the wrong icon: F6515130: Screenshot_20181229_124318.png F6515133: Screenshot_

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

anthonyfieroni added inline comments. INLINE COMMENTS > katepart5ui.rc:2 > > > Increase version REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-f

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. For me, too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katesearchbar.h:221-227 > You cannot add new members as well, they change object size. Since this class > not use pimpl idiom it will be harder to change anything in header except to > add new non-virtual functions. This

D17730: [WIP] Review KateStatusBar

cullmann added a comment. Beside that, I tried the patch, the status bar looks nice ;=) Your idea to replace the labels with buttons is a good one. I would have no issues to merge this as is (perhaps after you cleanup the 2 connects and have additional stuff like "configurable: show

D17730: [WIP] Review KateStatusBar

cullmann added a comment. connect(m_view->doc(), &KTextEditor::DocumentPrivate::modifiedOnDisk, this, &KateStatusBar::modifiedChanged); connect(m_view->doc(), &KTextEditor::DocumentPrivate::configChanged, this, &KateStatusBar::documentConfigChanged); should do the trick, as doc() has t

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 19:13:33 + Build duration: 6 min 3 sec and counting BUILD ARTIFACTS compat_repo

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c287d3858fd7: ViewConfig: Add 'Dynamic Wrap At Static Marker' option (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I played with it, it seems to work reasonable well. Lets give this patch a try ;=) Its optional, if people get issues, we can try to fix them later. (I have seen no ones myself) REP

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at aned of file

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when 'Allow scrolling past the end of the document' is set

D17015: Fix the Qt doc creation with Qt 5.12.

thiago added a comment. qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip the .0 release and upgrade. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17015 To: cgiboudeaux, kossebau Cc: thiago, tcberner, kde-frameworks-devel, kd

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 18:23:43 + Build duration: 4 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/101/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 29 Dec 2018 18:23:43 + Build duration: 4 min 29 sec and counting JUnit Tests Name: (root) F

D17692: Add a proper python-bytecode icon, use consistent color in python icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6baded2e1df4: Add a proper python-bytecode icon, use consistent color in python icons (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE htt

D17692: Add a proper python-bytecode icon, use consistent color in python icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks perfect! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17692 REVISION DETAIL https://phabricator.kde.org/D17692 To: trickyricky26, #vdg, ngraham Cc: ngraham, kde-frameworks-

D17856: Fix a regression introduced in 6a1852

vandenoever added reviewers: dfaure, arichardson, apol, aacid, ngraham. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17856 To: vandenoever, dfaure, arichardson, apol, aacid, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Sure. It's here https://phabricator.kde.org/D17856 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17856: Fix a regression introduced in 6a1852

vandenoever created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vandenoever requested review of this revision. REVISION SUMMARY Bytes from 'Strings' of type GroupString and KeyString should not be escaped because they are valid UTF-8. Onl

D17651: Escape bytes that are larger than or equal to 127 in config files

ngraham added a comment. Can you submit that patch using Phabricator? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Here is a patch that solves the problem: diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp index 39e5936..b674973 100644 --- a/src/core/kconfigini.cpp +++ b/src/core/kconfigini.cpp @@ -673,7 +673,12 @@ QByteArray KConfigIniBackend

D17692: Add a proper python-bytecode icon, use consistent color in python icons

trickyricky26 updated this revision to Diff 48361. trickyricky26 added a comment. Rebase on master to work around Pahbricator bug with symlinks. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17692?vs=48358&id=48361 BRANCH arcpatch-D17692 REVISION

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 16:36:27 + Build duration: 12 min and counting BUILD ARTIFACTS compat_reports/K

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 16:41:47 + Build duration: 4 min 40 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/100/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 29 Dec 2018 16:41:47 + Build duration: 2 min 28 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 16:29:07 + Build duration: 6 min 1 sec and counting BUILD ARTIFACTS compat_repo

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Found it. This is the failing test. FAIL! : KConfigTest::testEncoding() Compared values are not the same Actual (lines.first()): "[UTF-8:\\xc3\\xb6l]\n" Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"

D17692: Add a proper python-bytecode icon, use consistent color in python icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17692 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17692: Add a proper python-bytecode icon, use consistent color in python icons

trickyricky26 updated this revision to Diff 48358. trickyricky26 added a comment. Use custom shapes for the "0" and "1" in all sizes except `64px`, use a consistent 45° angled line in the "0". REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17692?vs=47

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 29 Dec 2018 15:38:12 + Build duration: 13 min and counting BUILD ARTIFACTS compat_reports/K

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

This revision was automatically updated to reflect the committed changes. Closed by commit R39:332935735994: Don't re-mark words added/ignored to the dictionary as misspelled (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabric

D17855: Don't rely on the Plasma workspace integration on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Instead, add a config file for the default notification types here. REPOSITORY R289 KNotifications BRANCH master

D17629: Add method to BackgroundChecker to add word to session

This revision was automatically updated to reflect the committed changes. Closed by commit R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session (authored by ahmadsamir, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17854: Search for notfication event configuration in qrc resources

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Simplifies deployment, and is particularly needed on Android, which has no concept of shared data or configuration f

D17623: Add YaST and new preference icons

rooty added a comment. +1 for the icons, really nice icons REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: rooty, sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17828: Don't check twice if the icon exists from ::availableSizes

This revision was automatically updated to reflect the committed changes. Closed by commit R302:bc916a6be818: Don't check twice if the icon exists from ::availableSizes (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17828?vs=48273&id=48346#toc REPOSITORY R302 KIconT

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG: 402594 REPOSITORY R39 KTextEditor REVISION DETAIL ht

D17629: Add method to BackgroundChecker to add word to session

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R246 Sonnet BRANCH addWordToSession (branched from master) REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsma

D17816: Initial support for xattrs on kio copy/move

cochise added a comment. In D17816#383421 , @davidedmundson wrote: > Why do we need the code in both CopyJob and File_unix? The code was initially put in file_unix, but testing I found it won't applies to directories, so I put on CopyJob

D17851: Add Android notification backend

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There are probably still many features that aren't properly mapped to Android, but at least the basics work: - te

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir updated this revision to Diff 48336. ahmadsamir added a comment. Add doxygen doc for the new method including @since REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17629?vs=48218&id=48336 BRANCH addWordToSession (branched from master) REVISION

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48334. loh.tar edited the summary of this revision. loh.tar added a comment. - Change to new signal/slot style (Idea how to fix the two missing ones?) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48285&id=48334 REVISION DETAIL https

D17816: Initial support for xattrs on kio copy/move

davidedmundson added a comment. Why do we need the code in both CopyJob and File_unix? INLINE COMMENTS > file_unix.cpp:425 > +#elif defined(Q_OS_MAC) > +ssize_t vallen = listxattr(_src.data(), key, NULL, 0, 0, 0); > +#elif defined(Q_OS_FREEBSD) || defin

D17816: Initial support for xattrs on kio copy/move

davidedmundson added a comment. Relevant autotests need adding REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns