D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18174 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-ruby REVISION DETAIL https://phabricator.kde.org/D18174 AFFECTED

D18164: Review KateGotoBar

cullmann added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katedialogs.cpp:1130 > > you can either cumulatively add the delta values from events until the > > value of 120 is reached > > I don't know what is unclear, it should be 120 not any other value. > > if (object ==

D18164: Review KateGotoBar

anthonyfieroni added inline comments. INLINE COMMENTS > loh.tar wrote in katedialogs.cpp:1130 > > It should be 120, > > Why? Have now read the doc, but without a new insight. > > > also you can have 2 separate delta members > > How and why? > you can either cumulatively add the delta values

D18164: Review KateGotoBar

loh.tar added a comment. I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a KateViewBarLayout. Here shot regarding 'Change label text to be less

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

apol added a comment. +1 to me too. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 20:04:18 + Build duration: 57 sec and counting JUnit Tests Name: projectroot

D18136: kconfig_compiler: delete the assignment operator and copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R237:601faf2ad9d4: kconfig_compiler: delete the assignment operator and copy constructor (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18136?vs=49108=49195#toc REPOSITORY

D18135: KEmailSettings: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R237:78da515c5deb: KEmailSettings: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 19:44:58 + Build duration: 1 min 4 sec and counting JUnit Tests Name:

D18134: KEncodingProber: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R270:d5ffc242950b: KEncodingProber: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

vkrause added a comment. IMHO a good idea, +1. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18136: kconfig_compiler: delete the assignment operator and copy constructor

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D18136 To: aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. I'm very much against such a label, and against the full name. "UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what. However,

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D18134 To: aacid, vkrause Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

ngraham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #frameworks, #dolphin, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY They really help making the code better so it's good to have all applications getting those

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 Jan 2019 19:26:08 + Build duration: 8 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 10 Jan 2019 19:26:08 + Build duration: 3 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 19:26:08 + Build duration: 2 min 27 sec and counting JUnit Tests Name:

D18137: delete copy constructor and assignment operator of some public classes

This revision was automatically updated to reflect the committed changes. Closed by commit R244:44b91ba50d2f: delete copy constructor and assignment operator of some public classes (authored by aacid). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D18137: delete copy constructor and assignment operator of some public classes

aacid added a comment. I did some grepping and didn't find anything obvious (which make sense since it would be crashy) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18137 To: aacid, mpyne Cc: mpyne, kde-frameworks-devel, michaelh, ngraham,

D18164: Review KateGotoBar

anthonyfieroni added inline comments. INLINE COMMENTS > katedialogs.cpp:1130 > +// and with my mousepad was the experience also flawlessly > +if (delta > 100) { > +delta = 0; https://doc.qt.io/qt-5/qwheelevent.html#angleDelta It should be 120, also you can have 2

D18164: Review KateGotoBar

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Set minimum value of spin-box to 1 - Don't force minimum

D10716: handle wrong password when using sudo which asks for another password

shubham edited the summary of this revision. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added reviewers: KTextEditor, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D10716#390699 , @jriddell wrote: > - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir What you want

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Otherwise the print preview dialog somehow gets the text color from the current default color

D18038: Fix semantics for ghns_exclude

ngraham added a comment. What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these? Also, the correct formatting is `CCBUG: 402888`. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R304 KNewStuff

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

cfeck created this revision. cfeck added reviewers: Frameworks, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. REVISION SUMMARY **[WIP/RFC] Please let me know if what I propose is sane** UNIX filenames

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc: cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham added a comment. Sorry, I lost track of this after large changes were requested for the dependent patch D17595 . I'll try to get this in for 5.54. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham,

D18125: KateStatusBar: Add dictionary button

ngraham added a comment. If we stay with `en_US`, I'd like to see a label so people know what it is. Otherwise, we should use the long name, because then it becomes obvious. So here are the two options I would approve of: - Dictionary: en_US v - American English v REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. In D17906#389914 , @mart wrote: > I wonder if it shouldn't be something in the future eventually part of the theme, I see things like menu font and toolbar font in fonts kcm as something completely obsolete, while those

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49175. jriddell added a comment. - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49173=49175 BRANCH arcpatch-D10716 REVISION DETAIL

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49173. jriddell added a comment. - write out path to kdesu_stub and su command from the tests to a config rather than setting it within the suprocess class, allows for other testing possibilities and binary relateability REPOSITORY R299 KDESu

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

ngraham added a comment. BTW you still need to correct your `~/.gitconfig` file to have your real name and email address. :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma Cc: cfeck, filipf,

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R236:dc901a1f0b5f: [KWidgetsAddons] Do not use light font styles for headings (3/3) (authored by Krešimir Čohar kco...@gmail.com, committed by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 10 Jan 2019 16:14:51 + Build duration: 11 min and counting BUILD ARTIFACTS

D17906: [kirigami] Do not use light font styles for headings (2/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5d392cb79f9: [kirigami] Do not use light font styles for headings (2/3) (authored by filipf, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 16:14:51 + Build duration: 4 min 18 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 Jan 2019 16:14:51 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS

D17905: [frameworks] Do not use light font styles for headings (1/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fdc912468785: [frameworks] Do not use light font styles for headings (1/3) (authored by filipf, committed by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. Yep, will do. We have other diffs for those. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks, mart Cc: fabianr, rooty, #frameworks,

D17528: Refactor SlaveInterface::calcSpeed

davidedmundson added a comment. I opened a review for documentation purposes: https://phabricator.kde.org/D18158 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17528 To: chinmoyr, dfaure Cc: davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham

D18158: Fix elapsed time check

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY To match the code it was refactored from it should be checking the code since the last time we checked

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > suprocess.cpp:124 > +if (d->testMode) { > +args += QByteArray(CMAKE_RUNTIME_OUTPUT_DIRECTORY) + "/kdesu_stub"; > +} else { This means the path

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49164. jriddell added a comment. - in stub su and sudo use passed argument to find kdesu_stub and in suprocess pass local kdesu_stub for test mode REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49163=49164

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr added inline comments. INLINE COMMENTS > davidedmundson wrote in slaveinterface.cpp:106 > That wasn't there in the old code because it has this guard: > > const qint64 diff = currentTime - d->start_time; > > (effectively calculating elapsed) > > Then > > if (diff - d->last_time >=

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49163. jriddell added a comment. - use locally built kdesu_stub REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49091=49163 BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

apol added inline comments. INLINE COMMENTS > broulik wrote in colorscope.h:134 > Complained with "QSharedPointer: cannot create a QSharedPointer from a > QObject-tracking QWeakPointer" Seems odd. And QSharedDataPointer? http://doc.qt.io/qt-5/qshareddatapointer.html or std::shared_ptr.

D17528: Refactor SlaveInterface::calcSpeed

davidedmundson added inline comments. INLINE COMMENTS > slaveinterface.cpp:106 > +const qint64 elapsed_time = d->elapsed_timer.elapsed(); > +if (elapsed_time >= 900) { > +if (d->transfer_details.count() == max_count) { That wasn't there in the old code because it has this guard:

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik added inline comments. INLINE COMMENTS > apol wrote in colorscope.h:134 > How about using a QSharedPointer? Complained with "QSharedPointer: cannot create a QSharedPointer from a QObject-tracking QWeakPointer" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D17528: Refactor SlaveInterface::calcSpeed

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. We're getting some `SIGFPE` crash reports in this area: Bug 402665 I failed to reproduce them, though. Best is probably to revert this patch because Frameworks release is imminent.

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

apol added inline comments. INLINE COMMENTS > colorscope.h:134 > + > +static Plasma::Theme *s_theme; > +static int s_themeRefCount; How about using a QSharedPointer? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma

D10716: handle wrong password when using sudo which asks for another password

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > su:28 > +self.state = State.GOOD > +call(["/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu_stub"]) > +exit(0) That

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik added a comment. > Now in multi-thread environment will have problems especially on actualTheme(), no? `ColorScope` is QML-only and should be fine? Not sure about `Svg`, it never mentioned being thread-safe. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

anthonyfieroni added a comment. Now in multi-thread environment will have problems especially on actualTheme(), no? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma Cc: anthonyfieroni, kde-frameworks-devel, michaelh,

D17543: [Dialog] Don't alter mainItem's visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b257029afc3b: [Dialog] Dont alter mainItems visibility (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17543?vs=47458=49147#toc REPOSITORY R242 Plasma Framework

D17542: Reset parentItem when mainItem changes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f4bd4a613187: Reset parentItem when mainItem changes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17542?vs=47457=49146

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 10 Jan 2019 11:15:19 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 Jan 2019 11:15:19 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 11:15:19 + Build duration: 2 min 44 sec and counting JUnit Tests

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. so, if this is pushed, the same thing should happen at the same time to the corresponding plasma components REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma,

D17542: Reset parentItem when mainItem changes

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sometimes in the past i had problems about setting parentitem of an item to nullptr, due to all the scenegraph nodes of the item being destroyed and recreated... somewhere else to do

D17543: [Dialog] Don't alter mainItem's visibility

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17543 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17932: Improvements to completion

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. Hey there, sorry for the long delay. In general, I think your suggestions are very sane - most notably preferring exact case matches over fuzzy matches is a good thing to have!

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 10 Jan 2019 09:57:49 + Build duration: 5 min 19 sec and counting JUnit Tests Name:

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18148: Use HTTPS, if available, in links visible to users

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b64681408d84: Use HTTPS, if available, in links visible to users (authored by gszymaszek). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49138=49140

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Especially since the `Theme` isn't modified in any way but just used to read some

D18148: Use HTTPS, if available, in links visible to users

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH https-in-end-user-links (branched from master) REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor, dhaumann Cc: lueck, kwrite-devel,

D18148: Use HTTPS, if available, in links visible to users

gszymaszek marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

gszymaszek updated this revision to Diff 49138. gszymaszek added a comment. Fixed two links to docs.kde.org REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49135=49138 BRANCH https-in-end-user-links (branched from master) REVISION DETAIL

D18148: Use HTTPS, if available, in links visible to users

lueck added inline comments. INLINE COMMENTS > katedocument.cpp:4592 > "Please replace with > 'remove-trailing-spaces modified;', see " > - >