D18941: Fix build with cmake 3.5

wbauer edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

wbauer edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

wbauer created this revision. wbauer added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. Herald added a project: Baloo. wbauer requested review of this revision. REVISION SUMMARY VERSION_GREATER_EQUAL requires cmake 3.7 or higher. So use NOT VERSION_LESS

D18940: Add battery icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

ndavis updated this revision to Diff 51462. ndavis added a comment. Fix missing PositiveText stylesheet for battery-020-charging REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51461=51462 BRANCH battery-icons (branched from master)

D18940: Add battery icons

ndavis added a comment. Not certain if I've got the `index.theme`s right REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

ndavis updated this revision to Diff 51461. ndavis added a comment. Add `status/32` to `index.theme` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51460=51461 BRANCH battery-icons (branched from master) REVISION DETAIL

D18940: Add battery icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

ndavis created this revision. ndavis added reviewers: VDG, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Adds battery icons at 16, 22 and 32 px. Adds `status/32` to `index.theme`. Includes

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. I've done some tests in a clean virtual environment, and must say that this patch actually does not work, because kioclient5 ls smb:/ does not detect workgroups without setting [global] client max protocol = NT1 in ~/.smb/smb.conf I

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Feb 2019 23:11:37 + Build duration: 4 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Feb 2019 23:11:37 + Build duration: 3 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Feb 2019 23:11:37 + Build duration: 3 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Feb 2019 22:56:39 + Build duration: 4 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Feb 2019 22:57:37 + Build duration: 3 min 30 sec and counting BUILD ARTIFACTS

D17302: Add test for adding properties to result

astippich added a comment. In D17302#410189 , @bruns wrote: > Currently, both > `Result::add(prop, "value1"); Result::add(prop, "value2");` > and > `Result::add(prop, {"value1", "value2"});` > are serialized (JSON) in the same way as

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Feb 2019 22:53:42 + Build duration: 3 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Feb 2019 22:53:42 + Build duration: 2 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Feb 2019 22:53:42 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

D18830: Handle folders matching substrings of included/excluded folders correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R293:97aa68252c4a: Handle folders matching substrings of included/excluded folders correctly (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

This revision was automatically updated to reflect the committed changes. Closed by commit R293:24223306d59c: [balooctl] Normalize include/exclude pathes before using it for the config (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops, forgot to accept. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18829 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc:

D17302: Add test for adding properties to result

bruns added a comment. Currently, both `Result::add(prop, "value1"); Result::add(prop, "value2");` and `Result::add(prop, {"value1", "value2"});` are serialized (JSON) in the same way as `{prop: ["value1", "value2"]}` by Baloo, which is IMHO fine. On the other hand,

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18829 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18878: Force NT1 protocol when listing smb:// network

mikhailnov updated this revision to Diff 51443. mikhailnov added a comment. fixed patch REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18878?vs=51302=51443 REVISION DETAIL https://phabricator.kde.org/D18878 AFFECTED FILES cmake/FindSamba.cmake

D18895: AsciiDoc: Add folding for sections

This revision was automatically updated to reflect the committed changes. Closed by commit R216:54ac6d34a339: AsciiDoc: Add folding for sections (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18895?vs=51314=51442#toc REPOSITORY R216 Syntax Highlighting CHANGES

D17302: Add test for adding properties to result

astippich added a comment. Is this a please don't merge or can I land it? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18933: Send optional events from wl_pointer v5

zzag edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

zzag retitled this revision from "Implement optional events from wl_pointer v5" to "Send optional events from wl_pointer v5". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Implement optional events from wl_pointer v5

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY So far not all v5 features were implemented because most of them are optional. But given that

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. Forgot to write that SMB1 is used to list the network, then, when connection is done, protocol version must be chosen again automatically, SMB3 is default in newest samba. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To:

D18901: Add device icons for drones

hein added a comment. Thank you! Just what I needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein, ngraham, rooty Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b23f4198a22a: ECMGeneratePkgConfigFile API dox: fix Since for DESCRIPTION arg (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. In D18878#409822 , @sitter wrote: > https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ > > I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. I hope not, but that's the problem with the wall-of-text communication style. Eventually people get exhausted and the discussion peters out with nothing getting done. What's the minimum viable change here? REPOSITORY R241 KIO REVISION DETAIL

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

ngraham added a comment. Yes, obviously this won't work when disk space is limited and we'll need to check for that. In this case, I would like the the confirmation dialog to actually say to the user that the overwrite operation cannot be canceled without destroying the target file.

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

dfaure added a comment. Your reasoning seems to forget that there is a first confirmation, in case of overwriting, in the form of the "Overwrite/Skip/Cancel" dialog? Otherwise I kind of like the idea, but there's the problem of overwriting a 4GB file on a 5GB partition... (no space for

D18901: Add device icons for drones

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d2dce05fa05e: Add device icons for drones (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18878: Force NT1 protocol when listing smb:// network

sitter added a comment. No. This is already unnecessary. If a user requires SMB1 it may be tuned via /etc/samba/smb.conf. And that tuning would never be necessary if we had ws-discovery support I think... there is no Windows version which doesn't have ws-discovery and (all?) non-windows

D18878: Force NT1 protocol when listing smb:// network

ngraham added a comment. In D18878#409822 , @sitter wrote: > https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ > > I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

ngraham added a comment. In D18904#409667 , @chinmoyr wrote: > @ngraham The destination file is corrupted as soon as the user clicks overwrite. That's exactly the problem we need to fix. For example, if the user starts an overwrite

D18878: Force NT1 protocol when listing smb:// network

sitter added a comment. https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges from sound upstream defaults, goes against advise and practises set forth by Microsoft,

D18895: AsciiDoc: Add folding for sections

andreasgr added a comment. In D18895#409743 , @dhaumann wrote: > ... Although, adding many RegExprs is slow compared to other rules. I understand that. I just don't see how to achieve the needed matches using other rules. E.g. a

D18864: FlatBuffers schema syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting (authored by harald). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51331=51398

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. So this is just going to become a victim of the better-is-the-enemy-of-good principle? I'm not saying there can be better ways to do this but AFAIC this is already pretty good, certainly good enough and even too good in practice to keep me from more interesting

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH fixsincelocationfordescription REVISION DETAIL https://phabricator.kde.org/D18913 To: kossebau, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh,

D18915: Fix batchrename changing extension to lower case

cfoster added inline comments. INLINE COMMENTS > abalaji wrote in batchrenamejob.cpp:62 > You can just `QString dot = "."`, but you should use a single character > instead of a string, since it's just a single character Without the fromStdString() I get the following compilation error.