KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Feb 2019 05:28:52 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 05:28:52 + Build duration: 5 min 6 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Feb 2019 05:28:52 + Build duration: 4 min 10 sec and counting BUILD ARTIFACTS

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar added a comment. For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. May try to fix that when got some +1 REPOSITORY R39 KTextEditor REVISION DETAIL

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D16579: Remove support for non-standard APE tag field names

smithjd retitled this revision from "Fix APE tag extraction" to "Remove support for non-standard APE tag field names". smithjd edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns, mgallien Cc:

D16579: Fix APE tag extraction

smithjd added a comment. I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a

D16579: Fix APE tag extraction

smithjd updated this revision to Diff 52185. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Re-base. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44708=52185 BRANCH master-musepackFixes (branched

D17518: Adapt favicon test to www.kde.org changes

bruns abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17518 To: bruns, #frameworks, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in propertydata.cpp:80 > This means that multiple entries with the same key get stored as single > entries in the property map, right? > This breaks the current behavior in dolphin and

D18915: Fix batchrename changing extension to lower case

bruns added a comment. And factor out the function, it is used in 2 places, and you can unit test it then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: bruns, ngraham, elvisangelaccio, chinmoyr,

D18915: Fix batchrename changing extension to lower case

bruns added a comment. In D18915#416402 , @cfoster wrote: > In D18915#416400 , @bruns wrote: > > > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName > > > > > Returns the suffix for the

D18915: Fix batchrename changing extension to lower case

cfoster added a comment. In D18915#416400 , @bruns wrote: > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName > > > Returns the suffix for the file fileName, as known by the MIME database. > > This allows to pre-select "tar.bz2"

D18915: Fix batchrename changing extension to lower case

bruns added a comment. https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName > Returns the suffix for the file fileName, as known by the MIME database. > This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only "txt" for my.file.with.dots.txt. REPOSITORY R241 KIO

D18915: Fix batchrename changing extension to lower case

cfoster added inline comments. INLINE COMMENTS > ngraham wrote in batchrenamejob.cpp:181 > Is it? > > `file.tar.gz` Ah yes... very good point... I think have to rethink how to solve this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin,

D18915: Fix batchrename changing extension to lower case

ngraham added inline comments. INLINE COMMENTS > batchrenamejob.cpp:181 > + > + //If the oldFileName contains a '.' then its extension is all to the > right of the last dot > +int dotIndex = oldFileName.lastIndexOf(QStringLiteral(".")); Is it? `file.tar.gz` REPOSITORY R241 KIO

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 52180. cfoster added a comment. - Changes after review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=51372=52180 BRANCH arcpatch-D18915_2 REVISION DETAIL https://phabricator.kde.org/D18915

D18845: authority: add support for passing details to polkit

bruns added a comment. Does this solve part of T8075 ? REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: kde-frameworks-devel

D18770: [KStatusNotifierItem] use fallback sizes when none is available

bruns added a comment. While this may be necessary in some cases, I wonder if there shouldn't be some more emphasis on using the IconName instead of a pixmap: - The icon stays scalable - Less data to serialize/deserialize over DBus Additionaly, the StatusNotifierHost could be to

D18853: Fix sharing files with spaces or quotes in names via Telegram

mikhailru added a comment. In D18853#416211 , @apol wrote: > Looks much better :D > > Can you land the patch? I'm afraid I can't. Actually this is my first KDE patch that have made it this far. :) REPOSITORY R495 Purpose Library

D18873: add baloo engine debugging category

bruns added a comment. @valeriymalov - are you going to push this? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D18986: [breeze-icons] Add video camera icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:85f4fe3a76e5: [breeze-icons] Add video camera icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18986: [breeze-icons] Add video camera icons

hein accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

trickyricky26 updated this revision to Diff 52165. trickyricky26 added a comment. - Add -symbolic symlinks to the 16px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52161=52165 BRANCH arcpatch-D18986 REVISION DETAIL

D18762: Add support for portals in KRun

GeeXT updated this revision to Diff 52163. GeeXT added a comment. Swap the conditions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=51047=52163 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762

D18762: Add support for portals in KRun

GeeXT marked an inline comment as done. REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18455: Port to new connect syntax

apol added a comment. What happened here? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18455 To: chinmoyr, davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

apol abandoned this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

apol added a comment. Has this been fixed? I haven't seen these warnings REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15795 To: dinoh, apol, dfaure Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

hein added a comment. Would it be possible to also add the lineart versions as -symbolic? In my new app I rely on Kirigami's icon recoloring feature and it only works with monochrome icons, so I rely on -symbolic to request them. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986

D17863: Add ecm_check_linker_flags function

apol added a comment. Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc:

D18762: Add support for portals in KRun

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Overall, it looks good to me. Let's get this in. Regarding your process, I think you could have passed `--devel` on the step 7 and compiled kio there together with konversation. Maybe that

D18986: [breeze-icons] Add video camera icons

rooty accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks much better :D Can you land the patch? REPOSITORY R495 Purpose Library BRANCH telegram-sharing-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D18853

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. @ngraham If you include this in TWIP, use this image since it's slightly sharper on the 64px icon. @trickyricky26's `montage` is screwing up even though he's using the same command as me. F6626420: montage-breeze-Background.png

D18986: [breeze-icons] Add video camera icons

ndavis accepted this revision. ndavis added a comment. LGTM! I really like how the 64px version turned out, especially that shotgun mic. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis,

D18986: [breeze-icons] Add video camera icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

trickyricky26 updated this revision to Diff 52161. trickyricky26 added a comment. - Add the bottom 1px shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52154=52161 BRANCH arcpatch-D18986 REVISION DETAIL

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar updated this revision to Diff 52158. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Do not wrap in some cases with block selection - Auto wrap once wrapped line again also when static wrap is

D19107: Write valid UTF8 characters without escaping.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:2cdcd4f30666: Write valid UTF8 characters without escaping. (authored by vandenoever). REPOSITORY R237 KConfig

D18986: [breeze-icons] Add video camera icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Now that's what I'm talkin' about!!! I love these! All in favor? REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To:

D18986: [breeze-icons] Add video camera icons

trickyricky26 updated this revision to Diff 52154. trickyricky26 added a comment. - Improve contrast by making the camera silver, add Breeze-style shadows to screen and buttons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52151=52154

D18986: [breeze-icons] Add video camera icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. It looks good to me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

trickyricky26 updated this revision to Diff 52151. trickyricky26 added a comment. - Use a 64px design with a shotgun-type mic; use steeper angle for the lens on small versions REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52021=52151

D19170: Fix crash while moving files

hallas added a comment. In D19170#415760 , @dfaure wrote: > If some code is deleting this job from a slot connected to it, that code needs to be fixed. This hack isn't a fix, it will only create more problems.. > > E.g. if some other bad

D19170: Fix crash while moving files

hallas added a comment. In D19170#416120 , @hallas wrote: > In D19170#416067 , @hallas wrote: > > > In D19170#415760 , @dfaure wrote: > > > > > If some

D18986: [breeze-icons] Add video camera icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel,

D19170: Fix crash while moving files

hallas added a comment. In D19170#416067 , @hallas wrote: > In D19170#415760 , @dfaure wrote: > > > If some code is deleting this job from a slot connected to it, that code needs to be fixed. This

D19035: Help build on Windows with usage of CMake Targets

cullmann added a comment. I think then we should just abandon it, if it has no real benefit at all, or? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: dantti, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel,

D19035: Help build on Windows with usage of CMake Targets

dantti added a comment. I ended up compiling it using vcpkg toolchain directly on Windows, which showed this isn't required. In fact even when cross-compiling this won't fix anything because the tool must run on the host OS. So I only still think this is useful because the user

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 09:20:01 + Build duration: 5 min 30 sec and counting JUnit Tests Name:

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas updated this revision to Diff 52132. hallas added a comment. Implemented review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52105=52132 BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAIL

D19107: Write valid UTF8 characters without escaping.

vandenoever added a comment. So it's accepted? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added a comment. In D19168#415767 , @dfaure wrote: > Looks good, just some minor improvement suggestions for the unittest. Thanks for the suggestions - I am still quite new to using QtTest :) Essentially I copied one of the other

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir added a comment. In D19161#415701 , @dhaumann wrote: > This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278. Another way to test, try setting