Re: Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

Hi, I will investigate today. Regards Le vendredi 1 mars 2019, 20:09:54 CET Ben Cooksley a écrit : > Hi Laurent, > > > Thanks for taking a look - unfortunately it looks like this is still > failing? > > > Cheers, > Ben

D19461: Logcat: fix dsError color with underline="0"

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In itemData's, using

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124398/ --- (Updated March 2, 2019, 5:44 a.m.) Status -- This change has been

[reposted from kde-devel] Building KDE statically

Hello KDE developers, If anyone is interested, here is a brief report on something I have been working on in my spare time. TLDR: Here are some scripts to build KDE frameworks and okular statically using gcc/musl and cross-building for mingw: https://github.com/jschultz/kde-static Look in

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bcooksley added a comment. Given that Baloo Widgets isn't the only project showing that class of failure, it's more likely to be a case of ECM getting something wrong. (The CI system doesn't do anything special when it comes to this part of the execution) REPOSITORY R824 Baloo Widgets

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 01 Mar 2019 21:38:48 + Build duration: 4 min 27 sec and counting JUnit Tests Name:

D19453: Fix repository deletion warning

dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D19453 To: vkrause, cullmann, dhaumann Cc: kossebau, cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D19455: [knotification] compile without deprecated methods

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R289

D19453: Fix repository deletion warning

kossebau added a comment. I can confirm this results in the warnings about `Repository got deleted while a highlighter is still active!` no longer being shown when using D19432 . Also no issues seen in Kate. But not enough understanding of this

D19453: Fix repository deletion warning

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good catch :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D19453 To: vkrause, cullmann Cc: cullmann, kwrite-devel,

D19453: Fix repository deletion warning

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Since 6166da75 the

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bruns added a comment. In D19268#422709 , @bcooksley wrote: > Sorry, I don't see where it's complaining about not finding the right binary? > (Not finding Dr Konqi is expected, given that it's part of Plasma and not a dependency of

T10547: Make helpers in LIBEXEC testable, make LIBEXEC runtime settable

bruns created this task. TASK DESCRIPTION While pathes to executables (PATH) and plugins (QT_PLUGIN_PATHS) can be adjusted, LIBEXEC is hardcoded, see e.g.: https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs > KStandardDirs::findExe (and the use of the "exe" resource)

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bcooksley added a comment. Sorry, I don't see where it's complaining about not finding the right binary? (Not finding Dr Konqi is expected, given that it's part of Plasma and not a dependency of baloo-widgets) REPOSITORY R824 Baloo Widgets REVISION DETAIL

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bruns added a comment. Actually, it is quite happy to report it can not execute the binary in build/bin/, which is IMHO an error in the CI setup. I don't have windows, so someone else has to look into this. REPOSITORY R824 Baloo Widgets REVISION DETAIL

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bruns added a subscriber: Windows. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19268 To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko Cc: #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:70 > Not sure I understand. I would like to avoid doing `file->properties();` and > `file->setProperties();` twice for those formats for which only the > PropertyMap is sufficient, e.g. Ape and Ogg, to avoid

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar added a comment. Ah, `r.toEditorRange().isValid()` is the trick, yes, would work. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar added a comment. > Hm, who is passing an invalid range here? Does it matter? Can't remember. Want to see the bt? > Would it be the same to check r.isValid()? No. No such function :p It's a vimode range (?) REPOSITORY R39 KTextEditor REVISION DETAIL

Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

Hi Laurent, Thanks for taking a look - unfortunately it looks like this is still failing? Cheers, Ben -- Forwarded message - From: CI System Date: Fri, Mar 1, 2019 at 11:05 AM Subject: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing! To: ,

D19407: ModeBase::goToPos: Ensure jump target is valid

dhaumann added a comment. It's FIXED-IN: 5.56... Hm, who is passing an invalid range here? Would it be the same to check r.isValid()? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel,

D19438: Add syntax definition for Elm language to syntax-highlighting

dhaumann added a comment. Could you elaborate what Elm is used for? Also, could you please provide a small test file (also MIT licensed) that we can use for unit testing? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim Cc:

D19442: [Kfilemetada] Make it compile without foreach

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This clashes with D19287 , and has to be rebased/merged then REPOSITORY R286 KFileMetaData REVISION DETAIL

D7732: Force KAuth helpers to have UTF-8 support

aacid added a comment. I'm not sure changing the codec for all kauth stuff is the best, but if we're going to do that i think we should add it to the documentation, something like "Forces UTF-8 text codec" or something REPOSITORY R283 KAuth REVISION DETAIL

D19450: DocumentPrivate: Respect indention mode when block selection

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch was in block selection mode always a tab

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson updated this revision to Diff 52913. davidedmundson added a comment. pedantic change REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7732?vs=52912=52913 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7732 AFFECTED FILES

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson updated this revision to Diff 52912. davidedmundson added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Rewrote using QTextCodec REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7732?vs=19307=52912

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ..how it should be by adding brackets to each line of the

D19445: Handle variant list in formatting functions

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Improve the formatting function of KFileMetaData such that

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/31/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Mar 2019 16:03:31 + Build duration: 7 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 01 Mar 2019 16:03:31 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 01 Mar 2019 14:30:51 + Build duration: 5 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/30/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Mar 2019 14:30:51 + Build duration: 2 min 13 sec and counting BUILD ARTIFACTS

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau updated this revision to Diff 52901. kossebau added a comment. Changes: - clip when drawing the text document, so our "page" margins stay clean - for that reuse vars some more Somehow the old custom margins look nicer to me, so I kept the logic in the code. Seems

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. We can not arbitrary scale the height, that must match what Qt does, else you get maximal ugly empty trash in-between the lines, e.g. if you partially select stuff or have different backgrounds for some glyphs. REPOSITORY R39 KTextEditor REVISION DETAIL

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > Just load the XML file from bug 404713. > Before this changes here, you did overpaint the next line randomly with the "oversized one", now you "cut" the oversized line. I don't know where to look specifically in that huge file. I do notice that with the

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

loh.tar added a comment. Sorry when I'm wrong, but it sounds to me that this bug is somehow relatated or maybe a solution, there is patch offered. Bug 328837 - Add configurable line height to katepart REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To:

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. New after: F6646824: Screenshot_20190301_144746.png Hm, meh, now I see that `textDocument.drawContents();` does not stay within the page size the document was given... let's see whether I can do some clipping

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau updated this revision to Diff 52899. kossebau added a comment. use original different x & y margins, to gain more chars rendered, as before REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19432?vs=52865=52899 BRANCH

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > vkrause wrote in textcreator.cpp:169 > I think default background color here refers to what your palette gives you. > The background color defined by highlighting is typically only used for small > text blocks like for alerts ("TODO", "HACK",

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/47/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 01 Mar 2019 13:00:55 + Build duration: 7 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 01 Mar 2019 13:00:55 + Build duration: 4 min 4 sec and counting JUnit Tests Name:

D19332: KProcess compile fix for obsolete QProcess members in 5.13

marten updated this revision to Diff 52898. marten added a comment. Use the same condition as the Qt header uses REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19332?vs=52601=52898 REVISION DETAIL https://phabricator.kde.org/D19332 AFFECTED FILES

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. Just load the XML file from bug 404713. Before this changes here, you did overpaint the next line randomly with the "oversized one", now you "cut" the oversized line. In both cases, one line is garbage. REPOSITORY R39 KTextEditor REVISION DETAIL

D19442: [Kfilemetada] Make it compile without foreach

astippich added a comment. There are currently larger refactorings ongoing (D19287 , D18826 ), could you please wait for them and rebase afterwards? INLINE COMMENTS > externalextractor.cpp:151 > +const auto

D19442: [Kfilemetada] Make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19442 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, #baloo, domson,

D19442: [Kfilemetada] Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN Autotest ok REPOSITORY R286

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

This revision was automatically updated to reflect the committed changes. Closed by commit R298:0217d5038550: Make it compile with QT_NO_CAST_FROM_ASCII (authored by mlaurent). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19430?vs=52860=52896

D17302: Add test for adding properties to result

astippich updated this revision to Diff 52894. astippich added a comment. - mark expected fail REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=48688=52894 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. So it seems that the partial revert works; you lost me re: what would break again by doing that? F6646645: Screen Shot 2019-03-01 at 13.07.52.png (background: full revert; foreground partial revert (only

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > If you keep the overpainting, you will just overpaint the next line partially with it, that won't help that much, IMHO. > > Take a look at bug 404713. I totally agree, but this is a different issue that is out of scope here as far as I see. Bugs 403868

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > We just can't use one fixed height for such texts. You can, but it'd have to be the maximum of all lineheights (of the entire document or of the visible section). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann,

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. If you keep the overpainting, you will just overpaint the next line partially with it, that won't help that much, IMHO. Take a look at bug 404713. We just can't use one fixed height for such texts. REPOSITORY R39 KTextEditor REVISION DETAIL

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > So **iff** the rating is updated at the same time as another property, taglib > has to adjust some in-memory structure twice. Obviously, for most formats > this poses no problem, but for Ape/Vorbis it does?

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

astippich added a comment. Windows CI seems not to be happy about this https://build.kde.org/job/Applications/job/baloo-widgets/job/kf5-qt5%20WindowsMSVCQt5.11 REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19268 To: bruns, #frameworks, #baloo, ngraham,

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH compile_with_QT_NO_CAST_FROM_ASCII (branched from master) REVISION DETAIL https://phabricator.kde.org/D19430 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh,

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:208 > Can you also use the same style as above, i.e. `const auto` and `for( : )`? Oh, damn copy > smithjd wrote in taglibextractor.cpp:195 > lstASF = asfTags->attribute("WM/Writer"); > ... > > The existing

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52890. astippich marked 8 inline comments as done. astippich added a comment. - rebase on master - implement review comments - cleanup includes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D19385: use KPackage::fileUrl to support rcc KCMs packages

This revision was automatically updated to reflect the committed changes. Closed by commit R296:096d214b67b3: use KPackage::fileUrl to support rcc KCMs packages (authored by sitter). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19385?vs=52716=52889

D19388: improve documentation on global config cascading

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d22f469be6fd: improve documentation on global config cascading (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19388?vs=52725=52888 REVISION

D19385: use KPackage::fileUrl to support rcc KCMs packages

sitter added a comment. LXR seems to show a whole bunch of these code segments https://lxr.kde.org/search?_filestring=&_string=package.filePath Deprecation is probably a good idea. From where I am standing an application can always grab the path out of an url if absolutely necessary.

Re: kconf_update lost its update.log in 2014

On Thu, Feb 28, 2019 at 8:20 PM Albert Astals Cid wrote: > > El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va > escriure: > > ...and I don't understand why > > > > Hi! > > > > this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0` > > and thus disabling the

D7820: man ioslave: spurious numbers included in clang(1) man page

marten added a reviewer: kfm-devel. Herald added projects: Dolphin, Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel Cc: kde-frameworks-devel, plasma-devel, jraleigh,

D9033: man ioslave: asserts trying to display pam(8)

marten added a reviewer: kfm-devel. Herald added projects: Dolphin, Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma, kfm-devel Cc: kde-frameworks-devel, apol, plasma-devel,

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

marten created this revision. marten added reviewers: Plasma, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY Compiling this module produces a number of warnings all

D19437: [knewstuff] Remove qt5.13 deprecated method

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.cpp:575 > +connect(ret, static_cast QProcess::ExitStatus)>(::finished), this, [this, command](int > exitcode){ > if (exitcode) { >

D19436: [kservice] compile without deprecated method

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ksycocathreadtest.cpp:306 > now = QDateTime::currentDateTime(); > -if (now.toTime_t() == ctime.toTime_t()) // truncate milliseconds > +