D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. Ok, I have implemented all the review feedback you gave, I have also done some unit tests. Some of the unit tests or Unix specific though, I still don't know what to do about Windows since I don't have a development environment. Please give it a good look :D

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas marked 9 inline comments as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas updated this revision to Diff 54827. hallas added a comment. Updated with review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20007?vs=54638=54827 BRANCH adds_kprocesslist (branched from master) REVISION DETAIL

D20047: Add X-GNOME-UsesNotifications as recognized key

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D20047 To: broulik, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#438310 , @ndavis wrote: > In D19952#438130 , @arvidhansson wrote: > > > In D19952#437726 , @ndavis wrote: > >

D20026: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54815. krutovmikhail added a comment. Upated - Working variant with proper widgets - amending due to lost changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=54812=54815 BRANCH

D20026: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54812. krutovmikhail edited the summary of this revision. krutovmikhail added a comment. Updated - Working variant with proper widgets REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=54810=54812 BRANCH

D19985: [KStatusNotifierItem] Send desktop-entry hint

This revision was automatically updated to reflect the committed changes. Closed by commit R289:90050b02d725: [KStatusNotifierItem] Send desktop-entry hint (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19985?vs=54585=54813

D20026: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail retitled this revision from "WIP: Bug 195801 - go up in folder hierachy when in "edit mode"" to "Bug 195801 - go up in folder hierachy when in "edit mode"". krutovmikhail edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL

D19985: [KStatusNotifierItem] Send desktop-entry hint

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19985 To: broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail marked 2 inline comments as done. krutovmikhail added a comment. After bit digging, found out a proper-er solution to both questions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel,

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54810. krutovmikhail added a comment. Updated - Working variant with proper widgets REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=54758=54810 BRANCH

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#438130 , @arvidhansson wrote: > In D19952#437726 , @ndavis wrote: > > > In D19952#437670 , @arvidhansson wrote: > >

D7732: Force KAuth helpers to have UTF-8 support

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson, apol, aacid Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D19903: Fix build with msvc

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. I don't know who is responsible for this, but noone seems to disagree, so if this fixes the build for MSVC and doesn't break other platforms let's go for it? REPOSITORY R159 KActivities

D20018: Update URLs to use https

This revision was automatically updated to reflect the committed changes. Closed by commit R264:ca4cca65c756: Update URLs to use https (authored by vkrause). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20018?vs=54798=54801 REVISION DETAIL

D20018: Update URLs to use https

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH arcpatch-D20018 REVISION DETAIL https://phabricator.kde.org/D20018 To: vkrause, yurchor Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns,

D20018: Update URLs to use https

vkrause updated this revision to Diff 54798. vkrause added a comment. Integrate review comments. REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20018?vs=54674=54798 BRANCH arcpatch-D20018 REVISION DETAIL https://phabricator.kde.org/D20018 AFFECTED

D20047: Add X-GNOME-UsesNotifications as recognized key

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is set by Gnome applications that will spawn notifications for identifying

D20047: Add X-GNOME-UsesNotifications as recognized key

broulik edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D20047 To: broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20046: Verify mimetypes for all existing sample files, add some more

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Check if the mimetypes for the existing

D20045: Add helper function to determine mime type based on content and extension

bruns added a dependent revision: D20046: Verify mimetypes for all existing sample files, add some more. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20045 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20045: Add helper function to determine mime type based on content and extension

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The QMimeDatabase::MatchDefault only falls

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#437726 , @ndavis wrote: > In D19952#437670 , @arvidhansson wrote: > > > In D19952#437419 , @ndavis wrote: > >

D20042: Show the plasmoid context menu on long tap

apol updated this revision to Diff 54777. apol added a comment. polish REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20042?vs=54776=54777 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20042 AFFECTED FILES

D20042: Show the plasmoid context menu on long tap

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Also expose a method to show the context menu so plasmoids that implement a

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags updated this revision to Diff 54775. nibags added a comment. - Use QStringLiteral REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19876?vs=54702=54775 BRANCH fix-schemas REVISION DETAIL https://phabricator.kde.org/D19876 AFFECTED FILES

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Mar 2019 14:51:18 + Build duration: 9 min 23 sec and counting BUILD ARTIFACTS

D20012: Fix number localization for properties

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please drop the changes in the unit test. INLINE COMMENTS > astippich wrote in propertyinfotest.cpp:97 > I do not want to start adding translations to unit tests, that seems over

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Mar 2019 14:51:18 + Build duration: 4 min 25 sec and counting BUILD ARTIFACTS

D19903: Fix build with msvc

vonreth added a comment. So then the workaround is correct, I haven't tried whether the original code compiles with CMAKE_CXX_STANDARD=17 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson, aacid Cc:

D20011: Be more precise with mimetype detection

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > app.cpp:147 > { > -QString mimetype = m_mimeDb.mimeTypeForFile(url, > QMimeDatabase::MatchContent).name(); > +QMimeType extensionMimeType =

D20032: Convert string formatting tests to be data driven

apol added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:71 > This saves adding the `QVariant(...)` around each value, and avoids the > repeated formatting of the row name/data index. The property enum is used > twice in each addRow. And instead it makes you create a

D7732: Force KAuth helpers to have UTF-8 support

apol added a comment. LGTM +1 I've dealt with such issues when working on samba-mounter, there we ended up encoding everything as base64 and using QString::fromUtf8 like maniacs. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson, apol Cc:

D20032: Convert string formatting tests to be data driven

bruns added inline comments. INLINE COMMENTS > apol wrote in propertyinfotest.cpp:71 > And instead it makes you create a weird local struct and loop to feed to > QTest. I don't find it very convincing. First 2 rows expanded, just for you: QTest::addRow("%s",

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson added a reviewer: apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson, apol Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson updated this revision to Diff 54771. davidedmundson added a comment. update docs REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7732?vs=53197=54771 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7732 AFFECTED FILES

D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The high nesting level makes the call hard to

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns updated this revision to Diff 54768. bruns added a comment. add list tests REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19087?vs=52401=54768 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D19087 AFFECTED FILES

D20013: Use Qt function for string list formatting

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20013: Use Qt function for string list formatting

bruns added a comment. I think this should go in before D19445 . INLINE COMMENTS > propertyinfo.cpp:635 > if (d->valueType == QVariant::StringList || d->valueType == > QVariant::String ) { > return

D19967: [kpeople] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R307:5db114c9aad3: [kpeople] make it compile without foreach (authored by mlaurent). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54749=54766 REVISION

D20032: Convert string formatting tests to be data driven

bruns added inline comments. INLINE COMMENTS > apol wrote in propertyinfotest.cpp:71 > Is the struct really necessary? > You can be about as short by calling QTest::addRow directly for each line. This saves adding the `QVariant(...)` around each value, and avoids the repeated formatting of the

D20039: [KConfig] Add Notify capability for revertToDefault

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20039 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh,

D20039: [KConfig] Add Notify capability for revertToDefault

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This enables `KConfigWatcher` TEST PLAN In preparation

D20032: Convert string formatting tests to be data driven

apol added a comment. +1 to _data splitting, makes a lot of sense. INLINE COMMENTS > propertyinfotest.cpp:71 > > -PropertyInfo bitRate(Property::BitRate); > -QCOMPARE(bitRate.formatAsDisplayString(QVariant(128000)), > QStringLiteral("128 kbit/s")); > -

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. I've updated the diff with a couple questions I have (about UI mostly). Still WIP. INLINE COMMENTS > kurlnavigator.cpp:406 > +hasParent = (currentDirectory != currentDirectory.resolved(levelUp)); > +currentDirectory =

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54758. krutovmikhail added a comment. - initial take at dropdown list REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=54722=54758 BRANCH mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#437220 , @cullmann wrote: > Hi, I still don't like that we do different things in replaceText depending on the selection of the potential activeView, that makes this function harder to use correctly, as it

D19967: [kpeople] make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19967 To: mlaurent, dfaure Cc: apol, pino, kde-frameworks-devel, michaelh, ngraham,

D20034: Pass focus to child searchbar when KPluginSelector is focused

ngraham edited the summary of this revision. REPOSITORY R295 KCMUtils BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20034 To: jayeshbhoot, #plasma, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20034: Pass focus to child searchbar when KPluginSelector is focused

ngraham added a dependent revision: D20035: Set autofocus to child KPluginSelector on UI load. REPOSITORY R295 KCMUtils BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20034 To: jayeshbhoot, #plasma, #frameworks, ngraham

D20034: Pass focus to child searchbar when KPluginSelector is focused

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20034 To: jayeshbhoot, #plasma, #frameworks, ngraham Cc:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/53/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 25 Mar 2019 04:54:20 + Build duration: 2 hr 59 min and counting JUnit Tests

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#437715 , @dfaure wrote: > ... > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Mar 2019 06:49:21 + Build duration: 3 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Mar 2019 06:49:21 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS

D20021: Add support for extracting data from ogg and ts files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2a76b11e1e9f: Add support for extracting data from ogg and ts files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D19930: [kwallets] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R311:0da6f73eddc0: [kwallets] compile without foreach (authored by mlaurent). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19930?vs=54455=54750 REVISION DETAIL

D19967: [kpeople] make it compile without foreach

mlaurent updated this revision to Diff 54749. mlaurent added a comment. Fix error reported by david REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54563=54749 BRANCH compile_without_foreach (branched from master) REVISION DETAIL