KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/37/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 18 Apr 2019 05:54:44 + Build duration: 2 min 3 sec and counting JUnit Tests Name:

D20639: Remove TODO

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20639 To: shubham, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20620: [balooctl] Switch multiline output to new helper

bruns added inline comments. INLINE COMMENTS > ngraham wrote in statuscommand.cpp:150 > Do we have to use `auto` here and below? We hardly ever have to, but I see no reason why an explicit type would be helpful here. You wouldn't have objected if I had used `auto filenameIt =

Re: New framework: KCalCore

On Wed, Apr 17, 2019 at 6:40 PM Volker Krause wrote: > > On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote: > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an

D20643: Fix invalid memory write on malformed tar files

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > aacid wrote in ktar.cpp:241 > You mean also printing std::numeric_limits::max() ? I meant in a comment, but yeah, it's on the warning already. REPOSITORY R243 KArchive

D20644: Fix memory leak when reading some tar files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20644 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20643: Fix invalid memory write on malformed tar files

aacid added inline comments. INLINE COMMENTS > apol wrote in ktar.cpp:241 > It could make sense to say that it's because of the maximum size longling can > have in a comment. You mean also printing std::numeric_limits::max() ? REPOSITORY R243 KArchive REVISION DETAIL

D20641: Fix uninitialized memory use when reading malformed tar files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20641 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20641: Fix uninitialized memory use when reading malformed tar files

aacid added a comment. In D20641#452130 , @apol wrote: > Should maybe warn if it fails? I am not sure, but i don't think so, there's if's below that account for name and symlink being empty, so it's not a problem if this fails afaics

D20644: Fix memory leak when reading some tar files

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > karchive.cpp:602 > Q_ASSERT(!d->rootDir); // Call setRootDir only once during parsing > please ;) > +delete d->rootDir; // but if it happens, try not to

D20641: Fix uninitialized memory use when reading malformed tar files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Should maybe warn if it fails? REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20641 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh,

D20643: Fix invalid memory write on malformed tar files

apol added a comment. +1 in general INLINE COMMENTS > ktar.cpp:241 > size--;// ignore trailing null > +if (size > std::numeric_limits::max()) { > +qCWarning(KArchiveLog) << "Failed to allocate memory for longlink of > size" << size; It could make sense to say that it's

D20639: Remove TODO

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it. The TODO talks about adding a startTimer method and deprecating timer (which it

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Apr 2019 20:20:47 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/84/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 17 Apr 2019 20:20:47 + Build duration: 5 min 22 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/81/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Apr 2019 20:20:47 + Build duration: 5 min 34 sec and counting BUILD ARTIFACTS

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

kossebau added a comment. Given also on irc, no-one showed any interest for Air/Oxygen ,going to just push this, having at least one +1. Thanks for that one :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20602 To: kossebau, #plasma, #vdg Cc:

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:084edba0db19: Air/Oxygen desktoptheme: fix progressbar height using hint-bar-size (authored by kossebau). REPOSITORY

D20158: Allow to set urgency for notifications

broulik added a comment. @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. Do you think it would be useful to add `HighUrgency`, too? For Android, maybe? For freedesktop Notifications we

D20529: add license to python test files

bruns added a comment. In D20529#451614 , @bcooksley wrote: > In D20529#451561 , @bruns wrote: > > > In D20529#451147 , @bcooksley wrote: > > > > >

D20644: Fix memory leak when reading some tar files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Not sure if they are even malformed (don't know enough about the tar format), but oss-fuzz has produced a file where

D20643: Fix invalid memory write on malformed tar files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If the file says it has a longlink of more than int_max bytes, the resize would do nothing (since casting to int means a

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/83/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 17 Apr 2019 18:11:51 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Apr 2019 18:11:52 + Build duration: 9 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/80/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Apr 2019 18:11:51 + Build duration: 8 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Apr 2019 17:53:11 + Build duration: 4 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/79/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Apr 2019 17:53:11 + Build duration: 4 min 6 sec and counting BUILD ARTIFACTS

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham updated this revision to Diff 56467. ngraham added a comment. `arc`, you are driving me crazy REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20283?vs=56466=56467 REVISION DETAIL https://phabricator.kde.org/D20283 AFFECTED FILES

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham updated this revision to Diff 56466. ngraham added a comment. Remove unintentional change REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20283?vs=56465=56466 BRANCH simplekcm-better-maximum-height (branched from master) REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/82/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 17 Apr 2019 17:53:11 + Build duration: 2 min 24 sec and counting JUnit Tests

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham updated this revision to Diff 56465. ngraham marked an inline comment as done. ngraham edited the summary of this revision. ngraham added a comment. Use implicitHeights for headers and footers REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20283: [RFC] [SimpleKCM] Fix height calculation

mart added inline comments. INLINE COMMENTS > SimpleKCM.qml:55 > ++ bottomPadding > ++ (header && header.visible ? header.height + header.topPadding + > header.bottomPadding : 0) > ++ (footer && footer.visible ? footer.height + footer.topPadding + > footer.bottomPadding

D20641: Fix uninitialized memory use when reading malformed tar files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Don't try to read longlink if readLongLink fails oss-fuzz #14310 REPOSITORY R243 KArchive BRANCH master

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham updated this revision to Diff 56462. ngraham added a comment. Remove accidentally added change REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20283?vs=56461=56462 REVISION DETAIL https://phabricator.kde.org/D20283 AFFECTED FILES

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham retitled this revision from "[SimpleKCM] Base the maximum height on the screen height, not some random value" to "[RFC] [SimpleKCM] Fix height calculation". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

ngraham updated this revision to Diff 56461. ngraham added a comment. Take headers and padding into account for height calculation REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20283?vs=55501=56461 BRANCH simplekcm-better-maximum-height (branched

D20639: Remove TODO

shubham created this revision. shubham added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO BRANCH todo REVISION DETAIL https://phabricator.kde.org/D20639 AFFECTED

D20606: Toggle folding of child ranges by right click

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The question is: with a context menu, isn't that then already too inconvenient? At the moment we have no context menu for the bar at all. I could live with the right

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ngraham added a comment. Submitted D20637 and D20638 to keep the Widget Explorer using the correct icons after this patch lands. REPOSITORY R242 Plasma Framework (Library) BRANCH update-icons (branched from

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH update-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg, #plasma, broulik, ngraham Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Apr 2019 16:34:40 + Build duration: 9 min 24 sec and counting BUILD ARTIFACTS

Re: New framework: KCalCore

On Sunday, 14 April 2019 20:30:07 CEST Alexander Potashev wrote: > вт, 9 апр. 2019 г. в 20:10, Volker Krause : > > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > > Hi, > > > > > > > > I'd like to propose KCalCore for review

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/88/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 17 Apr 2019 16:34:40 + Build duration: 6 min 6 sec and counting JUnit Tests Name:

Re: New framework: KCalCore

On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > I

D20625: Truncate trailing forward slashes(/)

shubham added a comment. @dfaure Intention was just to fix the TODO REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20625 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:acc6b9b71b51: Truncate trailing forward slashes(/) (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20625?vs=56437=56447 REVISION DETAIL

D20620: [balooctl] Switch multiline output to new helper

ngraham added inline comments. INLINE COMMENTS > statuscommand.cpp:150 > + > +for (const auto& fileName : args) { > +const auto file = collectFileStatus(tr, cfg, fileName); Do we have to use `auto` here and below? REPOSITORY R293 Baloo REVISION DETAIL

D20619: [balooctl] Use new helper in json output

ngraham added inline comments. INLINE COMMENTS > statuscommand.cpp:226 > > - QJsonDocument json; > - json.setArray(filesInfo); > - QTextStream out(stdout); > - out << json.toJson(QJsonDocument::Indented); > +for (const auto& fileName : args) { > +const auto file =

D20617: [balooctl] Factor out file index status collection from output

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH balooctl_status REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20618: [balooctl] Use new helper for simple format output

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH balooctl_status REVISION DETAIL https://phabricator.kde.org/D20618 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Volume icon are consistent now, Vault icon in tray is prettier (imho), media controls look unchanged/fine, folder view nav buttons look fine/better, lgtm REPOSITORY R242 Plasma

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. well.. I couldn't get it running as a toolchain and kept running into errors. I can give it another hit, though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem,

Re: New framework: KCalCore

On lundi 15 avril 2019 12:40:06 CEST Daniel Vrátil wrote: > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > > Maybe KCal is enough? Reminds of iCal. > > Wasn't KCal the original name of the library from pre-Akonadi times? > KCalCore was a fork of KCal with the pre-Akonadi "Resources"

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ngraham added a comment. This looks fine to me, but let's let a #plasma person weigh in too. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg, #plasma Cc: ngraham,

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#451898 , @sh-zam wrote: > In my case if I do this: `include (Android.cmake)`, then it won't be able to find the `ECMAndroidDeployQt.cmake` because I am using android-ndk's toolchain. And why do you have

D20625: Truncate trailing forward slashes(/)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Patch looks good now ;-) I'm curious about one more thing: what prompted this change? Did you have a mount point with a trailing slash, or was it just to "fix a TODO" (which, hehe,

D20558: Bug fix: find c++ stl using regex

This revision was automatically updated to reflect the committed changes. Closed by commit R240:307b36662ec9: Bug fix: find c++ stl using regex (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56311=56445 REVISION

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > What does it mean that "it expects to run as a toolchain"? Sorry, I didn't notice this. On this line get_filename_component(_CMAKE_ANDROID_DIR

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. hm, there is already a folding action in the View menu. I understood Dominik so, not to add a context menu to the icon border, but to add the action to the context menu of the "edit range". Whatever, as said I'm not in the mood for that, and it should be done in

D20606: Toggle folding of child ranges by right click

loh.tar updated this revision to Diff 56444. loh.tar added a comment. - Add docu to header, not full happy with - Add desired adjustment checks - Make toggleFoldingInRange more action friendly - Add first try to unfold range itself into toggleFoldingInRange - Be a smart ass,

D20558: Bug fix: find c++ stl using regex

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

sh-zam added inline comments. INLINE COMMENTS > apol wrote in ECMAndroidDeployQt.cmake:43 > This looks quite awful. Why do you prefer using regex to string(FIND)? It > could be something like > `string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific. Because `string (FIND ..)`

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450229 , @sh-zam wrote: > > Why are you using it without Android.cmake? > > I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake`

D20625: Truncate trailing forward slashes(/)

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20625 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

shubham updated this revision to Diff 56437. shubham marked an inline comment as done. shubham added a comment. Correcty chop trailing slash REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20625?vs=56416=56437 BRANCH arcpatch-D20625 REVISION DETAIL

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

kossebau added a comment. Anyone brave enough for a shipit? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20602 To: kossebau, #plasma, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kmountpoint.cpp:164 > } > -// TODO: Strip trailing '/' ? > +mountedFrom = > mountedFrom.left(mountedFrom.lastIndexOf(QLatin1Char('/'))); > }

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

davidedmundson added a comment. if (wl_proxy_get_version(d->surface) < ORG_KDE_PLASMA_SURFACE_ROLE_CRITICALNOTIFICATION_SINCE_VERSION) { //handle error code } INLINE COMMENTS > plasma-shell.xml:194 > + > + >

D20626: Refactor and cleanup

dfaure added a comment. I like the idea. The commit template has a "Test Plan" field, but it seems it was left empty - can you detail what tests you did? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh,

D20606: Toggle folding of child ranges by right click

mwolff added a comment. In D20606#451459 , @dhaumann wrote: > I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions. I agree. Right-click should show a

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20630: [Dialog] Add CriticalNotification type

broulik created this revision. broulik added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to flag a dialog window as critical notification that should be shown

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20630: [Dialog] Add CriticalNotification type. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, tests adjusted and pass. I need some help with the versioning stuff please

D20627: Introduce CriticalNotificationType

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is a dedicated window type indicating a critical notification that is more urgent

D20626: Refactor and cleanup

shubham created this revision. shubham added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20626 AFFECTED

D20625: Truncate trailing forward slashes(/)

shubham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20625 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

shubham created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO BRANCH trailing REVISION DETAIL https://phabricator.kde.org/D20625 AFFECTED FILES src/core/kmountpoint.cpp

Re: KCrash - test_crasher spins in a loop on Windows

On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > Hi all, > > Currently we have an issue where the test_crasher test will endlessly > fork itself while trying to setup it's conditions to run. > > This leads to an issue where it will occupy a single CPU core of a > builder indefinitely until it's

D20529: add license to python test files

bcooksley added a comment. In D20529#451561 , @bruns wrote: > In D20529#451147 , @bcooksley wrote: > > > can we get the full command it's running? > > > `ctest -V -R externalextractortest`