KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 27 Apr 2019 16:48:14 + Build duration: 7 min 34 sec and counting BUILD ARTIFACTS

D20870: Fix vimode_keys AltGr test

This revision was automatically updated to reflect the committed changes. Closed by commit R39:710a951d3053: Fix vimode_keys AltGr test (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20870?vs=57109=57112 REVISION DETAIL

D20852: Fix to show folding preview when move the mouse from bottom to top

cullmann added a comment. Harr, with that change it looks good here. Need that a Diff here or can I commit without? > Feel free to commit that. === For unit tests: if you have small improvements for the tests that make them more stable, feel free to commit

D20870: Fix vimode_keys AltGr test

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20870 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel,

D20870: Fix vimode_keys AltGr test

loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20870 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20870: Fix vimode_keys AltGr test

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Test has here always failed, now it passes again REPOSITORY

D20758: kpackagetool: read kpackage-generic.desktop from qrc

This revision was automatically updated to reflect the committed changes. Closed by commit R290:92abe506b8b1: kpackagetool: read kpackage-generic.desktop from qrc (authored by dfaure). Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 27 Apr 2019 14:15:08 + Build duration: 1 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 27 Apr 2019 14:11:54 + Build duration: 3 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.12 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 27 Apr 2019 14:11:53 + Build duration: 3 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 27 Apr 2019 14:11:53 + Build duration: 1 min 53 sec and counting JUnit Tests Name:

D20752: Add missing properties in kpackage-generic.desktop

dfaure added a comment. ping? REVISION DETAIL https://phabricator.kde.org/D20752 To: dfaure, mart, apol, sitter Cc: #frameworks

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 86 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 27 Apr 2019 14:09:43 + Build duration: 2 min 50 sec and counting CONSOLE OUTPUT

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

hallas closed this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20860 To: hallas, dfaure, aacid, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20852: Fix to show folding preview when move the mouse from bottom to top

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2c2e345d4fbf: Fix to show folding preview when move the mouse from bottom to top (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH fix_kboomarkmenutest_without_bookmarks_editor (branched from master) REVISION DETAIL https://phabricator.kde.org/D20860 To: hallas, dfaure, aacid, ngraham Cc:

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57101. meven added a comment. Have to keep a reference to the connection in the object, or it gets deleted before the closure is run REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57099=57101 BRANCH

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

hallas updated this revision to Diff 57100. hallas marked 4 inline comments as done. hallas added a comment. Make the global functions static. REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20860?vs=57084=57100 BRANCH

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

hallas marked an inline comment as not done. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20860 To: hallas, dfaure, aacid, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57099. meven added a comment. Fix dropping directory REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57098=57099 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57098. meven added a comment. Use mostLocalUrls when resolving the dropped url, bettor organize code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57056=57098 BRANCH arcpatch-D20838 REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 27 Apr 2019 13:10:23 + Build duration: 2 min 23 sec and counting JUnit Tests Name:

D20748: Fix wrong "Unable to find service type" warnings

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson, davidedmundson, mpyne, apol Cc: anthonyfieroni, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20748: Fix wrong "Unable to find service type" warnings

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in desktopfileparser.cpp:402 > Where def is deleted? It's owned by the QCache. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson,

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

dfaure added a comment. Thanks for the debugging. Looks good, just minor coding style issues. INLINE COMMENTS > kbookmarkmenutest.cpp:42 > > +bool hasBookmarkEditorInstalled() > +{ prepend static (good practice in general so the symbol isn't exported, although in a test program it

D20852: Fix to show folding preview when move the mouse from bottom to top

loh.tar added a comment. > Have the feeling kateview_test testDragAndDrop fails more and more often. Have already spend a lot of time in look at that but without success Harr, with that change it looks good here. Need that a Diff here or can I commit without? commit

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. In D20209#456311 , @aacid wrote: > In D20209#456213 , @hallas wrote: > > > In D20209#455579 , @aacid wrote: > > > > > @hallas

D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed

hallas created this revision. hallas added reviewers: dfaure, aacid, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fix KBoomarkMenuTest when Bookmarks Editor is not installed. The test

D20852: Fix to show folding preview when move the mouse from bottom to top

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm and is more readable, thanks. REVISION DETAIL https://phabricator.kde.org/D20852 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, brauch, kwrite-devel, kde-frameworks-devel,