D20193: Expose locked keystates on KModifierKeyInfo when on wayland

alexeymin added inline comments. INLINE COMMENTS > dfaure wrote in kmodifierkeyinfoprovider.cpp:90 > Calling this an "abuse" is very arguable, see > https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ > I'm not aware of a KF5 policy about this, so it's fine as is.

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

dfaure added inline comments. INLINE COMMENTS > zzag wrote in kmodifierkeyinfoprovider.cpp:90 > Abuse of `auto`. Calling this an "abuse" is very arguable, see https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ I'm not aware of a KF5 policy about this, so it's fine

D21959: Fix selectedNameFilter() multiple matches

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_selectedNameFilter REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn,

D21940: Make automatic spellcheck work after reloading a document

dhaumann added inline comments. INLINE COMMENTS > ahmadsamir wrote in ontheflycheck.cpp:75 > In file included from /usr/include/qt5/QtCore/qalgorithms.h:43, >from /usr/include/qt5/QtCore/qlist.h:43, >from /usr/include/qt5/QtCore/QList:1, >

D21861: Add default variables for variables interface

dhaumann edited the summary of this revision. dhaumann edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns,

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60393. dhaumann added a comment. - Drop 'Current' prefix and improve documentation This should be good enough now, OK to commit? REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60384=60393 BRANCH

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. So it boils down to "let's try this and improve later if necessary" - well then :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf, meven Cc: filipf, squeakypancakes, dhaumann, aacid,

D14467: Auth Support: Drop privileges if target is not owned by root

bcooksley added a comment. Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D21861: Add default variables for variables interface

gregormi added a comment. In D21861#484556 , @dhaumann wrote: > I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? There is no other Document than

D21861: Add default variables for variables interface

dhaumann added a comment. I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc:

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60384. dhaumann added a comment. - Implement JS: variable expansion, e.g. %{JS:3+%{JS:2+1}} --> 6 - Variable expansion: Add unit tests REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=59959=60384 BRANCH

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60366. romangg added a comment. - Minor style changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60364=60366 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60364. romangg added a comment. - Revert drm_fourcc.h whitespace changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60360=60364 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747

D22003: Change selected text color to black

ndavis edited the summary of this revision. ndavis added a dependency: D22000: [colors/Breeze] Change selected text color to black. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D22003 To: ndavis, #vdg, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n,

D22003: Change selected text color to black

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Also make black text color match the Shade Black color:

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60360. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=28986=60360 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg commandeered this revision. romangg added a reviewer: fredrik. romangg added a comment. Thanks @fredrik for initiating this. I'll try to finish the patches up. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin,

D13150: Add ellipsis where appropriate

ngraham accepted this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#484197 , @dhaumann wrote: > These two points were not discussed anymore: I addressed them in https://phabricator.kde.org/D21907#482181: > 1. Isn't there a better solution by creating the folder and

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/60/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 13:55:01 + Build duration: 1 min 32 sec and counting JUnit Tests Name:

D21989: Don't show error message if sharing is cancelled by the user

This revision was automatically updated to reflect the committed changes. Closed by commit R495:a207a669815f: Dont show error message if sharing is cancelled by the user (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D21989: Don't show error message if sharing is cancelled by the user

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH noerror REVISION DETAIL https://phabricator.kde.org/D21989 To: nicolasfella, apol, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 60346. nicolasfella added a comment. - fall back to name REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=60341=60346 BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. These two points were not discussed anymore: 1. Isn't there a better solution by creating the folder and immediately select it + change to edit mode? 2. Resizing dialogs are usually not preferred. If everyone else thinks this change is a good idea - then

D13150: Add ellipsis where appropriate

aspotashev added a comment. We probably need to fall back to "%1..." if X-Purpose-Action is not defined, which is possible for 3rd-party plugins. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 12:57:26 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/51/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 12:57:26 + Build duration: 11 min and counting JUnit Tests Name:

D13150: Add ellipsis where appropriate

ngraham added a comment. Looks like a couple of strings are now blank: F6923766: Screenshot_20190622_150439.png REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc:

D13150: Add ellipsis where appropriate

nicolasfella added a comment. This resolves the issue that the name with ellipsis shows up in the dialog title REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg,

D13150: Add ellipsis where appropriate

nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

nicolasfella planned changes to this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 60341. nicolasfella added a comment. Implement Alexander's suggestion REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=53551=60341 BRANCH ellipsis REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/50/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 12:16:36 + Build duration: 6 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/137/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 22 Jun 2019 11:48:00 + Build duration: 33 min and counting BUILD ARTIFACTS

D20526: Fix extracting of some properties to match what was written

astippich retitled this revision from "fix extracting of some properties to match what was writen" to "Fix extracting of some properties to match what was written". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL

D20526: fix extracting of some properties to match what was writen

astippich updated this revision to Diff 60334. astippich added a comment. - remove usage of contactsFromString entirely REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=56170=60334 BRANCH arcpatch-D20526 REVISION DETAIL

D20526: fix extracting of some properties to match what was writen

astippich commandeered this revision. astippich edited reviewers, added: mgallien; removed: astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 11:48:00 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 137 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/137/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 11:48:00 + Build duration: 7 min 49 sec and counting JUnit Tests Name:

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. In D14467#483848 , @bcooksley wrote: > It would appear that the commit of this change disturbed somethng with FreeBSD builds - see

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 136 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/136/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 11:32:25 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 868

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/136/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 22 Jun 2019 11:32:25 + Build duration: 8 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 11:32:25 + Build duration: 7 min 23 sec and counting BUILD ARTIFACTS

D21907: Show feedback inline when creating new files or folders

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4fb959b910bf: Show feedback inline when creating new files or folders (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60299=60329

D21986: RFC: Change initial size of the config dialog

ngraham added a comment. In D21986#484013 , @aacid wrote: > How hard is to make the size be related to the contents instead of a magic number? +1, this would probably involve basing the size on the `StackView`'s child items and bubbling

D21989: Don't show error message if sharing is cancelled by the user

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH noerror REVISION DETAIL https://phabricator.kde.org/D21989 To: nicolasfella, apol, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

This revision was automatically updated to reflect the committed changes. Closed by commit R127:71cbb548e0ad: Proof of concept of a wayland protocol to allow the keystate dataengine to work (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20191?vs=55913=60325#toc

D21989: Don't show error message if sharing is cancelled by the user

nicolasfella marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21989 To: nicolasfella, apol, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

nicolasfella updated this revision to Diff 60321. nicolasfella added a comment. - use KIO::ERR_USER_CANCELED REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21989?vs=60317=60321 BRANCH noerror REVISION DETAIL https://phabricator.kde.org/D21989

D21986: RFC: Change initial size of the config dialog

aacid added a comment. How hard is to make the size be related to the contents instead of a magic number? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21986 To: nicolasfella, #vdg, apol, ngraham Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh,

D21989: Don't show error message if sharing is cancelled by the user

broulik added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:55 > +// error == 0 means no error, error == 1 means cancelled by the user > +if (error <= 1) { > if (output.contains(QLatin1String("url"))) If possible use `KIO::ERR_USER_CANCELED`, otherwise

D21989: Don't show error message if sharing is cancelled by the user

nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Cancelling a share is usually intentional and should not result

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/49/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 10:26:26 + Build duration: 21 min and counting JUnit Tests Name:

D21986: RFC: Change initial size of the config dialog

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21986 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

nicolasfella created this revision. nicolasfella added reviewers: VDG, apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The dialog is larger than it needs to be REPOSITORY R495

D20443: Move to runtime the decision to use x11 or not

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:0fe2990dbad9: Move to runtime the decision to use x11 or not (authored by apol). REPOSITORY R273 KGuiAddons

Re: KInit - Current state and benchmarks

Benchmarks of dolphin on a low end ARM laptop: Dolphin via QProcess: 1233ms Dolphin via Kinit: 1144ms again a consistent saving in the order of ~7% Initially I had wanted to scrap it, I'm now very conflicted. I'll try to port all of plasma services to use it properly again and see what

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

This revision was automatically updated to reflect the committed changes. Closed by commit R300:0ae8718ff331: Downgrade KDEWebKit from Tier 3 to Porting Aids (authored by vkrause). REPOSITORY R300 KDEWebKit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21400?vs=58645=60303

D20526: fix extracting of some properties to match what was writen

mgallien added a comment. In D20526#483910 , @astippich wrote: > @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. > Or do you mind if I take over? I would

D21907: Show feedback inline when creating new files or folders

meven accepted this revision. meven added a comment. This is look good to me ! REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf, meven Cc: filipf,

D20526: fix extracting of some properties to match what was writen

astippich added a comment. @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. Or do you mind if I take over? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: mgallien,

D20526: fix extracting of some properties to match what was writen

ngraham edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: mgallien, astippich, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D21907: Show feedback inline when creating new files or folders

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

ngraham added inline comments. INLINE COMMENTS > meven wrote in knewfilemenu.cpp:1099 > Shouldn't we disable the ok button here ? No, because this isn't an error condition (it's just a warning). > meven wrote in knewfilemenu.cpp:1122 > Same here No, because this isn't an error condition (it's

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60299. ngraham marked 4 inline comments as done. ngraham added a comment. Disable Ok button for all error conditions (but not for warning conditions) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60137=60299

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/125/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 09:39:17 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/124/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 15:47:07 + Build duration: 17 hr and counting BUILD ARTIFACTS

D14467: Auth Support: Drop privileges if target is not owned by root

bcooksley added a comment. It would appear that the commit of this change disturbed somethng with FreeBSD builds - see https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/ Could someone take a look into that please? REPOSITORY R241 KIO REVISION

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 109 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/109/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 09:30:05 + Build duration: 2 min 48 sec and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 108 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/108/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 09:25:41 + Build duration: 44 sec and counting CONSOLE OUTPUT

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

zzag added inline comments. INLINE COMMENTS > kmodifierkeyinfo.cpp:34-44 > +#ifdef WITH_XCB > +if (qGuiApp->platformName() == QLatin1String("xcb")) > +return new KModifierKeyInfoProviderXcb; > +else > +#endif > +#ifdef WITH_WAYLAND > +if (qGuiApp->platformName() ==

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 107 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/107/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 09:22:59 + Build duration: 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 106 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/106/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 09:07:11 + Build duration: 4 min 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 09:04:20 + Build duration: 3 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 53 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 08:58:39 + Build duration: 5 min 40 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 22 Jun 2019 09:01:29 + Build duration: 1 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 105 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/105/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 09:01:30 + Build duration: 54 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/59/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 09:01:29 + Build duration: 1 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 104 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/104/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Jun 2019 08:58:39 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 22 Jun 2019 08:58:39 + Build duration: 41 sec and counting CONSOLE OUTPUT [...truncated 236

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/58/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 08:58:40 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT

D21967: Fix warning when reading plugin metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R495:3d3af03052d0: Fix warning when reading plugin metadata (authored by nicolasfella, committed by aacid). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D21907: Show feedback inline when creating new files or folders

meven added inline comments. INLINE COMMENTS > knewfilemenu.cpp:1099 > +m_messageWidget->setMessageType(KMessageWidget::Information); > +m_messageWidget->animatedShow(); > +} Shouldn't we disable the ok button here ? > knewfilemenu.cpp:1109 > +

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert marked an inline comment as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert updated this revision to Diff 60286. hoffmannrobert added a comment. - Remove redundant condition REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21959?vs=60217=60286 BRANCH fix_selectedNameFilter

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. If there are no formal objections, I'd like to land this. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf,

D21959: Fix selectedNameFilter() multiple matches

ngraham edited the test plan for this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > slavebase.cpp:1511 > +KIO_DATA << d->m_warningCaption << d->m_warningMessage << > privilegeOperationDetails; > +send(INF_PRIVILEGE_CONF, data); > +if

D21882: RFC: [CopyJob] Batch reporting processed amount

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK in principle, but it might be that a setProcessedAmount(Bytes, totalSize) is missing at the end of the last file, so we don't end up with a progress dialog that looks like

D21959: Fix selectedNameFilter() multiple matches

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. +1 for the included unittest. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:80 > */ > -static QString kde2QtFilter(const QStringList , const QString ) > +static QString

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > keystate.xml:22 > + > +xxx > + Interesting description. Does the number of 'x' mean anything? ;) >