D20526: Fix extracting of some properties to match what was written

astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D20766: Use appropriate background color for text previews

kossebau added a comment. In D20766#488044 , @meven wrote: > For context : > F6943088: Screenshot_20190629_110927.png > > Given D21295 , can we move forward here

D22144: - Add kio recentlyused:/ to access KactivitytStats data

elvisangelaccio added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D22147: Better use of Qt APIs in Plasma::Theme

fvogt resigned from this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22147 To: apol, #plasma, #frameworks Cc: bruns, tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60932. apol marked an inline comment as done. apol added a comment. address fvogt's comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60875=60932 BRANCH arcpatch-D22147 REVISION DETAIL

D22147: Better use of Qt APIs in Plasma::Theme

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > fvogt wrote in svg.cpp:317 > It really does not look that way as you're immediately using captures after > that. > > If that's really what you want (which I doubt), it should be >

D22147: Better use of Qt APIs in Plasma::Theme

bruns added inline comments. INLINE COMMENTS > tcanabrava wrote in svg.cpp:342-349 > looks a good example of code that could be written with an std::find_if You either have to sort on `bestFit.area()` first, or do the find_if in a nested loop, to find a better match (smaller one) after the

D22147: Better use of Qt APIs in Plasma::Theme

fvogt added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:317 > Please note this is only to make sure the regex was properly compiled. It > isn't matching there yet. It really does not look that way as you're immediately using captures after that. If that's really what you want

D22147: Better use of Qt APIs in Plasma::Theme

apol added inline comments. INLINE COMMENTS > fvogt wrote in svg.cpp:317 > `isValid` is always true, you probably want to use `hasMatch` instead. > > This is not obvious, I only noticed this because I debugged this error before > (https://phabricator.kde.org/D17359) Please note this is only

D22147: Better use of Qt APIs in Plasma::Theme

tcanabrava added inline comments. INLINE COMMENTS > svg.cpp:342-349 > +for (const QSize : elementSizeHints) { > > if (hint.width() >= s.width() * ratio && hint.height() >= > s.height() * ratio && > (!bestFit.isValid() || >

D22147: Better use of Qt APIs in Plasma::Theme

tcanabrava added inline comments. INLINE COMMENTS > svg.cpp:339-364 > if (!elementSizeHints.isEmpty()) { > QSize bestFit(-1, -1); > > -Q_FOREACH (QSize hint, elementSizeHints) { > +for (const QSize : elementSizeHints) { > > if

D22147: Better use of Qt APIs in Plasma::Theme

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > svg.cpp:317 > +const auto match = sizeHintedKeyExpr.match(key); > +if (match.isValid()) { > +QString baseElementId =

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. In D22155#488593 , @ngraham wrote: > In D22155#488485 , @anthonyfieroni wrote: > > > Renaming the icon is not quite good, if someone use newer framework and old

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60920. leinir added a comment. - Uncrash the author hash (don't use const QString references as key...) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60781=60920 BRANCH knsquick-feature-parity-with-kns

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven marked 4 inline comments as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven marked 2 inline comments as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D22102: Implement apply-on-double-click for all grid view KCM delegates

davidedmundson added a comment. > Exposing the options through a simple command line interface would be another option. At the risk of getting offtopic, it's the reason I started the KConfigWatcher class. The intention being for "kwriteconfig" to be used generically and then anything

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven updated this revision to Diff 60913. meven added a comment. Use an iterator to loop over globalFstabCache->m_fstabCache REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21204?vs=60855=60913 BRANCH arcpatch-D21204 REVISION DETAIL

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. Hi Marco, see https://phabricator.kde.org/D22138 (I also included the white background in there, because it turned out a bit tricky). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks,

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#487566 , @hpereiradacosta wrote: > ather simple and attached. Feel free to add this or something similar to any other modification you plan to do. F6938398: patch.diff >

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

broulik added inline comments. INLINE COMMENTS > fstabhandling.cpp:227 > +QStringList devices = globalFstabCache->m_mtabCache.keys(); > +const QStringList fstabDevices = globalFstabCache->m_fstabCache.keys(); > + Don't create a temporary `keys()` list just to iterate it. Use a loop like

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven retitled this revision from "Ensure mounted mounted nfs filesystems matches their fstab declared counterpart" to "Ensure mounted nfs filesystems matches their fstab declared counterpart". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns,

D21204: Ensure mounted mounted nfs filesystems matches their fstab declared counterpart

meven added a comment. In D21204#488719 , @dhaumann wrote: > Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin.

D21204: Ensure mounted mounted nfs filesystems matches their fstab declared counterpart

meven retitled this revision from "Ensure no trailing slash in mountpoint read from fstab file" to "Ensure mounted mounted nfs filesystems matches their fstab declared counterpart". meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R245 Solid