D21713: Fortran: implement free & fixed formats

nibags added inline comments. INLINE COMMENTS > dhaumann wrote in fortran-free.xml:3 > Is it correct that include keywords was added with 5.53? Include keywords was added in KF5.52, but the implementation had a bug that was fixed in KF5.53. So far, the files that use this (SCSS and TypeScript)

D21713: Fortran: implement free & fixed formats

dhaumann added inline comments. INLINE COMMENTS > fortran-free.xml:3 > + > + section="Sources" > extensions="*.f90;*.F90;*.f95;*.F95;*.f03;*.F03;*.f08;*.F08;" > mimetype="text/x-fortran-src" casesensitive="0" author="Franchin Matteo > (f...@libero.it), Janus Weil" license="LGPL"

D22258: Improve plugin caching

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Extend the plasmoid startup cache to DataEngines and ContaimentActions. Include a cache for

D22257: performance, Qt API

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use proper appending API Don't look-up twice REPOSITORY R290 KPackage BRANCH

D22253: Improve the Fortran fixed format syntax highlighting

nononux marked an inline comment as done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22253 To: nononux Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22253: Improve the Fortran fixed format syntax highlighting

nononux updated this revision to Diff 61110. nononux added a comment. Update of the version number + add the line proposed by nibags REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22253?vs=61103=61110 BRANCH fortran-fixed-format (branched

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth added inline comments. INLINE COMMENTS > brute4s99 wrote in kio_sftp.cpp:2257 > `S_IFLNK` is not defined on WIndows Does https://code.woboq.org/qt5/qtbase/mkspecs/common/posix/qplatformdefs.h.html#111 work? REPOSITORY R320 KIO Extras REVISION DETAIL

D21713: Fortran: implement free & fixed formats

nibags added a comment. Franchin Matteo & Janus Weil responded and agree to the MIT license. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D22253: Improve the Fortran fixed format syntax highlighting

nibags added a comment. Only a small detail needs to be added. You also have to increase the version of the file. INLINE COMMENTS > fortran-fixed.xml:557 > firstNonSpace="true"/> > column="0"/> > Here add the rule: `` In the previous fortran.xml file it was

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. `S_IFLNK` is not defined on WIndows REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D15645: Add scheme selection menu with a "System" entry.

amhndu added a comment. Sorry about the delay, got caught up in things. So here's the situation: Currently, the menu's actions store the scheme path as the data and applications that currently use this menu (eg. KDevelop and Kate), just store this scheme path in their config. So if we

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/133/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Jul 2019 20:16:22 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/143/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Jul 2019 20:16:22 + Build duration: 9 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/143/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Jul 2019 20:16:22 + Build duration: 8 min 15 sec and counting JUnit Tests Name:

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f9c2dfb6e8df: [ftp] Fix wrong access time in Ftp::ftpCopyGet() (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21952?vs=60195=61105 REVISION

D22253: Improve the Fortran fixed format syntax highlighting

nononux created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nononux requested review of this revision. REVISION SUMMARY 3 improvements: - Restore the comment highlighting when using the "!" character (comment all

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21952 To: wbauer, #frameworks, dfaure Cc: dfaure, kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

wbauer added a subscriber: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21952 To: wbauer, #frameworks Cc: dfaure, kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

mweichselbaumer closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To: mweichselbaumer, drosca Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 206 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/206/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 03 Jul 2019 18:36:21 + Build duration: 7 min 46 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 108 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/108/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Jul 2019 18:36:22 + Build duration: 6 min 56 sec and counting BUILD ARTIFACTS

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. ah, gotcha! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 104 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Jul 2019 18:36:22 + Build duration: 2 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/113/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Jul 2019 18:36:22 + Build duration: 1 min 59 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/107/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Jul 2019 18:25:22 + Build duration: 2 min 55 sec and counting BUILD ARTIFACTS

D22105: WIP : Fix SFTP Plugin of KIO for Windows

albertvaka added inline comments. INLINE COMMENTS > andriusr wrote in kio_sftp.cpp:2257 > I'm not sure what is intended to achieve here, the remote file _can_ be a > symlink, and IIRC when we had sftp on dolphin in KDE4 those symlinks were > shown as such. I think what they mean is that if

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 106 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/106/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Jul 2019 18:18:11 + Build duration: 7 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Jul 2019 18:21:05 + Build duration: 2 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 204 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/204/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 03 Jul 2019 18:18:12 + Build duration: 3 min 54 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/112/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Jul 2019 18:20:15 + Build duration: 1 min 52 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 102 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/102/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Jul 2019 18:18:11 + Build duration: 2 min 52 sec and counting BUILD ARTIFACTS

D21713: Fortran: implement free & fixed formats

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c579929d8667: Fortran: implement free fixed formats (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D22095: Fix CMake COMMAND nested paren highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2abb1fd6e151: Fix CMake COMMAND nested paren highlighting (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22095?vs=60819=61098#toc REPOSITORY R216 Syntax Highlighting

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/111/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Jul 2019 18:18:11 + Build duration: 2 min 2 sec and counting JUnit Tests

D22095: Fix CMake COMMAND nested paren highlighting

cullmann accepted this revision. cullmann added a comment. Then we merge this ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting, cullmann Cc: turbov, cullmann, kwrite-devel, kde-frameworks-devel,

D22250: get rid of blockSignals

This revision was automatically updated to reflect the committed changes. Closed by commit R296:087be3e4f4be: get rid of blockSignals (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22250?vs=61096=61097 REVISION DETAIL

D15645: Add scheme selection menu with a "System" entry.

ngraham added a comment. Gentle ping. :) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22250: get rid of blockSignals

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R296 KDeclarative BRANCH blocksignals REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, michaelh,

D22250: get rid of blockSignals

mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22250: get rid of blockSignals

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Don't call blockSignals, but instead, to avoid an infinite signal chain, check KCoreConfigSkeleton::configChanged wasn't

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. I believe I have covered all the issues with the patch now. (: REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 61084. brute4s99 added a comment. renamed variables (start with `m_` now) REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=60035=61084 BRANCH arcpatch-D21661 REVISION DETAIL

D22241: KModifierKeyInfo: we are sharing the internal implementation

apol created this revision. apol added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use data types that will only destroy it when necessary. REPOSITORY R273 KGuiAddons

D22216: Use wayland-protocols

zzag retitled this revision from "RFC: Use wayland-protocols" to "Use wayland-protocols". REPOSITORY R127 KWayland BRANCH use-wayland-protocols REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks, romangg, davidedmundson Cc: davidedmundson, apol, romangg,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61065. leinir added a comment. - Add profile page to the author classes - Add a spacer item to the CommentsPage listview - A touch of visual cleaning in the comment delegate - Type-safe comparisons are good - Throttle the fetch calls just a touch,

D22216: RFC: Use wayland-protocols

davidedmundson accepted this revision. davidedmundson added a comment. It's the technically correct thing to do. > Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release. The problem there is that then we're not giving

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. In D22105#489954 , @vonreth wrote: > Any reason why you skip the symlinks? > I mean displaying thm should be fine, dolphin probably can also follow them. > Creating them on windows is a bit more problematic.

D22235: PoC: asynchronous initialization of Solid::UDisks backend

apol planned changes to this revision. apol added a comment. This breaks solid, needs to notify about the new devices somehow. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22235 To: apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22235: PoC: asynchronous initialization of Solid::UDisks backend

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY There's a bunch of blocking calls in the construction of the backend that shouldn't be necessary. TEST PLAN Tests pass

D21713: Fortran: implement free & fixed formats

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fortran-fixed-free REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Ok, please merge REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns,

D22216: RFC: Use wayland-protocols

romangg accepted this revision. romangg added a subscriber: davidedmundson. romangg added a comment. This revision is now accepted and ready to land. Yea, let's wait until 5.60 branched and then push for 5.61 (after next weekend) as long as @davidedmundson does not say anything against it

D22216: RFC: Use wayland-protocols

zzag added a comment. Also, it's worth to point out that neither weston, nor Mutter, nor wlroots copy protocol specs, they just have wayland-protocols as a dependency. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: apol,

D22216: RFC: Use wayland-protocols

zzag added a comment. Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release. If the protocol is really importatnt, we can make temporary copy and after several kwayland releases drop it. REPOSITORY R127 KWayland REVISION

D22216: RFC: Use wayland-protocols

zzag added a comment. > Why was it done differently until now? I can't give you an answer, but my guess is for historical reasons. Initially, kwayland repo had only proprietary protocols, like server_decoration, etc. Protocols from wayland-protocols were copied to follow the pattern.

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488981 , @anthonyfieroni wrote: > +1 to be part of Plasma 5.17 Wouldn't my proposed approach be better? Also, only one patch out of many actually affects Plasma. In D22155#488595

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth added a comment. Any reason why you skip the symlinks? I mean displaying thm should be fine, dolphin probably can also follow them. Creating them on windows is a bit more problematic. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked an inline comment as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:402 > What about the QFileInfo? For my use case, I could not find any possibility of symlinks, (traversing Android filesystem) so I left it blank in here for any future