KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 24 Sep 2019 00:49:47 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 85 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Sep 2019 00:49:52 + Build duration: 15 min and counting BUILD ARTIFACTS

D24180: Jam: fix identifier in a SubRule

jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH jam_check_ident (branched from master) REVISION DETAIL

D24179: Fix skipOffset with dynamic RegExpr

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The pattern used depends on the previous contexts so skipOffset cannot be computed

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

nibags added a comment. In the function `KateModeMenuList::updateSelectedItem()` an empty QIcon is also created when selecting an item. It would be better to put `emptyIcon` as an attribute of the class and use it every time. I will do it in another commit, I have seen others bugs in

D24176: Add syntax definition for Perl6

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5e0343812c22: Add syntax definition for Perl6 (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24176?vs=66720=66721#toc REPOSITORY R216 Syntax Highlighting CHANGES

D24176: Add syntax definition for Perl6

jpoelen updated this revision to Diff 66720. jpoelen added a comment. Perl: increase version... over and over again :) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24176?vs=66718=66720 BRANCH perl6 (branched from master) REVISION DETAIL

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir added a comment. In D24171#536712 , @dfaure wrote: > Cool, I'll review this. BTW don't touch begin/end loops, that's done in D24160 already. Yep, I saw it on the ML :-) REPOSITORY R241

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added a comment. Cool, I'll review this. BTW don't touch begin/end loops, that's done in D24160 already. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc:

D24176: Add syntax definition for Perl6

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. This is incredible! I have no idea about Perl 6, but this looks cool given the example you added. Only nitpick: increase the perl.xml version, then push. Thanks a lot for

D24176: Add syntax definition for Perl6

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 392468 REPOSITORY R216 Syntax Highlighting BRANCH perl6 (branched from

D23512: Avoid overloading KCModule::changed

davidedmundson updated this revision to Diff 66716. davidedmundson added a comment. add KCONFIGWIDGETS_DEPRECATED REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23512?vs=64773=66716 BRANCH master REVISION DETAIL

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: kde-frameworks-devel, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and tests pass REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from

D21235: Add handling of fuseiso filesystem type

hallas added a comment. In D21235#535951 , @bruns wrote: > In D21235#535861 , @hallas wrote: > > > I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 96 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/96/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 23 Sep 2019 17:39:50 + Build duration: 5 min 50 sec and counting JUnit Tests Name:

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8cb82970b347: Status bar mode menu: Reuse empty QIcon that is implicitly shared (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH use-qicon-implicitly-shared REVISION DETAIL https://phabricator.kde.org/D24166 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Instead of creating N empty QIcons, use just one QIcon that

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 95 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/95/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 23 Sep 2019 16:45:11 + Build duration: 7 min 14 sec and counting JUnit Tests Name:

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f1ed78f55d64: Expose KTextEditor::MainWindow::showPluginConfigPage() (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24164?vs=66683=66686

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems useful, maches the int configPages()/configPage(int number, QWidget *parent) api REPOSITORY R39 KTextEditor BRANCH expose-show-plugin-config-page REVISION DETAIL

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY The application already has a counterpart that takes a

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. Changed the menu again! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 edited dependent revision(s), added 1: D24162: Hide "Lock Widgets" button from panel edit mode toolbar; removed 1: D23952: Remove panel toolbox. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg,

D23951: Improve desktop layout and panel editing UX

GB_2 removed a dependency: D23950: Only show "Add Widgets..." panel context menu option in panel edit mode. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D23951: Improve desktop layout and panel editing UX

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 66670. kossebau added a comment. add first set of unit tests covering the main functionality. Feedback on principal approach wanted! Also add some fixes to actual macro code found by the tests already :) REPOSITORY R240 Extra CMake Modules

D23951: Improve desktop layout and panel editing UX

GB_2 updated this revision to Diff 8. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66162=8 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 AFFECTED FILES

D24159: new module ECMSourceVersionControl

kossebau added a comment. In D24159#536388 , @kossebau wrote: > Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` I am blind, ignore me. REPOSITORY

D24159: new module ECMSourceVersionControl

kossebau added a comment. Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` Would be also good to have this variable being set mentioned in KDECompilerSettings, unless this is also not under public

D24160: [KIO] Modernize the code to use range-for in more places

kossebau added a comment. Will see to give this some review later this week (if still needed). Would agree the "modern" code is more easy to grasp by humans and thus better to maintain, so +1 for principle. All override changes please as separate commit though, unrelated to commit

D24159: new module ECMSourceVersionControl

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham,

D24160: [KIO] Modernize the code to use range-for in more places

dfaure created this revision. dfaure added reviewers: bruns, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This was done using clang-tidy's modernize-loop-convert, then clazy (for

D24159: new module ECMSourceVersionControl

sitter created this revision. sitter added reviewers: kde-buildsystem, dfaure. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY simply sets a variable when the source is under version

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/98/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 23 Sep 2019 13:52:05 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a subscriber: chehrlic. kossebau added a comment. @chehrlic Hi. As I just discovered, you are the author of the macros for Qt (commit ) which I took as inspiration/blue print when

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick Update (week 39): took me a bit longer to design and write tests, not trained to write such things in cmake code, all its magic & caches & scopes + own undiscovered typos make this not (yet?) fun, and I am not certain I have done things properly, so will be

D24076: add a simple smoke test for slaves by using kioclient5

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6bdc413c720b: add a simple smoke test for slaves by using kioclient5 (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24076?vs=66452=66655

D24076: add a simple smoke test for slaves by using kioclient5

sitter added a comment. In D24076#534627 , @feverfew wrote: > I won't review, but would like to note I think that with KIOFuse, in conjuction with fio we can do some really complex testing on KIO, correct me if