D24185: Add format-text-underline-squiggle actions icons

ndavis added a comment. 16px F7426808: format-text-underline-squiggle.svg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg,

D24185: Add format-text-underline-squiggle actions icons

ndavis added a comment. F7426794: Screenshot_20190924_222405.png F7426789: Screenshot_20190924_222520.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION

D24185: Add format-text-underline-squiggle actions icons

ndavis added a comment. F7426757: Screenshot_20190924_221218.png F7426760: Screenshot_20190924_221251.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master)

D24185: Add format-text-underline-squiggle actions icons

ndavis added a comment. F7426754: 2019-09-24 22.15.33.jpg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis,

D24185: Add format-text-underline-squiggle actions icons

ndavis added a comment. I have some improvement to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th. REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL

D24179: Fix skipOffset with dynamic RegExpr

jpoelen updated this revision to Diff 66788. jpoelen added a comment. - add a comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24179?vs=66724=66788 BRANCH d399388 (branched from master) REVISION DETAIL

D24180: Jam: fix identifier in a SubRule

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c409eb751b91: Jam: fix identifier in a SubRule (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24180?vs=66725=66789 REVISION

D24185: Add format-text-underline-squiggle actions icons

ngraham accepted this revision. ngraham added a subscriber: ndavis. ngraham added a comment. This revision is now accepted and ready to land. @ndavis? REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL

D23951: Improve desktop layout and panel editing UX

ngraham added a comment. In D23951#537209 , @GB_2 wrote: > In D23951#537202 , @ngraham wrote: > > > +1 in general, but since this removes the GUI ability to enter locked mode, it can't land until

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. In D23951#537202 , @ngraham wrote: > we need to wait for a visible non-right-click method to enter Panel Edit Mode. I think we'll need a task for that. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 updated this revision to Diff 66778. trickyricky26 added a comment. - Use butt line ending for slightly nicer asthetics REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24185?vs=66738=66778 BRANCH format-text-underline-squiggle

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. In D23951#537202 , @ngraham wrote: > +1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a

D23951: Improve desktop layout and panel editing UX

ngraham added a comment. +1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a visible non-right-click method to enter Panel Edit Mode. Maybe for now we can put

D24185: Add format-text-underline-squiggle actions icons

ngraham added a comment. Lol "squiggle." I can't think of anything better either. Maybe the stroke would look better with butt-style ends? Like this: F7424982: Screenshot_20190924_094046.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D24160: [KIO] Modernize the code to use range-for in more places

kossebau added a comment. Not tested the changes myself, only looked at the code here. Looks good to me in general, modulo the comments I made. When it comes to `it`, my code reading expectations are that it is a real iterator, same like `i` is an integer index. The current patch

D24185: Add format-text-underline-squiggle actions icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: WIP: port ftp slave to new error reporting system

sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: WIP: port ftp slave to new error reporting system

sitter added inline comments. INLINE COMMENTS > dfaure wrote in ftptest.cpp:186 > what's bad quot? > > Is this test about a bug, or the job failing is what we want? That was meant to read quota. I've changed it to QVERIFY(!job->exec()); as per your earlier comment. > dfaure wrote in

D23579: WIP: port ftp slave to new error reporting system

sitter updated this revision to Diff 66747. sitter marked 31 inline comments as done. sitter added a comment. address numerous comments (marked done on phab) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23579?vs=64989=66747 BRANCH ftp REVISION DETAIL

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. LGTM on the FreeBSD side (I've checked, the procctl() code does block debugger access which is all we're asking to do). REPOSITORY R299 KDESu REVISION DETAIL

D5394: KAuth integration in document saving - vol. 2

volkov added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL

D24182: Fix FindEGL when using Emscripten

hausmann closed this revision. hausmann added a comment. Thanks, landed in 3b0bf71a72789eb2b79310b4f67602115e347f56 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24182 To: hausmann, vkrause, tcberner, alexmerry Cc: kde-frameworks-devel,

D24182: Fix FindEGL when using Emscripten

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks safe to me, should not change the non-EMSCRIPTEN behavior. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24182 To: hausmann, vkrause,

D24182: Fix FindEGL when using Emscripten

hausmann created this revision. hausmann added reviewers: vkrause, tcberner, alexmerry. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hausmann requested review of this revision. REVISION SUMMARY When using the Emscripten

D24180: Jam: fix identifier in a SubRule

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH jam_check_ident (branched from master) REVISION DETAIL https://phabricator.kde.org/D24180 To: jpoelen, cullmann Cc: cullmann,

D24179: Fix skipOffset with dynamic RegExpr

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks I think it would be nice to have a comment added to the 612 ​ 613 /** 613 ​/** 614* no match 614 ​