KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 05:13:16 + Build duration: 9 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 04 Oct 2019 05:13:16 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 05:13:16 + Build duration: 2 min 24 sec and counting JUnit Tests Name:

D24318: Make 32px document-save icon colorful

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

ngraham updated this revision to Diff 67298. ngraham added a comment. Use a nicer color for the label REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24318?vs=67263=67298 BRANCH colorful-32px-save-icon (branched from master) REVISION DETAIL

D24354: Mustache/Handlebars: minor fixes

nibags added a comment. As the delimiters in WordDetect rules were changed in D24378 , I updated this diff only by making minor fixes in the Mustache/Handlebars definition. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24354: Mustache/Handlebars: minor fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D24354: Mustache/Handlebars: minor fixes

nibags retitled this revision from "Mustache/Handlebars: fix delimiters in HTML tags" to "Mustache/Handlebars: minor fixes". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags updated this revision to Diff 67297. nibags added a comment. Minor corrections: - Restore WordDetect rules - Use **kateversion="5.44"** (WordDetect with insensitive). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D24378: WordDetect rule: detect delimiters at the inner edge of the string

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D24400: Make hours qint64

usta added inline comments. INLINE COMMENTS > kformatprivate.cpp:339 > > -int hours = ms / MSecsInHour; > +const qint64 hours = ms / MSecsInHour; > ms = ms % MSecsInHour; why dont we use quint64 in here ? > kformatprivate.cpp:470 > quint64 ms = msecs; > int days = ms

D24010: Fix generating properties that start with an uppercase letter

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a23acd2f1535: Fix generating properties that start with an uppercase letter (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=67204=67294

D24384: Move Amusement to Games directory instead of Games > Toys

ltoscano added a comment. Can you please at least remove the steam example from the commit message, as it is not relevant (it is a downstream change) and remove the reference to the bug? Does it also mean that kf5-toys.directory is not used anymore? (not sure whether it can't be removed

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. I don't appreciate the flippant and dismissive attitude in that comment. I would ask that you interact with more respectfulness. Thanks. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks, #vdg,

D24384: Move Amusement to Games directory instead of Games > Toys

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D24384#541646 , @aacid wrote: > Really? toys are only for children and adults should be ashamed to play with toys? Come on, i thought we

D24402: [PlasmaComponents3] Fix checkable toolbutton background

ngraham added a dependent revision: D24407: Increase UI commonality between KCM and applet. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24402 To: ngraham, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24406: Small performance improvements suggested by clang tidy

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D24406 AFFECTED FILES

D24405: Small performance improvements suggested by clang-tidy

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24405 AFFECTED FILES

D24404: Small performance improvements suggested by clang-tidy

aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D24404 AFFECTED FILES

D24010: Fix generating properties that start with an uppercase letter

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24010 To: apol, #frameworks, davidedmundson Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24403: Small performance improvements suggested by clang-tidy

aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REVISION SUMMARY As far as i can see none of the modified .h files is actually public so that shouldn't be a BC problem

D24402: [PlasmaComponents3] Fix checkable toolbutton background

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This fixed the background of a checkable PC3 ToolButton not being visible when

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 21:19:17 + Build duration: 2 min 13 sec and counting JUnit Tests Name:

D24399: Pass QDir by const & instead of copy

aacid closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24399 To: aacid, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 107 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/107/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 21:07:05 + Build duration: 9 min 52 sec and counting JUnit Tests Name:

D24399: Pass QDir by const & instead of copy

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24399 To: aacid, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

muesli added a comment. Careful: we must _not_ land this before the next Plasma release. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. muesli requested review of this revision. REVISION SUMMARY Since https://phabricator.kde.org/D22381 has landed kactivitymanagerd now exposes

D24400: Make hours qint64

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY msec is qint64 and pretty sure the biggest qint64 / 360 still doesn't fit in an integer REPOSITORY R244 KCoreAddons

D24399: Pass QDir by const & instead of copy

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24399 AFFECTED FILES

D13541: Port solid from Qt5::Widgets to Qt5::Gui

dhaumann added a comment. @graesslin pong? One year passed. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

dhaumann added a comment. I think it's fine as is. The docbook says: Detect an exact string but additionally require word boundaries such as a dot '.' or a whitespace on the beginning and the end of the word. Think of \bstring\b in terms of a regular expression, but it is

D24398: Rewrite ugly for with pointer arithmetic into range for

aacid closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24398 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23266: Export Plasma core lib log category, add a category to a qWarning

apol accepted this revision. apol added a comment. Go for it, can change later too. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23266 REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik, davidedmundson, apol Cc: apol,

D24398: Rewrite ugly for with pointer arithmetic into range for

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24398 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

rjvbb added a comment. And my point is that you are doing 720 translations and 360 rotations per cycle, with subsequent smoothing of an image, continuously and with sufficient temporal resolution to get a fluid animation that is completely overkill here. Indicating a busy state (a two-state

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Lol it's opensuse being silly, oh well. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks, #vdg Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Really? toys are only for children and adults should be ashamed to play with toys? Come on, i thought we were past that. Anyway, i'm really confused now, does your Stream have the Amusement category? Because the steam.desktop from

D24389: Fix klistopenfilesjob header file not being installed

dfaure added a comment. `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included. (I do that on the first Saturday of the month) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24389 To: hallas, dfaure,

D24384: Move Amusement to Games directory instead of Games > Toys

ngraham added a reviewer: VDG. ngraham added a comment. I agree with @guoyunhe. "Toys" isn't an appropriate word to use in the context of computers and software. From a native English speaker's perspective here, a toy is something physical that you give to children. Using the word to

D24390: Add more file and directories to exclude filters

ngraham added inline comments. INLINE COMMENTS > ognarb wrote in fileexcludefilters.cpp:137 > This directory contains only pure PHP code, so not possible by filename or > minetype. Maybe we could use the fact that a composer.json is always included > in the same directory? PHP source code

D24398: Rewrite ugly for with pointer arithmetic into range for

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24398 AFFECTED FILES

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe added a comment. In D24384#541589 , @aacid wrote: > Have you contacted Valve to tell them amusement is the wrong category for Steam? > > Because the spec says Amusement - > a simple amusement > > And that's not what steam is >

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 17:15:18 + Build duration: 1 min 59 sec and counting JUnit Tests Name:

D24389: Fix klistopenfilesjob header file not being installed

hallas added a comment. In D24389#541539 , @ngraham wrote: > Please land this ASAP so it gets into Frameworks 5.63. Landed it now, is there anything else I need to do so that it makes the 5.63 release? REPOSITORY R244 KCoreAddons

D24389: Fix klistopenfilesjob header file not being installed

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24389 To: hallas, dfaure, meven, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24395: Add some std::move in setter functions

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten when we can, in fact, fix it properly, that'd be great :) REPOSITORY R235 Attica BRANCH master REVISION

D24395: Add some std::move in setter functions

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY typically we pass the param as const &, but here we forgot, we can fix that problem by adding an std::move and have a

D23266: Export Plasma core lib log category, add a category to a qWarning

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23266 REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik, davidedmundson Cc: apol, kde-frameworks-devel,

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a comment. ping @apol REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Have you contacted Valve to tell them amusement is the wrong category for Steam? Because the spec says Amusement - > a simple amusement And that's not what steam is IMHO this patch is wrong and steam is what needs fixing. REPOSITORY R309 KService

D24388: Mark technology propertie as constant to avoid warning

This revision was automatically updated to reflect the committed changes. Closed by commit R245:edb12de9490e: Mark technology propertie as constant to avoid warning (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24388?vs=67260=67266

D24390: Add more file and directories to exclude filters

ognarb added inline comments. INLINE COMMENTS > ngraham wrote in fileexcludefilters.cpp:137 > This one makes me a little nervous since it's a not-very-uncommon English > word, not something implicitly technical that we can be safe excluding. > > Is there any other way we could exclude the

D24389: Fix klistopenfilesjob header file not being installed

ngraham accepted this revision. ngraham added a comment. Please land this ASAP so it gets into Frameworks 5.63. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24389 To: hallas, dfaure, meven, ngraham Cc: ngraham, kde-frameworks-devel,

D24390: Add more file and directories to exclude filters

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fileexcludefilters.cpp:109 > > const int s_defaultFileExcludeFiltersVersion = 5; > Gotta bump this number whenever you change

D24390: Add more file and directories to exclude filters

ognarb added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: ognarb, #baloo Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

ognarb created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN None for the moment REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24390

D24389: Fix klistopenfilesjob header file not being installed

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24389 To: hallas, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24389: Fix klistopenfilesjob header file not being installed

hallas created this revision. hallas added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY The header file KListOpenFilesJob and klistopenfilesjob.h was not being

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 14:27:28 + Build duration: 1 min 30 sec and counting JUnit Tests Name:

D24318: Make 32px document-save icon colorful

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

ngraham updated this revision to Diff 67263. ngraham added a comment. Update according to review comments REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24318?vs=67083=67263 BRANCH colorful-32px-save-icon (branched from master) REVISION DETAIL

D24388: Mark technology propertie as constant to avoid warning

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D24388 To: meven, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

GB_2 edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

ngraham added a comment. +1 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24388: Mark technology propertie as constant to avoid warning

meven created this revision. meven added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To avoid output such as : QQmlExpression: Expression

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added a comment. My point is that your lamentations have nothing to do with this class but with Q*Animation on your system. So you need to find out what's wrong and talk to Qt. I am 100% against a workaround that degrades the user experience when the bug isn't even in this class.

D24378: WordDetect rule: detect delimiters at the inner edge of the string

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen Cc:

D24378: WordDetect rule: detect delimiters at the inner edge of the string

cullmann added a comment. Seems reasonable, do we need some doc updates? Or some more verbose description in the XSD? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen

D24387: improve error reporting for when kpasswdserver is unreachable

ngraham added reviewers: Frameworks, dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D24387: improve error reporting for when kpasswdserver is unreachable

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd not forward the errors coming out of the password dialog helper and instead

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

rjvbb added a comment. In D22375#541399 , @sitter wrote: > The demo doesn't even use this widget That wasn't the question I answered by referring to oxygen-demo > breeze > F7506213: Peek 2019-10-03 13-46.gif

D24263: edit mode action

GB_2 resigned from this revision. This revision now requires review to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24012: Supress mouse events in KCMs causing window moves

This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R295:8f0858eb79a9: Supress mouse events in KCMs causing window moves (authored by davidedmundson). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added a comment. The demo doesn't even use this widget breeze F7506213: Peek 2019-10-03 13-46.gif oxygen F7506215: Peek 2019-10-03 13-45.gif REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D24263: edit mode action

GB_2 accepted this revision as: VDG, GB_2. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, kde-frameworks-devel,

D24263: edit mode action

GB_2 added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24378: WordDetect rule: detect delimiters at the inner edge of the string

dhaumann added a comment. This looks good to me and as mentioned in D24354 WordDetect is better than RegExpr. +1, but I'd like another review by @cullmann or @vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe updated this revision to Diff 67252. guoyunhe added a comment. Fix tabs REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24384?vs=67251=67252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24384 AFFECTED FILES

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY The Amusement category doesn't mean it is about toys. For example, Steam, the gaming platform and store, isn't about

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

rjvbb added a comment. > Does it happen with every code that uses QPropertyAnimation, or just with this KBusyIndicator? I don't know, neither for QVariantAnimation (which is used here). Testing just now (on the N3150 machine) with the Sliders page of the oxygen-demo app I get

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added a comment. F7505620: Peek 2019-10-03 12-23.gif REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck, apol Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n,

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

cfeck added a comment. Does it happen with every code that uses QPropertyAnimation, or just with this KBusyIndicator? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck, apol Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel,

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The implementation is still done in terms of KSslError, swapping that is one of the

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/114/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 08:20:59 + Build duration: 23 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 08:26:42 + Build duration: 9 min 38 sec and counting JUnit Tests Name:

D24160: [KIO] Modernize the code to use range-for in more places

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24160 To: dfaure, bruns, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

rjvbb added a comment. I'll repeat here what I muttered on the associated commit page: This widget adds a lot of CPU overhead, too much IMHO: the dedicated test tool runs at a bit over 10%CPU, and that is not counting the additional overhead from the displaying layers (X server, the Mac

D7446: [Places panel] Revamp the Recently Saved section

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67242. meven marked 4 inline comments as done. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67241=67242 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67241. meven added a comment. Make bookmarkForUrl const, add context to translate Recent REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67203=67241 BRANCH arcpatch-D7446 REVISION DETAIL

D24378: WordDetect rule: detect delimiters at the inner edge of the string

nibags updated this revision to Diff 67238. nibags added a comment. - Add comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24378?vs=67237=67238 BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 AFFECTED FILES

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags added a comment. i did it in: D24378 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In

D24326: Add syntax highlighting for RenPy (.rpy)

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24326 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24354: Mustache/Handlebars: fix delimiters in HTML tags

dhaumann added a comment. Thanks a lot! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,