KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/117/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 05:43:45 + Build duration: 8 min 13 sec and counting JUnit Tests Name:

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
meven added a comment. In D7446#542055 , @ngraham wrote: > I think you can go for it. :) Tagging is tomorrow, so please do! Just landed ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e65bf3bc541a: [Places panel] Revamp the Recently Saved section (authored by ngraham, committed by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 116 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/116/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 03:13:09 + Build duration: 8 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 03:12:44 + Build duration: 4 min 0 sec and counting JUnit Tests

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kstyle.cpp:428 > +case QStyle::SP_DialogSaveAllButton: > +return QIcon::fromTheme(QStringLiteral("document-save")); > +case QStyle::SP_DialogAbortButton: why not `document-save-all`? REPOSITORY R252 Framework Integration

D24416: Declare Calendar::Ptr as metatype

2019-10-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, vkrause. nicolasfella requested review of this revision. REVISION SUMMARY I need this for usage in Calindori BRANCH metatype REVISION DETAIL https://phabricator.kde.org/D24416 AFFECTED FILES

Re: Framework for encrypted storage for apps

2019-10-04 Thread Albert Astals Cid
El divendres, 4 d’octubre de 2019, a les 18:53:15 CEST, Johan Ouwerkerk va escriure: > Hi all, > > Bhushan asked me to kick off a discussion on frameworks-devel about a > problem we face for otpclient. We are looking for help in deciding how > to best implement storage of the secrets which are

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 108 - Fixed!

2019-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/108/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 21:56:38 + Build duration: 10 min and counting JUnit Tests Name:

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24403 To: aacid, cullmann, dhaumann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Albert Astals Cid
aacid requested review of this revision. aacid added a comment. This revision is now accepted and ready to land. Ok, i'll commit it then :) INLINE COMMENTS > cullmann wrote in modebase.cpp:333 > Hmm, given that is a local var on the stack, I don't see an issue with this. > This would only be

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kstyle.cpp:422 > } > +#if QT_VERSION >= 0x050E00 // Check if Qt version >= 5.14 > +case QStyle::SP_DialogYesToAllButton: Instead of 0x050E00 you could use the macro QT_VERSION_CHECK(5, 14, 0). This would be a bit more self explanatory.

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. I also think it's fine. A next patch could convert the QRegExp to a QRegularExpression. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24403 To: aacid, cullmann, dhaumann Cc: dhaumann, cullmann,

Framework for encrypted storage for apps

2019-10-04 Thread Johan Ouwerkerk
Hi all, Bhushan asked me to kick off a discussion on frameworks-devel about a problem we face for otpclient. We are looking for help in deciding how to best implement storage of the secrets which are needed by the app. Any insights from people who are more familiar with frameworks would be much

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 398973 Implement the new enumarations introduced in Qt 5.14:

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Björn Feber
GB_2 added a reviewer: davidedmundson. GB_2 added a subscriber: davidedmundson. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24415 To: GB_2, #frameworks, #vdg, davidedmundson Cc: davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2,

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. I think this is ok to merge, I don't see the issue with the QRegExp. (I understand that it stores it result in mutable data in the object, but that patch didn't alter this, just avoids the copying of the regex before this happens,

D24404: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24404 To: aacid, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D24405: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24405 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24400: Make hours qint64

2019-10-04 Thread Albert Astals Cid
aacid planned changes to this revision. aacid added inline comments. INLINE COMMENTS > usta wrote in kformatprivate.cpp:339 > why dont we use quint64 in here ? because its unnecessary, qint64 / number don't need a quint64 to store it. > usta wrote in kformatprivate.cpp:470 > same problem here

D24406: Small performance improvements suggested by clang tidy

2019-10-04 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R286:f510f3eca6a0: Small performance improvements suggested by clang tidy (authored by aacid). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24406?vs=67291=67328

D24412: Add edit-line-width icons

2019-10-04 Thread Noah Davis
ndavis added a comment. I think something similar to this line width icon would work well: F6304104: Lines.png Inkscape uses a similar icon, but for all line styles: F7517386: Screenshot_20191004_143517.png

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. I think you can go for it. :) Tagging is tomorrow, so please do! REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
meven added a comment. Any new feedback ? REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-04 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-10-04 Thread Ahmad Samir
ahmadsamir added a comment. In D23902#542046 , @dfaure wrote: > In D23902#542037 , @ahmadsamir wrote: > > > In D23902#542026 , @dfaure wrote: > > > >

D24404: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D24404 To: aacid, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#541952 , @churaev wrote: > In D24318#541839 , @ndavis wrote: > > > How about this? > > F7513643: document-save.svg > >

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#542043 , @ngraham wrote: > @ndavis You wanna just submit a patch with that and I'll abandon this? Alright REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To:

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-10-04 Thread David Faure
dfaure added a comment. In D23902#542037 , @ahmadsamir wrote: > In D23902#542026 , @dfaure wrote: > > > For the record, JFBastien was actually wrong. Calling .begin() on a const return value does

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 115 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/115/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 15:40:40 + Build duration: 7 min 10 sec and counting JUnit Tests Name:

[EMAIL WAS STILL DRAFT] Re: Version-based deprecation macros for KDE Frameworks API: execution plan

2019-10-04 Thread Friedrich W. H. Kossebau
Am Freitag, 4. Oktober 2019, 17:37:12 CEST schrieb Friedrich W. H. Kossebau: > Hi, > > for those who missed things so far, quick recap first: Premature send due to Shift+Backspace becoming press of Shift+Return key and instant email sending while still drafting :) Well, please do the recap for

D24308: [DataProtocol] compile without implicit coversion from ascii

2019-10-04 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Version-based deprecation macros for KDE Frameworks API: execution plan

2019-10-04 Thread Friedrich W. H. Kossebau
Hi, for those who missed things so far, quick recap first: To better assist users of KDE Frameworks in dealing with its deprecated API, we might want to give them more control over visibility of such API to the compiler when building their software or if deprecation warnings are emitted. For

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. @ndavis You wanna just submit a patch with that and I'll abandon this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-10-04 Thread Ahmad Samir
ahmadsamir added a comment. In D23902#542026 , @dfaure wrote: > For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-10-04 Thread David Faure
dfaure added a comment. For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp But returning const QList would inhibit move semantics, e.g. `QList mylist = foo();`

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-04 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67324. kossebau added a comment. - extend unit tests to cover library group macro variants Sadly blows up by all combinations unit test time to >1 min on old machine REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-10-04 Thread René J . V . Bertin
rjvbb added a comment. A little tinker tool: github.com/RJVB/kbusygadget. An inter-frame freeze duration of 75ms already decreases CPU load (according to `top`) to approx. 3.6% (= almost 4x). I cannot really say if I notice the effect of this short a freeze on the rotation

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-04 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kio_smb_mount.cpp:72 > { > finished(); > return; (pre-existing: shouldn't this call `error` rather than `finished`?) REPOSITORY

D24412: Add edit-line-width icons

2019-10-04 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24412: Add edit-line-width icons

2019-10-04 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-line-width-icon (branched from master) REVISION DETAIL

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread Igor Poboiko
poboiko updated this revision to Diff 67318. poboiko added a comment. Minor optimization: change check order (filesize / extractor property) Also, it should be better check by "Id" instead of "Name" REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread Igor Poboiko
poboiko marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > app.cpp:173 > -if (fileInfo.size() >= 10 * 1024 * 1024) { > -tr->removePhaseOne(id); > -return; This original line seemed very very wrong. Just because we won't want to index phase 2 isn't a reason to

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > poboiko wrote in app.cpp:185 > I though users might actually want to know if file was excluded (and the > reasoning behind it). > I can make its severity less, i.e. `qCDebug`. Or you think it should be > completely removed? Users don't read log

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread Igor Poboiko
poboiko added inline comments. INLINE COMMENTS > bruns wrote in app.cpp:185 > Users will love us for spammig the logs ... I though users might actually want to know if file was excluded (and the reasoning behind it). I can make its severity less, i.e. `qCDebug`. Or you think it should be

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-10-04 Thread Igor Poboiko
poboiko added a comment. In D23787#537891 , @bruns wrote: > Can you please provide an example which: > > - is currently indexed though it should be skipped due to size > - is skipped after this change Sure. Any mimetype inherited

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-04 Thread Harald Sitter
sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. Heh that's a ton better than mine. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nikita Churaev
churaev added a comment. In D24318#541839 , @ndavis wrote: > How about this? > F7513643: document-save.svg > F7513644: montage.png Should the metal tab on

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. Nice, +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D24363: Fix several build system errors

2019-10-04 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R858:731b85008c21: Fix several build system errors (authored by alexeymin). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24363: Fix several build system errors

2019-10-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH alexeymin/fix-cmake-errors REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: cgiboudeaux,

D24405: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24405 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, lots0logs, LeGast00n,

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo
guoyunhe added a comment. If I install amor, it would be shown in both Games and Games > Toys. This patch will let it only shows in Games. Another situation is that, if the application is `Categories=Multimedia;Amusement;`, it will not fit Games or Games>Toys. This patch can also help

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo
guoyunhe updated this revision to Diff 67310. guoyunhe added a comment. In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games. REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo
guoyunhe added a comment. In RPM package groups, **Amusement** is a top level category and **Game** is its child category. So a game can be categorized as **Amusement/Game/Other**. However, in freedesktop.org specification, **Game** is primary category. **Amusement** is secondary

D24354: Mustache/Handlebars: minor fixes

2019-10-04 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks, #vdg, ngraham Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Albert Astals Cid
aacid planned changes to this revision. aacid added inline comments. INLINE COMMENTS > modebase.cpp:333 > - > -QRegExp endOfWORD(endOfWORDPattern); > This is wrong, QRegExp is broken and lastIndexIn modifies the object even if the function is marked as const REPOSITORY R39 KTextEditor

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo
guoyunhe updated this revision to Diff 67304. guoyunhe added a comment. Update description REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24384?vs=67252=67304 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24384 AFFECTED FILES

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Björn Feber
GB_2 added a comment. In D24318#541839 , @ndavis wrote: > How about this? > F7513643: document-save.svg > F7513644: montage.png I love it! REPOSITORY

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. How about this? F7513643: document-save.svg F7513644: montage.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc:

D23266: Export Plasma core lib log category, add a category to a qWarning

2019-10-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5f6996ee50f8: Export Plasma core lib log category, add a category to a qWarning (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23266?vs=64060=67300#toc REPOSITORY R242

D24354: Mustache/Handlebars: minor fixes

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-delimiters-mustache REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24406: Small performance improvements suggested by clang tidy

2019-10-04 Thread Matthieu Gallien
mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D24406 To: aacid, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, lots0logs,

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

2019-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 06:06:48 + Build duration: 9 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 05:58:46 + Build duration: 8 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 7 - Fixed!

2019-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/7/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 04 Oct 2019 06:02:31 + Build duration: 4 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Fixed!

2019-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 06:01:33 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 6 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 04 Oct 2019 05:58:46 + Build duration: 3 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 05:58:46 + Build duration: 1 min 22 sec and counting JUnit Tests Name: