D24841: Use modern way to set the C/CXX standard

kossebau added a comment. In D24841#552842 , @vonreth wrote: > Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/ The tests are currntly sadly skipped on CI, compare T11858

D24841: Use modern way to set the C/CXX standard

vonreth added a comment. In D24841#552600 , @cgiboudeaux wrote: > Another issue caused by the new CMake 3.5 dependency, some tests fail: > > > > > > > 59 - ecm_setup_version-old_simple (Failed) > > 60 -

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

kossebau added a comment. Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like with autotests which might need to support such a build with

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a task: T8075: Fix security issues with KAuth support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

ngraham added a task: T8075: Fix security issues with KAuth support in KIO. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves,

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause updated this revision to Diff 68619. vkrause added a comment. Adapt to the new deprecation macros. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24703?vs=68063=68619 BRANCH D24703 REVISION DETAIL https://phabricator.kde.org/D24703 AFFECTED

D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause added a comment. Follow up in D24892 to address the latest comments. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause, mlaurent Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause created this revision. vkrause added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

vkrause added a comment. In D24873#552697 , @ahmadsamir wrote: > In D24873#552410 , @vkrause wrote: > > > This will compile, but it will only work correctly once TCPSlaveBase has been ported to

Re: Quick Charts in KDE Review

On 22-10-2019 18:09, Luigi Toscano wrote: Jonathan Riddell ha scritto: There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

vkrause added a comment. Seeing things like https://lxr.kde.org/source/frameworks/ki18n/src/kuitmarkup.cpp#0336 I'm wondering if this isn't rather a bug in I18NC_NOOP? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: vkrause,

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

ahmadsamir added a comment. In D24873#552410 , @vkrause wrote: > This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too. If you say so. Anyway, I've started porting TcpSlaveBase. :)

D23537: extend state verification to open connection commands

sitter abandoned this revision. sitter added a comment. Replaced by D24887 which instead creates a more generic system to verify slave behavior. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter,

D24887: WIP slave command behavior assertion system

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This implements a simple expectation system covering slave commands. At its heart sits

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

mlaurent retitled this revision from "I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text) It will break code as: struct MessageStatusInfo { const char *text; const char *icon; }; static const MessageStatusInfo..." to "I18N_NOOP2

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)It will break code as:struct MessageStatusInfo { const char *text; const char *icon;

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY ...StatusValues[] = { { I18N_NOOP2("message status", "Important"), "emblem-important"}, ... }

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. Another issue caused by the new CMake 3.5 dependency, some tests fail: > > > 59 - ecm_setup_version-old_simple (Failed) > 60 - ecm_setup_version-old_soversion (Failed) > 61 - ecm_setup_version-old_version_file (Failed) > 62 -

D24882: Don't set C/C++ standards if already set

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24882 To: dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24882: Don't set C/C++ standards if already set

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks! tested successfullly REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D24882 To: dfaure, cgiboudeaux Cc:

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. In D24841#552577 , @dfaure wrote: > Where did -std=gnu++14 come from? The old code above certainly didn't set it. > > Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before including

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/155/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 08:38:28 + Build duration: 25 min and counting JUnit Tests Name: projectroot

D24841: Use modern way to set the C/CXX standard

dfaure added a comment. Where did -std=gnu++14 come from? The old code above certainly didn't set it. Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before including KDECompilerSettings? We could test the var here to avoid overwriting it... REPOSITORY R240 Extra CMake

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync) Building with clang9, before: `-std=c++0x -std=gnu++14` are set After:

D24880: kio_http: avoid double Content-Type and Depth when used by KDAV

This revision was automatically updated to reflect the committed changes. Closed by commit R241:02a8d3deb4f9: kio_http: avoid double Content-Type and Depth when used by KDAV (authored by dfaure). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24880?vs=68587=68588

D24880: kio_http: avoid double Content-Type and Depth when used by KDAV

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24880 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24880: kio_http: avoid double Content-Type and Depth when used by KDAV

dfaure created this revision. dfaure added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This makes libkdav 19.08 work again after commit 9713ea02e49eda

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. In D24316#552541 , @dfaure wrote: > Can I just ignore the Depth from the custom http headers instead? > > --- i/src/ioslaves/http/http.cpp > +++ w/src/ioslaves/http/http.cpp > @@ -172,7 +172,8 @@ static

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. Can I just ignore the Depth from the custom http headers instead? --- i/src/ioslaves/http/http.cpp +++ w/src/ioslaves/http/http.cpp @@ -172,7 +172,8 @@ static QString sanitizeCustomHTTPHeader(const QString &_header) if

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. In D24316#552528 , @dfaure wrote: > I'm on the Applications/19.08 git branch, which shouldn't get broken by a newer KF5 release. > > Your patch works for Content-Type, but the duplicated Depth still leads to "Bad

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. I'm on the Applications/19.08 git branch, which shouldn't get broken by a newer KF5 release. Your patch works for Content-Type, but the duplicated Depth still leads to "Bad request". Where does the second Depth come from? I see one at line 2411, I guess the

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. Overall we probably have two options, revert this change (and the corresponding change in KDAV) and defer it to KF6, or harden this code further against duplicates in custom headers. The below might work for Content-Type (no way to test here atm), a similar fix for

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. Which version of KDAV do you have? master or some older release? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns