KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 05:59:56 + Build duration: 3 min 14 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 05:48:21 + Build duration: 28 sec and counting CONSOLE OUTPUT

D25434: [plasma-framework] port away from deprecated KF5 APIs

dfaure created this revision. dfaure added reviewers: mart, davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KDeclarative::setupBindings() is deprecated, replaced calls with

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

dfaure added a dependent revision: D25434: [plasma-framework] port away from deprecated KF5 APIs. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

dfaure created this revision. dfaure added reviewers: kossebau, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY removed() is deprecated since 5.0 because the code has to

D25432: Fix HTTP proxy settings

trufanov created this revision. trufanov added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trufanov requested review of this revision. REVISION SUMMARY After latest libKF5KIOCore.so.5.65.0 update my KTorrent has stopped to work via

KDE CI: Frameworks » kglobalaccel » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:31:37 + Build duration: 6 min 26 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:30:36 + Build duration: 5 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:29:11 + Build duration: 4 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:29:05 + Build duration: 4 min 16 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 20 Nov 2019 22:25:25 + Build duration: 6 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:27:51 + Build duration: 2 min 43 sec and counting CONSOLE OUTPUT

D25397: Install .pri file for KAuthCore

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ah, makes sense. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 22:17:46 + Build duration: 34 sec and counting CONSOLE OUTPUT [...truncated

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure closed this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Isn't it simpler to commit as is, so we can just s/ENABLE/BUILD/ in *.cpp files once we add support for EXCLUDE_DEPRECATED_BEFORE_AND_AT? Faster than having to figure out where is the implementation of each method to exclude. REPOSITORY R241 KIO BRANCH

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. Ah, EXCLUDE_DEPRECATED_BEFORE_AND_AT is not yet available with KIO (compare the TODO next to the ecm_generate_export_header call). So as result also the BUILD macros are not available. Using instead the ENABLE macros in the sources of the library instead does not

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > directorysizejob.cpp:137 > KIO::ListJob *listJob = KIO::listRecursive(url, KIO::HideProgressInfo); > -listJob->addMetaData(QStringLiteral("details"), QStringLiteral("3")); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) > +// TODO KF6:

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hmm, I meant Name is always useful when *listing*. But when *stating*, we don't always need to get the name back. The NoDetails comment is about a stat that really can just succeed/fail.

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 189 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/189/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 19:35:49 + Build duration: 6 min 4 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 165 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/165/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 20 Nov 2019 19:35:49 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT

D25402: [KDirOperator] Add Backspace shortcut to back action

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9550ad88a995: [KDirOperator] Add Backspace shortcut to back action (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25402?vs=70076=70080 REVISION

D25429: JavaScript/TypeScript React: rename syntax definitions

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Rename definitions from

D25402: [KDirOperator] Add Backspace shortcut to back action

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25402 REVISION DETAIL https://phabricator.kde.org/D25402 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25402: [KDirOperator] Add Backspace shortcut to back action

meven updated this revision to Diff 70076. meven added a comment. Move shortcut to Back action instead of cdUp REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25402?vs=69996=70076 BRANCH arcpatch-D25402 REVISION DETAIL https://phabricator.kde.org/D25402

D25402: [KDirOperator] Add Backspace shortcut to cdUp action

meven added a comment. In D25402#565326 , @ngraham wrote: > Generally this key is used for "Back," not "Up." If we do this, it will be inconsistent with Dolphin. Maybe we should just match Dolphin's behavior. Nice to know, wasn't aware.

D25402: [KDirOperator] Add Backspace shortcut to back action

meven retitled this revision from "[KDirOperator] Add Backspace shortcut to cdUp action" to "[KDirOperator] Add Backspace shortcut to back action". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25402 To: meven, #frameworks, ngraham, elvisangelaccio Cc:

D25402: [KDirOperator] Add Backspace shortcut to cdUp action

ngraham added a comment. Generally this key is used for "Back," not "Up." If we do this, it will be inconsistent with Dolphin. Maybe we should just match Dolphin's behavior. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25402 To: meven, #frameworks, ngraham,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 17:11:49 + Build duration: 46 min and counting JUnit Tests Name:

D25421: [kio_tags] improve log message when the database can't be opened

ahmadsamir updated this revision to Diff 70062. ahmadsamir retitled this revision from "[file_extractor] improve log message when the database can't be opened" to "[kio_tags] improve log message when the database can't be opened". ahmadsamir edited the summary of this revision. ahmadsamir

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir added a comment. In D25421#565217 , @bruns wrote: > This is obviously the wrong line of code for the referenced bug report. Well, it's obvious now. :) (I should have tested, but now that I try to test, I can't reproduce

D25421: [file_extractor] improve log message when the database can't be opened

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This is obviously the wrong line of code for the referenced bug report. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25421 To: ahmadsamir, #baloo,

Re: Request backport of 4a9820a6df15a55a7d36d343ce70a25ba7d56b79 in kirigami

On mercredi 20 novembre 2019 11:20:56 CET David Edmundson wrote: > Hi all, > > I'm getting ~2 bug reports a day in systemsettings over a fixed Kirigami > issue. > > Can I recommend that we release a patchfix cherry-picking > 4a9820a6df15a55a7d36d343ce70a25ba7d56b79. Done: kirigami v5.64.1

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565205 , @cullmann wrote: > That is bad, then this must be fixed. > That should happen on Windows, too. BTW: Does starting slaves on Linux kills started slave after slave timeout occurs, which is

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. That is bad, then this must be fixed. That should happen on Windows, too. Just like it works nicely on macOS. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker,

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565113 , @cullmann wrote: > No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that > > static bool forkSlaves() but this function is only called

D25421: [file_extractor] improve log message when the database can't be opened

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH l-log-messages (branched from master) REVISION DETAIL https://phabricator.kde.org/D25421 To: ahmadsamir, #baloo, astippich, ngraham Cc: kde-frameworks-devel, hurikhan77,

D25106: Also allow invoking session restoration logic when apps are manually launched

This revision was automatically updated to reflect the committed changes. Closed by commit R263:46e5b32ed929: Also allow invoking session restoration logic when apps are manually launched (authored by ngraham). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Yep, there are no changes in behavior or regressions when testing with Okular, Kate, System Settings and Discover. REPOSITORY R263 KXmlGui BRANCH allow-restoring-session-manually (branched from master) REVISION DETAIL https://phabricator.kde.org/D25106 To:

D25219: Only create a session config when actually restoring a session

ngraham updated this revision to Diff 70054. ngraham marked an inline comment as done. ngraham added a comment. Check for `sessionConfig()` being nullptr REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25219?vs=69464=70054 BRANCH session-config (branched

D25402: [KDirOperator] Add Backspace shortcut to cdUp action

meven added reviewers: ngraham, elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25402 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70051. meven marked 8 inline comments as done. meven added a comment. Typos, rephrase a comment, move FileProtocol::getStatDetails to file.cpp, add a TODO for in file_win.cpp REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

kossebau updated this revision to Diff 70052. kossebau marked 2 inline comments as done. kossebau added a comment. Update to first review by @dfaure REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25058?vs=69002=70052 BRANCH addaboutplugindialog

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

kossebau marked 3 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kaboutplugindialog.cpp:119 > (I'm surprised by the explicit '&' in all those labels, doesn't > KAcceleratorManager take care of this automatically?) Seems it does. So removing then

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. REVISION SUMMARY Bug: 407786 REPOSITORY R293 Baloo BRANCH l-log-messages (branched from master) REVISION DETAIL

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY When _k_slotViewKeyEnterReturnPressed is called,

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that see in slave.cpp static bool forkSlaves() { // In such case we start the slave via QProcess. // It's possible to force this by

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565110 , @cullmann wrote: > kio doesn't require dbus for the normal slave stuff. > It can be that it requires it for the kcookie or auth stuff. klauncher is used to launch kio slaves. In the main()

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. kio doesn't require dbus for the normal slave stuff. It can be that it requires it for the kcookie or auth stuff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker,

KDE CI: Frameworks » kdbusaddons » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 10:43:28 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdbusaddons » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 20 Nov 2019 10:14:55 + Build duration: 16 min and counting JUnit Tests Name:

Request backport of 4a9820a6df15a55a7d36d343ce70a25ba7d56b79 in kirigami

Hi all, I'm getting ~2 bug reports a day in systemsettings over a fixed Kirigami issue. Can I recommend that we release a patchfix cherry-picking 4a9820a6df15a55a7d36d343ce70a25ba7d56b79. Thanks David

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#563560 , @bcooksley wrote: > Considering that D-Bus doesn't really belong on Windows, KDE uses dbus for many internal services. On a recent linux system I see the following KDE services in dbus

D22946: Include API to generically implement --replace arguments

This revision was automatically updated to reflect the committed changes. Closed by commit R271:75cf9e495edd: Include API to generically implement --replace arguments (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=70043=70044

D22946: Include API to generically implement --replace arguments

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH arcpatch-D22946 REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel,

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 70043. apol added a comment. Remove wrong comment REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=69997=70043 BRANCH arcpatch-D22946 REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED FILES

D25106: Also allow invoking session restoration logic when apps are manually launched

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Normal session restoration behavior after a reboot is unchanged Please make sure you try with a few apps that aren't just dolphin REPOSITORY R263 KXmlGui BRANCH

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure added a comment. Oops, local patch! (to add some debugging code in case of timeout). OK, that brown-paper-bag issue aside, the reasoning about deprecating classes remains :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. About granularity: I think it's fine. I was about to say that the use case of a recursive listing to calculate directory size only needs type and size, but it actually needs name

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

dfaure added a comment. Nice work. INLINE COMMENTS > kaboutplugindialog.cpp:119 > +QWidget *translatorWidget = > createTranslatorsWidget(pluginMetaData.translators(), QString(), q); > +tabWidget->addTab(translatorWidget, i18n("T")); > +} (I'm surprised by the explicit

D25059: KPluginSelector: use new KAboutPluginDialog

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH useaboutplugindialog REVISION DETAIL https://phabricator.kde.org/D25059 To: kossebau, #frameworks, dfaure, apol Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.h:478 > + * @deprecated Since 5.65, use KAboutPluginDialog to show info about a > plugin > + * instead of KAboutApplicationDialogso, with the latter

D24966: KXmlGui: port away from KF5 deprecated API

dfaure abandoned this revision. dfaure added a comment. Excellent, thanks! REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24966 To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns