D25756: Port from QStringList::ConstIterator to range-based for

broulik added inline comments. INLINE COMMENTS > kauthorized.cpp:252 > QStringList result; > -for (QStringList::ConstIterator it = menuIds.begin(); > -it != menuIds.end(); ++it) { > -if (cg.readEntry(*it, true)) { > -result.append(*it); > +for (const Q

D25746: Adapt to change in KConfigCompiler

ervin added a comment. notifySignal would definitely make sense on the signalling items indeed. It's kind of the information we're trying to guess here. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25746 To: apol, #frameworks, tcanabrava, ervin Cc: kde-frame

D25757: EBN purpose constructor cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Added explicit to the constructors REPOSITORY R495 Purpose Library BRANCH ebn-cleanup (branched from master) REVISI

D13541: Port solid from Qt5::Widgets to Qt5::Gui

davidedmundson added a comment. do it REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bru

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. I see this patch still works and applies. I'd say landing it would still make sense. If nobody disagrees I'll do so in a week. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhau

D22577: Remove unused pnm.desktop file

apol closed this revision. apol added a comment. This patch was already applied REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D22577 To: rempt, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

apol added a comment. Do we dislike iterators now? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25754: Refactor KHistoryComboBox::insertItems

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH refa REVISION DETAIL https://phabricator.kde.org/D25754 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25752: EBN extra-cmake-modules comments spelling cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-spelling-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25752 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB

D25753: EBN extra-cmake-modules transport cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, G

D25756: Port from QStringList::ConstIterator to range-based for

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN tests pass REPOSITORY R237 KConfig BRANCH for REVISION DETAIL htt

D25755: Replace iterators with range-based for

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds, kded starts REPOSITORY R297 KDED BRANCH iter REVISION DETAI

D25754: Refactor KHistoryComboBox::insertItems

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Use range-based for instead of iterators Apply return-early idiom

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun? I would expect it to have solved all this already, unless I'm missing something about the various code paths. The code you changed in k

D25753: EBN extra-cmake-modules transport cleanup

jhayes created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transport protocol from http to https REPOSITORY R240 Extra CMake Modules BRANCH

D25752: EBN extra-cmake-modules comments spelling cleanup

jhayes created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Correct spelling in extra-cmake-modules comments. REPOSITORY R240 Extra CMake Modules BRA

D25599: Fix plugin-metadata translations on windows

aacid added a comment. In D25599#572013 , @sars wrote: > I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is

D25720: Fix shortcut conflict between Cut and Delete File

aacid added a comment. Apps that need both should be aware of it and remove the secondary Cut shortcut. Or if you want to be mega fancy you can make kactioncollection (or something in xmlgui) do that REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ng

D25746: Adapt to change in KConfigCompiler

This revision was automatically updated to reflect the committed changes. Closed by commit R296:12b3c947a8a4: Adapt to change in KConfigCompiler (authored by apol). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25746?vs=70912&id=70921 REVISION DETAIL

D25746: Adapt to change in KConfigCompiler

apol added a comment. I'll land this for now because the alternative is to have this not working. Maybe it would make sense to include a KConfigSkeletonItem::propertyName property? Or even a KConfigSkeletonItem::notifySignal(KConfigSkeleton*)? Then here we could just consume the info

D25720: Fix shortcut conflict between Cut and Delete File

aspotashev added a comment. In D25720#572291 , @ngraham wrote: > Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. I don't know the intern

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 214 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/214/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 04 Dec 2019 19:31:13 + Build duration: 8 min 59 sec and counting JUnit Tests Name: projectro

D25720: Fix shortcut conflict between Cut and Delete File

ngraham added a comment. Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: a

D25720: Fix shortcut conflict between Cut and Delete File

ngraham added a comment. For example Dolphin REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25749: [CopyJob] When linking also consider https for text-html icon

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b78027f01176: [CopyJob] When linking also consider https for text-html icon (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25749?vs=70918&id=7091

D25749: [CopyJob] When linking also consider https for text-html icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25749 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25749: [CopyJob] When linking also consider https for text-html icon

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25749 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25749: [CopyJob] When linking also consider https for text-html icon

broulik created this revision. broulik added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures dragging a "https" link, which is most of them these days, has a

D25448: EBN cleanup of autotests transfer protocol

jhayes added a comment. I don't have commit access, could someone land this for me? REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michae

D25719: EBN KActivites transfer protocol cleanup

jhayes added a comment. I don't have commit access, could someone land this for me? REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25719 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bru

D25721: EBN kdeclarative transfer protocol cleanup

jhayes added a comment. I don't have commit access. Would someone land this for me? REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25721 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in jobuidelegateextension.h:279 > Sorry, you can't add a new virtual method to an exported+installed class. > > BIC rules (where "rules" is a noun, not a verb...) ;-) > > Possible solutions: > > - creating a new, separate, type of

D25720: Fix shortcut conflict between Cut and Delete File

aspotashev added a comment. What are the applications where both actions are used and thus one may notice this conflict? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks fine to me. @dfaure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25720: Fix shortcut conflict between Cut and Delete File

ngraham added a comment. We have to change //something//, or else there's conflict that breaks both of them in apps where both actions are implemented. Changing anything breaks someone's workflow; the question is whose we can live with breaking. REPOSITORY R237 KConfig REVISION DETAIL h

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 70914. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Addressed the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=67955&id=70914 BRANCH arcpatch-D21783 REVISION DETAIL https://

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In fact both issues I found seem to be caused by !2. See https://invent.kde.org/kde/kio-fuse/merge_requests/2#note_19771. We can continue the discussion there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmu

D25720: Fix shortcut conflict between Cut and Delete File

bcooksley added a comment. Shift+Delete is a widely known shortcut combination for "Delete File Immediately, do not send to the Recycle Bin" REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: bcooksley, davidedmundson, aacid, a

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Sure, I'll file bugs in https://bugs.kde.org/describecomponents.cgi?product=kiofuse. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-fram

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Anyway I guess this patch itself is fine now and the remaining issues are elsewhere. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-f

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. Issues with KIOFuse itself should be opened up as an issue, or as a reply to the MR that is being tested; this differential only concerns communication between the KIOFuse mount and KIO itself. In particular, if you could test writing with both master and FileJo

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#572199 , @fvogt wrote: > Was that with or without the KIO::open merge request? With. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfau

D25746: Adapt to change in KConfigCompiler

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. My gut feeling would be to keep the item and the property names in sync unlike now... but this is a good fix as well indeed. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D25743: Expose IndexerState enum to QML

davidedmundson planned changes to this revision. davidedmundson added a comment. Q_NAMESPACE_EXPORT is too new :( REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00

D25727: Expose enum to the metaobject compiler

davidedmundson added a comment. Bah, seems Q_NAMESPACE_EXPORT is quite new REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25742: move backgroundhints managment in Applet

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/hintsApplet REVISION DETAIL https://phabricator.kde.org/D25742 To: mart, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michae

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#572198 , @ngraham wrote: > I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results: > ... Was that with or without the KIO::open merge request? REPOSITORY

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results: - Gedit: everything works - Blender: everything works - Inkscape: though the file is very small, the save operation is somewhat slow, but everything works

D25746: Adapt to change in KConfigCompiler

apol created this revision. apol added reviewers: Frameworks, tcanabrava, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Properties need to start with lower-case letters, otherwise QML won't u

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. tempFilename() actually changes the filename to include the whole path plus some other bits and pieces; but as @mardelle proposes, the maximum filename length is NAME_MAX and it should take into account the percent encoding. Again, sorry about the noise... RE

D25734: MAke it compile without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0b428a5f93fb: MAke it compile without deprecated method (authored by mlaurent). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25734?vs=70892&id=70911 REVISIO

D25743: Expose IndexerState enum to QML

ngraham added a comment. This doesn't compile for me: [ 11%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/indexerstate.cpp.o In file included from /home/nate/kde/src/baloo/src/engine/indexerstate.cpp:1: /home/nate/kde/src/baloo/src/engine/indexerstate.h:32:19: e

D25743: Expose IndexerState enum to QML

ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns,

D25743: Expose IndexerState enum to QML

ngraham added a dependent revision: D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampal

D25742: move backgroundhints managment in Applet

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25742 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25742: move backgroundhints managment in Applet

mart added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25742 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25742: move backgroundhints managment in Applet

mart updated this revision to Diff 70907. mart added a comment. - add docs and properties REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25742?vs=70905&id=70907 BRANCH phab/hintsApplet REVISION DETAIL https://phabricator.kde.org/D25

D25743: Expose IndexerState enum to QML

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This no longer is just private API of the file code as we're using this all over balooctl an

D25734: MAke it compile without deprecated method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH make_it_compile_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D25734 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D25720: Fix shortcut conflict between Cut and Delete File

ngraham added a comment. Ack. So shall we change the shortcut for delete file then? Any suggestions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: davidedmundson, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michael

D25742: move backgroundhints managment in Applet

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Applet is the more proper way to do it (and will make easier porting to KF6) this also make it possible for the scripting in

D25734: MAke it compile without deprecated method

mlaurent added a reviewer: apol. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25734 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. Can you please move the DBus XML file in a common location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeG

D25599: Fix plugin-metadata translations on windows

sars added a comment. I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70895. apol added a comment. Export the namespace REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70872&id=70895 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25727 AFFECTED FILES src/declarat

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

davidedmundson added a comment. If something is ready for full code review, can we remove "WIP:" from the title. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-f

D25734: MAke it compile without deprecated method

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port deprecated method REPOSITORY R296 KDeclarative BRANCH make_it_compile_deprecated (branched from master) RE

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. In D25599#571880 , @sars wrote: > So the conclusion is that we are not using setDefault() yet and ki18n & gettext uses the LANGUAGE env so the logical thing, for now, is to also use LANGUAGE env here in KCoreAddons for t

D25727: Expose enum to the metaobject compiler

lnj added a comment. The ActionsTypes are already registered using a wrapper class (this was required before Qt 5.8 / Q_NAMESPACE) in peopleqmlplugin.cpp. The Q_NAMESPACE solution would be better I think. And yes, the namespace still needs to be registered using e.g. `qmlRegisterUncreat

D25727: Expose enum to the metaobject compiler

davidedmundson added a comment. I thought you need some kind of qmlRegisterType in order to use it? (but if it does work as-is, ship it) REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich Cc: davidedmundson, kde-frameworks-devel, LeGast0

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK, please give me a day or two to review this, it shouldn't go in before Saturday anyway so we have one month of testing in git before release REPOSITORY R241 KIO REVISION DET

D25717: [KSqueezedTextLabel] Add icon for "Copy entire text" action

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d45ea2c6c0f3: [KSqueezedTextLabel] Add icon for "Copy entire text" action (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25717?vs=7083

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 213 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/213/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 04 Dec 2019 10:22:04 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:816fc6f9444f: [KFileWidget] Avoid calling slotOk right after the url changed (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25420?vs=70883&id=70884

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D25420 REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven updated this revision to Diff 70883. meven added a comment. Add return after accepting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25420?vs=70848&id=70883 BRANCH arcpatch-D25420 REVISION DETAIL https://phabricator.kde.org/D25420 AFFECTED FILES

D25720: Fix shortcut conflict between Cut and Delete File

davidedmundson added a comment. It's not just old timers, it's an accessibility thing for people who are left handed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: davidedmundson, aacid, apol, kde-frameworks-devel, LeGast0

D25599: Fix plugin-metadata translations on windows

sars added a comment. So the conclusion is that we are not using setDefault() yet and ki18n & gettext uses the LANGUAGE env so the logical thing, for now, is to also use LANGUAGE env here in KCoreAddons for the plugin metadata translations? REPOSITORY R244 KCoreAddons REVISION DETAIL ht

D25720: Fix shortcut conflict between Cut and Delete File

aacid added a comment. Shift + Delete for cut is the old timer Unix cut shortcut, you're going to piss lots of people off if you remove that shortcut from every single application just because it causes a conflict in applications that do file management REPOSITORY R237 KConfig REVISION D