D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Few more comments on this: - general: you will never be able to make all the opiniated people happy, and you have to draw a line (otherwise your code will become bloated, buggy, and unmaintainable) - regarding this specific case: many widget style will

D25820: SimpleScreenRecorder icon added

2019-12-08 Thread Filip Fila
filipf added a comment. I agree, I think brighter and slightly less saturated colors would look nice. Thank you for adding this btw, the old icon doesn't fit in. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25820 To: vinzenzv, #vdg, ndavis Cc: filipf,

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Filip Fila
filipf added a comment. I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

2019-12-08 Thread Aleix Pol Gonzalez
apol added a comment. Plasma master can depend on kf5 master. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25820: SimpleScreenRecorder icon added

2019-12-08 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Good start! The lens flare looks upside down and the icon needs more pixel alignment. I feel like the red/green/blue colors of the center area are a bit too dark as well.

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis added a comment. @hpereiradacosta, Fair points and I'm glad you spoke up. JFYI, I'm in no rush to land this and I will consider reserving this change for KF6 if experienced KDE devs think that is best. In D25814#574105 ,

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Hugo Pereira Da Costa
hpereiradacosta added a subscriber: cfeck. hpereiradacosta added a comment. Would also be good to have the opinion of @cfeck on this. REPOSITORY R265 KConfigWidgets BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis,

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Noah Davis
ndavis added a comment. In D25815#574111 , @vinzenzv wrote: > In D25815#574103 , @ndavis wrote: > > > The actual name of the icon is `transmission`, so you would have to rename the file to that and

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Vinzenz Vietzke
vinzenzv updated this revision to Diff 71107. vinzenzv added a comment. In D25815#574103 , @ndavis wrote: > The actual name of the icon is `transmission`, so you would have to rename the file to that and add `id="transmission"` to the group.

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Adding new entries to the kcolorscheme should be done with a lot of care, because it could be seen as some sort of API break for existing colorscheme, as soon as you start using this color in the widget style: you would need a fallback implementation, for

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Vinzenz Vietzke
vinzenzv added a comment. Okay, gotcha. I played around a bit but am not too satisfied yet. I tends to look like a grave... F7805560: Screenshot_20191209_010939.png Best I could get yet: F7805561: Screenshot_20191209_011147.png

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Noah Davis
ndavis added a comment. The actual name of the icon is `transmission`, so you would have to rename the file to that and add `id="transmission"` to the group. Since this is a desktop theme icon, you would also have to add an invisible 22x22 rectangle to the group. However, even after

D25820: SimpleScreenRecorder icon added

2019-12-08 Thread Vinzenz Vietzke
vinzenzv created this revision. vinzenzv added a reviewer: VDG. vinzenzv added a project: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vinzenzv requested review of this revision. REVISION SUMMARY I took the existing DigiKam icon and tweaked it to

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Hey, thanks for the patch! - Breeze usually uses 1px lines, but does use 2px in some instances (mainly centered lines). You can use a 2px thickness at the bottom in this case

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Nathaniel Graham
ngraham added a comment. Very nice! You even embedded the stylesheet. However there are a number of lines and corners that would look better aligned to grid lines or points. You don't have to always to this, but in general it's better to. Also the Breeze icon style generally has pointy

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

2019-12-08 Thread Nicolas Fella
nicolasfella added a comment. Can Plasma depend on Frameworks master or does this have to wait until 5.66 release? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Dec 2019 22:59:11 + Build duration: 1 min 48 sec and counting JUnit Tests Name:

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-08 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R284:9fe2d187f8e9: [KHistoryComboBox] Add method to set an icon provider (authored by nicolasfella). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-08 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH icopro REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

2019-12-08 Thread David Faure
dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25816 To: dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

2019-12-08 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D25816 To: dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

2019-12-08 Thread David Faure
dfaure created this revision. dfaure added a reviewer: aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It's just simpler this way, we don't need the extra features of Q_GLOBAL_STATIC. TEST

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-08 Thread Nicolas Fella
nicolasfella updated this revision to Diff 71098. nicolasfella marked 3 inline comments as done. nicolasfella added a comment. - Comments REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=71072=71098 BRANCH icopro REVISION DETAIL

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 08 Dec 2019 22:34:26 + Build duration: 5 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 38 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 08 Dec 2019 22:34:26 + Build duration: 4 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Dec 2019 22:34:26 + Build duration: 3 min 56 sec and counting JUnit Tests Name:

D25414: xattr: fix crash on dangling symlinks

2019-12-08 Thread Ismael Asensio
iasensio added a comment. Ping? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-08 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > khistorycombobox.cpp:415 > > +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66) > void KHistoryComboBox::setPixmapProvider(KPixmapProvider *provider)

D25599: Fix plugin-metadata translations on windows

2019-12-08 Thread Albert Astals Cid
aacid added a comment. In D25599#573581 , @sars wrote: > Yes it works :) > > (I added QLocale::setDefault(QLocale(QString::fromLatin1(languageCode))); to the end of the if statement in initializeLanguages()) > > Hmm... For an application

D25815: Transmission-Qt tray icon added

2019-12-08 Thread Vinzenz Vietzke
vinzenzv created this revision. vinzenzv added a reviewer: VDG. vinzenzv added a project: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vinzenzv requested review of this revision. REVISION SUMMARY Replace the default Transmission-Qt icon with a

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

2019-12-08 Thread Albert Astals Cid
aacid added a comment. > Would this work for you? I guess, i'm not really sure if i understand all you wrote, but i just want to make sure we can do a "generic part loader that opens files" if we want to REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698

D25727: Expose enum to the metaobject compiler

2019-12-08 Thread David Faure
dfaure added a comment. CI = not happy src/declarative/peopleqmlplugin.cpp:73: undefined reference to `KPeople::staticMetaObject' REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj, davidedmundson,

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Code looks OK. No opinion on usefulness though. REPOSITORY R265 KConfigWidgets BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25814 To:

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis updated this revision to Diff 71096. ndavis added a comment. - update @since version REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25814?vs=71095=71096 BRANCH separator-color (branched from master) REVISION DETAIL

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

2019-12-08 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure, mpyne Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. ndavis added reviewers: Frameworks, VDG, dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Users sometimes ask for the ability to customize the color of separators. When talking about how the next version of

D25683: KDirOperator: Use a fixed line height for scroll speed

2019-12-08 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH diroperator_scrollspeed REVISION DETAIL https://phabricator.kde.org/D25683 To: ahiemstra, ngraham, elvisangelaccio Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 67 - Failure!

2019-12-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/67/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 08 Dec 2019 20:33:40 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Failure!

2019-12-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/31/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 08 Dec 2019 20:33:40 + Build duration: 1 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 45 - Failure!

2019-12-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 08 Dec 2019 20:33:40 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated 394

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 16 - Failure!

2019-12-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/16/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 08 Dec 2019 20:33:40 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated

D25727: Expose enum to the metaobject compiler

2019-12-08 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R307:508b1bab207e: Expose enum to the metaobject compiler (authored by apol). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70997=71093 REVISION DETAIL

D25775: Check cursor_open return value

2019-12-08 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25775 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, #baloo, hurikhan77,

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 08 Dec 2019 18:07:07 + Build duration: 3 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 37 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 08 Dec 2019 18:07:07 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

2019-12-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Dec 2019 18:07:08 + Build duration: 2 min 1 sec and counting JUnit Tests Name:

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-08 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D25720#572291 , @ngraham wrote: > Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. Yes it's messy

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis updated this revision to Diff 71092. ndavis added a comment. - change minimized bg opacity to 8% REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71084=71092 BRANCH arcpatch-D25340 (branched from master) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Nathaniel Graham
ngraham added a comment. This feels so close to perfection! But now it feels like the minimized bg is too subtle, maybe. I wonder if 0.08 opacity for minimized tasks might help. Or maybe I'm just torturing this poor patch to death... REPOSITORY R242 Plasma Framework (Library) REVISION

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

2019-12-08 Thread Andreas Sturmlechner
asturmlechner added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25812 To: asturmlechner, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

2019-12-08 Thread Andreas Sturmlechner
asturmlechner created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY In the end, not opening device nodes readonly just because it does not concern

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

2019-12-08 Thread Christoph Cullmann
cullmann added a comment. Nice that you take care of that stuff. Could you enhance the CMake test file, too, to cover some of the new stuff? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25811 To: turbov, #framework_syntax_highlighting Cc: cullmann,

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

2019-12-08 Thread Alex Turbov
turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D25809: Use standard ECMQMLModules

2019-12-08 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R495:8d7123896b98: Use standard ECMQMLModules (authored by asturmlechner). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25809?vs=71085=71087 REVISION DETAIL

D25809: Use standard ECMQMLModules

2019-12-08 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25809 To: asturmlechner, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

2019-12-08 Thread Andreas Sturmlechner
asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY Drop obsolete QMLModules.cmake and FindQMLModule.cmake.in Superseded by standard ECM modules. TEST

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis updated this revision to Diff 71084. ndavis added a comment. - Change normal bg to 15% opacity - Change minimized bg to 5% opacity REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71050=71084 BRANCH arcpatch-D25340

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24489: KAutosaveFile not respecting maximum filename length

2019-12-08 Thread Jean-Baptiste Mardelle
mardelle marked 3 inline comments as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure, mpyne Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

2019-12-08 Thread Jean-Baptiste Mardelle
mardelle updated this revision to Diff 71081. mardelle added a comment. Update patch according to discussion. extractManagedFilePath will be broken in case of long truncated path but that has always been the case... REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

2019-12-08 Thread Björn Feber
GB_2 added a comment. In D25360#573798 , @IlyaBizyaev wrote: > Should this also affect GTK apps? There's a matching radio group in the GTK KCM. D25703 REPOSITORY R252 Framework Integration

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis
ndavis commandeered this revision. ndavis edited reviewers, added: niccolove; removed: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

2019-12-08 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Should this also affect GTK apps? There's a matching radio group in the GTK KCM. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D25360 To: ngraham, #frameworks, #plasma Cc: IlyaBizyaev, broulik, kde-frameworks-devel,

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread laurent Montel
Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit : > Hi, > > very happy to see Grantlee "coming home" :) > > Technically I think it's largely in line with Frameworks requirements > already, and it has been reliably powering e.g. KMail's message viewer for > years. Moving to a

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread Volker Krause
Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message viewer for years. Moving to a faster and, more importantly, predictable release cycle would help us a lot with

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Niccolò Venerandi
niccolove added a comment. In D25340#573672 , @ndavis wrote: > @niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it. Feel free to do that :-) REPOSITORY