D26404: Turn application/x-ms-shortcut into an actual shortcut icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. For 16/22px, symlinking to existing monochrome link icons is acceptable. This patch does not apply cleanly. The base commit isn't available. REPOSITORY R266 Breeze Icons

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella added a comment. The goal is to remove the overall dependencies of KIO. There are multiple apps/other frameworks that use KIO without using KXmlGui. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: aacid,

Re: Does FreeBSD have HAL?

Hi, So, when I run your qdbus comand, I get this message: Service 'org.freedesktop.HalManager' does not exist. However, HAL has been compiled and is running on my system: [dwayne@Chiron ~]$ ps axww | grep hal 1257 - Ss 0:16.32 /usr/local/sbin/hald 1258 - I 0:00.09 hald-runner

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

aacid added a comment. What's the point of removing the KXMLGui dependency? I mean it's not like you will be able to do Kate or KDevelop without kxmlgui, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: aacid,

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

dfaure added a comment. In D26413#587425 , @ilic wrote: > I did intended it as public API, its usage is even explained in the Programmers Guide. So for the moment I would go with D26408 . OK, feel

D25517: Add an option to extract image data and add front cover property

bruns added a comment. I have thought about this and have come to the conclusion this is not really future proof. The `Property::FrontCover` is IMHO fine, i.e. the changes to `propertyinfo.cpp` and `properties.h` could go in as is. The request of additional properties should be

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella updated this revision to Diff 72772. nicolasfella added a comment. - Add since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26424?vs=72771=72772 BRANCH kac REVISION DETAIL https://phabricator.kde.org/D26424 AFFECTED FILES

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY To replace the actionCollection() method. This will allow

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella added a task: T12205: Port KDirOperator away from KActionCollection. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

broulik added a comment. > unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?) Works here. F7860716: Screenshot_20200104_204817.png I think it doesn't update the view live when the comment changes

D26331: Removed reading description from desktop files

bruns added a comment. In D26331#587259 , @dfaure wrote: > On the other hand I see that the dolphin GUI has an editable "Comment" on the right side, unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?).

D25833: Expose getter to KConfigWatcher's config

arojas added a comment. This breaks compilation of python bindings: sip: /build/kconfig/src/build/src/core/sip/PyKF5/KConfigCore/kconfigwatcher.sip:17: ::KConfigWatcher::config() unsupported function return type - provide %MethodCode and a C++ signature REPOSITORY R237 KConfig

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26412#587395 , @dfaure wrote: > Unittest for this method added in https://commits.kde.org/ki18n/a92305a4c15ac361417eeb7b933682960c7545e1 > Please check your change passes the test. > Extend as needed if you

D26420: Add a logging category to smb ioslave

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 To: meven, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26412 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26412: [Kuit] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7e20f49520d9: [Kuit] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26412?vs=72756=72764 REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a9f4cbdda790: [Kuit] Port QRegExp to QRegularExpression, third pass (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72748=72763

D26410: Port KLanguageButton from KConfig to QSettings

nicolasfella abandoned this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson, aacid Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26410: Port KLanguageButton from KConfig to QSettings

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson, aacid Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > > when a network mount is unresponsive > > If I do a `QFileInfo` on an unresponsive mount it will still block. You > already freeze before you even know it's a network mount. Good point, indeed the current

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven updated this revision to Diff 72761. meven added a comment. Remove outdate ifdef, we depend on KF5 5.62 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26416?vs=72735=72761 BRANCH arcpatch-D26416 REVISION DETAIL

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:49-50 > Put them in `getMountPoints` as local static variables, global static are > no-go. I agree. > meven wrote in

Does FreeBSD have HAL?

solid/src/CMakeLists.txt offers the option to use "UDisks2/bsdisks backend instead of HAL to manage disk devices" on FreeBSD, but OFF by default. So the default is the HAL backend, which however completely fails on CI:

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:251 > +auto getFileItem = [=] () { > +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0) > +// Avoid calling QT_LSTAT and accessing recent documents I'm pretty sure we can/should depend on newer KF5. I'd say

D26412: [Kuit] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH l-salvageMarkup (branched from master) REVISION DETAIL https://phabricator.kde.org/D26412 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel,

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH l-parseUiM (branched from master) REVISION DETAIL https://phabricator.kde.org/D26366 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel,

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Ping? Any update if somebody tried the proposed changes? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure, broulik, davidedmundson Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau,

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

cullmann added a comment. Hi, can you add stuff to the tests or shall we merge this as is? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25811 To: turbov, #framework_syntax_highlighting Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D26410: Port KLanguageButton from KConfig to QSettings

nicolasfella added a comment. In D26410#587473 , @pino wrote: > IIRC `KConfigGroup::readEntry() reads the translated version of the key, and every `kf5_entry.desktop` has such translations. QSettings does not do that. > > Did you test only

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. In D26358#587596 , @ngraham wrote: > BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :( I mistested this, and removed the "BUG: 414482" accordingly. I don't reproduce this bug locally

D25517: Add an option to extract image data and add front cover property

ngraham added a comment. LGTM REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72756. ahmadsamir added a comment. Rebase after unit test commits REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26412?vs=72727=72756 BRANCH l-salvageMarkup (branched from master) REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

ngraham added a comment. BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :( REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72749. meven added a comment. indent & "" REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72747=72749 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26420: Add a logging category to smb ioslave

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26420 To: meven, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26420: Add a logging category to smb ioslave

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:27 > +IDENTIFIER KIO_SMB_LOG > +CATEGORY_NAME log_kio_smb) > + indent > kio_smb.cpp:36 > >

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72748. ahmadsamir added a comment. Rebase after the unit tests commits REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72710=72748 BRANCH l-parseUiM (branched from master) REVISION DETAIL

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72747. meven added a comment. Clean REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72746=72747 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26420: Add a logging category to smb ioslave

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26358 REVISION DETAIL

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping! I would like to continue work on this. Is the new name better? If so, I will rebase follow-up patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc:

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72743. meven added a comment. Update commit message REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72742=72743 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26358 AFFECTED FILES

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. I have tested it and it solves https://bugs.kde.org/show_bug.cgi?id=414482 It seems .protocol file support has some issue. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol,

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72742. meven marked 4 inline comments as done. meven added a comment. Fix json REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72596=72742 BRANCH arcpatch-D26358 REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

pino added inline comments. INLINE COMMENTS > smb.json:27 > +"output": "filesystem", > +"protocol": "recentlyused", > +"reading": true, erm... > smb.protocol:11 > -deleting=true > -opening=true > -moving=true what about this key? REPOSITORY R320 KIO

D26358: KIO/SMB convert kio protocol declaration to json format

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > apol wrote in kio_smb.cpp:42 > Shouldn't this go in the SMBSlave class? No this is fine, this is done the same way in trash, file, recentlyused io~slaves... Follows

D26410: Port KLanguageButton from KConfig to QSettings

pino added a comment. IIRC `KConfigGroup::readEntry() reads the translated version of the key, and every `kf5_entry.desktop` has such translations. QSettings does not do that. Did you test only in an English setup? REPOSITORY R265 KConfigWidgets BRANCH klb REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

broulik added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:783 > Good point I have edited the commit message > when a network mount is unresponsive If I do a `QFileInfo` on an unresponsive mount it will still block. You already freeze before you even know it's a network

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > Yes, but the "never blocks" claim in the commit message is misleading. Good point I have edited the commit message REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 72738. meven marked 3 inline comments as done. meven added a comment. amend commit title REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=72732=72738 BRANCH arcpatch-D26407 REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven retitled this revision from "KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs" to "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs". REPOSITORY R241 KIO

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

broulik added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:783 > At least the mnttab reading business in KMountPoint::currentMountPoints is > saved. Yes, but the "never blocks" claim in the commit message is misleading. REPOSITORY R241 KIO REVISION DETAIL

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache > doesn't help at all. At least the mnttab reading business in KMountPoint::currentMountPoints is saved. > anthonyfieroni wrote in

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

broulik added inline comments. INLINE COMMENTS > kfileitem.cpp:783 > +const auto = getMountPoints(); > +auto mp = mountPoints.findByPath(path); > +if (mp) { This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache doesn't help at all.

D26415: Ensure to store resource uri without a trailing slash

meven updated this revision to Diff 72734. meven added a comment. Add ResourceInstance::setUri case REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26415?vs=72733=72734 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26415 AFFECTED FILES

D26415: Ensure to store resource uri without a trailing slash

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Some apps may send resource such as /home/me/Documents/ When others, can

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitem.cpp:49-50 > + */ > +static KMountPoint::List mountPoints; > +static QDateTime lastMountPointUpdate; > + Put them in `getMountPoints` as local static variables, global static are no-go. > dfaure wrote in kfileitem.cpp:787 > This

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

ilic added a comment. In D26413#587390 , @dfaure wrote: > Alternative approach: export it and unittest it, D26408 . > > @ilic your input would be very welcome on which approach should be taken. I don't

Re: File missing license header in KCoreAddons

On lundi 23 décembre 2019 13:47:13 CET Ahmad Samir wrote: > Hi there. > > While working on KCoreAddons I found that > "kcoreaddons/src/autotests/kstringhandlertest.cpp" doesn't have a > license header at all; digging around in the old kdelibs git repo > history, I found it was initially written

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

dfaure added inline comments. INLINE COMMENTS > kfileitem.cpp:787 > +} else { > +// if no mount point was found, can only mean we are on > android > +m_slow = Fast; This is not really true. We have that problem in the FreeBSD CI, where there's no

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven updated this revision to Diff 72732. meven added a comment. Address review, don't commit at 1 a.m REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=72720=72732 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. I have to check on the tests. INLINE COMMENTS > dfaure wrote in jobtest.cpp:2171 > Why the short 500ms timeout? CI can be slow sometimes. It was the previous value used line 2176 for the same use, except the file cleaning will now be more immediate. REPOSITORY

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25117_1 REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72729. meven added a comment. Use more appropriate error(KIO::ERR_USER_CANCELED) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=70401=72729 BRANCH arcpatch-D25117_1 REVISION DETAIL

D26412: [Kuit] Port QRegExp to QRegularExpression

dfaure added a comment. Unittest for this method added in https://commits.kde.org/ki18n/a92305a4c15ac361417eeb7b933682960c7545e1 Please check your change passes the test. Extend as needed if you noticed other cases that need to be handled. REPOSITORY R249 KI18n REVISION DETAIL

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

dfaure added a comment. Alternative approach: export it and unittest it, D26408 . @ilic your input would be very welcome on which approach should be taken. I don't care much personally, it's just really inconsistent right now (looks like public API,

D26408: ki18n: add unittest for KUitSetup::setFormatForMarker

dfaure added a comment. This makes KuitSetup actually usable from applications. Alternative approach: D26413 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26408 To: dfaure, ilic Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

dfaure created this revision. dfaure added a reviewer: ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Since setupForDomain wasn't exported, there was no way to use the KuitSetup API. So

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure added a comment. You just made me realize something. The setter is unused, but the getter is used in all cases, to lookup the builtin formats. So I just extended the unittests in https://commits.kde.org/ki18n/4f9d907fb8e8dba33aa80926d3b36ba12f30da04 These tests do check the

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port salvageMarkup() to QRegularExpression. Remove one redundant QRegExp #include.

D26331: Removed reading description from desktop files

dfaure added a comment. OK, remove it. The other feature (kfilemetadata?) should be fixed though REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni added a comment. Ping what else to do? If no objectives i'll push it for next framework release. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#587313 , @dfaure wrote: > See D26408 for a unittest. But maybe the code can just be killed... My 2p, keep it as it looks like a way to override the default

D26410: Port KLanguageButton from KConfig to QSettings

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH klb REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,