D26450: Port to QMultiHash as QHash::insertMulti is deprecated

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R244 KCoreAddons BRANCH port_multi_hash (branched from master) REVISION DETAIL

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

mlaurent added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26450 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:694 > Why? Surely the QTextStream destructor (which is called here) will take care > of that. I think that it was a problem when QTextStream used QString which doesn't flush it. code is a QString

D26449: [PoC] Port to KRecentFileMenu

mlaurent added a comment. So you need to increase kf5 dependancy no ? REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D26449 To: nicolasfella, #ark, #frameworks Cc: mlaurent, kde-utils-devel, fbampaloukas, tctara

D26448: Add KRecentFilesMenu to replace KRecentFileAction

cfeck added a comment. Nice :) INLINE COMMENTS > krecentfilesmenu.cpp:34 > + > +KRecentFilesMenu::KRecentFilesMenu(const QString& title, QWidget* parent) > +: QMenu(title, parent) Here you switch from `Type *var` to `Type* var` > krecentfilesmenu.cpp:41 > + >

Re: D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

I wanted to inform you that this user died 12/22 from injuries suffered after being struck on his motorcycle by an SUV On Sun, Dec 8, 2019, 07:04 Alex Turbov wrote: > turbov created this revision. > turbov added a reviewer: Framework: Syntax Highlighting. > Herald added projects: Kate,

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26416 REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 72844. nicolasfella added a comment. - Docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72842=72844 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26449: [PoC] Port to KRecentFileMenu

nicolasfella created this revision. nicolasfella added reviewers: Ark, Frameworks. Herald added a subscriber: kde-utils-devel. Herald added a project: Ark. nicolasfella requested review of this revision. REVISION SUMMARY PoC for using KRecentFileMenu. See D26448

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The way KRecentFilesAction is used has a number of

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d5d0e2668d4b: Turn application/x-ms-shortcut into an actual shortcut icon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26404?vs=72817=72834#toc REPOSITORY R266

D26441: New icon for KTimeTracker

ndavis added a comment. The top part looks a bit too flat and wide. There's also nothing attaching it to the body, so it looks like it's floating. I don't think Plasma Blue work well as a body color with no outline. This happens when I select the file in dolphin because it blends in

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72832. meven added a comment. Use QTRY_VERIFY instead of sleep + Q_VERIFY REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=72798=72832 BRANCH arcpatch-D25117_1 REVISION DETAIL https://phabricator.kde.org/D25117

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Make sure you copy to breeze dark as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26404 To: broulik, #vdg, ndavis Cc: ndavis, kde-frameworks-devel,

D26440: Add KSharedConfig::openStateConfig for storing state information

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ebd14f29f805: Add KSharedConfig::openStateConfig for storing state information (authored by nicolasfella). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a revision: D26443: KPluginMetaData: add initialPreference() getter. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ahmadsamir, ngraham, kpiwowarski, asturmlechner, jucato, cfeck, cullmann, vkrause,

D26440: Add KSharedConfig::openStateConfig for storing state information

dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R237 KConfig BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella updated this revision to Diff 72826. nicolasfella added a comment. - Change to staterc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26440?vs=72820=72826 BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440 AFFECTED FILES

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella retitled this revision from "Add utility method for opening a KSharedConfig suitable to store state information" to "Add KSharedConfig::openStateConfig for storing state information". REPOSITORY R237 KConfig BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a revision: D26442: desktoptojson: also convert InitialPreference key. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ahmadsamir, ngraham, kpiwowarski, asturmlechner, jucato, cfeck, cullmann, vkrause,

D26442: desktoptojson: also convert InitialPreference key

dfaure created this revision. dfaure added a reviewer: arichardson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is going to be useful to load KParts using KPluginLoader. Most other plugins

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

dfaure abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26413 To: dfaure, ilic Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg Cc: kde-frameworks-devel, aspotashev, LeGast00n, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This diff adds a new icon for KTimeTracker. T12305

D26331: Removed reading description from .desktop files AND .directory files

count added a comment. In D26331#588073 , @ngraham wrote: > Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information? It's count negative

D26440: Add utility method for opening a KSharedConfig suitable to store state information

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good. I'm just going back and forth in my mind between dolphinstate and dolphinstaterc. The latter would have the benefit of telling experienced developers that it uses the KConfig

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Oh boy this is going to really give a big conflict with D26202 ! Given that this commit is "more trivial" than D26202

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

dfaure added a reviewer: tcanabrava. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26432 To: mlaurent, dfaure, tcanabrava Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in ksharedconfig.cpp:124 > My idea was to add `const QString = QString()` to this method so > that complex apps can use multiple state files. Or for parts and plugins to > use a fixed name whatever app they're in. > (one

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella updated this revision to Diff 72820. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Add filename arg and use simpleconfig REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26440?vs=72818=72820 BRANCH state

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella added a comment. In D26440#588110 , @dfaure wrote: > > For e.g. dolphin the file .config/dolphin/dolphinstate would be created. > > You mean ~/.local/share/dolphin/dolphinstate, right? Of course REPOSITORY R237 KConfig

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

dfaure added a comment. Interesting suggestion. We're used to using names for actions everywhere, but in this specific case an enum would do indeed. When this is ported away from KActionCollection in the future, one should remember to do action->setObjectName("...") for code that

D26440: Add utility method for opening a KSharedConfig suitable to store state information

dfaure added a comment. > For e.g. dolphin the file .config/dolphin/dolphinstate would be created. You mean ~/.local/share/dolphin/dolphinstate, right? INLINE COMMENTS > ksharedconfig.cpp:124 > > +KSharedConfig::Ptr KSharedConfig::openStateConfig() > +{ My idea was to add `const

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY A common complaint is that our apps store 'state'

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

broulik updated this revision to Diff 72817. broulik added a comment. - Rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26404?vs=72712=72817 REVISION DETAIL https://phabricator.kde.org/D26404 AFFECTED FILES

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:2075 > +QThread::msleep(500); > +QVERIFY(!QFile::exists(destToCheck)); > } How about QTRY_VERIFY instead of a hardcoded 500ms sleep?

D26408: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker

This revision was automatically updated to reflect the committed changes. Closed by commit R249:836908f3b83e: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker (authored by dfaure). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure,

D26408: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker

dfaure updated this revision to Diff 72814. dfaure retitled this revision from "ki18n: add unittest for KUitSetup::setFormatForMarker" to "ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker". dfaure edited the summary of this revision. dfaure added a comment. Update

D26331: Removed reading description from .desktop files AND .directory files

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ilic added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:90 > Interesting idea, this simplifies the code. > > However the name "wsRx" no longer matches what this regexp does. > > Also, the old trimming is missing here, isn't it? > I guess \s*:?\s* is needed, and \s*/?\s* >

D26331: Removed reading description from .desktop files AND .directory files

ngraham accepted this revision. ngraham added a comment. Everybody good with this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25517: Add an option to extract image data and add front cover property

bruns added a comment. The problem is the extractor serves two different use cases: - retrieval for searching/caching properties - on-demand extraction Baloo falls into the first category. It is only interested in properties which can be queried/compared in a meaningful way.

Re: Does FreeBSD have HAL?

On Saturday, 4 January 2020 18:16:30 CET David Faure wrote: > qdbus --system org.freedesktop.HalManage Does not exist. There's some complications around HAL. We don't necessarily run it, but solid wants it, and the CD-eject functionality of Plasma Device notifier needs it (so I can't eject CD's

Re: Does FreeBSD have HAL?

On Sun, Jan 5, 2020 at 3:37 PM Tijl Coosemans wrote: > On Sun, 5 Jan 2020 10:06:08 +0100 "Tobias C. Berner" > wrote: > > Moin moin > > > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > > "bsdisks2" in the near future by default. > > > > Hald is likely not enabled on the

D26408: ki18n: add unittest for KUitSetup::setFormatForMarker

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D26408 To: dfaure, ilic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Does FreeBSD have HAL?

Hi David, [dwayne@Chiron ~/Downloads]$ qdbus --system org.freedesktop.Hal / /org /org/freedesktop /org/freedesktop/Hal /org/freedesktop/Hal/Manager /org/freedesktop/Hal/devices /org/freedesktop/Hal/devices/nvidia_0_drm_nvidia_card0 /org/freedesktop/Hal/devices/pcm_0_oss_mixer_0

D26331: Removed reading description from .desktop files AND .directory files

count updated this revision to Diff 72807. count added a comment. added removing of .directory files reading REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26331?vs=72803=72807 REVISION DETAIL https://phabricator.kde.org/D26331 AFFECTED FILES

D26331: Removed reading description from .desktop files AND .directory files

count set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. I think you lost the original diff with the latest update to this patch. REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25517: Add an option to extract image data and add front cover property

ngraham added a comment. In D25517#587957 , @astippich wrote: > I also fear that it may not be clear to distinguish between "simple" and "complex" properties and that users of the API would expect that every property works for the

D26331: Removed reading description from .desktop files AND .directory files

count updated this revision to Diff 72803. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26331?vs=72490=72803 REVISION DETAIL https://phabricator.kde.org/D26331 AFFECTED FILES src/core/kfileitem.cpp To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham,

D26331: Removed reading description from .desktop files AND .directory files

count retitled this revision from "Removed reading description from desktop files" to "Removed reading description from .desktop files AND .directory files". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham

D26331: Removed reading description from desktop files

ngraham added a comment. Makes sense to me, following the same logic. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

anthonyfieroni added inline comments. INLINE COMMENTS > kconfigtest.cpp:533-542 > +out << "[Test Group]\n" > +<< "homePath=$HOME/foo\n" > +<< "homePath2=file://$HOME/foo\n" > +<< "withSlash=$WITHSLASH/foo\n" > +<< "withSlash2=$WITHSLASH\n"

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72798. meven added a comment. Stabilise test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=72729=72798 BRANCH arcpatch-D25117_1 REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED FILES

D25517: Add an option to extract image data and add front cover property

astippich added a comment. In D25517#587776 , @bruns wrote: > I have thought about this and have come to the conclusion this is not really future proof. > > The `Property::FrontCover` is IMHO fine, i.e. the changes to `propertyinfo.cpp` and

D26415: Ensure to store resource uri without a trailing slash

meven edited the summary of this revision. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D26415 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven added a reviewer: apol. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26432 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl as in qt5.15 it's namespaced REPOSITORY R237 KConfig BRANCH port_endl (branched from master)

D26431: Fix build of python bindings for kcolumnheadersmodel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:89e24bd88ea7: Fix build of python bindings for kcolumnheadersmodel (authored by arojas). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26431?vs=72789=72791

D26431: Fix build of python bindings for kcolumnheadersmodel

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Silly sip :/ REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D26431 To: arojas, dfaure, ahiemstra, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D26431: Fix build of python bindings for kcolumnheadersmodel

arojas created this revision. arojas added reviewers: dfaure, ahiemstra, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Replace QModelIndex{} with QModelIndex() to make sip happy.

Re: Does FreeBSD have HAL?

On Sun, Jan 5, 2020 at 1:06 PM Tobias C. Berner wrote: > Moin moin > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > "bsdisks2" in the near future by default. > > Hald is likely not enabled on the CI hosts -- I could enable it :) -- > or we could push the switch and make

Re: Does FreeBSD have HAL?

On Sun, 5 Jan 2020 10:06:08 +0100 "Tobias C. Berner" wrote: > Moin moin > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > "bsdisks2" in the near future by default. > > Hald is likely not enabled on the CI hosts -- I could enable it :) -- > or we could push the switch

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

aacid added a comment. Why are we using a string instead of an enum? It's not like this is KXMLGui where people can define their own actions, is it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid,

D26168: i18n: Split translations for strings "Translation"

This revision was automatically updated to reflect the committed changes. Closed by commit R263:cfa4f04d4303: i18n: Split translations for strings Translation (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26168?vs=72025=72787

D26170: i18n: Add more semantic context strings

This revision was automatically updated to reflect the committed changes. Closed by commit R263:b834a855bf29: i18n: Add more semantic context strings (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26170?vs=72028=72788 REVISION

D26429: [KCompletion] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R284:846f686dfe5b: [KCompletion] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26429?vs=72777=72786

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a comment. My current thinking is to go with option 3, with high-level API in KParts itself, to encapsulate underlying discovery and loading mechanisms completely. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 92 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/92/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 05 Jan 2020 10:52:15 + Build duration: 3 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 139 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/139/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 05 Jan 2020 10:52:14 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/87/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 05 Jan 2020 10:52:15 + Build duration: 2 min 21 sec and counting JUnit Tests Name:

D26009: KCoreAddons: fix compilation with qtbase git dev branch

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26009 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009

This revision was automatically updated to reflect the committed changes. Closed by commit R237:171a2c26d280: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26099: Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > timelinetools.cpp:122 > +} else if (sections.count() > 1) { > +match = s_dateRegexp.match(sections[sections.count() - 2]); > +

D26429: [KCompletion] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26429 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n,

D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26430 To: arojas, davidedmundson, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Does FreeBSD have HAL?

Hi Dwayne, I think I confused service name and interface name. Does `qdbus --system org.freedesktop.Hal` work? Thanks, David. On dimanche 5 janvier 2020 01:34:49 CET Dwayne MacKinnon wrote: > Hi, > > So, when I run your qdbus comand, I get this message: > > Service

D26412: [Kuit] Port QRegExp to QRegularExpression

dfaure added a comment. Me neither, but the regexp should tell us what it's about, right? ;) Indeed it seems to me that this is about things like but also and even REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26412 To: ahmadsamir, #frameworks, ilic,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

dfaure added a comment. +1, API and code look good REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26194: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D26194 To: ahmadsamir, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24793: [Konqueror] Remove KonqView::setActiveComponent()

This revision was automatically updated to reflect the committed changes. Closed by commit R226:fefbc0ce295c: [Konqueror] Remove KonqView::setActiveComponent() (authored by ahmadsamir). REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=72782=72783

D24793: [Konqueror] Remove KonqView::setActiveComponent()

ahmadsamir updated this revision to Diff 72782. ahmadsamir added a comment. Rebase REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=68322=72782 BRANCH ahmad/setactiveComponent (branched from master) REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R265:05ea3d2926e7: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72780=72781 REVISION

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72780. ahmadsamir added a comment. Rebase REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72083=72780 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: apol, dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009

arojas created this revision. arojas added reviewers: davidedmundson, broulik, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Exclude the new function from the sip parser TEST PLAN Python

D26177: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R237:2055025c0c79: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72138=72779 REVISION DETAIL

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

dhaumann added inline comments. INLINE COMMENTS > kdiroperator.h:428 > +/** > + * an accessor to a collection of all available Actions. The actions > + * are static, they will be there all the time. Imho the API documentation should be improved (I am aware it was copied). Returns

D26429: [KCompletion] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was pretty trivial. TEST PLAN make && ctest and klineedittest still works. REPOSITORY R284

D25877: [KColorschemeManager] Add option to reenable following global theme

asemke added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.cpp:220 > Should we also do this for the other overloads? Or would that behavior change > be a blocker? ALso an application would want to call > `KColorSchemeManager::createSchemeSelectionMenu(const QString >

D26331: Removed reading description from desktop files

count added a comment. Ok, I've played a little around, and imho we should remove the support for .directory file comments too: Here you see, the type column is read from the comment field inside the .directory file F7861776: screen.png

Re: Does FreeBSD have HAL?

Moin moin We will replace (ancient) hal with Gleb's implementation of usdisks2 "bsdisks2" in the near future by default. Hald is likely not enabled on the CI hosts -- I could enable it :) -- or we could push the switch and make bsdisks2 the default in master, which I would prefer. What is your