D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. From me I am ok with David comment for this code it's not necessary to have a flush() many time. Adding \n is enough for me. Regards REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol,

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73114. trmdi added a comment. - Improve code - Improve code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73113=73114 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73113. trmdi added a comment. - Improve code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73112=73113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/core/job_base.h

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73112. trmdi added a comment. - Remove the new signal and show a "Fetching data" menu while delaying REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73076=73112 BRANCH master REVISION DETAIL

D26484: Add a new parameter for delaying showing menu

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

apol accepted this revision. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26513: Port KNotification from KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R289:32c84f532f66: Port KNotification from KWindowSystem (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26513?vs=73027=73107

D26512: Drop unused headers

This revision was automatically updated to reflect the committed changes. Closed by commit R263:0c410c8e3855: Drop unused headers (authored by davidedmundson). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26512?vs=73026=73106 REVISION DETAIL

D26513: Port KNotification from KWindowSystem

davidedmundson added a task: T12413: RFC: Split KWindowSystem into KX11 and KHighLevelWindowStuff. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26513 To: davidedmundson, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26532: Don't use KWindowSystem on Android

nicolasfella added a subscriber: dfaure. nicolasfella added a comment. Pragmatically speaking I want to say 'No'. @dfaure Do you have an opinion on this? REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella,

D26532: Don't use KWindowSystem on Android

vkrause added a comment. In D26532#590609 , @nicolasfella wrote: > In D26532#590598 , @vkrause wrote: > > > We are already not building a few things here on Android (including public API on other

D26532: Don't use KWindowSystem on Android

nicolasfella added a comment. In D26532#590598 , @vkrause wrote: > We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't

D26532: Don't use KWindowSystem on Android

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an

D25679: Implement writing of front cover in taglibwriter

astippich updated this revision to Diff 73099. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25679?vs=70725=73099 BRANCH tagLibBinaryWrite REVISION DETAIL https://phabricator.kde.org/D25679

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 73097. astippich added a comment. - adress review comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=71623=73097 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 73098. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=70724=73098 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518

D26513: Port KNotification from KWindowSystem

nicolasfella added a dependent revision: D26532: Don't use KWindowSystem on Android. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26513 To: davidedmundson, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D26513: Port KNotification from KWindowSystem. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n,

D26532: Don't use KWindowSystem on Android

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The usage of KWindowSystem is not relevant on Android.

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio,

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre edited the summary of this revision. REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 73079. davidre added a comment. Forgot to save file REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=73077=73079 BRANCH systemthem (branched from master) REVISION DETAIL

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre edited the summary of this revision. davidre edited the test plan for this revision. REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ahmadsamir, asemke, kossebau,

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 73077. davidre added a comment. @since 5.67 REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=73075=73077 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D26484: Add a new parameter for delaying showing menu

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73076. trmdi added a comment. - Move delayPopup to JobFlag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73030=73076 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 73075. davidre added a comment. Also provide defaults for the other overloads REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=72623=73075 BRANCH systemthem (branched from master) REVISION DETAIL

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

ervin added inline comments. INLINE COMMENTS > managedconfigmodule.h:206 > + * it may be needed to call settingsChanged() > + */ > +void registerSettings(KCoreConfigSkeleton* skeleton); Now needs @since 5.67 REPOSITORY R296 KDeclarative REVISION DETAIL

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'll initialize with dumb values and refresh it when shown, which

D26484: Add a new parameter for delaying showing menu

broulik added a comment. I don't fully understand why `popupMenuAboutToShow` isn't sufficient. An alternative approach I could think would be allowing the signal handler to delay the menu as necessary rather than having to create the drop job differently? INLINE COMMENTS > dropjob.h:131

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

kossebau added a comment. In D26320#586935 , @mlaurent wrote: > So what I need to change in this patch ? (if I need to change a code :) ) When it comes to me, so far I have been more curious what the best principled approach is in

D26512: Drop unused headers

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26512 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519 To: bport, ervin, meven, crossi, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

bport updated this revision to Diff 73045. bport added a comment. Simplify code REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73042=73045 REVISION DETAIL https://phabricator.kde.org/D26519 AFFECTED FILES src/kcmultidialog.cpp To: bport,

D26519: Show button respecting what is declared by KCModule

bport added inline comments. INLINE COMMENTS > ervin wrote in kcmultidialog.cpp:217 > Well, I think I wouldn't temper with the setVisible of helpButton at all. > Just to keep the behavior in line with systemsettings and keep the old > behavior. This is not what this patch is supposed to change

D26519: Show button respecting what is declared by KCModule

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > meven wrote in kcmultidialog.cpp:217 > You can remove this line I think : no need to disable a hidden button, or > enable a visible one. Well, I think I

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

ervin accepted this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26517 To: bport, ervin, meven, crossi, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

meven added inline comments. INLINE COMMENTS > kcmultidialog.cpp:217 > +helpButton->setVisible(buttons & KCModule::Help); > helpButton->setEnabled(activeModule->buttons() & KCModule::Help); > } You can remove this line I think : no need to disable a hidden

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26517 To: bport, ervin, meven, crossi, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL