D26650: Use KService to look for Filelight

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

shubham updated this revision to Diff 73593. shubham added a comment. Make requested changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26650?vs=73556=73593 BRANCH filelight REVISION DETAIL https://phabricator.kde.org/D26650 AFFECTED FILES

D26652: Unbreak module imports for Python2

kossebau added a comment. Last night's run of api.kde.org generation with kapidox locally patched with this change worked again, So unless there are objections will push then latest next WE, though happy to have people give green light before :) REPOSITORY R264 KApiDox REVISION DETAIL

D26671: Cleanup and add 22px media repeat icons

astippich added a comment. here you go: F7883937: media-repet.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26671 To: astippich, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26671: Cleanup and add 22px media repeat icons

astippich updated this revision to Diff 73592. astippich added a comment. - remove color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26671?vs=73567=73592 BRANCH repeatIcons REVISION DETAIL https://phabricator.kde.org/D26671 AFFECTED FILES

D26671: Cleanup and add 22px media repeat icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Making monochrome breeze icons is tricky; you'll want to read https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips if you haven't already. Also, screenshots

D26677: Port away from KLineEdit and KComboBox to Q equivalent

gassaf added a reviewer: kde-frameworks-devel. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D26677 To: gassaf, kde-frameworks-devel Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

gassaf added a task: T12168: KNotifyConfig: Port away from KLineEdit and KComboBox to Q equivalent. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D26677 To: gassaf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

gassaf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gassaf requested review of this revision. REVISION SUMMARY Port away from KLineEdit and KComboBox to Q equivalent REPOSITORY R305 KNotifyConfig BRANCH port_to_q_ui (branched

D26671: Cleanup and add 22px media repeat icons

astippich created this revision. astippich added reviewers: VDG, ngraham, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY This patch does the following things: -small cleanup to the

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre edited the summary of this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre, #framework_syntax_highlighting, #localization, #build_system Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

kossebau added inline comments. INLINE COMMENTS > KF5I18nMacros.cmake.in:52 > foreach (_current_FILE ${ARGN}) > - > + if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/${_current_FILE}) > + message(SEND_ERROR This assumes a relative path given. It might make sense to also deal with

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre edited the test plan for this revision. davidre added reviewers: Framework: Syntax Highlighting, Localization, Build System. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre, #framework_syntax_highlighting, #localization, #build_system Cc:

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Makes it clear why the current build is failing instead of the develoepr wasting time investigating other causes.

D26650: Use KService to look for Filelight

anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1114 > + > d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon())); > connect(d->m_sizeDetailsButton, ::clicked, this, > ::slotSizeDetails); >

D26650: Use KService to look for Filelight

anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1452-1457 > void KFilePropsPlugin::slotSizeDetails() > { > // Open the current folder in filelight > -KRun::run((QStandardPaths::findExecutable(QStringLiteral("filelight"))), > { properties->url() },

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

ngraham added a subscriber: elvisangelaccio. ngraham added a comment. #frameworks folks, #dolphin folks, and/or @elvisangelaccio, how is this looking? It would be really nice to be able to use the same

D26650: Use KService to look for Filelight

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

ngraham added a comment. Please mark the inline comments that are resolved as "Done" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73557. tcanabrava added a comment. - Add missing copyright holders REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73510=73557 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202

D26650: Use KService to look for Filelight

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

shubham updated this revision to Diff 73556. shubham added a comment. Use desciptive variable name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26650?vs=73535=73556 BRANCH filelight REVISION DETAIL https://phabricator.kde.org/D26650 AFFECTED FILES

D26650: Use KService to look for Filelight

ngraham added a comment. Much better, thanks. Remember to mark inline comments as "Done" once you've addressed them. INLINE COMMENTS > kpropertiesdialog.cpp:1109 > > -if > (!QStandardPaths::findExecutable(QStringLiteral("filelight")).isEmpty()) { > +KService::Ptr serv =

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

This revision was automatically updated to reflect the committed changes. Closed by commit R236:945f1849cc24: [KMessageBox] Only allow selecting text in the dialog box using the mouse (authored by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham added a comment. In D26649#593825 , @broulik wrote: > So you can't tab around to end up focusing the text field? As Noah said, you already can't. This doesn't change anything about what you can focus with the tab key. REPOSITORY

D26664: Same behavior for scrollbar as the desktop style

ngraham added a comment. I don't see the separator lines in plasma applets. Is that intentional? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26664 To: mart, #plasma, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 14 Jan 2020 16:26:55 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/53/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 14 Jan 2020 16:26:55 + Build duration: 18 min and counting BUILD ARTIFACTS

D26648: Improved quality of JPEG thumbnails

chroniceel edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. It's not overly scientific, but with this little fix, it can gen ~10 thumbnails a second on my system (1.6 Ghz pentium, ~10MP). This seems on par with png files of a similar size. As far as I can tell, there is not a super huge performance decrease. Please note,

D26248: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant

This revision was automatically updated to reflect the committed changes. Closed by commit R304:bd2e67ea61b5: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant (authored by kossebau). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73545. mart added a comment. - add missing property REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73543=73545 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 271 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/271/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 14 Jan 2020 15:21:47 + Build duration: 40 min and counting JUnit Tests Name: projectroot

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73543. mart added a comment. - smoother transition REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73525=73543 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664

D26648: Improved quality of JPEG thumbnails

bruns added a comment. In D26648#593895 , @volkov wrote: > But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible. Can we have some quick

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 279 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/279/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 14 Jan 2020 15:21:47 + Build duration: 9 min 9 sec and counting BUILD ARTIFACTS

D26663: Fix doc block in KProtocolInfoFactory

This revision was automatically updated to reflect the committed changes. Closed by commit R241:be69b302f1d7: Fix doc block in KProtocolInfoFactory (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26663?vs=73522=73538 REVISION DETAIL

D26650: Use KService to look for Filelight

shubham updated this revision to Diff 73535. shubham added a comment. Use KService to get the application's icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26650?vs=73483=73535 BRANCH filelight REVISION DETAIL https://phabricator.kde.org/D26650

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 96 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/96/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 14 Jan 2020 14:42:54 + Build duration: 5 min 43 sec and counting BUILD ARTIFACTS

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73530. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73529=73530 BRANCH l-qregexp-deprecate (branched from master)

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kcoredirlister.h:595 > This class is exported, you cannot change this existing method and you also > cannot add a new `virtual`, see > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B Thanks,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/91/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 14 Jan 2020 14:42:52 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73529. ahmadsamir removed a subscriber: broulik. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73527=73529 BRANCH l-qregexp-deprecate (branched from master) REVISION

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. Now we have a small list of potential users of this : plasma-desktop/kcms/kfontinst/lib/Misc.cpp:391 plasma-desktop/kcms/baloo/filteredfoldermodel.cpp:50 plasma-workspace/runners/baloo/baloosearchrunner.cpp:176

D26122: Add utility text function KShell::tildeCollapse

This revision was automatically updated to reflect the committed changes. Closed by commit R244:94e6927d2f8c: Add utility text function KShell::tildeCollapse (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=73386=73528

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73527. ahmadsamir added a comment. Can't change doNameFilter due to BIC REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73515=73527 BRANCH l-qregexp-deprecate (branched from master) REVISION DETAIL

D26664: Same behavior for scrollbar as the desktop style

mart retitled this revision from "same behavior for scrollbar as the desktop style" to "Same behavior for scrollbar as the desktop style". mart edited the test plan for this revision. mart added a reviewer: ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26664: same behavior for scrollbar as the desktop style

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY bigger scrollbar and add a small line separator to look consistent with D26655

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis added a comment. In D26649#593825 , @broulik wrote: > So you can't tab around to end up focusing the text field? You currently aren't able to, but after you click with the mouse on the text, you can use the arrow keys to move an I

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a comment. I am thinking about adding some api to check status of nfs, sftp or smb mounts by checking their hostname network reachability, to complement isSlow(), and perhaps then running a stat of the mount with a timeout. This would be kept in a cache with a short duration.

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73524. meven marked 4 inline comments as done. meven added a comment. Address review: Make KMountPoint::Ptr KMountPoint::List::findByPath non-blocking, checking recursively intermediate symlinks REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. In D25856#594088 , @meven wrote: > In D25856#575125 , @fvogt wrote: > > > In D25856#575083 , @ngraham wrote: > > > > > In

D25856: Show IOSlaves that return local files when in local file mode

meven added a comment. In D25856#575125 , @fvogt wrote: > In D25856#575083 , @ngraham wrote: > > > In D25856#575044 , @fvogt wrote: > > > > > IMO this

D26663: Fix doc block in KProtocolInfoFactory

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26663 To: meven, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26663: Fix doc block in KProtocolInfoFactory

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevented documentation to appear. REPOSITORY R241 KIO BRANCH master

D26122: Add utility text function KShell::tildeCollapse

meven edited the summary of this revision. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

kossebau updated this revision to Diff 73518. kossebau added a comment. fix comment locale -> filesystem encoding REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26661?vs=73517=73518 BRANCH hackfsencoding REVISION DETAIL

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

kossebau added a comment. D22836 was tried before to fix this, but later it was found this still did not work on api.kde.org. At that time I had added some local patches on api.kde.org itself, but not getting further at one point forgot about things

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

kossebau created this revision. kossebau added reviewers: bshah, ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R264 KApiDox BRANCH hackfsencoding REVISION

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

broulik added inline comments. INLINE COMMENTS > kcoredirlister.h:595 > */ > -virtual bool doNameFilter(const QString , const QList > ) const; > +virtual bool doNameFilter(const QString , const > QVector ) const; > This class is exported, you cannot change this existing method

D26122: Add utility text function KShell::tildeCollapse

apol accepted this revision. apol added a comment. Looks good to me, just explain what it does on the commit message. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol,

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY doNameFilter() was the only protected function that took a QRegExp param., but I couldn't find any users of it in KDE. Also

D26248: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorry it took so long to tick this box, but go for it REPOSITORY R304 KNewStuff BRANCH moredetailsaboutKDE_INSTALL_KNSRCDIR REVISION DETAIL https://phabricator.kde.org/D26248 To:

D26652: Unbreak module imports for Python2

kossebau updated this revision to Diff 73513. kossebau added a comment. Brown paper bag for me: if one changes code, they should also see to trigger that code, in this case passing the --depdiagram-dot-dir arg to kapidox_generate... I can confirm now in my testing on the server that

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Took the time to nuke the SignalArguments and use Param instead, easier than I initially tougth. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:180 > I meant QVERIFY2(diffFile.open(...), ...). > No need to make a separate call to isOpen(). ups :)

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73510. tcanabrava marked 10 inline comments as done. tcanabrava added a comment. - Simplify List creation - Fail with the diff file name - Simplify Code - Fix Typo - Remove `SignalArgument` for `Param` - Nitpicks and Include fixes REPOSITORY

D26652: Unbreak module imports for Python2

kossebau added a comment. For now, given @bcooksley's comment going to try some simple change to 'from kapidox.depdiagram import gvutils', this is a pattern found elsewhere in the old code. Will do a local patch to the checkout on the server and see if this has any effect on next cron job

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This adds a perlSplit() overload that takes a QRegularExpression parameter, and also deprecates the

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bb06250bd2a5: cmake: Fix `CMAKE_POLICY_*_CMPN` regex and add special args to… (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D26652: Unbreak module imports for Python2

kossebau added a comment. To add to my confusion, running the unpatched version works with my local 2.7.17 python interpreter (checked with `print (sys.version)`) and worse, running things manually on api.kde.org in some test subdir also works with its 2.7.15... Now why does it fail in

D26648: Improved quality of JPEG thumbnails

volkov added a comment. `imageReader.setQuality(0);` was added in https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when I ported `JpegCreator` to `QImageReader`. But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to

D26648: Improved quality of JPEG thumbnails

cfeck added a comment. @meven, this isn't about save quality, but load quality. REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D26014: remove compiler information from bug report dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R263:3014b0278c50: remove compiler information from bug report dialog (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26014?vs=71587=73498#toc REPOSITORY R263 KXmlGui

D26019: remove ability to report bugs against arbitrary stuff from a static list

This revision was automatically updated to reflect the committed changes. Closed by commit R263:59954316cc95: remove ability to report bugs against arbitrary stuff from a static list (authored by sitter). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 270 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/270/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 14 Jan 2020 09:43:53 + Build duration: 9 min 10 sec and counting JUnit Tests Name:

D26519: Show button respecting what is declared by KCModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:f52314e6cf19: Show button respecting what is declared by KCModule (authored by bport). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73045=73494

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20WindowsMSVCQt5.13/36/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 14 Jan 2020 09:36:53 + Build duration: 11 min and counting JUnit Tests Name:

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. @apol is it ok with you ? REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

This revision was automatically updated to reflect the committed changes. Closed by commit R265:4dc3f18f1443: Fix KCMModule::setButtons documentation, if Apply is activated we also want to… (authored by bport). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 269 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/269/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 14 Jan 2020 09:33:54 + Build duration: 9 min 52 sec and counting JUnit Tests Name:

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

This revision was automatically updated to reflect the committed changes. Closed by commit R241:76470c116640: Allow to handle apps with Terminal=True in their desktop file, handle their… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven added a comment. > OK, scheme-handler replaces most of these uses. I think we should just deprecate "helper protocols" (which either hardcode an exec line or abuse mimetypes) and move it all to the scheme-handler mechanism. I completely agree, we have a standardized way to handle

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D26557 REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73490. meven added a comment. Remove uncorrect comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73449=73490 BRANCH arcpatch-D26557 REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

This revision was automatically updated to reflect the committed changes. Closed by commit R241:56732facdb3b: KOpenWithDialog: Allow to return a newly created KService created associated to… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: KUrlPixmapProvider & kdelibs4support

Am Dienstag, 14. Januar 2020, 10:30:02 CET schrieb Ben Cooksley: > Hi all, > > Recently there have been some changes to deprecate parts of > KUrlPixmapProvider - changes that appear to have landed in the last 24 > hours. > > Unfortunately this has caused breakage in kdelibs4support as shown by >

KUrlPixmapProvider & kdelibs4support

Hi all, Recently there have been some changes to deprecate parts of KUrlPixmapProvider - changes that appear to have landed in the last 24 hours. Unfortunately this has caused breakage in kdelibs4support as shown by the current status of several Dependency Builds on all platforms. See

D26652: Unbreak module imports for Python2

kossebau added inline comments. INLINE COMMENTS > bcooksley wrote in frameworkdb.py:39 > This probably needs to be `import gvutils from kapidox.depdiagram` otherwise > any calling code will need to be `kapidox.depdiagram.gvutils.` > instead of just `fvutils.` (unless Python3 allows something

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > shubham wrote in kpropertiesdialog.cpp:1113 > I tried removing it, but I couldn't see the icon on the button then. Does this not work? d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()); REPOSITORY R241 KIO REVISION DETAIL

D26648: Improved quality of JPEG thumbnails

meven added subscribers: volkov, meven. meven added a comment. Nice first patch @chroniceel ! https://github.com/openwebos/qt/blob/master/src/gui/image/qimagereader.cpp#L1202 is the only use of quality in ImageReader, its default is -1 so it depends on its

D26650: Use KService to look for Filelight

shubham added inline comments. INLINE COMMENTS > broulik wrote in kpropertiesdialog.cpp:1113 > You can also use the icon from the service I tried removing it, but I couldn't see the icon on the button then. > anthonyfieroni wrote in kpropertiesdialog.cpp:1455 > service can be nullptr, add a

D26652: Unbreak module imports for Python2

bcooksley added inline comments. INLINE COMMENTS > frameworkdb.py:39 > +else: > +import kapidox.depdiagram.gvutils > +from kapidox.depdiagram.framework import Framework This probably needs to be `import gvutils from kapidox.depdiagram` otherwise any calling code will need to be

D26652: Unbreak module imports for Python2

kossebau added a comment. Because the very user api.kde.org right now in production still uses python2 sadly. And replacing that server with something modern is sadly not a few-hours job, still waiting for someone to spend the weeks on getting a substitution done. REPOSITORY R264 KApiDox

D26648: Improved quality of JPEG thumbnails

cfeck added a comment. Did you time a performance difference? I think the idea was to get the downscaled result as fast as possible, by using integer IDCT instead of float IDCT, and by using only the DC coefficient instead of performing the IDCT at all for scale factors <= 1/8. REVISION

D26652: Unbreak module imports for Python2

awilcox added a comment. Why should Python 2 continue to be supported, after its EOL on 2020-01-01? What cases would a user be running the latest KDE release, but still have a Python 2 interpreter present as their primary/only Python interpreter? REPOSITORY R264 KApiDox REVISION

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

broulik added a comment. So you can't tab around to end up focusing the text field? REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26650: Use KService to look for Filelight

anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1455 > // Open the current folder in filelight > -KRun::run((QStandardPaths::findExecutable(QStringLiteral("filelight"))), > { properties->url() }, properties->window(), QStringLiteral("Filelight"), >

D25632: Fix module imports with Python3

kossebau added a comment. D26652 now up as proposal to fix this REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud Cc: kossebau, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,

D26652: Unbreak module imports for Python2

kossebau created this revision. kossebau added reviewers: ochurlaud, cordlandwehr. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Using kapidox_generate with python3 &

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1113 > d->m_sizeDetailsButton = new QPushButton(i18n("Explore in > Filelight"), d->m_frame); > > d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(QStringLiteral("filelight"))); >

  1   2   >