KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.12 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 06:39:57 + Build duration: 9 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 05:50:02 + Build duration: 20 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/56/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 16 Jan 2020 05:49:44 + Build duration: 4 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.13 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.13/44/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 16 Jan 2020 05:49:43 + Build duration: 2 min 55 sec and counting JUnit Tests

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 05:49:45 + Build duration: 3 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/50/ Project: kf5-qt5 AndroidQt5.13 Date of build: Thu, 16 Jan 2020 05:50:04 + Build duration: 1 min 9 sec and counting

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpressoin-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26693 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel,

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham added a comment. Hmm, I'm not totally sure I agree. If the text becomes focusable by tabbing, then I think that just clutters up the focus chain with non-interactive UI elements that nobody is actually going to care about doing something with 99% of the time. REPOSITORY R236

D25798: Deprecated allowAsDefault

nicolasfella updated this revision to Diff 73672. nicolasfella added a comment. - Fix and update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=71036=73672 BRANCH allo REVISION DETAIL https://phabricator.kde.org/D25798 AFFECTED FILES

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

dfaure added a comment. s/Schema/Scheme/ everywhere (method name, commit log) I want to deprecate KMimeTypeTrader, this should rather go into the upcoming KApplicationTrader D25698 , if new API is needed. I'm pretty sure you can use

D26701: Add KFileCustomDialog constructor with a startDir parameter.

dfaure updated this revision to Diff 73671. dfaure added a comment. Fix docu (oops, I'm tired) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26701?vs=73668=73671 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26701 AFFECTED FILES

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. There could be a ton more unittests, but OK, good enough since the old code didn't have more. REPOSITORY R244 KCoreAddons BRANCH l-perlsplit (branched from master) REVISION DETAIL

D26701: Add KFileCustomDialog constructor with a startDir parameter.

alexeymin added inline comments. INLINE COMMENTS > kfilecustomdialog.h:40 > +/** > + * Constructors a custom file dialog > + */ Constructs? > kfilecustomdialog.h:45 > +/** > + * Constructors a custom file dialog > + * @param startDir see the KFileWidget constructor for

D26701: Add KFileCustomDialog constructor with a startDir parameter.

dfaure updated this revision to Diff 73668. dfaure added a comment. off-by-10 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26701?vs=73667=73668 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26701 AFFECTED FILES

D26701: Add KFileCustomDialog constructor with a startDir parameter.

dfaure created this revision. dfaure added reviewers: broulik, pino. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is needed because KFileWidget does special handling of the startDir

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 73666. nicolasfella marked 11 inline comments as done. nicolasfella added a comment. - Decouple from KActionCollection - Set action name - Restore root check - Use constructor delegation - Update since - fix docs - Docs fixes - Use

D26405: Add mime type for backtraces saved from DrKonqi

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. Thanks Harald. Patch looks good and I've checked that the file name pattern is what Dr. Konqi uses by default. One question though, @broulik you mentioned there's also text/x-apport, should

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

dfaure added a comment. IMHO the proper fix is to make tabbing work, and to fix Qt not to show a caret when the label gets the focus via a mouse click. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D25682: add initial wsdiscovery support

dfaure added inline comments. INLINE COMMENTS > wsdiscoverer.cpp:97 > +while (!m_discovery) { > +QCoreApplication::processEvents(); > +} You could also connect the signal resolved() to a local QEventLoop here? Would be cleaner and less CPU-intensive. REPOSITORY

D26205: KWallet: Port QRegExp to QRegularExpression

aacid added a comment. In D26205#595080 , @ahmadsamir wrote: > In D26205#595034 , @blaze wrote: > > >

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. > otherwise, we could just revert this patch The rest of the code is OK. The part that works funny is just the wildcard method, and since it's relatively new, I hope there could be a good workaround until the situation stabilizes REPOSITORY R311 KWallet

D26697: Message-related methods: Use more member-function-pointer-based connect

kossebau created this revision. kossebau added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

kossebau added a comment. Seen while forking the Message classes for KDevelop for some shell-level message area :) https://invent.kde.org/kde/kdevelop/merge_requests/87 Was confused initially by the old code, and then found it also less µ-optimized ;) REPOSITORY R39 KTextEditor

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

kossebau created this revision. kossebau added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH avoidmultiplehashaccess REVISION DETAIL

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26205#595034 , @blaze wrote: > https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187 > > QMap entries; > if (m_wallet->readEntryList("*", entries)

D26633: Deprecate KWindowEffects::markAsDashboard()

This revision was automatically updated to reflect the committed changes. Closed by commit R278:181d4f31f5c7: Deprecate KWindowEffects::markAsDashboard() (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26633?vs=73440=73655 REVISION

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 15 Jan 2020 19:02:18 + Build duration: 37 sec and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.13 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.13/43/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 15 Jan 2020 19:02:18 + Build duration: 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Jan 2020 19:02:17 + Build duration: 51 sec and counting CONSOLE OUTPUT Started by an

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/55/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 15 Jan 2020 19:02:18 + Build duration: 23 sec and counting CONSOLE OUTPUT Started by an

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/49/ Project: kf5-qt5 AndroidQt5.13 Date of build: Wed, 15 Jan 2020 19:02:19 + Build duration: 49 sec and counting CONSOLE OUTPUT Started

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187 QMap entries; if (m_wallet->readEntryList("*", entries) != 0) { qWarning() << "KWalletPasswordBackend::initialize Cannot read entries!";

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson added inline comments. INLINE COMMENTS > quickengine.h:54 > Q_PROPERTY(QString searchTerm READ searchTerm WRITE setSearchTerm RESET > resetSearchTerm NOTIFY searchTermChanged) > -Q_PROPERTY(KNSCore::EntryInternal::List changedEntries READ > changedEntries RESET

D26671: Cleanup and add 22px media repeat icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH repeatIcons REVISION DETAIL https://phabricator.kde.org/D26671 To: astippich, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @ndavis? REPOSITORY R266 Breeze Icons BRANCH repeatIcons REVISION DETAIL https://phabricator.kde.org/D26671 To: astippich, #vdg, ngraham, ndavis Cc: kde-frameworks-devel,

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

sitter added a subscriber: mpyne. sitter added a comment. +1 form me. not sure if @mpyne wants to have a look as well. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26405 To: broulik, #frameworks, sitter Cc: mpyne, kde-frameworks-devel, LeGast00n, GB_2,

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. In D26205#594867 , @ahmadsamir wrote: > A test case of what is broken would be appreciated, to try and fix/debug the issue. INLINE COMMENTS > ahmadsamir wrote in kwallet.cpp:180 > Any suggestions?

D26691: Optimize code when dropping files into the desktop

trmdi retitled this revision from "[WIP] Optimize code when dropping files into the desktop" to "Optimize code when dropping files into the desktop". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma,

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi added reviewers: Plasma, mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. trmdi added a subscriber: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven added a comment. I mean here to build consensus then implement about the need for this, then on how to implement it. I think KService should handle building this when parsing mimeapps.list files. And then expose this as `KService::findDefaultSchemeHandler(scheme)` REPOSITORY

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven retitled this revision from "Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme" to "[WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme". meven edited the summary of this revision. meven added reviewers:

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 AFFECTED

D26690: Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FILES

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > blaze wrote in kwallet.cpp:179 > QRegularExpression::wildcardToRegularExpression() already returns an anchored > output. What do you mean? I didn't get what you meant before. I've just tested and you're right; I didn't know that

D26664: Same behavior for scrollbar as the desktop style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:02e57319f791: Same behavior for scrollbar as the desktop style (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26664: Same behavior for scrollbar as the desktop style

mart marked 3 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664 To: mart, #plasma, #vdg, ngraham Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73631. mart added a comment. - round things REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73621=73631 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added inline comments. INLINE COMMENTS > ahmadsamir wrote in kwallet.cpp:179 > The pattern has to be anchored if we want to replicate what > QRegExp::exactMatch() did, with \A and \z or ^ and $. > > If you have a test case where it anchoredPattern() anchors twice, file a bug > report

D26664: Same behavior for scrollbar as the desktop style

davidedmundson added inline comments. INLINE COMMENTS > ScrollBar.qml:90 > +visible: !controlRoot.interactive > +x: controlRoot.orientation == Qt.Vertical > +? (parent.width - width) - (parent.width/2 - width/2) * > handleState Math.round? >

D26664: Same behavior for scrollbar as the desktop style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah that's fine for now. We can adjust plasmoid layouts to better accommodate the line in Plasma 5.19. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/newscrollbar REVISION

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. A test case of what is broken would be appreciated, to try and fix/debug the issue. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2,

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > blaze wrote in kwallet.cpp:179 > anchoredPattern() is excessive here, it creates a horror like that > "\\A(?:\\A(?:[^/]*)\\z)\\z" with the stuff being anchored twice. > It has to be removed with no doubt at all. The pattern has to be anchored

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73621. mart added a comment. - only show when *not* a plasmoid REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73545=73621 BRANCH phab/newscrollbar REVISION DETAIL

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. This changeset breaks the app, making it impossible to get the list of entries from outside. Tested against Falkon browser with KDE integration plugin. See my inline comments here INLINE COMMENTS > kwallet.cpp:179 > if (searchItemsJob->exec()) { > -

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. I would put for now an exception for plasmoids to not have such line, thenin a second moment we think about a proper and more complicated solution to update plasmoids design to have something along the lines of the latter mockup REPOSITORY R242 Plasma Framework

D26650: Use KService to look for Filelight

sitter added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kpropertiesdialog.cpp:1114 > OK, it can be a problem since we can have many objects of KFilePropsPlugin > thus lambda will extend service ptr life to the process end, which can result > in memory leak (it's not leak) But

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. actually, doesn't look that good. F7884183: Screenshot_20200115_16.png this is because the scrollview has some margins and no frame, so now the scrollbar appears not centered. those plasmoids would need to not have any

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. In D26664#594322 , @ngraham wrote: > I don't see the separator lines in plasma applets. Is that intentional? most of them are still qqc1, i can look into adding them there as well REPOSITORY R242 Plasma Framework

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. I am not 100% sure. It seems installed under `/etc/xdg/menus/*.menu`. You can install as many *.menu files as you want but keep different names. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. In D24423#594728 , @guoyunhe wrote: > if we copy `applications.menu` to plasma-workspace and patch it there, it will only be shipped with future plasma releases. Isn't it going to conflict with the

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. if we copy `applications.menu` to plasma-workspace and patch it there, it will only be shipped with future plasma releases. Existing released plasma can still get the old menu from kservice even with newer frameworks and it is not updated. REPOSITORY R309

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. In D24423#594718 , @guoyunhe wrote: > Then how about I copy this file `applications.menu` to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > OK, this needs a hint for the person debugging regressions then. Something > like > > QVERIFY2(content == contentRef, "Failure, see foo.diff"); This is done now within the appendFileDiff

D26202: WIP: Refactor KConfigXT

tcanabrava marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73608. tcanabrava added a comment. - Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73557=73608 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED FILES

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. Then how about I copy this file `applications.menu` to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in both repositories for some time. REPOSITORY R309 KService REVISION DETAIL

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. The question is the same. What happens with older Plasma with newer Frameworks? It may be that nothing really breaks, of course. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: davidedmundson,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. The dependency D24424 has been landed three month ago. Do you think it is safe to ship this patch now? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73605. ahmadsamir added a comment. Add TODO KF6 to doNameFilter() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73530=73605 BRANCH l-qregexp-deprecate (branched from master) REVISION DETAIL

D26650: Use KService to look for Filelight

anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in kpropertiesdialog.cpp:1114 > service is a QExplicitlySharedDataPointer in fact, I guess it > covers lambda use cases. OK, it can be a problem since we can have many objects of KFilePropsPlugin thus lambda will extend

D26650: Use KService to look for Filelight

meven added inline comments. INLINE COMMENTS > broulik wrote in kpropertiesdialog.cpp:1114 > Not sure copying that pointer into the lambda is a good idea? service is a QExplicitlySharedDataPointer in fact, I guess it covers lambda use cases. REPOSITORY R241 KIO REVISION DETAIL

D26652: Unbreak module imports for Python2

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH fixpython2support REVISION DETAIL https://phabricator.kde.org/D26652 To: kossebau, ochurlaud, cordlandwehr, davidedmundson Cc: bcooksley, awilcox, kde-frameworks-devel,

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1114 > + > d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon())); > +connect(d->m_sizeDetailsButton, ::clicked, this, > [this, service]() { > +KRun::runApplication(*service, {