D26759: [Solid] Port away from deprecated QList methods

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R245 Solid BRANCH l-toset (branched from master) REVISION DETAIL

D26600: Refactor fstab handling

hallas added a comment. In D26600#596631 , @bruns wrote: > and this is definitely too much code being moved around. Please split this up into multiple reviews. > > You should likely start with the introduction of the FilesystemEntry class,

D25015: Update breeze theme shadows

ndavis added a comment. I noticed a few things. --- The masks have a rather odd shape and it's not pixel aligned, which might mean something is wrong: F7891523: Screenshot_20200118_225818.PNG It's different from master, which looks pretty

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. For some reason, the corners of the checkbox indicator don't overlap perfectly with the corners of the base checkbox, even though the corners are exactly the same in the SVGs. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. This patch has a few problems and some things to consider. - Changing the size to `units.iconSizes.small` doesn't seem to break any layouts we have, but I have not done extensive testing with 3rd party widgets. - Is the size too small for touch input? If yes,

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The checkboxes and radio buttons in plasmashell were signficantly different from

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/95/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 19 Jan 2020 01:53:35 + Build duration: 2 min 15 sec and counting JUnit Tests Name:

D26757: Reduce dependencies on Windows

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Other than that looks good to me REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26757 To: vonreth, broulik, brute4s99,

D26757: Reduce dependencies on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:42 > > -if (NOT ANDROID) > +if (NOT ANDROID AND NOT WIN32) > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) This results in KStatusNotifierItem not being built on Windows. Is KSNI any useful on Windows

D26756: Strip richtext on Windows, as Windows does not support it

nicolasfella added a comment. We have the same problem on Linux (if the server doesn't support rich text) and probably Android too. In notifybypopup we do this with QXmlStreamReader + some API from KCodecs, but your solution is much simpler and nicer. Ideally this should be done in

D26757: Reduce dependencies on Windows

vonreth added reviewers: broulik, brute4s99, vkrause. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26757 To: vonreth, broulik, brute4s99, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26757: Reduce dependencies on Windows

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26757 AFFECTED FILES CMakeLists.txt

D26756: Strip richtext on Windows, as Windows does not support it

vonreth updated this revision to Diff 73850. vonreth added a comment. Switch to QTextDocumentFragment REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73849=73850 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756

D26756: Strip richtext on Windows, as Windows does not support it

vonreth added reviewers: broulik, brute4s99. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99 Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, as Windows does not support it

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 AFFECTED FILES

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Aparently the kmymoney issue was the same: empty kconfig file. I just successfully compiled kdevelop and kmymoney. I'll let the computer to compile the whole kde applications from scratch tonigth to see if it will fail somewhere. REPOSITORY R237 KConfig

D26600: Refactor fstab handling

bruns added a comment. and this is definitely too much code being moved around. Please split this up into multiple reviews. You should likely start with the introduction of the FilesystemEntry class, use that from the existing code. REPOSITORY R245 Solid REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73846. tcanabrava added a comment. - Revert "Revert "WIP: Refactor KConfigXT"" - Add Reference files for Broken KDevelop Configuration - Fix generating of empty configuration files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. who knew? This actually was not a false positive: the kdevelop build failure was a bug in kdevelop. I already opened a ticket: https://invent.kde.org/kde/kdevelop/merge_requests/90 but at the same time I added code to handle the case of broken / empty

D26755: KMessageWidget: Set widget height on resize event

SGOrava edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26755: KMessageWidget: Set widget height on resize event

SGOrava created this revision. SGOrava added a reviewer: Frameworks. Herald added a project: Frameworks. SGOrava requested review of this revision. REVISION SUMMARY When the resize event was triggered only the content was resized and the widget itself was kept with same height. This results

D26742: Adding new exchangerate-api source for currencies

avaldes added reviewers: ngraham, Frameworks. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D26742 To: avaldes, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

ngraham accepted this revision. ngraham added a comment. Looks like you fixed the rounded corner issues, nice. This does look much better IMO. +1 from me. Are other VDG folks good with this? @ndavis do the SVG changes look appropriate from a technical point of view? REPOSITORY R242

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73844. niccolove added a comment. Fix possible bug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73843=73844 BRANCH bettershadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73843. niccolove added a comment. Resized mask to better fit rounding shape REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73842=73843 BRANCH bettershadows (branched from master)

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73842. niccolove added a comment. Removed unrelated tabbar change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73841=73842 BRANCH bettershadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

niccolove added a comment. Can you please doublecheck that you see everything correctly? The mask thing was weird, but I think I fixed it REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D25015 To:

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73841. niccolove added a comment. - Merge branch 'master' into bettershadows - Changed masks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=69886=73841 BRANCH bettershadows (branched

D26600: Refactor fstab handling

hallas added a comment. In D26600#596533 , @bruns wrote: > Moving existing code to new files does not make you the copyright owner. Yes, sorry about that - I need to fix that. This is just my editor, when I create new files this is the

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven planned changes to this revision. meven added a comment. In D26690#596551 , @dfaure wrote: > I'm quite confused by all this. Wouldn't it be enough to do http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ? > The modified unittest

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven planned changes to this revision. meven added a comment. > Really? that's not what all callers might want. > e.g. for \"free disk space\" calculation we want the real final mountpoint for that path. > If you need something else, it should be a different method, or indeed a flag

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73836. meven marked 3 inline comments as done. meven added a comment. Fix comment issues and improve syntax used REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73831=73836 BRANCH arcpatch-D26407 REVISION DETAIL

D26690: Make "Default Applications" in mimeapps.list the preferred applications

dfaure added a comment. I'm quite confused by all this. Wouldn't it be enough to do http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ? The modified unittest passes :-) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure added inline comments. INLINE COMMENTS > kmountpoint.cpp:436 > +if (result && !result->probablySlow()) { > +// check recursively its eventual parent dir transitive symlinks > +int cursor = path.lastIndexOf(QLatin1Char('/')); is the word "for" missing in this sentence?

D26600: Refactor fstab handling

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Moving existing code to new files does not make you the copyright owner. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks,

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

patrickelectric retitled this revision from "ECMAddAppIcon: Do not warn about mac icons if isnt a mac build" to "ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build". REPOSITORY R240 Extra CMake Modules BRANCH warning_icons REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH warning_icons REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

patrickelectric added reviewers: apol, tcanabrava. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

patrickelectric created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY KSVG2ICNS will not exist if the program is not being compiled to APPLE

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmountpoint.cpp:443 > Why reuse and assign, compared to just `const QFileInfo fileinfo(parentPath)`? > > (Same for parentPath -- I prefer C++ over C) I expected reviewers to tell to have declaration outside of loops... > dfaure

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73831. meven marked 3 inline comments as done. meven added a comment. Use mid/lastIndexOf instead of split/join, use const assign in loop REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73819=73831 BRANCH

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a reviewer: apol. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D26600: Refactor fstab handling

alexde retitled this revision from "Refator fstab handling" to "Refactor fstab handling". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a comment. From ECMInstallIcons: is a numeric pixel size (typically 16, 22, 32, 48, 64, 128 or 256) or sc for scalable (SVG) files, is one of the standard FreeDesktop.org icon groups (actions, animations, apps, categories, devices, emblems, emotes, intl,

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R240 Extra CMake

D21235: Add handling of fuseiso filesystem type

hallas added a comment. I have refactored the fstab handling to make supporting fuseiso _much_ simpler - so please take a look at D26600 - once that is merged I will push a new review of this patch. REPOSITORY R245 Solid REVISION DETAIL

D26734: Revert readEntryList() to use QRegExp::Wildcard

This revision was automatically updated to reflect the committed changes. Closed by commit R311:02ab54ea6fe8: Revert readEntryList() to use QRegExp::Wildcard (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73808=73828

D26671: Cleanup and add 22px media repeat icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26671?vs=73592=73823 REVISION

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. In D26734#596420 , @dfaure wrote: > Any longer terms plan for porting away from QRegExp then? > > Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files? Qt upstream

D26749: WIP: Support NDK r20 and Qt 5.14

vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: WIP: Support NDK r20 and Qt 5.14

vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: Support NDK r20 and Qt 5.14

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-qregexp-deprecate (branched from master) REVISION DETAIL https://phabricator.kde.org/D26659 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure added inline comments. INLINE COMMENTS > kmountpoint.cpp:443 > +parentPath = splitted.join(QDir::separator()); > +fileinfo = QFileInfo(parentPath); > +if (fileinfo.isSymLink()) { Why reuse and assign, compared to just `const QFileInfo

D26713: Adapt to Qt 5.14 Android changes

This revision was automatically updated to reflect the committed changes. Closed by commit R289:41b270f06f6e: Adapt to Qt 5.14 Android changes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26713?vs=73726=73821 REVISION DETAIL

D26734: Revert readEntryList() to use QRegExp::Wildcard

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Any longer terms plan for porting away from QRegExp then? Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files? REPOSITORY R311 KWallet

D26740: Add KService::isSubseq as a public API for filtering queries.

dfaure added a comment. isContained() sounds like QString::contains(). I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying. This

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmountpoint.cpp:438 > Hmm, what if the symlink *is* the very last component, like your previous > iteration tried to handle? I made the incorrect assumption, I had already checked it > dfaure wrote in kmountpoint.cpp:445 > I don't

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73819. meven marked 3 inline comments as done. meven added a comment. Make the recursive canonical work REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73690=73819 BRANCH arcpatch-D26407 REVISION DETAIL

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

ahmadsamir added a comment. FRT, there's only one usage of perlSplit(QChar...), https://lxr.kde.org/source/kde/kdemultimedia/libkcddb/libkcddb/cdinfo.cpp#0313 nothing else uses any of the perlSplit() functions. REPOSITORY R244 KCoreAddons REVISION DETAIL