D27185: Use the right translation catalog to show translations

2020-02-07 Thread Yuri Chornoivan
yurchor added a reviewer: Localization. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27185 To: yurchor, #frameworks, #localization Cc: victorr, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27157: [KConfigLoader] Code cleanup

2020-02-07 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R237:9dec6961b3ae: [KConfigLoader] Code cleanup (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75029=75210 REVISION DETAIL

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

2020-02-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 75208. ngraham marked an inline comment as done. ngraham added a comment. Good catch; only set icon height and width if an icon has actually been provided REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: KPeople/ECM/KConfig build regression

2020-02-07 Thread Ben Cooksley
On Sat, Feb 8, 2020 at 10:20 AM David Faure wrote: > > On vendredi 7 février 2020 19:03:35 CET Ben Cooksley wrote: > > Hi all, > > > > Recently i've observed that a dependency build has started to fail > > (along with some other Binary Factory builds) due to the following > > message: > > > >

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

2020-02-07 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-pc3-toolbutton-sizing (branched from master) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham, #vdg, #plasma, broulik, ndavis Cc: gvgeo,

D26441: New icon for KTimeTracker

2020-02-07 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think I'll just accept this as it is. REPOSITORY R266 Breeze Icons BRANCH ktimetracker-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack,

D26595: Add network-wireless-hotspot icon

2020-02-07 Thread Noah Davis
ndavis commandeered this revision. ndavis added a reviewer: cblack. ndavis added a comment. sure REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: ndavis, #vdg, cblack Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27157: [KConfigLoader] Code cleanup

2020-02-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH l-configloader (branched from master) REVISION DETAIL https://phabricator.kde.org/D27157 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-07 Thread David Faure
dfaure added a comment. I'm OK with "only" a documentation fix at the KParts level. If you reimplement openUrl, you get to handle that URL, obviously. That includes possibly doing the async job that resolves it to a local file path. "making ReadOnlyPart::setUrl() set d->m_file if the

D26441: New icon for KTimeTracker

2020-02-07 Thread Carson Black
cblack added a comment. @ndavis ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg, ndavis Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

2020-02-07 Thread Carson Black
cblack added a comment. @ndavis do you want to take over this revision? You have a better sense of what this icon should be than I do. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

Re: KPeople/ECM/KConfig build regression

2020-02-07 Thread David Faure
On vendredi 7 février 2020 19:03:35 CET Ben Cooksley wrote: > Hi all, > > Recently i've observed that a dependency build has started to fail > (along with some other Binary Factory builds) due to the following > message: > > CMake Error at >

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

2020-02-07 Thread George Vogiatzis
gvgeo added inline comments. INLINE COMMENTS > ToolButton.qml:58 > Layout.fillHeight: control.icon.height <= 0 > Layout.preferredWidth: control.icon.width > 0 ? > control.icon.width : -1 > Layout.preferredHeight: control.icon.height > 0 ? >

D27224: add Kongress icon

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. F8090935: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27224: add Kongress icon

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH kongress (branched from master) REVISION DETAIL https://phabricator.kde.org/D27224

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-02-07 Thread Ahmad Samir
ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-galery icon

2020-02-07 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75194. mbruchert added a comment. - align pixel grid REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75193=75194 BRANCH kirigami_galery (branched from master) REVISION DETAIL

D27223: add kirigami-galery icon

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH kirigami_galery (branched from master) REVISION DETAIL https://phabricator.kde.org/D27223

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

2020-02-07 Thread Nathaniel Graham
ngraham added a dependent revision: D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes, per VDG mockup. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham, #vdg, #plasma, broulik Cc: kde-frameworks-devel,

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

2020-02-07 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY PC3 ToolButtons do not have the same size as PC2 and QWidgets

KPeople/ECM/KConfig build regression

2020-02-07 Thread Ben Cooksley
Hi all, Recently i've observed that a dependency build has started to fail (along with some other Binary Factory builds) due to the following message: CMake Error at /usr/home/jenkins/install-prefix/share/ECM/modules/ECMGeneratePriFile.cmake:183 (get_target_property): get_target_property()

D27220: add pix icon

2020-02-07 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75186. mbruchert added a comment. - fix pix icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27220?vs=75185=75186 BRANCH pix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27220

D27220: add pix icon

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. F8090803: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27220: add pix icon

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH pix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27220 AFFECTED

D27218: Add icon for org.kde.Ikona

2020-02-07 Thread Carson Black
cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

2020-02-07 Thread Carson Black
cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

2020-02-07 Thread Carson Black
cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

2020-02-07 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL

D25495: Fix Sonnet autodetect failing on Indian langs

2020-02-07 Thread Waqar Ahmed
waqar added a comment. ping REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27217: change bg

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH puremaps REVISION DETAIL https://phabricator.kde.org/D27217 AFFECTED FILES

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-02-07 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a process that KRun tried to run fails to launch: - Tell the user when the executable could not be found

D27215: add vvave icon

2020-02-07 Thread Camilo Higuita
camiloh accepted this revision. camiloh added a comment. This revision is now accepted and ready to land. I really nice. REPOSITORY R266 Breeze Icons BRANCH vvave (branched from master) REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert, #vdg, camiloh Cc:

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-07 Thread Nathaniel Graham
ngraham added a comment. In D27035#604158 , @davidre wrote: > Something like this: > F8059669: Screenshot_20200131_163146.PNG That would be fine, yes. In the current code I took the approach

D27215: add vvave icon

2020-02-07 Thread Nathaniel Graham
ngraham added a reviewer: camiloh. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert, #vdg, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27215: add vvave icon

2020-02-07 Thread Nathaniel Graham
ngraham added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27215: add vvave icon

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. F8090560: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27215: add vvave icon

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH vvave (branched from master) REVISION DETAIL https://phabricator.kde.org/D27215 AFFECTED

D27214: add puremaps icon

2020-02-07 Thread Carl Schwan
ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27214 To: mbruchert, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27214: add puremaps icon

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. F8090516: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27214 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27214: add puremaps icon

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH puremaps-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27214

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-07 Thread David Redondo
davidre added a comment. Ping, how should I proceed? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75175. mbruchert added a comment. - remoe puremaps icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27210?vs=75172=75175 BRANCH puremaps REVISION DETAIL https://phabricator.kde.org/D27210 AFFECTED

D27213: fix wrong icons

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH KDEonnect REVISION DETAIL https://phabricator.kde.org/D27213 AFFECTED FILES

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. wrong branch REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg, #kde_connect Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75172. mbruchert added a comment. - add puremaps icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27210?vs=75160=75172 BRANCH puremaps REVISION DETAIL https://phabricator.kde.org/D27210 AFFECTED

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Good. So will land this next Tuesday, Feb 11th then, so other people will have had 7 days of feedback opportunity. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau,

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. F8090354: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg, #kde_connect Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:fd5b37818e6a: Fix the KNSQuick Dialogs close title and basic layout (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27204?vs=75151=75165

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D27204#607325 , @ngraham wrote: > LGTM and fixes all the bugs! Thanks. Thanks! :D > If it lands quickly, I wonder if it would be worth it to try and squeeze this into Frameworks 5.67 so all the

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM and fixes all the bugs! Thanks. If it lands quickly, I wonder if it would be worth it to try and squeeze this into Frameworks 5.67 so all the people using this dialog in Plasma

D27080: Don't warn for invalid plugin metata

2020-02-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b76b908e1056: Dont warn for invalid plugin metata (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27080?vs=75149=75164

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 291 - Still Unstable!

2020-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/291/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 07 Feb 2020 13:26:47 + Build duration: 8 min 4 sec and counting JUnit Tests Name:

D27207: Use a less convoluted way to check if it's in flatpak

2020-02-07 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R271:9027710fb817: Use a less convoluted way to check if its in flatpak (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27207?vs=75156=75163

D27067: Change "AutoSkip" to "Skip All"

2020-02-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:2c84f4b1c8fb: Change AutoSkip to Skip All (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27067?vs=74781=75161 REVISION DETAIL

D27210: add KDEconnect Icons

2020-02-07 Thread Nathaniel Graham
ngraham added reviewers: VDG, KDE Connect. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg, #kde_connect Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75160. mbruchert added a comment. fix REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27210?vs=75159=75160 BRANCH KDEconnect (branched from master) REVISION DETAIL https://phabricator.kde.org/D27210

D27210: add KDEconnect Icons

2020-02-07 Thread Nicolas Fella
nicolasfella added a comment. Screenshot please REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

2020-02-07 Thread Harald Sitter
sitter added a subscriber: winterz. sitter added a comment. Oh dear! I just noticed that kdsoap 1.9 isn't out yet. @dfaure @winterz any chance of a release some time soon? REPOSITORY R320 KIO Extras BRANCH arcpatch-D25682 REVISION DETAIL https://phabricator.kde.org/D25682 To:

D27207: Use a less convoluted way to check if it's in flatpak

2020-02-07 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27207 To: apol, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27210: add KDEconnect Icons

2020-02-07 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH KDEconnect (branched from master) REVISION DETAIL https://phabricator.kde.org/D27210

D27187: update travel-family icons

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. thank you :D REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

Re: License Statement Clarification in KArchive

2020-02-07 Thread David Faure
On vendredi 7 février 2020 10:41:00 CET Christophe Giboudeaux wrote: > On vendredi 7 février 2020 09:27:49 CET David Faure wrote: > > On mercredi 5 février 2020 18:43:10 CET Andreas Cord-Landwehr wrote: > > > Hi David, > > > > > > during the SPDX license marker introduction into KArchive we found

D27187: update travel-family icons

2020-02-07 Thread Volker Krause
vkrause added a comment. Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 57 - Still Unstable!

2020-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/57/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 07 Feb 2020 11:03:43 + Build duration: 13 min and counting JUnit Tests Name:

D27207: Use a less convoluted way to check if it's in flatpak

2020-02-07 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27207 AFFECTED

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 91 - Still Unstable!

2020-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/91/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 07 Feb 2020 11:03:42 + Build duration: 6 min 40 sec and counting JUnit Tests Name:

D26394: ECMGeneratePriFile: Fix static configurations

2020-02-07 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R240:fafbc8cec665: ECMGeneratePriFile: Fix static configurations (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26394?vs=72687=75155

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. leinir added reviewers: Frameworks, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27204 To: leinir, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This resolves several issues found in the KNSQuick Dialog component. Specifically it puts a background in the dialog

D27067: Change "AutoSkip" to "Skip All"

2020-02-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure, apol Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: License Statement Clarification in KArchive

2020-02-07 Thread Christophe Giboudeaux
On vendredi 7 février 2020 09:27:49 CET David Faure wrote: > On mercredi 5 février 2020 18:43:10 CET Andreas Cord-Landwehr wrote: > > Hi David, > > > > during the SPDX license marker introduction into KArchive we found the > > following two files in KArchive with ambiguous license statements,

D27080: Don't warn for invalid plugin metata

2020-02-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH less-warning-spam (branched from master) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham, #plasma, mart, apol Cc: apol, alex,

Re: License Statement Clarification in KArchive

2020-02-07 Thread David Faure
On mercredi 5 février 2020 18:43:10 CET Andreas Cord-Landwehr wrote: > Hi David, > > during the SPDX license marker introduction into KArchive we found the > following two files in KArchive with ambiguous license statements, which mix > LGPL and GPL terms: > >