D27321: Add status icons: data-error, data-warning, data-information

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R267 Oxygen Icons BRANCH adddatastatusicons REVISION DETAIL https://phabricator.kde.org/D27321 To: kossebau, #vdg, ndavis, andreask Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27272: Add status icons: data-error, data-warning, data-information

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Personally, I think emblems are fine, but I'm not going to hold up the KDevelop patch just because of that. They already existed in Papirus, the most popular 3rd party theme. The

D27153: port sftp to Result system to force serialization of error/finish condition

feverfew requested changes to this revision. feverfew added a comment. This revision now requires changes to proceed. Good stuff, I'll admit I kind of skimmed over the bits that were rewrites `error(...); return;` -> `Result::fail()`, I assume you've mapped correctly there. Only minor

D27332: try to fix issue with ispellchecker on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R246:6e2f32b931e3: fix segfault at exit (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75536=75646 REVISION DETAIL

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

dhaumann added a subscriber: cullmann. dhaumann added a comment. Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing. What I wonder is how much of this needs to be configurable. We could also just make the left fill of 4

D27372: smb: disable mode bits getting forwarded to KIO

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, this fixes the bug for me and I think the code change makes logical sense. I really appreciate these long comments. REPOSITORY R320 KIO Extras BRANCH bug414482 REVISION

D27315: Fix size of the header in GridViewKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d9b52d900471: Fix size of the header in GridViewKCM (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27315?vs=75445=75642 REVISION

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 13 Feb 2020 20:49:04 + Build duration: 1 min 23 sec and counting JUnit Tests Name:

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

nicolasfella edited reviewers, added: Frameworks, dfaure, meven; removed: kiokiio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27385 To: fifr, #frameworks, dfaure, meven, kiokiio Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

fifr retitled this revision from "Return error instead of aborting when receiving an unexpected answer" to "[RFC] Return error instead of aborting when receiving an unexpected answer". fifr added a reviewer: kiokiio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27385

D27385: Return error instead of aborting when receiving an unexpected answer

fifr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fifr requested review of this revision. REVISION SUMMARY If SlaveBase::waitForAnswer receives an unexpected subcommand it aborts by calling qFatal. However, an unexpected subcommand

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

ngraham added a comment. So like this? F8101694: Screenshot_20200213_130357.png Hmm, I'm not really sure. For one "timeout on server" is pretty jargonistic. Also, in this case, there is no server! I think the "Could not connect to host for "

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

sitter added a comment. Use an ip address that isn't used by anything. Failing to resolve the hostname is different from failing to contact an ip address i.e. "I dunno who this is" versus "you have called a number that has been disconnected or is no longer in service". REPOSITORY R320

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

ngraham added a comment. I tested out this patch by unplugging the network cable to the machine hosting my samba share and then trying to connect to it in Dolphin using the saved location in my Places panel where I access it from (`smb://gaston@living-room-pc/Users/gaston/Desktop/`) , but I

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY same as the ftp does. in fact, also steal the error message

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug415436 REVISION DETAIL https://phabricator.kde.org/D27377 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

ngraham added a comment. I think this is reasonable and at least a small improvement given the limitations at play here. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27377 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27354: Remove hardcoded colors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ed47e7c4188: Remove hardcoded colors (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27354?vs=75572=75629 REVISION

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY seems the most reasonable candidate given the pretty strings in

D27376: Sync IndexerConfig on exit

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a0f8e748159b: Sync IndexerConfig on exit (authored by davidedmundson). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27376?vs=75624=75625 REVISION DETAIL

D27376: Sync IndexerConfig on exit

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. damn! REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D27376 To: davidedmundson, ervin, crossi, meven, bport Cc: broulik, kde-frameworks-devel,

D27376: Sync IndexerConfig on exit

ervin added reviewers: ervin, crossi, meven, bport. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27376 To: davidedmundson, ervin, crossi, meven, bport Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D27376: Sync IndexerConfig on exit

broulik added a comment. +1 worksforme REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27376 To: davidedmundson Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D27376: Sync IndexerConfig on exit

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KCoreConfigSkeleton, unlike KConfig does not automagically save on exit. BUG: 417127

D27372: smb: disable mode bits getting forwarded to KIO

sitter added a subscriber: dfaure. sitter added a comment. @dfaure btw, it seems you cannot have no ACL displayed. i.e. properties dialog does `d->hasExtendedACL = item.ACL().isExtended() || item.defaultACL().isValid();` but isExtended is even true for invalid ACLs, so in the smb scenario I

D27372: smb: disable mode bits getting forwarded to KIO

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY mode bits in libsmb_stat are fairly cheaply constructed. file and

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a reviewer: Frameworks. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. @ndavis Hi, any chance this can sneak in your busy schedule the next days? :) Anyone else from the VDG who might have time to sponsor these icons to have them available with Breeze? REPOSITORY R266 Breeze Icons REVISION DETAIL

D27366: Construct NullEngine with KPluginMetaData()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData() (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27366: Construct NullEngine with KPluginMetaData()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27366 To: broulik, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

cblack added a comment. In D27246#610777 , @ndavis wrote: > What is buho? Maui's note taking app REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack,

D27246: add buho icon

ndavis added a comment. What is buho? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. In D27357#610605 , @broulik wrote: > Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. > However, I don't know if that won't

D27363: KHolidays: Convert license statements to SPDX expressions

cgiboudeaux added subscribers: winterz, cgiboudeaux. cgiboudeaux added inline comments. INLINE COMMENTS > holidayregion.cpp:31 > // Copied from qlocale_data_p.h and qlocale.h > -// Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies). > +// SPDX-FileCopyrightText: 2014 Digia Plc and /or its

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. Sorry, no. Swamped with last-minute reconstruction efforts in the, erm, structure that's supposed to become my new house next week :-/ REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks, rjvbb, cgilles Cc:

D27366: Construct NullEngine with KPluginMetaData()

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The deprecated constructor taking a `KPluginInfo` unconditionally calls

D27351: call smb_cutime on the correct url to actually set mtime properly

This revision was automatically updated to reflect the committed changes. Closed by commit R320:aaedd983729f: smb: call smb_cutime on the correct url to actually set mtime properly (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27295: smb: support more advanced hidden file flag

This revision was automatically updated to reflect the committed changes. Closed by commit R320:e2eadb7555a6: smb: support more advanced hidden file flag (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27295?vs=75387=75599 REVISION

D27291: install smb as both smb:// and cifs://

This revision was automatically updated to reflect the committed changes. Closed by commit R320:a5f51238fab7: smb: install smb as both smb:// and cifs:// (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27291?vs=75382=75603 REVISION

D27292: set the share comment as UDS_COMMENT for the UI to display

This revision was automatically updated to reflect the committed changes. Closed by commit R320:dddafae55363: smb: set the share comment as UDS_COMMENT for the UI to display (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27352: retain atime properly

This revision was automatically updated to reflect the committed changes. Closed by commit R320:7f47119b22d5: smb: retain atime properly (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27352?vs=75558=75597 REVISION DETAIL

D27293: smb: do not map uid and gid

This revision was automatically updated to reflect the committed changes. Closed by commit R320:25a02064dbee: smb: do not map uid and gid (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27293?vs=75385=75601 REVISION DETAIL

D27294: fix free space calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6832817f311b: smb: fix free space calculation (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27294?vs=75386=75600 REVISION DETAIL

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only license text: https://github.com/fsfe/reuse-tool/issues/178 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: cgiboudeaux,

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in LGPL-3.0-only.txt:15-17 > well, the SPDX text doesn't have these extra lines: > https://spdx.org/licenses/LGPL-3.0-only.html#licenseText Just tested again with the reuse tool and it actually provides the license with

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. ping? any update? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks, rjvbb, cgilles Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added inline comments. INLINE COMMENTS > cordlandwehr wrote in LGPL-3.0-only.txt:15-17 > Actually, I have no idea. But according to the REUSE specification, the > license files must no be changed and used exactly as provided by SPDX. > All license files, except the LicenseRef files,

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification.

Re: 2 kirigami fixes for a point release

On jeudi 13 février 2020 09:46:20 CET David Edmundson wrote: > > Kirigami seems to be rather unstable, I wonder if anything can be done to > > improve upon that [*]. > > One important thing seems to have been getting sloppy in those repos; > mandatory code reviews. > That's an easy thing to

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr marked an inline comment as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr updated this revision to Diff 75592. cordlandwehr added a comment. Remove unneeded whitespace REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75591=75592 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 AFFECTED

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr updated this revision to Diff 75591. cordlandwehr added a comment. Unify license comment header style REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75246=75591 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in LGPL-3.0-only.txt:15-17 > why are there so many empty lines? Actually, I have no idea. But according to the REUSE specification, the license files must no be changed and used exactly as provided by SPDX. All license

D27103: KItemModels: Convert license headers to SPDX markers

This revision was automatically updated to reflect the committed changes. Closed by commit R275:be32ab6c49f9: KItemModels: Convert license headers to SPDX markers (authored by cordlandwehr). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D27103: KItemModels: Convert license headers to SPDX markers

cordlandwehr updated this revision to Diff 75587. cordlandwehr added a comment. Remove unneeded whitespace REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27103?vs=75580=75587 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27103

D27103: KItemModels: Convert license headers to SPDX markers

cordlandwehr marked an inline comment as done. REPOSITORY R275 KItemModels BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. some headers have 3 leading whitespaces, some 4. Can you clarify? INLINE COMMENTS > LGPL-3.0-only.txt:15-17 > + > + > + why are there so many empty lines? > gettext.h:2 > /* Convenience header for conditional use of GNU . > - Copyright (C) 1995-1998,

D27106: Attica: Convert license statements to SPDX markers

This revision was automatically updated to reflect the committed changes. Closed by commit R235:4db348a7bb1c: Attica: Convert license statements to SPDX markers (authored by cordlandwehr). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27106?vs=75579=75586

D27332: try to fix issue with ispellchecker on windows

vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. looks good but in a future version of sonnet plugins should be unloaded when shutting down and we should properly unload stuff. REPOSITORY R246 Sonnet BRANCH arcpatch-D27332

D12283: Allow to load dictionaries form a rcc

vonreth abandoned this revision. vonreth added a comment. as we now have a native windows backend there is no point in this REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, cblack,

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

catherinez added a comment. I do not. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin, davidedmundson Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27352: retain atime properly

sitter added a comment. Oh I'm sorry, I thought this was the other time diff. In this case before the accessed time before the patch was flat out garbage https://bugsfiles.kde.org/attachment.cgi?id=121948 note the year **2106** REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin, davidedmundson Cc: davidedmundson,

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov created this revision. alnikiforov added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alnikiforov requested review of this revision. REVISION SUMMARY Follow up for D27279

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

catherinez added a comment. Note that there are what I assume 3 more instances of a similar copy-paste error, for `DropdownMenu`, `PopupMenu`, and `Notification`. I didn't touch them because KDE is currently EWMH compliant for these window types, and because I lack the context to understand

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

broulik added a comment. Nice find! It appears the `DropdownMenu`, `PopupMenu`, and `Notification` type also incorrectly use a `len = 1`? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin Cc: broulik, kde-frameworks-devel,

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

broulik added a reviewer: KWin. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

catherinez created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. catherinez requested review of this revision. REVISION SUMMARY The EWMH specification for _NET_WM_WINDOW_TYPE states: > The Client SHOULD specify window types in order of

D27279: Port away from QWidget

alnikiforov added a comment. I think I found source of infinite recursion. First call is on https://phabricator.kde.org/source/powerdevil/browse/master/daemon/powerdevilcore.cpp$821 Second call is on

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. (side note: I am not sure whether to use phabricator.kde.org or invent.kde.org for this. Are they complementary or orthogonal?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: dhaumann, kwrite-devel,

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. > No offense meant, but even with the screenshots I still have no idea what this is about :) Good point, I somehow missed to explain the rationale for the change. :) If you are familiar with vim, this would be the `breakindent` and `breakindentopt` settings

D27103: KItemModels: Convert license headers to SPDX markers

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Please push after fixing the remaining issues REPOSITORY R275 KItemModels BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure,

D27103: KItemModels: Convert license headers to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > modeltest.h:4 > > +SPDX-FileCopyrightText: 2013 Digia Plc and /or its subsidiary(-ies) > > +SPDX-FileCopyrightText: 2010 Stephen Kelly Unneeded extra space added for a couple files "and /or"

D27103: KItemModels: Convert license headers to SPDX markers

cordlandwehr marked an inline comment as done. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

cordlandwehr updated this revision to Diff 75580. cordlandwehr added a comment. Incorporate review findings - Use FileContributor tag for stating authors without copyright claim - Resolving Qt legal redirect - Unify comment style for copyright statements REPOSITORY R275 KItemModels

D27106: Attica: Convert license statements to SPDX markers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr, cgiboudeaux Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27106: Attica: Convert license statements to SPDX markers

cordlandwehr marked 2 inline comments as done. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27106: Attica: Convert license statements to SPDX markers

cordlandwehr updated this revision to Diff 75579. cordlandwehr added a comment. Solve review findings - Fix license files - Use FileContributor tag for Author statements without copyright claim REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE

Re: 2 kirigami fixes for a point release

On Thu, Feb 13, 2020 at 9:00 PM Christoph Feck wrote: > > On 02/13/20 08:42, Ben Cooksley wrote: > > Part of the issue here is that Plasma has been known to add API to > > Frameworks and then immediately, without any delay, start using it > > (pretty much always breaking CI in the process) > > >

D27235: add calindori icon in the new pm style

dkardarakos added a comment. OK from me (although not a fan of the top white hole, but probably a matter of taste). Let the VDG people review it before submitting. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, #vdg Cc:

D27224: add Kongress icon

dkardarakos added a comment. I like it and I will be happy to be the icon of Kongress. But let VDG people review it as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert, dkardarakos, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: 2 kirigami fixes for a point release

On 02/13/20 08:42, Ben Cooksley wrote: Part of the issue here is that Plasma has been known to add API to Frameworks and then immediately, without any delay, start using it (pretty much always breaking CI in the process) This means that other changes are likely being pushed into Frameworks by