D28088: Fix warnings

ahmadsamir added inline comments. INLINE COMMENTS > containmentactions.cpp:138 > #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0) > +int o = > QObject::staticQtMetaObject.indexOfEnumerator("Orientations"); > +QMetaEnum orient = QObject::staticQtMetaObject.enumerator(o); const ?

D27416: Add small icons for KeePassXC

ndavis requested changes to this revision. ndavis added a comment. Since this is a systray icon, you don't actually need to do the 16px version, but I guess there's no harm in having a 16px version. As @cblack said, this needs some work on the pixel alignment. If you don't do the 16px

D27416: Add small icons for KeePassXC

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The key in both icons should be pixel aligned to prevent blurry edges at the size it's going to be rendered at. F8180107: image.png

D28088: Fix warnings

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D27871: sftp: fix seekPos + file resuming when part file is of size 11

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Let's land this now as-is and make that change universally in a separate patch before we bikeshed it to death. :) REPOSITORY R320 KIO Extras BRANCH sftp-seekpos REVISION DETAIL

D25815: Transmission-Qt tray icon added

ndavis added a comment. In D25815#628429 , @ngraham wrote: > Does this have to live in the plasma theme? Could it live in the Breeze icon theme? yes, I think I'll move this patch to breeze-icons since there is no longer a name conflict

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Ping :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr added a comment. Gently "ping", does anybody has a little bit of time to review this? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 109 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/109/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 18:58:14 + Build duration: 7 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/61/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 18:58:14 + Build duration: 6 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/68/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 16 Mar 2020 18:58:14 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS

D28056: KWindowSystem: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R278:d67cc57cf067: KWindowSystem: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D28058: KWayland: Convert license headers to SPDX

This revision was automatically updated to reflect the committed changes. Closed by commit R127:09147becf9b1: KWayland: Convert license headers to SPDX (authored by cordlandwehr). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28058?vs=77657=0 REVISION

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Fwd: KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Still Failing!

Hi Aleix and Harald, The below appears to have been caused by recent changes you've made to Dr Konqi and KCrash - mind taking a look? Note that FreeBSD is also affected by this breakage. Cheers, Ben -- Forwarded message - From: CI System Date: Tue, 17 Mar 2020, 6:42 AM

D25679: Implement writing of front cover in taglibwriter

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:78 > > +TagLib::String determineMimeTypeOfPicture(const QByteArray ) > +{ https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypeForData > taglibwriter.cpp:85 > + pictureData.startsWith(QByteArray::fromHex("FFD8FFEE"))

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/65/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 17:34:12 + Build duration: 3 min 1 sec and counting JUnit Tests

D25679: Implement writing of front cover in taglibwriter

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH tagLibBinaryWrite REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir updated this revision to Diff 77754. ahmadsamir added a comment. Tweak comment REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28079?vs=77753=77754 BRANCH l-mainglobpattern (branched from master) REVISION DETAIL

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY QMimeDatabase re-adds/prepends the "main" glob pattern (the

D25517: Add an option to extract image data and add front cover property

astippich added a comment. ping @bruns this has now been open and unanswered for month! Same for the dependent patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel,

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.13 - Build # 95 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.13/95/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 16 Mar 2020 16:29:24 + Build duration: 1 min 21 sec and counting CONSOLE OUTPUT [...truncated 370

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 214 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/214/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 16:28:13 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 370

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/90/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 16:28:34 + Build duration: 32 sec and counting CONSOLE OUTPUT [...truncated 284

D27855: [Debug] Improve readability of positioninfo debug format

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d3d5cda0e462: [Debug] Improve readability of positioninfo debug format (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27855?vs=76983=77751

D27853: [WriteTransactionTest] Test removal of positions only

This revision was automatically updated to reflect the committed changes. Closed by commit R293:be8ae0f34689: [WriteTransactionTest] Test removal of positions only (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27853?vs=76980=77749

D27772: [WriteTransaction] Extend position test case

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bcdaa6c9a029: [WriteTransaction] Extend position test case (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27772?vs=76743=77748 REVISION DETAIL

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b3217e3cb31d: [Debug] Correct output of *::toTestMap(), silence non-error (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27854?vs=76982=77750

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b0b32093524f: [WriteTransaction] Avoid growing m_pendingOperations twice on replace (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28078: guard against duplicated service discoveries

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah. REPOSITORY R320 KIO Extras BRANCH smb-no-dupes REVISION DETAIL https://phabricator.kde.org/D28078 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov,

D25421: [kio_tags] improve log message when the database can't be opened

ngraham accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25421 To: ahmadsamir, #baloo, astippich, ngraham, bruns Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25517: Add an option to extract image data and add front cover property

ngraham accepted this revision. ngraham added a comment. I agree, let's get this in now and refactor it later. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77,

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. What @meven said about the typo, otherwise LGTM indeed. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson, ervin Cc: ervin, meven,

D27502: Create ConfigView an unmanaged ConfigWidget

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

ngraham added a comment. Does this have to live in the plasma theme? Could it live in the Breeze icon theme? REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack,

D28078: guard against duplicated service discoveries

sitter added a comment. FTR: this could technically still dupe with smbc native NT1 listing, except smbc would list workgroups while we list services, so this should generally not be duplicative information. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28078

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

Am Montag, 16. März 2020, 10:39:39 CET schrieb Ben Cooksley: > On Mon, Mar 16, 2020 at 10:24 PM David Edmundson > > wrote: > > There is not a SIC. KIO is fine > > > > It's merely this crap again: > > > > if (EXISTS "${CMAKE_SOURCE_DIR}/.git") > > > >

D28078: guard against duplicated service discoveries

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY if both dnssd and wsdiscovery have the same server on offer we'd

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D28061: Reduce unneeded dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R871:aa2ea5059e02: Reduce unneeded dependencies (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28061?vs=77678=77732 REVISION DETAIL

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

meven abandoned this revision. meven added a comment. This is not needed anymore. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. Yep. I'm 100% certain of this. The library in fact has no API that returns a complete URL or anything near a complete URL. It's using dirent-inspired API to let us iterate/stat paths and only ever returns paths relative to whatever input it got, from those paths we

D27520: add readdirplus2 support for samba>=4.12

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec40cd6ef3f4: add readdirplus2 support for samba=4.12 (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27520?vs=76048=77717#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D27872: sftp: fix partial transfer resuming when copying to local

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27872 To: sitter, ngraham, feverfew, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D27873: sftp: do not show creation time when we do not know it

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D27902: smb: figure out the best host to use for the UDS_URL

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D28014: smb: do not double finish

This revision was automatically updated to reflect the committed changes. Closed by commit R320:8252861157a2: smb: do not double finish (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28014?vs=77502=77714 REVISION DETAIL

D28061: Reduce unneeded dependencies

sitter accepted this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 To: apol, #frameworks, davidedmundson, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

On Mon, Mar 16, 2020 at 10:24 PM David Edmundson wrote: > > There is not a SIC. KIO is fine > > It's merely this crap again: > > if (EXISTS "${CMAKE_SOURCE_DIR}/.git") >add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) >

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

There is not a SIC. KIO is fine It's merely this crap again: if (EXISTS "${CMAKE_SOURCE_DIR}/.git") add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06) endif() in kreversi In plasma I ported all these to:

Fwd: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

This appears to be yet more fallout due to the regression within KIO. I'm therefore treating this as a Source Incompatibie Change to KIO, and will be reverting that change in 24 hours unless someone has an alternative solution. Cheers, Ben -- Forwarded message - From: CI System