KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » attica » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 17 min and counting BUILD ARTIFACTS

D28349: Fix Warnings

meven updated this revision to Diff 78655. meven added a comment. Add an argc value check REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78654=78655 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28349 AFFECTED FILES

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kplotting » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 14 min and counting BUILD ARTIFACTS

D28325: [Inotify] Call QFile::decode only in a single place

kossebau added inline comments. INLINE COMMENTS > kinotify.cpp:368 > +uint32_t fileEvents = EventAll & ~(EventMoveFrom | > EventQueueOverflow | EventIgnored); > +const QString fname = event->mask & fileEvents ? > QFile::decodeName(path) : QString(); > + For better code

KDE CI: Frameworks » kmediaplayer » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KDED-5.69.0.xml

KDE CI: Frameworks » kemoticons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcompletion » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kjs » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 11 min and counting BUILD ARTIFACTS acc/KF5JS-5.69.0.xml

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kauth » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » prison » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 10 min and counting BUILD ARTIFACTS

D28325: [Inotify] Call QFile::decode only in a single place

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28325 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

KDE CI: Frameworks » kross » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kross/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 9 min 58 sec and counting BUILD ARTIFACTS

D28349: Fix Warnings

davidedmundson added inline comments. INLINE COMMENTS > kprocesstest_helper.cpp:17 > { > +Q_UNUSED(argc) > KProcess p; If we use argv[1] we very much should be using argc beforehand REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28349 To: meven,

KDE CI: Frameworks » kjsembed » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcrash » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:08 + Build duration: 9 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 8 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:08 + Build duration: 9 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » modemmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/modemmanager-qt/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 7 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 8 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 7 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 7 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 7 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kjobwidgets » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 6 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 5 min 46 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 5 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:07 + Build duration: 6 min 27 sec and counting BUILD ARTIFACTS

D28349: Fix Warnings

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had 10 compile warnings before. 0 after REPOSITORY R244 KCoreAddons BRANCH

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 4 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 5 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kunitconversion » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 4 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 3 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 2 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 3 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:05 + Build duration: 2 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdnssd » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdnssd/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:06 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:05 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifyconfig » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:05 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS

D27203: Don't try to open files we can't figure out where they are

ngraham added a reviewer: Plasma. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28327 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28326 To: bruns, #baloo, ngraham, davidedmundson Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. Ah, that was an oversight on my behalf. I changed the rating icon to be black to fix a bug where it becomes invisible on a selected item. I probably forgot to change it to be white for the dark version. :/ TASK DETAIL https://phabricator.kde.org/T12855 To:

Re: Problems in KWayland causes by API and ABI compatibility promises

Hello, First, a big fat disclaimer: I'm by no mean expert in what's going on the Wayland side, so take what I'll be writing here with truck loads of salt. I'm jumping in mainly because it looks like you guys are in pain and I'm trying to lend a hand to find a way forward. It's obviously

D28295: Introduce KNotificationJobUiDelegate

broulik added a dependent revision: D28347: Port services and shell runner away from KRun. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure added inline comments. INLINE COMMENTS > commandlauncherjobtest.cpp:99 > + > +void CommandLauncherJobTest::doesNotFailOnNonExistingExecutable() > +{ See this unittest ;-) As the comment says, QProcess works since it manages to start /bin/sh. We don't want to wait until the

D28295: Introduce KNotificationJobUiDelegate

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Otherwise looks good to me INLINE COMMENTS > knotificationjobuidelegate.h:28 > + * @class KNotificationJobUiDelegate knotificationjobuidelegate.h > KNotificationJobUiDelegate

D28295: Introduce KNotificationJobUiDelegate

broulik updated this revision to Diff 78644. broulik added a comment. - Fix docs REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78520=78644 REVISION DETAIL https://phabricator.kde.org/D28295 AFFECTED FILES src/CMakeLists.txt

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

broulik added a comment. One thing I noticed, when I do `new CommandLaunchJob("somenonexistantbinary")` no error is raised and I just get console output `/bin/sh: 1: somenonexistantbinary: not found Though this was also the case of `runCommand`, so maybe not an issue. REPOSITORY

D28295: Introduce KNotificationJobUiDelegate

nicolasfella added inline comments. INLINE COMMENTS > knotificationjobuidelegate.h:29 > + * > + * A UI delegate using KMessageBox for interaction (showing errors and > warnings). > + * s/KMessageBox/KNotification/g? REPOSITORY R289 KNotifications REVISION DETAIL

D28336: Drop klauncher usage from KCrash

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY As per other discussions, kdeinit has limited gains and is not widely deployed in KDE application.

D20085: Expose a method to show the context menu of an applet from QML

apol abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20085 To: apol, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27203: Don't try to open files we can't figure out where they are

apol added a comment. Ping? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28088: Fix warnings

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28088 To: apol, #frameworks Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28088: Fix warnings

apol updated this revision to Diff 78630. apol added a comment. add const REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28088?vs=77795=78630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28088 AFFECTED FILES

D28129: Read the new message string after rather than before

This revision was automatically updated to reflect the committed changes. Closed by commit R871:cfa43ed278c8: Read the new message string after rather than before (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78627=78628

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78627. apol added a comment. address weird +2 in the code REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78605=78627 BRANCH arcpatch-D28129 REVISION DETAIL https://phabricator.kde.org/D28129 AFFECTED FILES

D28129: Read the new message string after rather than before

sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + >

D25660: Decouple KBookmarksMenu from KActionCollection

mlaurent added a comment. In D25660#635693 , @dfaure wrote: > @mlaurent AFAICS you removed the deprecation macro completely in master, and left it (with 0x06) in release/20.04? nope or I missed to forward port in 20.04. So it's an

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. Just as reminder: When keeping the use of the macro flags, make sure to - also set the `*_DEPRECATED_WARNINGS_SINCE` flags to 0x06, otherwise deprecation warnings for newer API will no longer be shown, due to default set by `*_DISABLE_DEPRECATED_BEFORE*`

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure added a subscriber: mlaurent. dfaure added a comment. @mlaurent AFAICS you removed the deprecation macro completely in master, and left it (with 0x06) in release/20.04? I thought we wanted - to remove it in release/20.04 (or set it to a tested value like 0x053A00) - to

D27840: Introduce SettingState* elements to ease KCM writing

broulik added a comment. Cool INLINE COMMENTS > SettingStateBinding.qml:40 > + * target: Item > + * The graphical element which state we want to manage based on a setting > + */ *whose > SettingStateBinding.qml:58 > + * extraEnabledPredicate: bool > + * An extra

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. In D25660#635658 , @bcooksley wrote: > Thanks. That macro really does cause quite a bit of trouble... It is not the macro, but using it with a future version of 0x06. See

D25660: Decouple KBookmarksMenu from KActionCollection

bcooksley added a comment. Thanks. That macro really does cause quite a bit of trouble... REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack,

D27840: Introduce SettingState* elements to ease KCM writing

davidedmundson added inline comments. INLINE COMMENTS > SettingStateIndicator.qml:30 > +Item { > +id: root > + This is a faux-button. Which means it needs all the relevant: Accessible.blah roles to be manually added Should it be in the tab focus chain? (or we could just inherit

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure added a comment. As usual, it's the too strong "no deprecated API usage" define in the apps. Fixed. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, kossebau, dfaure, apol,

D28323: Fix some stylesheet colors in 2 icon files

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0b834e41640f: Fix some stylesheet colors in 2 icon files (authored by davidhurka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D25660: Decouple KBookmarksMenu from KActionCollection

bcooksley added a comment. Could this commit be the cause of https://build.kde.org/job/Applications/job/krdc/job/stable-kf5-qt5%20FreeBSDQt5.14/3/consoleText (ie. this commit is SIC?) REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#635596 , @dfaure wrote: > Symlinks are a bit special, we could add a way to ask kio_file not to follow them. > > But at least it should work for regular files and directories, right? > > Anyhow, we don't

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28326 To: bruns, #baloo, ngraham, davidedmundson Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

dfaure added a comment. Symlinks are a bit special, we could add a way to ask kio_file not to follow them. But at least it should work for regular files and directories, right? Anyhow, we don't have a kio_file result here so I guess my point is moot. REPOSITORY R241 KIO REVISION

D28324: [Inotify] Remove dead/duplicate code

pino added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:350 > man inotify > > > IN_Q_OVERFLOW > > Event queue overflowed (wd is -1 for this event). then add an assert for this case, referencing the documentation? REPOSITORY R293 Baloo REVISION DETAIL

D27983: Make find-location show a magnifier on a map, to be different to mark-location

ndavis added a comment. Not sure how I missed this. LGTM! REPOSITORY R266 Breeze Icons BRANCH create-find-location REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27983: Make find-location show a magnifier on a map, to be different to mark-location

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH create-find-location REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28323: Fix some stylesheet colors in 2 icon files

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-some-stylesheet-colors REVISION DETAIL https://phabricator.kde.org/D28323 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik added a comment. > KDesktopFileActions uses the name and icon from the action rather than the namd and icon from the service. Dunno if that's better though? I think we want to communicate to the user that "[Firefox icon] Firefox" is starting, not "[No icon] New incognito tab",

<    1   2