D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-10 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28737: Add sim card device icons

2020-04-10 Thread Carson Black
cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk,

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh,

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master)

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis added a project: Plasma: Mobile. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer,

D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack updated this revision to Diff 79798. cblack added a comment. Remove unused Bootstrap 3 assets REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79796=79798 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack updated this revision to Diff 79796. cblack added a comment. Fix footer text REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79794=79796 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack created this revision. cblack added reviewers: VDG, ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Output generated by kapidox now uses Aether

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:48a112fb64dc: Add rotation icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=79765=79791 REVISION DETAIL

D19736: Add rotation icons

2020-04-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol, ngraham Cc: ngraham,

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-10 Thread Konrad Materka
kmaterka added a comment. ping, review needed :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 10 Apr 2020 17:58:49 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 10 Apr 2020 17:58:49 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

D27844: Store and fetch complete view config in and from session config

2020-04-10 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0611924df7b0: Store and fetch complete view config in and from session config (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D28460: Add KCModuleStateProbe as base class for plugin

2020-04-10 Thread Benjamin Port
bport updated this revision to Diff 79780. bport added a comment. Rename state probe to data (because can be useful for more than only state probe) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=79772=79780 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 36 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/36/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 10 Apr 2020 16:54:14 + Build duration: 7 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 535 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/535/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 10 Apr 2020 16:54:14 + Build duration: 7 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 44 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/44/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 10 Apr 2020 16:54:14 + Build duration: 6 min 33 sec and counting JUnit Tests Name:

D28723: [KPropertiesDialog] Fix QLayout warning

2020-04-10 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4bf478b7d07: [KPropertiesDialog] Fix QLayout warning (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28723?vs=79767=79778 REVISION DETAIL

D28723: [KPropertiesDialog] Fix QLayout warning

2020-04-10 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kprop-qframe (branched from master) REVISION DETAIL https://phabricator.kde.org/D28723 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28726: [KJS] Port QRegExp to QRegularExpression

2020-04-10 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, porten. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D28460: Add KCModuleStateProbe as base class for plugin

2020-04-10 Thread Benjamin Port
bport marked 10 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

2020-04-10 Thread Benjamin Port
bport updated this revision to Diff 79772. bport added a comment. ervin feedback REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=79496=79772 REVISION DETAIL https://phabricator.kde.org/D28460 AFFECTED FILES src/CMakeLists.txt

D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether (authored by cblack). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28712?vs=79738=79769 REVISION DETAIL

D28723: [KPropertiesDialog] Fix QLayout warning

2020-04-10 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If a widget, QFrame in this case, already has a QLayout, adding/parenting another layout to it shows a

D28679: [KPropertiesDialog] Disable changing remote dir icons

2020-04-10 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79766. ahmadsamir retitled this revision from "[KPropertiesDialog] Disable changing dir icon on samba shares" to "[KPropertiesDialog] Disable changing remote dir icons". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

2020-04-10 Thread Ahmad Samir
ahmadsamir added a comment. And it seems recentdocuments:/ shows representation of recent "documents", parsed from .desktop files in ~/.local/share/RecentDocuments/, so it doesn't need to be handled here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To:

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
ndavis retitled this revision from "Add view-orientation-auto/landscape/portrait" to "Add rotation icons". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel,

D19736: Add view-orientation-auto/landscape/portrait

2020-04-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

2020-04-10 Thread Noah Davis
ndavis updated this revision to Diff 79765. ndavis added a comment. - Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=55804=79765 BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

2020-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 10 Apr 2020 13:16:58 + Build duration: 1 min 28 sec and counting JUnit Tests Name:

D28699: Add startCapture method

2020-04-10 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R296:5eb3c795a8f2: Add startCapture method (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28699?vs=79691=79764 REVISION DETAIL

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-10 Thread Benjamin Port
bport accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-monospace-checkbox REVISION DETAIL https://phabricator.kde.org/D28274 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

2020-04-10 Thread Ahmad Samir
ahmadsamir added a comment. I did some more testing: $ grep -ir :local *protocol about.protocol:Class=:local activities.protocol:Class=:local applications.protocol:Class=:local ar.protocol:Class=:local baloosearch.protocol:Class=:local

D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. LGTM REPOSITORY R264 KApiDox BRANCH cblack/aether (branched from master) REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n,

D27844: Store and fetch complete view config in and from session config

2020-04-10 Thread Christoph Cullmann
cullmann added a comment. Yes, please push, thanks! REPOSITORY R39 KTextEditor BRANCH fullviewconfigsessionsupport REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D28682: rename and export done signal in filecontentindexer

2020-04-10 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filecontentindexer.cpp:111 > [this, elapsed, batchSize] { newBatchTime(elapsed, > batchSize); }, > Qt::QueuedConnection); >

D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-04-10 Thread Tranter Madi
trmdi added a comment. In D27951#645212 , @meven wrote: > I might take over to finish it eventually. Yes, please. I'm very glad that you support this. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To:

D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-10 Thread David Faure
dfaure added a comment. This looks good. I think I failed to notice the last update, sorry for the delay. Can you rebase (I suspect a few conflicts) and update version numbers to 5.70? Then it'll be good to go. Ah, and the documentation for the KFileItem getter needs to say that

D28682: rename and export done signal in filecontentindexer

2020-04-10 Thread Alexander Stippich
astippich retitled this revision from "export done signal in filecontentindexer" to "rename and export done signal in filecontentindexer". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77,

D28682: export done signal in filecontentindexer

2020-04-10 Thread Alexander Stippich
astippich updated this revision to Diff 79751. astippich added a comment. - rename signal REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79657=79751 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES

D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-04-10 Thread Méven Car
meven added a comment. In D27951#641207 , @trmdi wrote: > In D27951#641173 , @meven wrote: > > > In D27951#639386 , @trmdi wrote: > > > > > In

D26113: Places: For mounted volume display mount points instead of description

2020-04-10 Thread Méven Car
meven planned changes to this revision. meven added a comment. Working on solid : D28590 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew, bruns, broulik, kde-frameworks-devel,