D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela,

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. I guess a proper fix will need to revert part of this to have the KModuleInfo ctor that took a KService not use KPluginInfo internally; better still, of course, is having the KPluginInfo ctor work for the case of X-KDE-ServiceTypes=SystemSettingsExternalApp, (I

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid

D29358: Implement lock-screen visibility control on Android

nicolasfella requested changes to this revision. nicolasfella added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > notifybyandroid.cpp:110 > n.setField("urgency", (jint)(notification->urgency() == > KNotification::DefaultUrgency ?

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

rikmills added a comment. In D28765#673191 , @wbauer wrote: > This caused a crash in openSUSE: > https://bugs.kde.org/show_bug.cgi?id=421566 The same crash can been seen in Kubuntu when trying to launch the external

D29050: KRunner fix prepare/teardown signals

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. It is hard to understand why it was wrongly placed here, that makes this hard to review and approve. But you are getting familiar with KRunner internals, so since it does seem benign and

D29232: Introduce the Header color set

meven added a comment. @mart you have a couple of typos left and recommendation to add some doc. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack, ndavis Cc: meven, davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni added a reviewer: davidedmundson. anthonyfieroni added a comment. So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated. REPOSITORY R297 KDED

D29793: Rename Perl6 syntax to Raku

nibags abandoned this revision. nibags added a comment. This is equivalent to: https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/1 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29793 To: nibags, #framework_syntax_highlighting,

D29232: Introduce the Header color set

mart closed this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack, ndavis Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: Introduce the Header color set

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D29232 REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack, ndavis Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n,

D29232: Introduce the Header color set

mart marked 9 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: Introduce the Header color set

mart retitled this revision from "[WIP][RFC]Introduce the Header color set" to "Introduce the Header color set". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n,

D29232: [WIP][RFC]Introduce the Header color set

mart updated this revision to Diff 83090. mart added a comment. - update to new colors REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29232?vs=81363=83090 BRANCH arcpatch-D29232 REVISION DETAIL https://phabricator.kde.org/D29232 AFFECTED

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

zzag added a comment. In D29815#672682 , @anthonyfieroni wrote: > Is that KWin that set titlebar menus? from `#plasma` irc 5:02:41 PM kded does not load kwin 5:03:15 PM I believe the appmenu version where it's shown in the title

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

zzag removed a reviewer: zzag. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29795: Add collaboration guide

nibags abandoned this revision. nibags added a comment. This is moved to https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/2 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29795 To: nibags, #framework_syntax_highlighting, dhaumann,

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

ndavis added a comment. Suggested colors are based on https://invent.kde.org/plasma/breeze/-/merge_requests/2 INLINE COMMENTS > kcolorscheme.cpp:258 > +static const SetDefaultColors defaultHeaderColors = { > +{ 49, 54, 59 }, // Background > +{ 59, 64, 69 }, // Alternate `

D29358: Implement lock-screen visibility control on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > notifybypopup.cpp:363 > +watcher->deleteLater(); > +QDBusPendingReply reply = *watcher; > +notifications.insert(reply.argumentAt<0>(),

D29793: Rename Perl6 syntax to Raku

nibags updated this revision to Diff 83088. nibags added a comment. - Fix extensions and unit tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29793?vs=82987=83088 BRANCH rename-perl6-raku REVISION DETAIL

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

wbauer added a comment. This caused a crash in openSUSE: https://bugs.kde.org/show_bug.cgi?id=421566 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: wbauer, kossebau, svuorela, cblack,

D29795: Add collaboration guide

nibags added a comment. I put it all in the README. I also corrected the repository, I had not noticed that this repository was already in GitLab! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29795 To: nibags, #framework_syntax_highlighting,

D29795: Add collaboration guide

nibags updated this revision to Diff 83086. nibags added a comment. - Add collaboration guide in the README file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29795?vs=82995=83086 BRANCH add-collaboration-guide REVISION DETAIL

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. Browsing the code it looks like it mmaps the file though? And when I add some strategic sleeping I can verify that file goes towards shared memory. Oh, I suppose the trouble is that load gets called each ::create? Simply wrap it in a cpp class and static scope it

D29050: KRunner fix prepare/teardown signals

alex edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot,

D29050: KRunner fix prepare/teardown signals

alex retitled this revision from "WIP KRunner fix prepare/teardown signals" to "KRunner fix prepare/teardown signals". REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n,

D29050: WIP KRunner fix prepare/teardown signals

cfeck added a project: Plasma. cfeck added a comment. If this is no longer Work-In-Progress, please remove "WIP" from the title. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage,

D29534: Implement scroll and drag adjustment of values for SpinBox control

ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH implement-spinbox-wheel-adjustment (branched from master) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/17/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 20 May 2020 09:06:33 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 20 May 2020 09:06:33 + Build duration: 10 min and counting JUnit Tests Name:

D29397: KPreviewJob : Support for DeviceRatioPixel

meven added a comment. ping dear reviewers REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns