D13921: Don't show confirmation dialog for Trash action by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7d15dad5e427: Dont show confirmation dialog for Trash action by default (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin edited the summary of this revision. REPOSITORY R241 KIO BRANCH dont_confirm_trash REVISION DETAIL https://phabricator.kde.org/D13921 To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin added a comment. In D13921#288012 , @ngraham wrote: > There's a problem with the git setup on the computer you used to make this commit; the `name` field appears to be empty, so I get an error when I try to apply the patch

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin created this revision. aleksejshilin added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Dolphin and KIO default

D12490: concatPaths: process empty path1 correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R241:47340d6a554c: concatPaths: process empty path1 correctly (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12490?vs=32961=33260 REVISION

D12490: concatPaths: process empty path1 correctly

aleksejshilin added a comment. In D12490#252959 , @anthonyfieroni wrote: > path1 *should* never be empty Hm... I thought concatPaths() is supposed to be used like this: `concatPaths(basePath, relativePath)` - then an empty basePath

D12490: concatPaths: process empty path1 correctly

aleksejshilin added reviewers: anthonyfieroni, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks, anthonyfieroni, dfaure Cc: michaelh, bruns

D12490: concatPaths: process empty path1 correctly

aleksejshilin requested review of this revision. aleksejshilin added a comment. Here is an example of KUrlCompletion breakage. Before, it returned invalid absolute paths like /Desktop etc.: F5820341: Before.png After: F5820340: After.png

D12490: concatPaths: process empty path1 correctly

aleksejshilin created this revision. aleksejshilin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. aleksejshilin requested review of this revision. REVISION SUMMARY When path1 was empty (i.e. 'current directory'), concatPaths() used to return an absolute path

D12490: concatPaths: process empty path1 correctly

aleksejshilin planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks Cc: michaelh, bruns

D11331: add gaming_input devices and others to Battery

aleksejshilin added a comment. In D11331#226428 , @dollinger wrote: > Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`, `UP_DEVICE_KIND_MEDIA_PLAYER`? > Is there a reason why they are excluded? The reason is

D11331: add gaming_input devices and others to Battery

aleksejshilin added inline comments. INLINE COMMENTS > upowerdevice.cpp:98 > + */ > +return (uptype != 0 && uptype != 1 && uptype != 4); > default: So you're changing from 'whitelist' to 'blacklist' behavior here. What will happen when another UPower device type is added

D10993: Fix protocol selection in KUrlNavigator

This revision was automatically updated to reflect the committed changes. Closed by commit R241:37868c2c57f7: Fix protocol selection in KUrlNavigator (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10993?vs=28571=28574 REVISION DETAIL

D10993: Fix protocol selection in KUrlNavigator

aleksejshilin added inline comments. INLINE COMMENTS > dfaure wrote in kurlnavigator.cpp:349 > Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary > to make that method call. So given that we have an if() already, why not only > do it in the else? > Well, OK, it's

D10993: Fix protocol selection in KUrlNavigator

aleksejshilin updated this revision to Diff 28571. aleksejshilin added a comment. - Move setting authority to the else branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10993?vs=28519=28571 BRANCH fix_kurlnavigator_protocol_selection REVISION DETAIL

D10993: Fix protocol selection in KUrlNavigator

aleksejshilin updated this revision to Diff 28519. aleksejshilin added a comment. - Add comment explaining the empty authority REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10993?vs=28496=28519 BRANCH fix_kurlnavigator_protocol_selection REVISION DETAIL

D10993: Fix protocol selection in KUrlNavigator

aleksejshilin added inline comments. INLINE COMMENTS > dfaure wrote in kurlnavigator.cpp:349 > Is this in order to get smb:// instead of smb: ? It looks correct, but not > for "file", how about moving that to an else{} branch of the if below? And I > could add a comment like "we want smb:// or

D10993: Fix protocol selection in KUrlNavigator

aleksejshilin created this revision. aleksejshilin added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. aleksejshilin requested review of this revision. REVISION SUMMARY QUrl no longer accepts an empty authority and a non-empty path that starts with '//'

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. In D8958#212246 , @ngraham wrote: > @aleksejshilin doesn't have commit access Actually, I do now. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin,

D8958: Fix unintentional breadcrumb menu item activation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4a6a3b81bedc: Fix unintentional breadcrumb menu item activation (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8958?vs=26872=27866

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin edited the summary of this revision. REPOSITORY R241 KIO BRANCH fix_accidental_breadcrumb_menu_item_activation REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. In D8958#209050 , @dfaure wrote: > Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. In https://phabricator.kde.org/D8958#203931, @ngraham wrote: > OK cool. The patch works for me! +1. Great, thanks a lot! > Get a code review from someone else before committing. I don't have push access, so no worries. :) REPOSITORY R241

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added inline comments. INLINE COMMENTS > ngraham wrote in kurlnavigatormenu.cpp:85 > Will this still work if the user is using the mouse in left-handed mode? Quoting Qt documentation [1]: > | Qt::LeftButton | The left button is pressed, or an event refers to the left > button.

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin updated this revision to Diff 26872. aleksejshilin added a comment. - Don't consider mouse moves which are smaller than drag distance - Don't pass the ignored mouse release event to the base class REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. Hi again. :) Any news on this? Is there anything I should improve? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks Cc: broulik, ngraham, michaelh

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. So, any comments on the updated revision? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks Cc: broulik, ngraham

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin updated this revision to Diff 22866. aleksejshilin added a comment. - Don't consider mouse moves which are smaller than drag distance - Don't pass the ignored mouse release event to the base class REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin created this revision. aleksejshilin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Since breadcrumb menu is opened on mouse press, it may receive the corresponding mouse release event which may unintentionally activate the