D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

apol added a comment. This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? INLINE COMMENTS > kservice.cpp:739 > +{ > +if > (qvariant_cast(property(QStringLiteral("X-KDE-NoGlobalShortcut"), >

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D24974 To: dfaure, kossebau, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24938: Fix memory leak in KXzFilter::init

apol added a comment. +1 makes sense REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24938 To: aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24909: [PC3/button] Elide text always

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D24909 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n,

D24898: Add KLocalizedString::untranslatedText

apol added a comment. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 68546. apol added a comment. Unrelated change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68544=68546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 68544. apol added a comment. Adopt new deprecation macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65328=68544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682

D24859: Add a .desktop file for kdeinit

apol added a comment. Same as D24858 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D24859 To: meven, apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

apol added a comment. These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these interfaces only requested when they're necessary. REPOSITORY R311 KWallet REVISION DETAIL

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24824: Remove outdated comment about [$e] expansion

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D24824 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24671: Use ECMGenerateExportHeader to manage deprecated API better

apol added a comment.  sorry about slow reviews. The patch looks good. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

apol added a comment. LGTM otherwise INLINE COMMENTS > ksslcertificatemanager.cpp:537 > +}); > return {}; > } `return ret; ` ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24725: Fix grammar

apol retitled this revision from "GIT_SILENT Fix grammar" to "Fix grammar". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH text-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24629: RFC: Introduce KClockSkewNotifier class

apol added a comment. It feels weird to create a class directly into KF5 when it hasn't even started to be used. It could make sense to develop it within some of the apps and when we are sure the API is stable and it wants to be used on other components/products, we can promote it to the

D24630: Replace all qWarning and related calls with categorised logging

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH categorised_logging REVISION DETAIL https://phabricator.kde.org/D24630 To: ahiemstra, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

apol added a comment. I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH simplify-proxy-load REVISION DETAIL https://phabricator.kde.org/D24559 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol added a comment. ok, let's just land this for now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24554: Don't build static library when BUILD_TESTING=OFF

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D24554 To: arojas, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

apol accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson, apol Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 67671. apol added a comment. Unnecessary change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=67670=67671 BRANCH arcpatch-D22362 REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 67670. apol added a comment. Just don't use KWayland::Global Lets generated code do its thing already REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61478=67670 BRANCH arcpatch-D22362 REVISION DETAIL

D22362: Port keystates to use QtWayland's generator

apol added a comment. In D22362#493722 , @davidedmundson wrote: > As some background: > > At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol added a comment. #if FRAMEWORK_VERSION < 6 defaultValue = false #else defaultValue = true #endif Or at least #if FRAMEWORK_VERSION >= 6 #pragma message Consider enabling ParentInConstructor by default #endif It's just a thought, not necessary. REPOSITORY R237

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

apol added a comment. Looks better, it could make sense to add a KF6 TODO/Warning. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol accepted this revision. apol added a comment. It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's true by default. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Right, makes sense. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: apol, kde-frameworks-devel,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol added a comment. +1 in spirit. INLINE COMMENTS > test_notifiers.cpp.ref:7 > +TestNotifiers::TestNotifiers( int Number, QObject *parent ) >: KConfigSkeleton( QStringLiteral( "test7rc" ) ) >, mParamNumber(Number) Maybe it would be better to use the parent argument in

D24294: Port KSslCertificateManager to QSslError

apol added a comment. I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: apol,

D23682: Make use of KPluginMetaData where we can

apol added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a23acd2f1535: Fix generating properties that start with an uppercase letter (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=67204=67294

D23266: Export Plasma core lib log category, add a category to a qWarning

apol accepted this revision. apol added a comment. Go for it, can change later too. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23266 REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik, davidedmundson, apol Cc: apol,

D24398: Rewrite ugly for with pointer arithmetic into range for

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24398 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

apol updated this revision to Diff 67204. apol added a comment. Update test, it seems like tests aren't comparing with .ref now :( REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66271=67204 BRANCH master REVISION DETAIL

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH 2019_09_okbutton_configurable REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D23512: Avoid overloading KCModule::changed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D23512 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24159: new module ECMSourceVersionControl

apol added a comment. +1 REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

apol added inline comments. INLINE COMMENTS > broulik wrote in dataengine.cpp:70 > Where is this constructor used? Unsure, but we can't remove symbols anyway... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik,

D24072: properly install whole plasmacomponent3

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/components3 REVISION DETAIL https://phabricator.kde.org/D24072 To: mart, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24050: Deploy default avatar via qrc

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH avatar REVISION DETAIL https://phabricator.kde.org/D24050 To: nicolasfella, apol Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

apol added a comment. The patch looks good to me, is there a reason why it wasn't accepted? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24025: Don't use KCrash on Android

apol added a comment. In D24025#533418 , @vkrause wrote: > I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go

D24025: Don't use KCrash on Android

apol added a comment. Why not? it could be useful. The alternative is darkness over what happened there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24024: Bundle plugin files on Android

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24024 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, laraque, GB_2, jackyalcine, vatra, michaelh, ognarb, ngraham, bruns,

D24010: Fix generating properties that start with an uppercase letter

apol updated this revision to Diff 66271. apol added a comment. Also make the property lowercase QML doesn't like properties that start uppercase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66270=66271 BRANCH master REVISION DETAIL

D24010: Fix generating properties that start with an uppercase letter

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY We were not adjusting the property name to the getter letter-casing. TEST PLAN See

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thank you! REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23994 To: dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D23990 To: dfaure, apol, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D23968: Use app specific location for DB on Android

apol added a comment. In D23968#532237 , @nicolasfella wrote: > I thought the same thing, but I'm not sure if changing that could break some apps I don't see how many apps would be using a writtableLocation they can't write into. :/

D23970: Port away from deprecated methods in Qt 5.14

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23970 To: dfaure, davidedmundson, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23968: Use app specific location for DB on Android

apol added a comment. Then maybe Qt shouldn't offer it? It's supposed to be writtable after all... REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23828: Disable DBus pieces on Android

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH dbus REVISION DETAIL https://phabricator.kde.org/D23828 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23827: Add manual tests for PC3

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. cool! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23827 To: davidedmundson, #plasma, apol Cc: apol, kde-frameworks-devel,

D23777: Fix diff

apol added a comment. Please fix commit message. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23411: Fix crash in writer collection and cleanup

apol added inline comments. INLINE COMMENTS > writer.h:63 > > +WriterPrivate *d; > friend class WriterCollection; Why's this change? > writercollection.cpp:133 > +Writer writer; > +writer.d->m_plugin = plugin; > +

D23764: Make it possible to delete contacts from backends

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23764 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23722: Warn if KPackage is invalid

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's consider it an iteration though. INLINE COMMENTS > broulik wrote in configmodule.cpp:174 > Is "mainscript" mandatory? > > In any case, if your package has the incorrect folder

D23722: Warn if KPackage is invalid

apol added inline comments. INLINE COMMENTS > configmodule.cpp:174 > + > if (!package.filePath("mainscript").isEmpty()) { > d->_qmlObject->setSource(package.fileUrl("mainscript")); maybe put it after checking the mainscript? the "no QML file provided" error is more accurate. We

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 65328. apol marked 6 inline comments as done. apol added a comment. Forgot these REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65327=65328 BRANCH master REVISION DETAIL

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 65327. apol added a comment. address comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65261=65327 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D22968: Make it possible to modify contacts

apol abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol added a comment. Committed as https://commits.kde.org/kpeople/7cf00a2cb27dcc11c8cd5b06423ce69c41537c82. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23682: Make use of KPluginMetaData where we can

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of relying on the older KPluginInfo which is slower (parses de metadata twice) and

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3848 > } else { > -cAfter.setColumn(textLines.last().length() - 0); > -cAfter.setLine(cAfter.line() + textLines.length() - 1); > +const int lastLineLength = pastedText.size() - >

D23625: Use QString::count(QChar) over QString::split().length() - 1

apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3844 > KTextEditor::Cursor cAfter = pasteLocation; > -const QStringList textLines = pastedText.split(QStringLiteral("\n")); > +const QStringList textLines = pastedText.split(QLatin1Char('\n')); > if

D23588: remove unnecessary check

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY setDevicePixelRatio already checks if it needs to enable m_textureChanged. TEST PLAN

D23587: Skip test on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ea88d2aa51d2: Skip test on wayland (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23587?vs=65007=65008 REVISION DETAIL

D23587: Skip test on wayland

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's using some API that isn't available TEST PLAN Noise gone REPOSITORY R242 Plasma Framework (Library) BRANCH

D23586: Improve code that detects useful elements in an Svg file

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Detect any that contains a "-[a-z]" (i.e. a dash and a lowercase letter. So far

D22968: Make it possible to modify contacts

apol marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64963. apol added a comment. Don't get creative naming classes on the qml plugin REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64834=64963 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968

D23551: CMake config files: use as min dep version the Qt version we built against

apol added a comment. This will only work one-way. If the "wrong" Qt is older, but it's not necessarily the case. Also cmake may be linking against the "right" Qt but then use the "wrong" one at runtime. I'm not convinced. REPOSITORY R263 KXmlGui REVISION DETAIL

D21328: Add qml import for KItemModels

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Alright then, let's get this in and kossebau can port it eventually. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson,

D21328: Add qml import for KItemModels

apol added a comment. Can you look into kossebau's coment? Let's get this in once that's ironed out. INLINE COMMENTS > CMakeLists.txt:30 > > +if (${Qt5Qml_FOUND}) > +ecm_add_tests( I like `if (TARGET Qt5::Qml)` better. REPOSITORY R275 KItemModels REVISION DETAIL

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64834. apol added a comment. Address Bhushan's comments REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64325=64834 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES

D22968: Make it possible to modify contacts

apol marked 3 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23512: Avoid overloading KCModule::changed

apol added a comment. +1 INLINE COMMENTS > kcmodule.h:382 > */ > void changed(); > Use KCONFIGWIDGETS_DEPRECATED? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D23512 To: davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,

D23497: Keep 'lib' as default libdir on Arch Linux based systems

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23497 To: arojas, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23470: Offer an xdg-compatible mode for convertToQVariant

apol added a comment. In D23470#519726 , @kossebau wrote: > How exactly are you using ths from KService? If just by passing the flag set, won't this break any existing custom properties which are relying on "," as separator?

D23470: Offer an xdg-compatible mode for convertToQVariant

apol added inline comments. INLINE COMMENTS > kossebau wrote in kconfiggroup.h:653 > No `bool` flags, please :) > https://community.kde.org/Policies/Library_Code_Policy#Flags Thought about it, it's private API, are you sure it makes sense to have an enum just for this? REPOSITORY R237

D23381: Allow splitting lists using ;

apol abandoned this revision. apol added a comment. Doing https://phabricator.kde.org/D23470 instead, which is less radical. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23381 To: apol, #frameworks Cc: dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n,

D23470: Offer an xdg-compatible mode for convertToQVariant

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's used from KService, which works with desktop files, add support to parse xdg lists.

D23468: Resolve whether there's dbus before processing src/

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2db6ead89036: Resolve whether theres dbus before processing src/ (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23468?vs=64677=64681

D23468: Resolve whether there's dbus before processing src/

apol edited the summary of this revision. apol edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23468 To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23468: Resolve whether there's dbus before processing src/

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise \#if HAVE_DBUSMENUQT will be always false. REPOSITORY R289 KNotifications

D23388: add a border for the toolbars WIP

apol added a comment. Well it's the same color, it just looks okay. Set the applications' color scheme to another one and you'll see what I mean. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc:

D23388: add a border for the toolbars WIP

apol added a comment. I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol

D23381: Allow splitting lists using ;

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY This is what the standard says is the separator: The multiple values should be separated

D23367: make the sizing of the toolbuttons more coherent

apol added inline comments. INLINE COMMENTS > ToolButton.qml:56 > +anchors.centerIn: parent > +visible: parent.visible > +height: Kirigami.Units.iconSizes.smallMedium That's always the case, isn't it? if a parent isn't visible, an item will never

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64325. apol added a comment. Fix JBB's crash REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64314=64325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64314. apol added a comment. Make it possible to create new contacts REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=63191=64314 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

apol added a comment. Makes sense, but I feel some explanation is missing ^^' Put it in the commit message? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

apol abandoned this revision. apol added a comment. https://commits.kde.org/krunner/ae5a477b9d41e33137c4c8447e3fbe6e4b72cf32 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt, davidedmundson Cc: aacid, kde-frameworks-devel,

D22723: Fix RunnerManager::queryFinished()

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in runnermanager.cpp:360 > can you explain why we need this? In checkTearDown we have the code that reacts to the job being done. If we don't set it to true we'll never be looking at whether all jobs are done because we'll

D23047: Properly turn real into integer

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ee1d424f1cb9: Properly turn real into integer (authored by apol). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23047?vs=63418=64204 REVISION DETAIL

D23315: Port runnertest to QGuiApplication

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D23315 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH dbustest REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks, apol Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n,

<    1   2   3   4   5   6   7   8   9   10   >