marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support
more options and are generally better than our plugins. The only
advantage our plugins offer is that the Qt
On Saturday 02 August 2014 15:48:01 David Faure wrote:
I just tagged and packed 5.1.0.
Main changes:
* KTextEditor: Major refactorings and improvements of the vi-mode
* KAuth: Now based on PolkitQt5-1
* New migration agent for KWallet
* Windows compilation fixes
* Internationalization
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119590/
---
Review request for KDE Frameworks and Alex Merry.
Repository
and Alex Merry.
Changes
---
Oops, Qt 5.3, not Qt 4.3.
Summary (updated)
-
Disable the JPEG-2000 plugin when Qt version is 5.3 or later
Repository: kimageformats
Description (updated)
---
QtImageFormats 5.3 comes with a JPEG-2000 plugin, which supports more
options
and Alex Merry.
Changes
---
Also, DDS.
Summary (updated)
-
Disable the DDS and JPEG-2000 plugins when Qt version is 5.3 or later
Repository: kimageformats
Description (updated)
---
QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support
more options
and Alex Merry.
Repository: kimageformats
Description (updated)
---
QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support
more options and are generally better than our plugins. The only
advantage our plugins offer is that the Qt DDS plugin does not work on
sequential devices
and Alex Merry.
Changes
---
5.3, not 4.3
Repository: kimageformats
Description (updated)
---
QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support
more options and are generally better than our plugins. The only
advantage our plugins offer is that the Qt DDS plugin does
for a reason, to
prevent accidental use of dangerous behaviour, and I'm not too keen on undoing
that move for all software that uses KDECompilerSettings.
- Alex Merry
On Aug. 1, 2014, 4:06 p.m., Axel Rasmussen wrote
CMAKE_INSTALL_DATADIR anyway, really). I had to replace ${DATA_INSTALL_DIR}
with share/icons to test installation.
- Alex Merry
On July 25, 2014, 2:49 a.m., David Narváez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Friday 25 July 2014 02:52:09 Eike Hein wrote:
On 07/24/2014 08:35 PM, Alex Merry wrote:
As Jonathan said, yes, you are correct. And, yes, I should really write a
porting script for that.
Yay! That's the excuse I needed to avoid fixing Konvi's icon
installs until your script is ready
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119417/#review63142
---
Ship it!
Ship It!
- Alex Merry
On July 22, 2014, 11:35
On Wednesday 23 July 2014 18:08:42 David Narvaez wrote:
Hi,
The information at [0] seems to indicate I just need to worry about
renaming files to match the new categories (btw, is there a script for
that?) but what I get from
CMake Warning (dev) at
than one plugin :-)
- Alex Merry
On July 19, 2014, 3:41 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079
changed the KPluginLoader methods - have you looked to see if
they are the ones that are likely to be useful?
- Alex Merry
On July 18, 2014, 1:34 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply
be loadable by QLibrary).
- Alex Merry
On July 19, 2014, 1:15 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119331/#review62636
---
Ship it!
Ship It!
- Alex Merry
On July 17, 2014, 11:01
using
kdesrc-build. I just suspected that it's something related to my setup since
it went away once I manually ran 'make install' from the build directory
created by kdesrc-build.
While building on Windows using emerge I didn't see this though.
Alex Merry wrote:
I can't reproduce
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119291/#review62407
---
Ship it!
Ship It!
- Alex Merry
On July 15, 2014, 8:29 a.m
/r/119275/
---
(Updated July 14, 2014, 6 p.m.)
Review request for KDE Frameworks, Alex Merry and Michael Pyne.
Repository: kcoreaddons
Description
---
Using the same variable name for var1 and var2 in the new
${${camelcase_headers_var}} with ${${EGH_REQUIRED_HEADERS}}. Unintuitive, I
know.
- Alex Merry
On July 15, 2014, 1:38 p.m., Andreas Xavier wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119289/#review62414
---
Ship it!
Huh, guess I missed that :-)
- Alex Merry
the CamelCase
headers and the REQUIRED_HEADERS should work just fine. I suspect you have a
build issue at your end. Can you try removing both your build and install
directories, and building again?
- Alex Merry
On July 13, 2014, 9:54 a.m., Andreas Xavier wrote
suggests you haven't tried
running the tests. Running make test to check your changes is always a good
idea. I applied your patch to my checkout, and they ran fine, though, so you
can ship it.
- Alex Merry
On July 13, 2014, 11:19 a.m., Andreas Xavier wrote
, not work
around it here. Possibly by using Q_DECL_IMPORT in the forward declaration.
tests/kprintpreview_test.cpp
https://git.reviewboard.kde.org/r/119249/#comment43244
This should have a comment, otherwise someone well-meaning will undo your
change.
- Alex Merry
On July 12, 2014, 5
/119251/#comment43252
Normally, it goes before the return type. It presumably still works where
you put it, but it looks very odd.
- Alex Merry
On July 12, 2014, 7:02 p.m., Cristian Oneț wrote:
---
This is an automatically generated e
(except issue 2, of course,
since that's covered in the other review request).
- Alex Merry
On July 12, 2014, 7:15 p.m., Cristian Oneț wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
the lconvert that matches the
lrelease we're using.
- Alex Merry
On July 9, 2014, 2:12 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119198
://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#modules and
http://api.kde.org/ecm/manual/ecm-developer.7.html
- Alex Merry
On July 11, 2014, 10:56 a.m., Heiko Becker wrote:
---
This is an automatically generated e-mail
/#review61935
---
On July 7, 2014, 5:27 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119111
On Tuesday 08 July 2014 17:30:19 Kevin Ottens wrote:
* he's also like to see the android port progress, in particular he got no
answer about getting a file in ECM to that effect;
Sorry, life's a bit crazy at the mo. Will try to look at soon. Although I'd
appreciate the input of anyone else
?
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
as part of this
patch. Is this stuff noted in the apidocs?
Also, I assume that not changing the behaviour of setXMLFile is a deliberate
decision. What's the reasoning? That should probably be noted in a comment or
in the apidocs.
- Alex Merry
On July 6, 2014, 9:47 a.m., David Faure wrote
On July 6, 2014, 12:52 p.m., Alex Merry wrote:
A little concerned that there are no documentation changes as part of this
patch. Is this stuff noted in the apidocs?
Also, I assume that not changing the behaviour of setXMLFile is a
deliberate decision. What's the reasoning
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119142/#review61739
---
Ship it!
Ship It!
- Alex Merry
On July 6, 2014, 3:32 p.m
On Tuesday 03 June 2014 23:01:23 Anuj Pahuja wrote:
Hi,
I am building libkdegames on KF5/Qt5 using CMake 3 but I'm not getting
deprecation warnings for KDELibs4Support classes (KDialog, KFileDialog
etc.). However, I get all the deprecation warnings when I use CMake 2.8.
Also, functions like
On Saturday 05 July 2014 18:31:20 Marko Käning wrote:
Hi David and all,
Which proves my point: .rc files don't go into the kf5 subfolder.
I was pondering this again just now and came to the conclusion that
all the KF5/KDE frameworks and apps should install everything into
some subdir of
On July 5, 2014, 9:33 a.m., David Faure wrote:
src/lib/plugin/kpluginmetadata.h, lines 204-205
https://git.reviewboard.kde.org/r/119079/diff/3/?file=286685#file286685line204
Make member vars private.
It's not like deriving from a value class makes any sense anyway, and
On 03/07/14 22:06, Jonathan Riddell wrote:
kdelibs4support ships an old copy of FindGettext.cmake. This is incompatible
with the version shipping in cmake and causes some compile failures. Can I
remove it?
The interfaces of both files look like they should be the same. Do you
have any info
On 04/07/14 10:07, Jonathan Riddell wrote:
On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote:
On 03/07/14 22:06, Jonathan Riddell wrote:
kdelibs4support ships an old copy of FindGettext.cmake. This is
incompatible with the version shipping in cmake and causes some compile
failures
/FindGettext.cmake 91e88f7e00ac52539066e71eeffb7df6c2148196
Diff: https://git.reviewboard.kde.org/r/119111/diff/
Testing
---
None whatsoever: Jonathan, you know where this isssue has been seen, can you
test?
Thanks,
Alex Merry
___
Kde-frameworks
On 04/07/14 10:41, Alex Merry wrote:
On 04/07/14 10:07, Jonathan Riddell wrote:
On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote:
On 03/07/14 22:06, Jonathan Riddell wrote:
kdelibs4support ships an old copy of FindGettext.cmake. This is
incompatible with the version shipping
,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On 04/07/14 17:40, Marco Martin wrote:
HI all,
I recently noticed that the two GHNS windows in Plasma 5 very recently freeze
the whole process as soon the dialog opens
I tried to bisect things and the problem is definitely in the commit
8cb050ea61dfb195fee0293c7c0eb87cb0a90654
in the
On 27/06/14 11:24, Mario Fux wrote:
Morning
As I was asked recently why the release schedule of KDE Frameworks 5 is not
(yet) on techbase.kde.org I took the liberty to change this:
http://techbase.kde.org/Schedules/Frameworks
It's link to the main page as well:
Git commit f6f1e8c7b8321389fe8268fc25254bd512a6f399 by Alex Merry.
Committed on 15/06/2014 at 16:21.
Pushed by alexmerry into branch 'master'.
ECMAddTests: make NAME_PREFIX only apply to the test, not the target
David Faure and Patrick Spendrin have convinced me that NAME_PREFIX
should
frameworks. Some need patching up (kconfig and kio in
particular). I think the safest thing is to remove the use of NAME_PREFIX from
those, so that people don't have to update ECM in order to build them.
Also, I should write some unit tests...
Thanks,
Alex Merry
On 19/06/14 00:32, Aleix Pol wrote:
On Wed, Jun 18, 2014 at 10:56 PM, Ben Cooksley bcooks...@kde.org
mailto:bcooks...@kde.org wrote:
Note though that I consider this a workaround for an upstream
regression which we have detected.
One of the reasons the CI system runs the next
On 19/06/14 22:21, Marco Martin wrote:
Hi all,
I was thinking, since the policy for committing in frameworks is to always
asking for a review, what about on repositories under frameworks/* adding an
hook that accepts pushes only if the comment has a REVIEW: line?
I have been guilty too
check.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
check.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the architecture check.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On 07/06/14 23:31, Alex Merry wrote:
OK, since this seems to be what pretty much everyone who has said
anything to me about this wants, let's make the name prefix only for the
test name, then. I won't have time until Friday. If anyone wants to
create an RR for it before then, I'll just say
On 07/06/14 15:40, David Faure wrote:
On Saturday 07 June 2014 13:51:17 KDE CI System wrote:
See http://build.kde.org/job/ktexteditor_master_qt5/420/changes
The following tests FAILED:
43 - indenttest (Timeout)
Not sure what happened after PASS : IndentTest::testPascal(case6)
in the tests/ directory of KParts
successfully loads khtml when you point it at a HTML file. I can't get it to
load any of the other parts, though, with or without this patch.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
On 07/06/14 16:03, Alex Merry wrote:
On 07/06/14 15:40, David Faure wrote:
On Saturday 07 June 2014 13:51:17 KDE CI System wrote:
See http://build.kde.org/job/ktexteditor_master_qt5/420/changes
The following tests FAILED:
43 - indenttest (Timeout)
Not sure what happened after PASS
On 06/06/14 20:29, David Faure wrote:
On Saturday 10 May 2014 10:28:43 Alex Merry wrote:
Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry.
Committed on 10/05/2014 at 10:26.
Pushed by alexmerry into branch 'master'.
Revert use the NAME_PREFIX only for the test
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118490/#review59299
---
Ship it!
Ship It!
- Alex Merry
On June 5, 2014, 3:56 a.m
.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
676a8be30df41b042758d55b58caa22fc6c89311
src/platformstatus/kded_platformstatus.desktop
9976fa3041a6c12fc4b3ce2146fb481181fa65b8
Diff: https://git.reviewboard.kde.org/r/118476/diff/
Testing
---
qdbus org.kde.kded5 /kded loadModule kded_platformstatus
succeeds
Thanks,
Alex Merry
/
Testing
---
Tests pass, but not sure how to test the installed location. Chusslove: do you
have a standard way to test the loading and operation of the transcript plugin?
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
On June 3, 2014, 10:16 a.m., Alex Merry wrote:
src/mdnsd-servicetypebrowser.cpp, line 51
https://git.reviewboard.kde.org/r/118490/diff/1/?file=277690#file277690line51
Interesting... any idea which monday?
Matthew Dawson wrote:
I'm assuming that is any Monday, as that used
On June 3, 2014, 10:12 a.m., Alex Merry wrote:
Changing the macro name is a no-brainer. Comments below; a lot of them are
about binary compatibility issues, and these depend on how we expect this
macro to be used. I believe that Qt5 makes all its deprecated functions
header-only so
?
src/gui/kconfigloader.h
https://git.reviewboard.kde.org/r/118489/#comment41110
Q_DECL_OVERRIDE?
- Alex Merry
On June 3, 2014, 6:34 a.m., Matthew Dawson wrote:
---
This is an automatically generated e-mail. To reply, visit
?
src/servicetypebrowser.h
https://git.reviewboard.kde.org/r/118490/#comment41114
It looks like the mdnsd backend even just returns false, so this is not
even reliable. With that in mind, I'd be tempted to make it an inline method
that just always returns false.
- Alex Merry
On June 3, 2014
/#review59035
---
On June 2, 2014, 10:03 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118486
b4d1fe9e4c60f5fbf30fb9315ea134faebcaec9c
src/part/katepart.desktop fa760e9d1257c1d613d4fc59e7798202cde25fdd
Diff: https://git.reviewboard.kde.org/r/118484/diff/
Testing
---
kwrite still works.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks
/
Testing
---
Configures properly, tests pass. Visually inspected ECMConfigVersion.cmake file
to see that it will return before the architecture check.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
On 03/06/14 13:08, Daniel Vrátil wrote:
Hi,
I noticed that in ECM, the generated file in
/usr/share/ECM/cmake/ECMConfigVersion.cmake contains an architecture check:
# check that the installed version has the same 32/64bit-ness as the one
which
is currently searching:
if(NOT
get it to
load any of the other parts, though, with or without this patch.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On 03/06/14 17:24, Kevin Ottens wrote:
I see room for improvement in what gets evaluated when (like ability to run a
patch in jenkins as part of the review process), I'm just stuck on the term
enforcing there, not sure what you have in mind.
Neither am I, to be honest. It just feels like
?
Martin Gräßlin wrote:
I have a feeling that the MacOS and Windows maintainer won't like a
required XCB dependency :-)
Alex Merry wrote:
How about making it recommended? At least on non-Apple Unix systems.
Aleix Pol Gonzalez wrote:
MacOS or Windows shouldn't be running
?
Martin Gräßlin wrote:
I have a feeling that the MacOS and Windows maintainer won't like a
required XCB dependency :-)
Alex Merry wrote:
How about making it recommended? At least on non-Apple Unix systems.
Aleix Pol Gonzalez wrote:
MacOS or Windows shouldn't be running
setup. Is it one we
care about?
- Alex Merry
On May 30, 2014, 6:15 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118234
we should make it
mandatory, I'm going to say ship it. Making it required later on is easy if
that turns out to be the best thing to do.
- Alex Merry
On May 30, 2014, 6:15 a.m., Martin Gräßlin wrote:
---
This is an automatically
b792b3cbe1b4dc95e74426ca358ea7005f8c7998
Diff: https://git.reviewboard.kde.org/r/118474/diff/
Testing
---
Module is properly loaded when accessing the
org.kde.kded5/modules/networkstatus D-Bus interface.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing
9976fa3041a6c12fc4b3ce2146fb481181fa65b8
Diff: https://git.reviewboard.kde.org/r/118476/diff/
Testing
---
qdbus org.kde.kded5 /kded loadModule kded_platformstatus
succeeds
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
/r/118472/diff/
Testing
---
All the modules are properly loaded on demand when attempting to access their
D-Bus interface.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
://git.reviewboard.kde.org/r/118484/diff/
Testing
---
kwrite still works.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
a standard way to test the loading and operation of the transcript plugin?
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
autotests/CMakeLists.txt 4b230b2128406be806e9250aeef532ed698dff7c
Diff: https://git.reviewboard.kde.org/r/118385/diff/
Testing
---
Builds, tests pass.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kdesignerplugin
Description
---
Improve the kgendesignerplugin man page
The options now match what is actually accepted, the authors section
properly reflects the authors of the man page, rather than
marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kdesignerplugin
Description
---
Add autotests for designer plugin generation
Diffs
-
CMakeLists.txt e7464fc9036e3c4b8664d601b06d02f5bd924fdb
autotests/CMakeLists.txt PRE-CREATION
autotests
that
is locally built).
Diffs
-
src/CMakeLists.txt 6c3a0f3c974c5f48dc8b9a8874440424f0f7d0f0
Diff: https://git.reviewboard.kde.org/r/118193/diff/
Testing
---
Builds, installs, added an arrow button to a form in designer.
Thanks,
Alex Merry
On 26/04/14 23:32, Kevin Ottens wrote:
Please get back to us when you're done checking your framework, if you get
any
issue or if something is unclear.
Alex Merry:
- kdesignerplugin
- kimageformats
- kmediaplayer (porting aid)
All checked.
Alex
if there isn't another
release, because packagers can pick it up as an official patch if they want.
But I'll let Ivan have the final say.
- Alex Merry
On May 31, 2014, 3:42 a.m., Matthew Dawson wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118403/#review58790
---
Ship it!
Ship It!
- Alex Merry
On May 29, 2014, 4:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118404/#review58791
---
Ship it!
Ship It!
- Alex Merry
On May 29, 2014, 4:21 p.m
On 29/05/14 08:05, Ben Cooksley wrote:
On Thu, May 29, 2014 at 8:08 AM, Marko Käning mk-li...@email.de wrote:
Could not locate file kf5/kdoctools/customization in
(/Users/kdeci/Library/Application Support, /Library/Application Support)
---
which leaves me a little puzzled now.
It is
On May 12, 2014, 3:16 p.m., Kevin Ottens wrote:
examples/bzip2gzip/main.cpp, line 74
https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74
Maybe a better idea to use a loop to avoid the readAll? I know that's
an example which needs to be kept simple, but
On May 5, 2014, 7:17 a.m., Kevin Ottens wrote:
IIRC that was intentional as to not have kjs depend on kdoctools.
Hrm. Distros like Debian aren't going to be super-happy about this. And KJS is
officially a porting aid, so I'm not sure bumping it to tier 3 is that big of
an issue (especially
On May 14, 2014, 2:24 p.m., David Faure wrote:
It is correct that this is about a string representation of the filesize,
to displaying in a column of the model.
For machine processing one can use KFileItem::size() after getting the
KFileItem out of the KDirModel.
However, do we
don't need the NAME_PREFIX
arguments any more, but I'll wait to see what people think of
https://git.reviewboard.kde.org/r/118385/ first.
- Alex Merry
On May 15, 2014, 3 p.m., Patrick Spendrin wrote:
---
This is an automatically
On April 11, 2014, 4:46 p.m., Commit Hook wrote:
This review has been submitted with commit
e898d13b430692e775060d49342181192e122fdf by Hrvoje Senjan to branch master.
Hrvoje Senjan wrote:
i've reverted the commit now. capabilities break LD_LIBRARY_PATH, so this
is a no-go.
case also fix the
capabilities case?
- Alex Merry
On May 15, 2014, 9:12 p.m., Hrvoje Senjan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117125
On May 16, 2014, 11:49 a.m., Alex Merry wrote:
This sounds like an issue that needs to be fixed in KArchive...
Where, exactly, were the files appearing? And which files were appearing there?
- Alex
---
This is an automatically
think this can go in again.
- Alex Merry
On May 15, 2014, 9:12 p.m., Hrvoje Senjan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117125
and Alex Merry.
Changes
---
Add a test for the least info you can get away with in a widgets file.
Summary (updated)
-
Add autotests for designer plugin generation
Repository: kdesignerplugin
Description (updated)
---
Add autotests for designer plugin generation
autotests/qpushbuttonview.png PRE-CREATION
autotests/sth.png PRE-CREATION
autotests/testplugin.qrc PRE-CREATION
autotests/testplugin.widgets PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/118377/diff/
Testing
---
Builds, test passes.
Thanks,
Alex Merry
and Alex Merry.
Changes
---
Fix the first example, which didn't work (KConfig requires you to put at least
one key in a group for it to notice the group).
Repository: kdesignerplugin
Description
---
Improve the kgendesignerplugin man page
The options now match what is actually accepted
and Alex Merry.
Changes
---
Remove two incorrect keys from the man page. I misread the code - you can't set
Class or PluginName for individual classes.
Repository: kdesignerplugin
Description
---
Improve the kgendesignerplugin man page
The options now match what is actually accepted
201 - 300 of 1560 matches
Mail list logo
