D12950: add test which checks the property types

astippich updated this revision to Diff 51550. astippich added a comment. - fix space REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12950?vs=48691=51550 BRANCH property_tests REVISION DETAIL https://phabricator.kde.org/D12950 AFFECTED FILES

D18972: Format EXIF photo flash data

astippich added a comment. The data is taken from exiv2 library: https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348 Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData. This is the only property remaining that

D18972: Format EXIF photo flash data

astippich created this revision. astippich added a reviewer: ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Translate the number of the EXIF photo data to a human readable

D17302: Add test for adding properties to result

astippich added a comment. In D17302#410189 , @bruns wrote: > Currently, both > `Result::add(prop, "value1"); Result::add(prop, "value2");` > and > `Result::add(prop, {"value1", "value2"});` > are serialized (JSON) in the same way as

D17302: Add test for adding properties to result

astippich added a comment. Is this a please don't merge or can I land it? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18910: Use Kformat for bit and sample rate

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e1fa79b30da2: Use Kformat for bit and sample rate (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18910?vs=51346=51367 REVISION

D18911: Add units to framerate and gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a14030bf7182: Add units to framerate and gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18911?vs=51353=51359 REVISION

D18910: Use Kformat for bit and sample rate

astippich added a comment. The unit will be corrected (it is _bit_rate) and three significant digits will always be shown: 123 400 will be displayed as 123 kbit/s 1 234 000 will be displayed as 1.23 Mbit/s 12 345 000 will be displayed as 12.3 Mbit/s REPOSITORY R286 KFileMetaData

D18911: Add units to framerate and gps data

astippich updated this revision to Diff 51353. astippich added a comment. - remove unrelated new lines REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18911?vs=51352=51353 BRANCH format_units REVISION DETAIL https://phabricator.kde.org/D18911

D18911: Add units to framerate and gps data

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add units to some of the properties of kfilemetadata. This

D18910: Use Kformat for bit and sample rate

astippich added a comment. I actually have not started porting Dolphin to the new feature yet, since this will require Kf 5.56 and is probably stuff for 19.08. If a screenshot is a must I will adjust priorities :) REPOSITORY R286 KFileMetaData REVISION DETAIL

D18910: Use Kformat for bit and sample rate

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Format bit and sample rate to 3 significant digits

D18900: Avoid side effects due to stale errno value

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D18900 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17245: Add string formatting function to property info

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bedfd6609c6: Add string formatting function to property info (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=51271=51330

D17245: Add string formatting function to property info

astippich updated this revision to Diff 51271. astippich added a comment. - rebase onto current master - rename header - update docs REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=48690=51271 BRANCH display_value REVISION DETAIL

D18819: Use content to determine mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7415aa60d9f6: Use content to determine mime type (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18819?vs=51112=51258 REVISION DETAIL

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich created this revision. astippich added reviewers: ngraham, bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Rewrite the taglib extractor to use taglib's

D18819: Use content to determine mime type

astippich added a comment. In D18819#407360 , @ngraham wrote: > The default match mode tries both file extension and content ; this would make it just do content. So I guess if they

D18819: Use content to determine mime type

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Determine the mime type for the extractors based on the

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:229 > but in case file.tag() returns an ApeTag, the dynamic_cast will return a > nullptr. This is a dynamic_cast, not a static_cast. It always returns a nullptr REPOSITORY R286 KFileMetaData REVISION DETAIL

D17245: Add string formatting function to property info

astippich added a comment. Can someone please give this a yes or a no? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:229 > Is this the same as > > auto id3Tags = dynamic_cast(file.tag()); > if (id3Tags) { ... } > > ? No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not possible. REPOSITORY R286

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > When you make this > `void writeGenericProperties(Taglib::File *file, const PropertyMap > )`, you can do `file->properties(); {/* merge */}; > file->setProperties(...);` here, saving most of the duplicate

D17302: Add test for adding properties to result

astippich added inline comments. INLINE COMMENTS > bruns wrote in resulttest.cpp:63 > This looks wrong to me ... > How many items do you get when you append "keyword3" first and ["keyword1", > "keyword2"] next? It's the same. The properties will get merged regardless of their form if the

D17302: Add test for adding properties to result

astippich added a comment. Since nobody seems to care and this is just testing the status quo, I'll merge it next week unless somebody objects REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov,

D18665: Cleanup taglib writer test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Cleanup taglib writer test and add a warning when they are

D18604: Implement support for writing rating information for taglib writer

astippich added a dependent revision: D18665: Cleanup taglib writer test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18665: Cleanup taglib writer test

astippich added a dependency: D18604: Implement support for writing rating information for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18665 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:409 > What are the differences between the various mp3 test cases? It tests all possible ratings, since the commonly used numbers are somewhat arbitrary, and I wanted to make sure writing and extracting

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 50709. astippich added a comment. - rebase on latest parent revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=50505=50709 BRANCH rating_write2 REVISION DETAIL

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 50705. astippich added a comment. - rebase on latest parent revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50501=50705 BRANCH enhance_taglibwriter2 REVISION DETAIL

D18603: Implement more tags for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:276 > You should probably add a warning when `extractorList.size() > 1`, as in this > case the extractor you run would be arbitrary. > > Though, I am currently not aware of cases where one mimetype is

D18601: Rewrite taglib writer to use property interface

astippich added a comment. In D18601#402905 , @bruns wrote: > I think this becomes better structured when you: > > 1. Create one function per file type, with parameters (Taglib::Filestream, KFM::PropertyMap) > 2. From this function, call a

D18601: Rewrite taglib writer to use property interface

astippich updated this revision to Diff 50704. astippich added a comment. - rewrite for better readability and to avoid heap allocation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18601?vs=50497=50704 BRANCH rewrite_taglib2 REVISION DETAIL

D18450: Add extractor for AppImage files

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Just noticed, you never use the AppDataParser.name(). Is that intentional? Otherwise looks good, but you may want to wait for someone more experienced than me. REPOSITORY R286

D18450: Add extractor for AppImage files

astippich added a comment. got it up and running! One question: Why is the extra desktop file parser necessary? Shouldn't all required information be available from the app data parser? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau,

D18603: Implement more tags for taglib writer

astippich added a dependent revision: D18604: Implement support for writing rating information for taglib writer. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc:

D18604: Implement support for writing rating information for taglib writer

astippich added a dependency: D18603: Implement more tags for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D18603: Implement more tags for taglib writer

astippich added a comment. I forgot to add the dependent revision. Thanks for the review, as it's been hard lately to get a reply to anything related to KFileMetaData REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To:

D18603: Implement more tags for taglib writer

astippich added a dependency: D18601: Rewrite taglib writer to use property interface. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D18450: Add extractor for AppImage files

astippich added a comment. In D18450#402175 , @TheAssassin wrote: > `LIBAPPIMAGE_BINARIES` (or, more likely, `LIBAPPIMAGE_LIBRARIES`) doesn't exist, maybe it existed for a short while but got deleted. @kossebau can you please link to

D18601: Rewrite taglib writer to use property interface

astippich added a dependent revision: D18603: Implement more tags for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18604: Implement support for writing rating information for taglib writer

astippich retitled this revision from "implement support for writing rating information for taglib writer" to "Implement support for writing rating information for taglib writer". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns,

D18604: implement support for writing rating information for taglib writer

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add support for writing the rating tag to all supported

D18603: Implement more tags for taglib writer

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Implement more tags for writing for the taglib writer

D18601: Rewrite taglib writer to use property interface

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Rewrite the taglib writer to use taglib's unified

D18450: Add extractor for AppImage files

astippich added a comment. The first issue is when BUILD_TESTING is not set to false, cmake fails with CMake Error at lib/CMakeLists.txt:8 (add_subdirectory): The source directory ~/Code/libappimage-0.1.8/lib/gtest does not contain a CMakeLists.txt file.

D12950: add test which checks the property types

astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17245: Add string formatting function to property info

astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D18450: Add extractor for AppImage files

astippich added a comment. I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building libappimage, but now I can't get it to work in KFileMetaData because cmake complains that

D18434: exiv2extractor: add support for bmp, gif, webp, tga

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH covergiftgabmp REVISION DETAIL https://phabricator.kde.org/D18434 To: kossebau, #baloo, #dolphin, astippich Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh,

D17302: Add test for adding properties to result

astippich added a comment. ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

astippich added a comment. Can you add a test please? In D18450#397920 , @kossebau wrote: > There seems to be some bug with the Comment field though, somehow in Dolphin the comment is not shown, where "dump" displays it as existing.

D18010: Fix failing test of exiv gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c3fbdea4f7f3: Fix failing test of exiv gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=49750=50079 REVISION DETAIL

D18205: Test empty and zero gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:15d8c42d8ce0: Test empty and zero gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49749=50078 REVISION DETAIL

D18010: Fix failing test of exiv gps data

astippich retitled this revision from "Allow zero altitude/longitude/latitude exiv gps data" to "Fix failing test of exiv gps data". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010 To:

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich updated this revision to Diff 49750. astippich added a comment. - fix gps altitude precision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=49317=49750 BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010

D18205: Test empty and zero gps data

astippich updated this revision to Diff 49749. astippich added a comment. - update REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49377=49749 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:298 > when you rewrite this as > > if (it != data.end()) { > auto ratio = it->value().toRational(); > it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef")); > if ((ratio.second !=

D17245: Add string formatting function to property info

astippich added a comment. @broulik since you've made the feature request, do you mind giving this a quick look? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel,

D18205: Test empty and zero gps data

astippich retitled this revision from "test empty and zero gps data" to "Test empty and zero gps data". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D18205: test empty and zero gps data

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractortest.cpp:65 > although only copied, I think it should be written like the other two: > `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);` That's

D18205: test empty and zero gps data

astippich updated this revision to Diff 49377. astippich added a comment. - move namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49316=49377 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich added a dependency: D18205: test empty and zero gps data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18010 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18205: test empty and zero gps data

astippich added a dependent revision: D18010: Allow zero altitude/longitude/latitude exiv gps data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich updated this revision to Diff 49317. astippich added a comment. - rebase on revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=48789=49317 BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010 AFFECTED

D18205: test empty and zero gps data

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Create a new test that more extensively checks gps data obtained

D17391: add support for more mimetypes to taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:b6fa5f7245fb: add support for more mimetypes to taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17391?vs=46994=48918

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY A zero value was used before to indicate invalid data, and thus 0°

D12950: add test which checks the property types

astippich added a comment. ping! I would like to land this as a preparation for T8196 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D12950: add test which checks the property types

astippich updated this revision to Diff 48691. astippich added a comment. - rebase - cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12950?vs=34396=48691 BRANCH property_tests REVISION DETAIL https://phabricator.kde.org/D12950

D17245: Add string formatting function to property info

astippich updated this revision to Diff 48690. astippich marked an inline comment as done. astippich added a comment. - add _p to header define REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=47816=48690 BRANCH display_value REVISION

D17391: add support for more mimetypes to taglibwriter

astippich added a comment. friendly ping. this is pretty straightforward REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17391 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17500: Restore mobipocket extractor

astippich planned changes to this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

astippich retitled this revision from "add simple test for string merging" to "Add test for adding properties to result". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc:

D17302: add simple test for string merging

astippich updated this revision to Diff 48688. astippich added a comment. - extend the test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=47329=48688 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D17245: Add string formatting function to property info

astippich marked 3 inline comments as done. astippich added a comment. Thanks for the review! INLINE COMMENTS > bruns wrote in formatstrings.cpp:50 > Why is midnight an invalid time? Same with the previous discussing around the orientation values, I simply copied the code. My plan was to

D17245: Add string formatting function to property info

astippich updated this revision to Diff 47816. astippich added a comment. - remove static kformat - always show time - change default display function handling REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=47660=47816 BRANCH

D17245: Add string formatting function to property info

astippich added a comment. String freeze is approaching next week, and I would like to get this in for 5.54 so that I can start porting Dolphin and baloo-widgets. Anyone? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns,

D17245: Add string formatting function to property info

astippich updated this revision to Diff 47660. astippich added a comment. - improve code readability REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46859=47660 BRANCH display_value REVISION DETAIL https://phabricator.kde.org/D17245

D17548: Fixed link to the coding style wiki page

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5d9f4415f7a8: Fixed link to the coding style wiki page (authored by janpr, committed by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17500: Restore mobipocket extractor

astippich added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17302: add simple test for string merging

astippich added a comment. I was recently wondering if this is actually desired behavior. Right now it is definitely required since KFileMetaData wrongly outputs QStrings instead of a QStringList, but when this is fixed, this behavior should be removed imho. Otherwise, querying metadata via

D17500: Restore mobipocket extractor

astippich added a comment. Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at

D17500: Restore mobipocket extractor

astippich updated this revision to Diff 47335. astippich added a comment. - add missing test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47334=47335 BRANCH mobi REVISION DETAIL https://phabricator.kde.org/D17500 AFFECTED FILES

D17500: Restore mobipocket extractor

astippich added a comment. I was unable to get a version check running with cmake, any help is appreciated REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D17500: Restore mobipocket extractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Restore mobipocket extractor

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Restore the mobipocket extractor based on the QMobipocket library,

D17245: Add string formatting function to property info

astippich marked 3 inline comments as done. astippich added a comment. any further comments/objections? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov,

D17301: add documentation to result class

This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R293:60d6fc82ae5a: add documentation to result class (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17302: add simple test for string merging

astippich updated this revision to Diff 47329. astippich added a comment. - updates for master REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=46710=47329 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D16716: fail writing test if mime type is not supported by the extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:239b0ef2b23b: fail writing test if mime type is not supported by the extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17338 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16716: fail writing test if mime type is not supported by the extractor

astippich retitled this revision from "skip writing test if mime type is not supported by the extractor" to "fail writing test if mime type is not supported by the extractor". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns

D17391: add support for more mimetypes to taglibwriter

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY adds support for basic tag writing to aiff, wav, wavpack,

D16716: skip writing test if mime type is not supported by the extractor

astippich added a comment. Well, if it is not even signaled via ctest, that's pretty bad, I agree REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16716: skip writing test if mime type is not supported by the extractor

astippich updated this revision to Diff 46990. astippich added a comment. - use QFAIL REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16716?vs=44983=46990 BRANCH skip_missing REVISION DETAIL https://phabricator.kde.org/D16716 AFFECTED FILES

D17301: add documentation to result class

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in result.h:79 > The TermGenerator's do not contain any data themselves, but > > - keep/update the position state when adding data > - add the data to the referenced Baloo::Document when

D17301: add documentation to result class

astippich updated this revision to Diff 46987. astippich added a comment. - rephase description of TermGenerator REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46864=46987 BRANCH result_documentation REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >