[Differential] [Abandoned] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D4455 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni added a comment. > Also: how do you know whether your change will still work in Qt 5.7? I noticed same downside there, if someone still has Qt 5.7 can test it. Tested Qt 5.6 on Kubuntu backport -> works. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Request, 8 lines] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni created this revision. anthonyfieroni added a reviewer: Plasma. anthonyfieroni added subscribers: mart, davidedmundson. anthonyfieroni set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 by Anthony Fieroni to branch master. Repository: kfilemetadata Description --- startsWith is a weak precondition + guard for duplicate plugin Diffs

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit d2bb8062e6d21057900359333ca2bff085dcb951 by Anthony Fieroni to branch master. Repository: knotifications Description --- I think, we want minized window to be shown

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

anthonyfieroni added a comment. I understand code, it will work now, but to me it's a workaround. What about to call QIODevice::seek(0) in constructor, other unchanged to original code ? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D4422 EMAIL PREFERENCES

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

anthonyfieroni added a comment. > When subclassing QIODevice, you must call QIODevice::seek() at the start of your function to ensure integrity with QIODevice's built-in buffer. http://doc.qt.io/qt-5/qiodevice.html#seek For me, i'm not test it, it should be if

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Ян. 26, 2017, 7:18 преди обяд, Anthony Fieroni wrote: > > Ping > > Anthony Fieroni wrote: > KMail do this explicitly, i think it should be expected behavior. Ping - Anthony --- This is an automaticall

Re: Review Request 129885: [KStandadAction] Correct menubars logic

me. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/#review102318 --- On Ян. 29, 2017, 8:25 след обяд, Anthon

Re: Review Request 129885: [KStandadAction] Correct menubars logic

fs - src/kstandardaction.cpp 6e5bba7 Diff: https://git.reviewboard.kde.org/r/129885/diff/ Testing --- Works correct on KDE, test it on Unity. Please don't make such a patch, respect application behavior. Thanks, Anthony Fieroni

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > &g

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > &g

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > &g

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Jan. 26, 2017, 7:18 a.m., Anthony Fieroni wrote: > > Ping KMail do this explicitly, i think it should be expected behavior. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboar

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

or Plasma* from https://git.reviewboard.kde.org/r/129885/ I want an explanation, i never use Unity, i will never use it, but i want know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, wasNative == true ? If so, i'm -1 for this approach - Anthony Fieroni On Ян. 27, 2017

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review102245 --- Ping - Anthony Fieroni On Ян. 21, 2017, 7:52 преди обяд

Re: Review Request 129885: [KStandadAction] Correct menubars logic

nity i suppose to be true -> true. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/#review102239 --- On Ян. 25, 2

Re: Review Request 129885: [KStandadAction] Correct menubars logic

iscard modified states Diffs - src/kstandardaction.cpp 6e5bba7 Diff: https://git.reviewboard.kde.org/r/129885/diff/ Testing --- Works correct on KDE, test it on Unity. Please don't make such a patch, respect application behavior. Thanks, Anthony Fieroni

Review Request 129885: [KStandadAction] Correct mebars logic

n Unity. Please don't make such a patch, respect application behavior. Thanks, Anthony Fieroni

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

to be shown as normal when it's closed in tray. Why we could want a window to be shown as minimized ? Diffs (updated) - src/kstatusnotifieritem.cpp fcbe6a8 Diff: https://git.reviewboard.kde.org/r/129665/diff/ Testing --- + Remove deprecated warnings Thanks, Anthony Fieroni

[Differential] [Changed Subscribers] D4201: Make it possible to lower KCrash to tier 1

anthonyfieroni added inline comments. INLINE COMMENTS > kcrash.cpp:437 > > const char *argv[29]; // don't forget to update this > int i = 0; You have a comment to follow :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

ways, line 150 appending to list, this guard to protect duplicate extractor - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review102096 ------------

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review102091 --- Ping - Anthony Fieroni On Дек. 18, 2016, 9:55 след обяд

Re: Review Request 129776: Allow multiline text for KIconDialog icon names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129776/#review102033 --- +1 - Anthony Fieroni On Ян. 4, 2017, 8:58 след обяд

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101814 --- You don't like the feature? - Anthony Fieroni On Дек. 18

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101716 --- On Дек. 29, 2016, 9:17 преди обяд, Anthony Fieroni wrote: > > -

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101696 --- ping - Anthony Fieroni On Дек. 18, 2016, 9:55 след обяд

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101693 --- ping - Anthony Fieroni On Дек. 29, 2016, 9:17 преди обяд

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Дек. 27, 2016, 11:16 след обяд, Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: Review Request 129706: Don't focus progress windows

tps://git.reviewboard.kde.org/r/129706/#comment68001> You can try vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus); I didn't know there is input required widget ? - Anthony Fieroni On Дек. 26, 2016, 5:15 след обяд, Martin Tobias Holmedahl Sandsm

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

Testing --- Thanks, Anthony Fieroni

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

://git.reviewboard.kde.org/r/129665/diff/ Testing --- + Remove deprecated warnings Thanks, Anthony Fieroni

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Дек. 10, 2016, 6:36 преди обяд, Anthony Fieroni wrote: > > filenamesearch/kio_filenamesearch.cpp, line 113 > > <https://git.reviewboard.kde.org/r/129394/diff/2/?file=487091#file487091line113> > > > > Or we must keep KIO::UDSEntry::UDS_URL in new pat

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Дек. 18, 2016, 10:51 преди обяд, Martin Gräßlin wrote: > > src/kstatusnotifieritem.cpp, line 980 > > <https://git.reviewboard.kde.org/r/129665/diff/1/?file=487738#file487738line980> > > > > AFAIK show and showNormal is the same. What is the difference

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

p window (showNormal) rather than show it minized (show) - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101490 ------------

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

Testing --- Thanks, Anthony Fieroni

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

------- On Дек. 17, 2016, 5:48 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129666/ > --

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

----------- On Дек. 17, 2016, 5:48 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129666/ > --

Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

: knotifications Description --- "no_reason_specified" looks annoying reason Diffs - src/knotificationrestrictions.h e9179ae src/knotificationrestrictions.cpp 5f5d908 Diff: https://git.reviewboard.kde.org/r/129666/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

://git.reviewboard.kde.org/r/129665/diff/ Testing --- + Remove deprecated warnings Thanks, Anthony Fieroni

Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

warnings Thanks, Anthony Fieroni

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

tps://git.reviewboard.kde.org/r/129394/#comment67868> Or we must keep KIO::UDSEntry::UDS_URL in new patch ? - Anthony Fieroni On Дек. 5, 2016, 10:04 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically g

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

does not contain paths anymore 2. It cannot open file from it 3. Search view rejects completely all actions - Anthony Fieroni On Дек. 5, 2016, 10:04 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generat

Re: Review Request 129607: Display Application version in About dialog header

> On Дек. 3, 2016, 6:48 след обяд, Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context,

Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/ --- Review request for KDE Frameworks, Anthony Fieroni, David Faure

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

namesearch:?search=file=file:///path/to/file" then dirUrl.path() > > is empty, and this code is incorrect (it should use the query item "url", > > not the path). What am I missing? > > Anthony Fieroni wrote: > This is a big misunderstanding mainly by m

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

marked as submitted. Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek. Changes --- Submitted with commit 6198841710fb128987c308bd3ef3ff8cbd294ce0 by Anthony Fieroni to branch master. Bugs: 356523 https://bugs.kde.org/show_bug.cgi?id=356523 Repository

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > <https://git.reviewboard.kde.org/r/127216/diff/7/?file=485236#file485236line972> > > > > maybe move this to the else? > > Anthony Fieroni wrote:

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

s not needed anymore. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review101203 --- On Nov. 13, 2016,

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

namesearch:?search=file=file:///path/to/file" then dirUrl.path() > > is empty, and this code is incorrect (it should use the query item "url", > > not the path). What am I missing? > > Anthony Fieroni wrote: > This is a big misunderstanding mainly by m

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Ноев. 16, 2016, 8 след обяд, Anthony Fieroni wrote: > > Ping, i'm still using it without issues, it isn't good enough? > > Anthony Fieroni wrote: > Ping? Any problems with to go in ? - Anthony --- This i

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

namesearch:?search=file=file:///path/to/file" then dirUrl.path() > > is empty, and this code is incorrect (it should use the query item "url", > > not the path). What am I missing? > > Anthony Fieroni wrote: > This is a big misunderstanding mainly by m

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Ноев. 16, 2016, 8 след обяд, Anthony Fieroni wrote: > > Ping, i'm still using it without issues, it isn't good enough? Ping? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboar

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

namesearch:?search=file=file:///path/to/file" then dirUrl.path() > > is empty, and this code is incorrect (it should use the query item "url", > > not the path). What am I missing? > > Anthony Fieroni wrote: > This is a big misunderstanding mainly by m

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

namesearch:?search=file=file:///path/to/file" then dirUrl.path() > > is empty, and this code is incorrect (it should use the query item "url", > > not the path). What am I missing? > > Anthony Fieroni wrote: > This is a big misunderstanding mainly by me. Emitte

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

is is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101007 --- On Ноев. 14, 2016, 1:44 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

oes it > > require testing and debugging? > > Anthony Fieroni wrote: > I don't see documementation, in Dolphin it is used > KDirLister::openUrl(QUrl("filenamesearch:?search=file=file:///path/to/file")) > > Anthony Fieroni wrote: > https://git.reviewboard.kde.

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

oes it > > require testing and debugging? > > Anthony Fieroni wrote: > I don't see documementation, in Dolphin it is used > KDirLister::openUrl(QUrl("filenamesearch:?search=file=file:///path/to/file"))

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

ly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review100862 --- On Ноев. 14, 2016, 1:44 след обяд, Anthony Fieroni wrote: > > --- > This is an auto

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

enough? - Anthony Fieroni On Ноев. 13, 2016, 7:17 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

--- No big ram usage but still not works as expected. 1. Perform search in Dolphin 2. Delete one result item 3. View must be update, but it's not Thanks, Anthony Fieroni

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

tps://git.reviewboard.kde.org/r/129390/#comment67658> Yeah, you can't avoid copying, you can move it here QUrl url = m_urls[action]; emit q->urlSelection(url); But comment is needed again, because *strong* reference became weak - Anthony Fieroni On Ноев. 13, 2016, 1:45 след обяд, Elvis A

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

tps://git.reviewboard.kde.org/r/129390/#comment67656> removeAction(selectableActionGroup()->actions().first())->deleteLater() This should work as expected, about me. - Anthony Fieroni On Ноев. 13, 2016, 1:45 след обяд, Elvis Ange

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

, Anthony Fieroni

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

tps://git.reviewboard.kde.org/r/129361/#comment67609> I think we shouldn't search in fixed path i.e. /usr/... ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter So "patch" like above one is error prone - Anthony Fieroni On Nov. 8, 2016, 1:02 a.m., Albert

Re: Review Request 129348: [htmlcreator] Port to QtWebEngine

marked as submitted. Review request for KDE Frameworks, Christoph Feck and David Faure. Changes --- Submitted with commit 6dccc7739ba3d754b9209674a8985ce9d9546c2c by Anthony Fieroni to branch master. Repository: kio-extras Description --- Enable html thimbnail only

Review Request 129348: [htmlcreator] Port to QtWebEngine

thumbnail/htmlcreator.cpp 99d2636 Diff: https://git.reviewboard.kde.org/r/129348/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

> On Oct. 31, 2016, 12:38 a.m., David Faure wrote: > > src/core/kcoredirlister.h, line 429 > > <https://git.reviewboard.kde.org/r/129205/diff/3/?file=482930#file482930line429> > > > > You can't add virtual methods to a public class, this is not binary >

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

is performed and reload is needed. The cache look good, tests pass, works but in filenamesearch. Thanks, Anthony Fieroni

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

iewboard.kde.org/r/129205/#review100411 --- On Окт. 24, 2016, 10:05 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/#review100401 --- Ping, any suggestions? - Anthony Fieroni On Окт. 24

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

and reload is needed. The cache look good, tests pass, works but in filenamesearch. Thanks, Anthony Fieroni

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

. Thanks, Anthony Fieroni

Review Request 129205: [kcoredirlister] Ability to watch files changes

) in dolphin 2. When appear in view delete him 3. Signal ItemsDeleted is not triggered, file stays in the view even if new search is performed and reload is needed. The cache look good, tests pass, works but in filenamesearch. Thanks, Anthony Fieroni

Re: Review Request 129187: Fix dangling pointer in KPackageJob

tps://git.reviewboard.kde.org/r/129187/#comment67174> emit? - Anthony Fieroni On Окт. 15, 2016, 12:43 преди обяд, David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

board.kde.org/r/129170/#comment67164> same src/karchive_p.h (line 54) <https://git.reviewboard.kde.org/r/129170/#comment67165> same - Anthony Fieroni On Окт. 14, 2016, 7:29 преди обяд, Romário Rios wrote: > >

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

should be setErrorCode and client application can show user help string. - Anthony Fieroni On Oct. 13, 2016, 7:45 a.m., Romário Rios wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 3:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > <https://git.reviewboard.kde.org/r/129146/diff/1/?file=481937#file481937line203> > > > > n->close() > > David Edmundson wrote: > I did thi

Re: Review Request 129146: Fix emitting close when an event has no actions

tps://git.reviewboard.kde.org/r/129146/#comment67111> n->close() - Anthony Fieroni On Oct. 11, 2016, 2:19 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 129092: Fix crashes in NotifyByAudio

> On Oct. 4, 2016, 7:32 a.m., Anthony Fieroni wrote: > > This is not a correct place to patch it. What is your used phonon backend? > > Albert Astals Cid wrote: > I disagree with you, none of the phonon backends call finished from stop, > because finished mea

Re: Review Request 129092: Fix crashes in NotifyByAudio

phonon backend? src/notifybyaudio.cpp (line 144) <https://git.reviewboard.kde.org/r/129092/#comment67060> if (notification) { finish... - Anthony Fieroni On Окт. 4, 2016, 12:31 преди обяд, Albert Astals Cid

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

tps://git.reviewboard.kde.org/r/129042/#comment66964> Can you try to add a function to remove this annoying code duplication? - Anthony Fieroni On Sept. 27, 2016, 10:59 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

tps://git.reviewboard.kde.org/r/129019/#comment66944> factory can be nullptr - Anthony Fieroni On Sept. 26, 2016, 11:10 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

> On Sept. 15, 2016, 4:41 p.m., Kai Uwe Broulik wrote: > > tests/kmessageboxtest.cpp, line 232 > > > > > > QString QString::repeated(int times) const > > > > Returns a copy of this string repeated the

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

> On Септ. 11, 2016, 9:32 след обяд, Anthony Fieroni wrote: > > src/engine/database.cpp, line 128 > > <https://git.reviewboard.kde.org/r/128890/diff/1/?file=476743#file476743line128> > > > > It's needed *m_env = 0;* > > Or you can add method clos

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

tps://git.reviewboard.kde.org/r/128890/#comment66720> It's needed *m_env = 0;* Or you can add method close to call it in all way. src/engine/database.cpp (line 128) <https://git.reviewboard.kde.org/r/128890/#comment66721> - Anthony Fieroni On Септ. 11, 2016, 9:27 след обяд, Christoph Cu

Re: Review Request 128759: Show shortcut for New Folder action

> On Авг. 25, 2016, 8:21 след обяд, Anthony Fieroni wrote: > > src/filewidgets/knewfilemenu.cpp, line 671 > > <https://git.reviewboard.kde.org/r/128759/diff/1/?file=475283#file475283line671> > > > > I have a stupid question, but where (i can't see) actio

Re: Review Request 128759: Show shortcut for New Folder action

tps://git.reviewboard.kde.org/r/128759/#comment66450> I have a stupid question, but where (i can't see) action is added to collection i.e. case when act != nullptr - Anthony Fieroni On Авг. 25, 2016, 7:57 след обяд, Elvis Angelaccio

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98646 --- Looks good to me. +1 - Anthony Fieroni On Авг. 25, 2016

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

tps://git.reviewboard.kde.org/r/128754/#comment66446> I think always emitting is error prone. You can emitting twice even 3 times. Same below. - Anthony Fieroni On Авг. 25, 2016, 2:48 след обяд, David Edmundson

Re: Review Request 128730: kdeclarative: fix crash in IconDialog when no QApplication is available.

31) <https://git.reviewboard.kde.org/r/128730/#comment66380> You mean IconDialog is instantiate *before* QApplication? If it's true, i think this is wrong place to patch it. - Anthony Fieroni On Авг. 21, 2016, 8:36 след обяд, David Faure

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

/uploaded/files/2016/06/11/de3deaa7-7c04-49d2-b2cd-4561dcb37e38__ark-20160611-091720.kcrash.txt Thanks, Anthony Fieroni

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

tps://git.reviewboard.kde.org/r/128627/#comment66149> Here is setted sender, it cannot be nullptr. - Anthony Fieroni On Авг. 8, 2016, 10:38 преди обяд, Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote: > > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt > > issue, options are: > > 1. leave the code as is (i'm not prefer it, the bug is annoying) > > 2. do it on *right* way stori

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Авг. 3, 2016, 5:50 след обяд, Anthony Fieroni wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 500 > > <https://git.reviewboard.kde.org/r/128576/diff/1/?file=472755#file472755line500> > > > > This line must be > > if (s_d &

Re: Review Request 128597: support a size for adding applets

180) <https://git.reviewboard.kde.org/r/128597/#comment66069> Isn't it better to be void appletAdded(QObject *applet, int x, int y, int width = -1, int height = -1); - Anthony Fieroni On Авг. 4, 2016, 1:32 след обяд, Marco Martin

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

tps://git.reviewboard.kde.org/r/128576/#comment66043> This line must be if (s_d && wasCompositing != s_d->compositingEnable) { - Anthony Fieroni On Авг. 3, 2016, 12:34 след обяд, Martin Gräßlin wrote: > > --- >

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

> On Юли 31, 2016, 12:47 след обяд, David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: > For KIO::SimpleJob opStack is

Re: Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

liar with path expectations, you can make exclusive check before 2 loops, i.e. before foreach. - Anthony Fieroni On Юли 24, 2016, 3:27 след обяд, David Faure wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

- Anthony Fieroni On July 8, 2016, 3:24 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

<    1   2   3   4   5   6   7   >