Re: Review Request 128283: Add checksums tab to the properties dialog

tps://git.reviewboard.kde.org/r/128283/#comment65520> I suppose to be *new QFutureWatcher(this)* Destoying the dialog before future finishes can cause a crash, it think. Same below. - Anthony Fieroni On Юни 29, 2016, 9:06 след обяд, Elvis Angelaccio

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

> On Юни 28, 2016, 2:47 след обяд, David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 122 > > > > > > we already have setFlags(Qt::Tooltip) > > > > why is this not enough? >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote: > > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt > > issue, options are: > > 1. leave the code as is (i'm not prefer it, the bug is annoying) > > 2. do it on *right* way stori

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png Thanks, Anthony Fieroni ___ Kde-frameworks-de

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

ing experiment, but I have my doubts as to whether it's done > > correctly... > > Anthony Fieroni wrote: > Ark calls in this order > terminate > unregister > terminate > unregister > Yes, make it 2 times > > Anthony Fieroni wrote: >

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

ing experiment, but I have my doubts as to whether it's done > > correctly... > > Anthony Fieroni wrote: > Ark calls in this order > terminate > unregister > terminate > unregister >

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

ofore* parent call and job must be removed from list. if (!d->progressJobView.contains(job)) ... KJobTrackerInterface::unregisterJob(job); - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96558 ----------- On Юни 10, 2016, 8:07 преди обяд, Anthony Fieroni wrote: > > --- > This is an a

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128150/#review96568 --- On Юни 11, 2016, 9:33 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96508 --- Ping, this is surly a bug. - Anthony Fieroni On Юни 10

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

) <https://git.reviewboard.kde.org/r/128181/#comment65164> So, this connect and below must be removed? Same connections in newly setupConnections - Anthony Fieroni On Юни 14, 2016, 12:03 след обяд, David Edmundson

Re: Review Request 127587: [Kate view] Correct override cursor

. Context menu is closed Diffs - src/view/kateviewinternal.cpp ca5acfc Diff: https://git.reviewboard.kde.org/r/127587/diff/ Testing --- Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

t you attached here? > > Anthony Fieroni wrote: > LD_PRELOAD=$(jobpath)/libKF5JobWidgets.so.5.22.0 ark --changetofirstpath > --add --autofilename zip kjobwidgets > patched libKF5JobWidgets cause first crash it's in, then crash in > libkerfuffle (not every time) > I

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128150/#review96354 ----------- On Юни 11, 2016, 9:33 преди обяд, Anthony Fieroni wrote: > > --- > This

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

h like in bug report. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128150/#review96354 --- On Юни 11, 2016, 9:33

Review Request 128150: [libkerfuffle] Ark application exits before job's finished

Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 9, 2016, 6:22 преди обяд, Anthony Fieroni wrote: > > Ping. > > Elvis Angelaccio wrote: > This doesn't seem to fix the crash with Ark 16.04.1 > > Anthony Fieroni wrote: > Backtrace? > > Elvis Angelaccio wrote: > > Backtrace? >

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 9, 2016, 6:22 преди обяд, Anthony Fieroni wrote: > > Ping. > > Elvis Angelaccio wrote: > This doesn't seem to fix the crash with Ark 16.04.1 Backtrace? - Anthony --- This is an automatically generate

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck memcheck 7 errorrs https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2 Thanks, Anthony Fieroni ___ Kde

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96305 --- Ping. - Anthony Fieroni On Юни 8, 2016, 7:17 преди обяд

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

-7530d053d6f0__memcheck memcheck 7 errorrs https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2 Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2 Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 7, 2016, 12:03 преди обяд, Elvis Angelaccio wrote: > > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977 > > > > If yes, it's already fixed on Ark master. > > Anthony Fieroni wrote: > It's not this, it happens on all backen

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

-7530d053d6f0__memcheck memcheck 7 errorrs https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2 Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

-7530d053d6f0__memcheck Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96234 ------- On Юни 7, 2016, 6:25 преди обяд, Anthony Fieroni wrote: > > --

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

backend. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96235 --- On Юни 6, 2016, 10:53 след обяд,

Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

backtrace https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review96206 --- Ping? - Anthony Fieroni On Май 12, 2016, 2:20 преди обяд

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

on mouse back/forward buttons Diffs - kate/katemainwindow.h ece0db8 kate/katemainwindow.cpp f630e28 Diff: https://git.reviewboard.kde.org/r/127122/diff/ Testing --- Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

marked as submitted. Review request for KDE Frameworks, KDE Usability and Martin Gräßlin. Changes --- Submitted with commit e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f by Anthony Fieroni to branch master. Bugs: 362324 https://bugs.kde.org/show_bug.cgi?id=362324 Repository: kwindowsystem

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit 2275db4b397d66114e05f434d5a90dadc2ec14fb by Anthony Fieroni to branch master. Repository: plasma-framework Description --- ^^ Diffs - autotests/pluginloadertest.h

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95595 --- Ping - Anthony Fieroni On Май 4, 2016, 8:06 след обяд

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

because 48 is not 64/2 so 56-48 = 8, 64-8 = 56 so 56 *equidistance* between 48 and 64. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95540 --------

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 9, 2016, 3:37 след обяд, Anthony Fieroni wrote: > > Ping. It is ok, now? Martin is there any problems with whis patch? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95296 --- Ping. It is ok, now? - Anthony Fieroni On Май 6, 2016, 12

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

it: https://git.reviewboard.kde.org/r/127809/#review95152 ----------- On Май 2, 2016, 5:04 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

://git.reviewboard.kde.org/r/127795/diff/ Testing --- Test pass. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

> On Май 3, 2016, 1:49 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > <https://git.reviewboard.kde.org/r/127795/diff/4/?file=464040#file464040line573> > > > > should this line still be here? > > Anthony Fieroni

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

On Май 3, 2016, 7:10 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127795/ > -

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

by KWin and Plasma. I'm a little bit scared of touching it. > > > > The change does not come with a test, so I have problems understanding what > > you want to change. Could you please extend the tests to ensure that this > > does not break existing functionality? > &g

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

by KWin and Plasma. I'm a little bit scared of touching it. > > > > The change does not come with a test, so I have problems understanding what > > you want to change. Could you please extend the tests to ensure that this > > does not break existing functionality? > &g

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

: plasma-framework Description --- ^^ Diffs (updated) - autotests/pluginloadertest.h 61fc963 autotests/pluginloadertest.cpp 4f96780 src/plasma/dataengine.cpp f942926 Diff: https://git.reviewboard.kde.org/r/127795/diff/ Testing --- Test pass. Thanks, Anthony Fieroni

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

storageCount > 1 and storage is null we have a huge bug elsewhere. > > Anthony Fieroni wrote: > So this *can* dangerous, if job emit twice. It's complex. > > David Edmundson wrote: > If a job emits what twice? So, you

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

's wrong. > > > > we get called from: > > > > QObject::connect(source, SIGNAL(destroyed(QObject*)), this, > > SLOT(sourceDestroyed(QObject*))); > > > > > > destroyed() signal is emitted in QObject::~QObject

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

urs makes far more sense, given you haven't mentioned > > it, it seem like you're just changing things at random without > > understanding it. > > Anthony Fieroni wrote: > I change it to 0, at first, but i saw, after that, loading engine can be > make it without

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

rous, if job emit twice. It's complex. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95092 --- On Май 2, 2

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

/datacontainer.cpp ee067db src/plasma/dataengine.cpp f942926 src/plasma/private/dataenginemanager.cpp 08e42fb Diff: https://git.reviewboard.kde.org/r/127795/diff/ Testing --- Test pass. Thanks, Anthony Fieroni ___ Kde-frameworks-devel

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

l. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95084 ----------- On Май 2, 2016, 5:04 след обяд, Anthony Fieroni wrote: > > --- > This is an automatic

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

viewboard.kde.org/r/127809/#review95084 --- On Май 2, 2016, 5:04 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony Fieroni

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

/datacontainer.cpp ee067db src/plasma/dataengine.cpp f942926 src/plasma/private/dataenginemanager.cpp 08e42fb Diff: https://git.reviewboard.kde.org/r/127795/diff/ Testing --- Test pass. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95047 --- On Април 30, 2016, 6:18 след обяд, Anthony Fieroni wrote: > &

Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

/r/127795/diff/ Testing --- Test pass. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

9369 strace dolphin |& grep ENOENT | wc -l 9603 with patch strace kate |& grep ENOENT | wc -l 4021 strace dolphin |& grep ENOENT | wc -l 5278 - Anthony Fieroni On Април 12, 2016, 2:17 преди обяд, Aleix Po

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

selectable it's not big problem, about me (i prefer this way) 3. Someone can test this patch with more recent version of Qt 5.6.1 or 5.7 - Anthony Fieroni On Април 10, 2016, 10:48 след обяд, Anthony Fieroni wrote

Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

ore correct pos Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127587: [Kate view] Correct override cursor

> On Април 8, 2016, 10:29 преди обяд, Kåre Särs wrote: > > What is it that needs fixing? > > > > I don't have a problem in either case listed. > > Emmanuel Pescosta wrote: > > 3. Context menu is closed > > I can reproduce this problem >

Re: Review Request 127587: [Kate view] Correct override cursor

> On Април 8, 2016, 10:29 преди обяд, Kåre Särs wrote: > > What is it that needs fixing? > > > > I don't have a problem in either case listed. > > Emmanuel Pescosta wrote: > > 3. Context menu is closed > > I can reproduce this problem >

Re: Review Request 127587: [Kate view] Correct override cursor

.reviewboard.kde.org/r/127587/#review94421 --- On Април 8, 2016, 7:36 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 127587: [Kate view] Correct override cursor

/ restore / maximize 3. Context menu is closed Diffs (updated) - src/view/kateviewinternal.cpp ca5acfc Diff: https://git.reviewboard.kde.org/r/127587/diff/ Testing --- Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde

Review Request 127587: [Kate view] Correct override cursor

: https://git.reviewboard.kde.org/r/127587/diff/ Testing --- Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

' - restore in correct pos Hide by click at icon in systray - restore correct pos Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127522: kcodec: Simplify code (qCount -> std::count, homegrown isprint -> QChar::isPrint)

priority if (isPrintable && 4 >= aBuf[1] && aBuf[1] >= 0) - Anthony Fieroni On Март 29, 2016, 7:14 след обяд, Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127398/#review94105 --- +1 for 5.21 - Anthony Fieroni On Март 21, 2016, 11:59

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fie

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fie

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

r/127122/#review94084 --- On Март 28, 2016, 11:20 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

kate/katemainwindow.cpp f630e28 Diff: https://git.reviewboard.kde.org/r/127122/diff/ Testing (updated) --- Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

lazy commits, unfortunately, this bug is also in > > the latest frameworks release. > > > > Thanks for looking into this, though. > > However, since this is fixed now, please discard this review request, the > > code is correct as is. > > Anthony Fier

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127497/#review94022 ------- On Март 26, 2016, 3:19 след обяд, Anthony Fieroni wrote: > > --

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

edia/uploaded/files/2016/03/26/8154d84d-d858-46c1-956b-290ea604984a__Screenshot_20160326_091738.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93783 --- Please, be sure this works as expected on Linux. - Anthony

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

tps://git.reviewboard.kde.org/r/127424/#comment63904> After show, call activateWindow(), even you can call raise() - Anthony Fieroni On Март 19, 2016, 10:56 след обяд, Dominik Haumann wrote: > > --- > This is an automatically generated e

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

to the original code. > It would also work to add a #ifdef, but given that temporary workarounds > tend to become pernanent ones, this is probably the worst solution. > > So what is the proper fix / approach we can take here? > > Anthony Fieroni wrote: >

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On Март 19, 2016, 3:22 след обяд, Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

t: https://git.reviewboard.kde.org/r/127353/#review93449 --- On Март 12, 2016, 4:53 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

://git.reviewboard.kde.org/r/127318/ Diffs - src/knotification.cpp 17b0be2 Diff: https://git.reviewboard.kde.org/r/127326/diff/ Testing --- No real test, just blame me if i'm not right. Thanks, Anthony Fieroni ___ Kde-frameworks-devel

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

e = true, id not present how can take value? force is compromised - Anthony Fieroni On Март 16, 2016, 10:23 след обяд, Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 127380: More conservative approach to saving some disk accesses

quot;, ".svg", ".xpm" }; This is a prefered order? The order can safe disk activity, linear search increase it. Did you try other order or *smart* reoredering on-the-fly? - Anthony Fieroni On Март 15, 2016, 3

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

> On Март 14, 2016, 9:10 след обяд, Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? > > David Edmundson wrote: > Oh wow thanks. I'd just started redoing the same patch. I could have > wasted quite some time. > > David Rosca is super

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

06b-15a373bdbe32__Screenshot_20160312_110707.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org ht

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

tps://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png Thanks, Anthony Fier

Re: Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

Март 12, 2016, 11:31 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127353/ >

Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

560-8b97-963b2f4f1737__Screenshot_20160312_111731.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

ease do test > > your patches before posting them. > > Anthony Fieroni wrote: > Looks like my English is really bad :) > auto n = new KNotification; > n->close(); <--- ref = 0, closed() is not emitted, > deleteLater() is not called => leak >

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/#review93387 ------- On Март 10, 2016, 11:28 преди обяд, Anthony Fieroni wrote: > > -

Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

: https://git.reviewboard.kde.org/r/127326/diff/ Testing --- No real test, just blame me if i'm not right. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only when yo

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only when yo

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only when yo

Re: Review Request 127240: [Applet] Don't crash on remove panel

marked as submitted. Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco Martin. Changes --- Submitted with commit 6bb02c88ebece5c732bbacd861002bd00999d3bc by Anthony Fieroni to branch master. Bugs: 345723 http://bugs.kde.org/show_bug.cgi?id=345723

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only when yo

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only when yo

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

t; point is invalid, so you might want to "qDebug() << associatedWidgetPos;" > > to check whether it's invalid for the failing clients. > > Anthony Fieroni wrote: > Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is > called only wh

<    1   2   3   4   5   6   7   >