chinmoyr updated this revision to Diff 15518.
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6199?vs=15390=15518
REVISION DETAIL
https://phabricator.kde.org/D6199
AFFECTED FILES
src/dolphinmainwindow.cpp
src/views/dolphinview.cpp
To: chinmoyr,
chinmoyr updated this revision to Diff 15517.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15516=15517
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
chinmoyr updated this revision to Diff 15516.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15388=15516
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
chinmoyr updated this revision to Diff 15515.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15385=15515
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
autotests/kiotesthelper.h
src/core/jobuidelegateextension.h
chinmoyr edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr created this revision.
Restricted Application added a subscriber: Konqueror.
REVISION SUMMARY
This is a temporary patch which allows deleting items from write-protected
location. This is only for testing the diff's https://phabricator.kde.org/D6197
and
chinmoyr added a dependent revision: D6198: Add KAuth support to delete
operation.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch makes it possible to delete root owned files and folders.
To avoid any accidental deletion a warning is shown informing the user about
the write-protection. The warnings can either
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch adds the relevant KAuth code to file ioslave that can be used to
perform various file management operations with escalated privilege.
//execWithRoot()// : This method performs the
decide that the users can create files in write protected locations,
> > but they cannot delete existing files.
>
> Chinmoy Ranjan Pradhan wrote:
> Some operation may use more than one polkit action like Delete. If we use
> one polkit action per operation then we will have to p
ut I
> > didn't get this warning.
>
> Chinmoy Ranjan Pradhan wrote:
> so was it the warning for file? or auth dialog? or the folder was delted
> straightaway? In my system I am getting this warning only if the folder is
> empty.
>
> Elvis Angelaccio wrote:
> I o
://git.reviewboard.kde.org/r/129983/diff/
Testing
---
File Attachments
warning dialog
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
Thanks,
Chinmoy Ranjan Pradhan
decide that the users can create files in write protected locations,
> > but they cannot delete existing files.
>
> Chinmoy Ranjan Pradhan wrote:
> Some operation may use more than one polkit action like Delete. If we use
> one polkit action per operation then we will have to p
tem I am getting this warning only if the folder is
empty.
- Chinmoy Ranjan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/#review102944
--------------
decide that the users can create files in write protected locations,
> > but they cannot delete existing files.
>
> Chinmoy Ranjan Pradhan wrote:
> Some operation may use more than one polkit action like Delete. If we use
> one polkit action per operation then we will have to p
--------------
On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129983/
>
s an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/#review102848
---
On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote:
>
> --
cpp smarter? It could
> > show a more "scary" message if the file that's being deleted is
> > write-protected.
>
> Chinmoy Ranjan Pradhan wrote:
> In my system when i use Shift+del there is no warning dialog (few months
> back dolphin used to show the dialog bu
gt; > Apparently kauth doesn't exist on Windows.
Shall I move all the kauth specific code to file_unix ?
- Chinmoy Ranjan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/1299
.reviewboard.kde.org/r/129983/#review102826
-------
On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To repl
---
File Attachments
warning dialog
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
Thanks,
Chinmoy Ranjan Pradhan
dialog
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
Thanks,
Chinmoy Ranjan Pradhan
t you let
> > it call the action right away?
>
> Chinmoy Ranjan Pradhan wrote:
> For a single file calling action right away might work but doing this for
> multiple files will show the authentication dialog everytime before file is
> deleted. This is something we do
-CREATION
Diff: https://git.reviewboard.kde.org/r/129983/diff/
Testing
---
File Attachments (updated)
warning dialog
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
Thanks,
Chinmoy Ranjan Pradhan
iewboard.kde.org/r/129983/#review102738
---
On March 6, 2017, 3:51 p.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
1a
src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION
src/ioslaves/file/kauth/file.actions PRE-CREATION
src/ioslaves/file/kauth/helper.h PRE-CREATION
src/ioslaves/file/kauth/helper.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129983/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
src/ioslaves/file/kauth/helper.h PRE-CREATION
src/ioslaves/file/kauth/helper.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129983/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
Thanks,
Chinmoy Ranjan Pradhan
an. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129737/
> ---
://git.reviewboard.kde.org/r/129737/diff/
Testing
---
File Attachments
Error message
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png
Thanks,
Chinmoy Ranjan Pradhan
iolic-link}
and for a plain text file it'll be like : {""} (here it should be completely
empty, size=0)
This patch attempts to fix the issue.
Diffs
-
src/core/kfileitem.cpp b5ed5fd
Diff: https://git.reviewboard.kde.org/r/128889/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
etely
empty, size=0)
This patch attempts to fix the issue.
Diffs
-
src/core/kfileitem.cpp b5ed5fd
Diff: https://git.reviewboard.kde.org/r/128889/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit b27d51f61d5d89390026bbb094218df2f39dd343 by Chinmoy
Ranjan Pradhan to branch master.
Repository: kio
Description
---
KIO::link creates symlink when either protocol+host+port
://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
Thanks,
Chinmoy Ranjan Pradhan
---
All tests pass.
File Attachments
error message
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
Thanks,
Chinmoy Ranjan Pradhan
/
Testing
---
All tests pass.
File Attachments
error message
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
Thanks,
Chinmoy Ranjan Pradhan
o's jobtest.cpp as starting point:
> > void createSymlink();
> > void createSymlinkAsShouldSucceed();
> > void createSymlinkAsShouldFail();
> > and add tests for any other code path you see in your code.
>
> Chinmoy Ranjan Pradhan wrote:
> I think a m
ld be to overload kio::link. What do you say?
- Chinmoy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98236
-----------
error message
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
Thanks,
Chinmoy Ranjan Pradhan
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> >
> > So you should be able to just use if (m_dest.isLocalFile()) { ... }
> > here.
>
> Chinmoy Ranjan Pradhan wrote:
&g
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> >
> > So you should be able to just use if (m_dest.isLocalFile()) { ... }
> > here.
>
> Chinmoy Ranjan Pradhan wrote:
&g
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> >
> > So you should be able to just use if (m_dest.isLocalFile()) { ... }
> > here.
>
> Chinmoy Ranjan Pradhan wrote:
&g
cause the destination doesn't exist
at the time of stat.
- Chinmoy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
--------------
-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
Thanks,
Chinmoy Ranjan Pradhan
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 116d7dfddbfc4b3433954f79711a4f19ee32d48b by Chinmoy
Ranjan Pradhan to branch master.
Repository: kio
Description
---
This patch adds the support for undoing creation of new
autotests/fileundomanagertest.cpp 761cc76
src/filewidgets/knewfilemenu.cpp bb6fc04
Diff: https://git.reviewboard.kde.org/r/128527/diff/
Testing
---
build
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks
- to use KIO::link
The only issue with using KIO::link is that creating new links in Folder View
plasmoid will fail due to the checks in CopyJob::linkNextFile.
- Chinmoy
---
This is an automatically generated e-mail. To reply, visit
/filewidgets/knewfilemenu.cpp bb6fc04
Diff: https://git.reviewboard.kde.org/r/128527/diff/
Testing
---
build
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
> On July 31, 2016, 9:47 a.m., David Faure wrote:
> > src/widgets/fileundomanager.cpp, line 421
> > <https://git.reviewboard.kde.org/r/128527/diff/2/?file=472624#file472624line421>
> >
> > Why the isEmpty() check?
>
> Chinmoy Ranjan Pradhan wrote:
&g
--
On July 31, 2016, 9:28 a.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128527/
> -
(updated)
-
autotests/fileundomanagertest.h c663f92
autotests/fileundomanagertest.cpp 761cc76
src/filewidgets/knewfilemenu.cpp bb6fc04
src/widgets/fileundomanager.cpp ed5edb0
Diff: https://git.reviewboard.kde.org/r/128527/diff/
Testing
---
build
Thanks,
Chinmoy Ranjan
---
build
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
- Chinmoy Ranjan Pradhan
On July 23, 2016, 7:09 p.m., Wolfgang Bauer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
a5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png
add new device menu
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailin
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 2dd13d36f3f9810c8d92acfff89e9cd6e1c63689 by David Faure
on behalf of Chinmoy Ranjan Pradhan to branch master.
Repository: kio
Description
---
When creating a new file
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 525232d30ee682de4778667c8244778b50620e67 by David Faure
on behalf of Chinmoy Ranjan Pradhan to branch master.
Bugs: 363673
https://bugs.kde.org/show_bug.cgi?id=363673
ing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: https://git.reviewboard.kde.org/r/128499/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: https://git.reviewboard.kde.org/r/128499/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
s (updated)
-
src/filewidgets/knewfilemenu.cpp 2e613b1
Diff: https://git.reviewboard.kde.org/r/128499/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
viewboard.kde.org/r/128499/#review97746
---
On July 22, 2016, 6:35 a.m., Chinmoy Ranjan Pradhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
Diff: https://git.reviewboard.kde.org/r/128499/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ps://git.reviewboard.kde.org/r/128499/diff/
Testing
---
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
s is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128471/#review97725
---
On July 21, 2016, 4:30 p.m., Chinmoy Ranjan Pradhan wrote:
>
>
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 1f30604a4cd1a96d8b733cdae53c5adbe38fda59 by Albert Astals
Cid on behalf of Chinmoy Ranjan Pradhan to branch master.
Repository: kio
Description
---
This fixes a typo in file
016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
on my behalf :)
- Chinmoy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128492/#review97688
---
On July 21, 2016, 3:34 a.m., C
://git.reviewboard.kde.org/r/128492/diff/
Testing
---
File Attachments
the error message
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png
Thanks,
Chinmoy Ranjan Pradhan
___
Kde
nsion with the filename or not.
- Chinmoy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128471/#review97622
---
On July 20, 2016, 7:
erpatch.png
after_patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
9513-478b-a865-9fc791c006d5__linktoapplication_afterpatch.png
after_patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png
Thanks,
Chinmoy Ranjan Pradhan
___
Kde-frameworks-dev
501 - 572 of 572 matches
Mail list logo
