D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#460766 , @apol wrote: > Looks good to me, have you checked that it's now not breaking what @broulik found? Yes, I tested loading systemsettings.svg (`/usr/share/icons/breeze/apps/48/systemsettings.svg`)

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#441163 , @croick wrote: > Would you accept now @apol? Or now? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. Would you accept now @apol? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#422043 , @apol wrote: > With a unit test it would be much easier to accept the patch ;) ... and to identify a remaining bug. The header is now read again after re-initialization. REVISION DETAIL

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick updated this revision to Diff 52868. croick added a comment. add unit test, reset bNeedHeader CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19420?vs=52825=52868 REVISION DETAIL https://phabricator.kde.org/D19420 AFFECTED FILES autotests/data/noop_big.gz

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick created this revision. croick added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. croick requested review of this revision. REVISION SUMMARY - return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading - reset

D11235: Request change of ptrace scope from KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R871:9f3cfcff960c: Request change of ptrace scope from KCrash (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11235?vs=49717=50215#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D11235: Request change of ptrace scope from KCrash

croick retitled this revision from "[DrKonqi] Request change of ptrace scope from KCrash" to "Request change of ptrace scope from KCrash". croick edited the summary of this revision. REPOSITORY R871 DrKonqi BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 To: croick,

D11236: [KCrash] Establish socket to allow change of ptracer

This revision was automatically updated to reflect the committed changes. Closed by commit R285:2af59ef51f8c: [KCrash] Establish socket to allow change of ptracer (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11236?vs=49711=50214#toc REPOSITORY R285 KCrash

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. Ok, now I got it. After reading the YAMA doc again (more carefully) I realize that it really just is the parent that can be attached to the child by default and not the other way around. I still wonder why I seem to recall that there was a working backtrace for the

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. > the 3rd line is still wrong ... So I used the word "tracer" now. Otherwise I don't know what you mean. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. croick edited the test plan for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49717. croick added a comment. - swap variable declaration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49710=49717 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked an inline comment as done. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. I think it's quite useful (see BUG 175362). Remaining threads remain quite busy otherwise, especially since KCrash is closing all file descriptors by default, which leads to a lot of polling of non-existant FDs in the background. Maybe you would like to join the

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked an inline comment as done. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49711. croick marked an inline comment as done. croick added a comment. - invert debugger-debuggee hierarchy in comment REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=49650=49711 BRANCH ptracer REVISION

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added a comment. > you got the parent-child ordering wrong in the commit message. ^^ What do you mean? The (internal) debugger is a child of the debuggee. $ pstree -pn $(pidof crashtest) crashtest(17220)─┬─{crashtest}(17221) ├─{crashtest}(17222)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49710. croick added a comment. - swap lines, declare array for response message where needed REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49705=49710 BRANCH ptracer REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49705. croick edited the summary of this revision. croick added a comment. - adjust warning and check for EINTR when polling REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49651=49705 BRANCH ptracer

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49651. croick marked 5 inline comments as done. croick added a comment. - emit warning if no socket is available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49649=49651 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > ossi wrote in ptracer.cpp:65 > you really could just use != here ... ^^ wow... REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel,

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked 2 inline comments as done. croick added a comment. > that sounds suspicious. i don't think the kernel's behavior did changed, and the process hierarchy presumably didn't, either. the right is handed down the ancestry, and that's irrespective of whether the tracer is a "natural"

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49650. croick marked 2 inline comments as done. croick added a comment. - modify comment and remove check for EAGAIN REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=49617=49650 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49649. croick marked an inline comment as done. croick added a comment. - change order and add comment to kdeinit option in crashtest - add warning if debuggee does not respond as expected REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 11 inline comments as done. croick added a comment. `read()` and `write()` were assumed to work right away, I added a loop around. INLINE COMMENTS > ossi wrote in crashtest.cpp:133 > this addition isn't used or explained anywhere for all i can tell. It's used to unset the

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked 10 inline comments as done. croick added a comment. > please explicitly mark all handled issues as done - you'll notice on the way that you didn't address some of them. Sorry, you were just responding too quickly. > you adjusted the summary kinda the wrong way around

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49618. croick added a comment. - use debuggee pid instead of DrKonqi pid for socket name - make sure to read/write all bytes from/to socket REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49607=49618 BRANCH

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49617. croick marked 2 inline comments as done. croick added a comment. - unlink old sockets before binding - remove superfluous EAGAIN check - use debuggee pid instead of DrKonqi pid for socket name - fix comments REPOSITORY R285 KCrash CHANGES

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49609. croick retitled this revision from "[KCrash] Establish socket to allow change of ptrace scope" to "[KCrash] Establish socket to allow change of ptracer". croick edited the summary of this revision. croick added a comment. - use poll instead of

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49607. croick edited the summary of this revision. croick edited the test plan for this revision. croick added a comment. - rename queryPtrace to setPtracer - add a kdeinit option in crashtest REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. In D11236#393063 , @ossi wrote: > yay, i finally have "some" time for this. ^^ Great! :) And thanks for your input. > it took me a while to get a coherent picture of the problem and solution, because your

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 43560. croick added a comment. - Use empty body for while loop REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=43020=43560 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 43020. croick added a comment. - check for interrupted signal calls when polling - create path string to socket only once - add comments REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34673=43020 BRANCH

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. Is there anybody who feels like reviewing this? I'm happily using the patch on my system, but I understand that there might still be hidden issues here. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks Cc:

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34673. croick added a comment. - remove superfluous line... REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34672=34673 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34672. croick added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - use `QDir::tempPath()` REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=31244=34672 BRANCH ptracer REVISION

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34671. croick marked an inline comment as done. croick added a comment. - check size of socket path REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=34670=34671 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 6 inline comments as done. croick added a comment. Thank you for your comments, totally forgot about licensing. INLINE COMMENTS > maximilianocuria wrote in queryptrace.cpp:26 > Please honour TMPDIR or, even better, use QTemporaryDir (this will also make > the generated path

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34670. croick added a comment. - add license text - use `QDir::tempPath()` - ifdefs to definition REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=30979=34670 BRANCH ptracer REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. In D11236#239055 , @sitter wrote: > Maybe I am missing something here but wouldn't this allow any application to get ptrace access? > > e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 31244. croick added a comment. - check for peer PID to restrict socket connection to DrKonqi - add ifdefs to deactivate code for non-linuxes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=30980=31244 BRANCH

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 30980. croick added a comment. - change socket file location and delete file after use REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=29248=30980 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 30979. croick added a comment. - update socket file location REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29249=30979 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > crashtest.cpp:138 > > - //start drkonqi directly so that drkonqi's output goes to the console > - KCrash::CrashFlags flags = KCrash::AlwaysDirectly; That reasoning does not seem to be true. The output can still be read when started

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 29249. croick added a comment. - remove superfluous include REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29247=29249 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick created this revision. croick added a reviewer: Frameworks. Restricted Application added a project: Frameworks. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow attaching of processes to a debugger, if - the right to attach to processes

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick created this revision. croick added reviewers: Plasma: Workspaces, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow

D8710: Fix VI-Mode buffer commands

This revision was automatically updated to reflect the committed changes. Closed by commit R39:62e4c17cbc79: Fix VI-Mode buffer commands (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8710?vs=22057=22239 REVISION DETAIL

D8710: Fix VI-Mode buffer commands

croick added a comment. In https://phabricator.kde.org/D8710#166793, @cullmann wrote: > The single shots are not that nice, but I understand that they are necessary to defer the action. At first I changed the invokeMethod arguments in utils/application.cpp to

D8710: Fix VI-Mode buffer commands

croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - :tabclose currently makes kate crash. - Switching tabs with commands like :bp or :tabp only

D7167: Ignore default mark in icon border for single selectable mark

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7fcdfd95dc69: Ignore default mark in icon border for single selectable mark (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7167: Ignore default mark in icon border for single selectable mark

croick added a comment. Should I commit? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7167 To: croick, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, #frameworks

D8154: Minor spell check interface fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:06ab983c7a3d: Minor spell check interface fixes (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8154?vs=20381=20407 REVISION DETAIL

D8154: Minor spell check interface fixes

croick added a comment. In https://phabricator.kde.org/D8154#152602, @dhaumann wrote: > Looks already quite good. Btw, are there any bug reports in the Kate or frameworks-ktexteditor product on bugs.kde.org that you fix here? I didn't find one. I just discovered these yesterday

D8154: Minor spell check interface fixes

croick added inline comments. INLINE COMMENTS > spellcheckbar.cpp:146 > d->deleteProgressDialog(false); // this method can be called in response > to > +d->replaceAllMap.clear(); > // pressing 'Cancel' on the dialog This might have been a feature, but without clearing the map,

D8154: Minor spell check interface fixes

croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - empty document does not resize bar widget when spell check is started without effect -

D8147: Use QActionGroup for input mode selection

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9d1a97532ce3: Use QActionGroup for input mode selection (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8147?vs=20359=20377 REVISION DETAIL

D8148: Fix missing spell check bar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9a77f365de57: Fix missing spell check bar (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8148?vs=20360=20376 REVISION DETAIL

D8148: Fix missing spell check bar

croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - the spell check bar removes itself from the bottom view bar, now is added again when required

D8147: Use QActionGroup for input mode selection

croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - now shows the current mode at start - automatically is mutually exclusive TEST PLAN -

D7167: Ignore default mark in icon border for single selectable mark

croick marked an inline comment as done. croick added a comment. In https://phabricator.kde.org/D7167#146752, @dhaumann wrote: > I think the patch makes sense, but I would prefer using a Qt function qPopulationCount to count the bits instead of doing own bitmask magic. Could you provide

D7167: Ignore default mark in icon border for single selectable mark

croick updated this revision to Diff 19807. croick added a comment. - use qPopulationCount to count editable marks REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7167?vs=17786=19807 BRANCH defaultmarker REVISION DETAIL

D7458: Show icons in icon border context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5118d39bb24e: Show icons in icon border context menu (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7458?vs=18554=18558#toc REPOSITORY R39 KTextEditor CHANGES SINCE

D7458: Show icons in icon border context menu

croick marked an inline comment as done. croick added a comment. Yes, the QAction simply overwrites its icon, which then just stays null. Works fine, thank you! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7458 To: croick, #ktexteditor, dhaumann Cc: dhaumann,

D7458: Show icons in icon border context menu

croick updated this revision to Diff 18554. croick added a comment. - use icon without checking REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7458?vs=18519=18554 BRANCH iconbordermenu REVISION DETAIL https://phabricator.kde.org/D7458 AFFECTED

D7458: Show icons in icon border context menu

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - if icons are defined for marks, use them in the context menu - more general approach than https://phabricator.kde.org/D7158

D7167: Ignore default mark in icon border for single selectable mark

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - do not pop up menu if the only selectable mark (i.e. bookmark) is not the default mark for left click on icon border TEST

D6541: Emit signals from icon border when no mark was clicked

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3b202d26f2ee: Emit signals from icon border when no mark was clicked (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6541?vs=16282=16605

D6541: Emit signals from icon border when no mark was clicked

croick added a comment. In https://phabricator.kde.org/D6541#123758, @dhaumann wrote: > The patch looks good, but is there a concrete use-case? I tried to implement a custom context menu for breakpoints and bookmarks in https://phabricator.kde.org/tag/kdevelop/, mainly for

D6541: Emit signals from icon border when no mark was clicked

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - currently it is not possible to get a signal from the icon border menu when no mark is clicked, which prevents the creation

D6535: Use mutually exclusive group in Default Mark Type

croick added inline comments. INLINE COMMENTS > kateviewhelpers.cpp:2257 > dMA = selectDefaultMark.addAction(i18n("Mark Type %1", bit + > 1)); > +selectDefaultMarkActionGroup->addAction(dMA); > } this could be done once, after the if-else-block REPOSITORY

D6540: Use QActionGroup in icon border default marker menu

croick abandoned this revision. croick added a comment. Duplicate of D6535 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6540 To: croick, #ktexteditor Cc: kwrite-devel, #frameworks

D6540: Use QActionGroup in icon border default marker menu

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - the current checkboxes imply that it is possible to select more than one default marker, QActionGroup groups them to one