D10621: Highlighting Indexer: list of suggestions

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Btw, current generated list finds 1658 issues: https://paste.kde.org/p7iareuxc Not all of them are correct, for instance zsh.xml" line 919 RegExpr candidate for

D7175: Redesign CMake syntax

dhaumann added a comment. Oh, and btw. sorry that this review took essentially 7 months. Sometimes we simply suck and things go badly wrong :-) REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann, #frameworks,

D7175: Redesign CMake syntax

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. So everyone seems to agree that in general it's a good idea. @turbov Please go ahead and commit. Don't forget to run make test, and possibly update the unit test rererence with

D10621: Highlighting Indexer: list of suggestions

dhaumann added a comment. As quick comment: I like the idea of programmatically suggesting better usage of rules. I did not yet fine the time to look into this, so I do not know how much output this currently generates. In any case, for the highlighting files we ship with the syntax

D10956: Add syntax highlighting for MIB files

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c53dfc5024d1: Add syntax highlighting for MIB files (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10956?vs=28363=28471#toc REPOSITORY R216 Syntax Highlighting

D10956: Add syntax highlighting for MIB files

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks ok to me now. Please get an update of the committed file, and please maintain this file within the syntax-highlighting framework in the future. REPOSITORY R216 Syntax

D10956: Add syntax highlighting for MIB files

dhaumann added a comment. Calling make test creates the reference unit test data, this was missing. I did this now, adding: new file: autotests/folding/test.mib.fold new file: autotests/html/test.mib.html new file: autotests/reference/test.mib.ref REPOSITORY R216

D10956: Add syntax highlighting for MIB files

dhaumann added a comment. Compiling results in: Error XSDError in file:///home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/mib.xml, at line 4, column 165: Content of attribute version does not match its type definition: 1.0 is not valid according to xs:integer.. Version

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann closed this revision. dhaumann added a comment. Committed with https://cgit.kde.org/ktexteditor.git/commit/?id=ac8f9f61a0d160a04fd46cb7f87b1509987892aa REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9211 To: dhaumann, mwolff, apol Cc: ngraham,

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann marked 2 inline comments as done. REPOSITORY R39 KTextEditor BRANCH AvoidAllocs (branched from master) REVISION DETAIL https://phabricator.kde.org/D9211 To: dhaumann, mwolff, apol Cc: ngraham, #frameworks, michaelh, kevinapavew, kmorwinski, demsking, cullmann, sars, dhaumann

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann marked 8 inline comments as done. dhaumann added a comment. Mark comments as done. INLINE COMMENTS > mwolff wrote in katedocument.cpp:109 > you want to return `std::distance(list.begin(), it)` here Good catch! REPOSITORY R39 KTextEditor BRANCH AvoidAllocs (branched from

D10719: Highlighting for OpenSCAD

dhaumann added a comment. Hm, did you update with `arc diff`, or did you do this differently? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh, kmorwinski

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann updated this revision to Diff 27963. dhaumann added a comment. - Add and use contains() - Use QLaint1String REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9211?vs=23526=27963 BRANCH AvoidAllocs (branched from master) REVISION DETAIL

D7864: Basic support for PHP and Python fenced code blocks in Markdown

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4f7e020e332d: Basic support for PHP and Python fenced code blocks in Markdown (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. @vkrause Do you already have something in mind, when you say this does not scale? ... REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-blocks (branched from master) REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D10646: Support case-insensitive WordDetect

This revision was automatically updated to reflect the committed changes. Closed by commit R216:933eecb13d9a: Support case-insensitive WordDetect (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10646?vs=27496=27959 REVISION

D10646: Support case-insensitive WordDetect

dhaumann added a comment. Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate. REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION DETAIL https://phabricator.kde.org/D10646 To: jpoelen, dhaumann Cc: dhaumann,

D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6132c15c0d44: Add syntax highlighting for SELinux CIL Policies File Contexts (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10174?vs=26240=27958#toc REPOSITORY R216

D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I'll remove the selColor attributes, since these will not work with dark color schemes. Similar, I will remove all underline, italic, and bold attributes where not needed by default.

D10595: Adding ctp file extension to the PHP syntax highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10595 To: martonmiklos, #framework_syntax_highlighting, dhaumann Cc: dhaumann,

D10595: Adding ctp file extension to the PHP syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1b02007242ec: Adding ctp file extension to the PHP syntax highlighting (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

dhaumann closed this revision. dhaumann added a comment. Done, see commit https://commits.kde.org/syntax-highlighting/f5a32272d26e3b46d4c4201a5d9531de8f23867a REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10783 To: nibags,

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, will integrate. REPOSITORY R216 Syntax Highlighting BRANCH update-yacc-bison (branched from master) REVISION DETAIL https://phabricator.kde.org/D10783 To:

D10719: Highlighting for OpenSCAD

dhaumann added a comment. @julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To:

D10719: Highlighting for OpenSCAD

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files. Also, could you

[Bug 390288] KIO/KDirModel: Kate crash while trying to save a new file to a Samba share

Hi everyone, given the momentum we currently have in KIO fixes, I would like to raise attention to the bug below, which may be 10+ years old. Maybe we have some developers here who can reproduce? Best regards, Dominik Am 20.02.2018 23:38 schrieb "Valdo" :

D10646: Support case-insensitive WordDetect

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In general looks good, and it even revealed a bug as I understand. However, the KTextEditor framework still has its own implementation of the syntax highlighting. Can you also

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6a3599b9e803: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text… (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

dhaumann accepted this revision. dhaumann added a comment. Yes, looks ok, will integrate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10509 To: mmustac, #ktexteditor, ngraham, #kate, cullmann, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew,

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann closed this revision. dhaumann added a comment. Close as it should work now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann added a comment. This is fixed, see commit https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann added a comment. Question is: what happens in the vi test? Did we really introduce a regression or is the test wrong? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. This fixes bug https://bugs.kde.org/show_bug.cgi?id=389307 at least partially. More languages such as Ruby etc can still be added. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D10286: Fix C# var regex

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b874bbe19165: Fix C# var regex (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10286?vs=26471=26520#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D10286: Fix C# var regex

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. This is a good patch - for next time, please increase the version number :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10286 To: wesdawg,

D7909: Add syntax support for Crystal Programming Language

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Sorry for the late reply. Please do the following changes: - remove hard-coded colors from itemDatas. This way, your highlighting will look good in all color themes.

D8371: Support for underscores in numeric literals (Python 3.6)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0abe7dab204f: Support for underscores in numeric literals (Python 3.6) (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D8371: Support for underscores in numeric literals (Python 3.6)

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. If you have more updates, please let us know by sending more patches :-) REPOSITORY R216 Syntax Highlighting BRANCH python_separators REVISION DETAIL

D10220: AppArmor: Fix style

This revision was automatically updated to reflect the committed changes. Closed by commit R216:47dd1a4a1f81: AppArmor: Fix style (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10220?vs=26298=26346

D10220: AppArmor: Fix style

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-apparmor (branched from master) REVISION DETAIL https://phabricator.kde.org/D10220 To: nibags, #framework_syntax_highlighting, dhaumann Cc: #frameworks,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

dhaumann added a comment. +1, but someone else must approve. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: dhaumann, #frameworks, #build_system, michaelh

D10167: Initialize m_usableAdapter with nullptr

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D10167 To: aacid, dhaumann Cc: dhaumann, drosca, #frameworks, michaelh

D10158: Fix ini highlighting of values containing ; or # characters

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D10158 To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann Cc: #frameworks, michaelh

D10159: Highlight Khronos Collada and glTF files

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D10159 To: vkrause, #framework_syntax_highlighting, dhaumann Cc: #frameworks, michaelh

D10135: Put built-in holiday definitions into qrc

dhaumann added a comment. Ok, I can see that now ;) Thanks. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D10135 To: vkrause, #frameworks, #kde_pim, mlaurent Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. @genethomas Unfortunately we are so late with the review that your patch does not apply cleanly anymore. Could you update your patch? REPOSITORY R216 Syntax Highlighting

D10135: Put built-in holiday definitions into qrc

dhaumann added a comment. I'm late to the game, but in general looks good. Minor comments: - What's missing (or I miss something) is that it could be that entries exist twice, if in resource and on disk. Since this is not the case right now, this is probably not an issue. -

D10136: AppArmor: new keywords, improvements & fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c0f5d9ec6eec: AppArmor: new keywords, improvements fixes (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D10136: AppArmor: new keywords, improvements & fixes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good and test passes. Just one minor comment that is not really relevant for now - will push in a second. INLINE COMMENTS > apparmor.xml:709 >

D10145: Improve line height

dhaumann added a comment. Testing under Linux, I cannot see any visual difference when selecting the same font in KWrite with and without patch. I guess this is mostly a good sign. From my side this is a "+1", but a bit more testing also by @rjvbb is certainly appreciated, therefore not

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

dhaumann added inline comments. INLINE COMMENTS > filemetadataprovider.h:114 > void loadingFinished(); > +void dataAvailable(); > Could you add API documentation there what this signal indicates and when to use it? Typically, if you find code that is documented it is good practice

D10072: Add APKBUILD to be highlighted as a Bash file

dhaumann added a comment. The version needs to be increased from 6 to 7. Besides this, the patch looks good. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10054: Fix: View jumps when Scroll past end of document is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2bed94b6d463: Fix: View jumps when Scroll past end of document is enabled (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D10058: KateView unit test: simplify finding KateViewInternal

This revision was automatically updated to reflect the committed changes. Closed by commit R39:fbdfe779e46c: KateView unit test: simplify finding KateViewInternal (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10058?vs=25836=25898

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann updated this revision to Diff 25837. dhaumann added a comment. - Add unit test for scroll past end of document REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10054?vs=25830=25837 BRANCH FixScrollPastEnd (branched from master) REVISION

D10058: KateView unit test: simplify finding KateViewInternal

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY See title TEST PLAN make test REPOSITORY R39

D10045: Don't assert on empty names

dhaumann added a comment. @dfaure It seems to me there is some know-how in your head that you should add as comment to the ASSERT then ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: dhaumann, #frameworks

Re: KHolidays as Framework (redux)

Another question: there are holiday files in the git repo. Are these files compiled in as resource or loaded via filesystem? If these files are not added as resource, this probably breaks on Windows and OSX. Best regards Dominik Am 20.01.2018 17:37 schrieb "Dominik Haumann" <dha

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY This patch fixes a corner case for the following

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

dhaumann added a comment. @davidedmundson If the associated bug is fixed, it should be closed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

Re: KHolidays as Framework (redux)

Am 20.01.2018 17:22 schrieb "Volker Krause" <vkra...@kde.org>: Thanks, should be fixed now. Certainly better, although code examples and the like still would make a significant difference ;) Cheers Dominik On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: &g

Re: KHolidays as Framework (redux)

Hi, CC: only kdepim, kde-frameworks-devel I have some general comments about the API documentation. Looking at https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html the list mostly (only?) contains classes that are internal. Looking at

D9987: Lessen log spam by not checking for existence of file with empty name

dhaumann added a comment. +1, but someone else must approve. You could even add this as comment: // check for empty string to avoid warning message in QFileExists. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: dhaumann

D9766: Use at least the requested width for the argument hint tree

dhaumann added a comment. I would prefer if you commit this soon, since then we still have 3 weeks for testing. To me this look ok, but I cannot say whether there are side-effects or not. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff,

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

dhaumann added subscribers: dfaure, dhaumann. dhaumann added a comment. @dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on kde-distro-packag...@kde.org, since this breaks Kate. Second question: How did this happen in the

D6831: Make use of kauth helper in methods of file ioslave

dhaumann added a comment. Ok, good :) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6831 To: chinmoyr, dfaure, #frameworks Cc: dhaumann, #frameworks

D6831: Make use of kauth helper in methods of file ioslave

dhaumann added a comment. Without looking too much into details of the patch: what happens, if you are already root? Does that work as expected? I am asking, since we introduced regressions into Kate since using kauth to save data with elevated privileges: Kate disallows running as

D9571: clang-tidy modernize-use-override

This revision was automatically updated to reflect the committed changes. Closed by commit R39:225d774b5219: clang-tidy modernize-use-override (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9571?vs=24508=24535 REVISION DETAIL

Required Compiler for KDE Frameworks

Hi, on https://community.kde.org/Frameworks/Policies, it says: The following minimal compiler versions are supported by KDE Frameworks: - GCC 4.6 - Clang 3.1 - VS2012 (MSVC11) Is this list really up-do-date? Afaik, we even require VS2015 these days. What about the others? Also: Can

D9569: Fix wildcard matching for modelines

This revision was automatically updated to reflect the committed changes. Closed by commit R39:eff6bd61e2d7: Fix wildcard matching for modelines (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9569?vs=24503=24505 REVISION DETAIL

D9569: Fix wildcard matching for modelines

dhaumann added a reviewer: nalvarez. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9569 To: dhaumann, cullmann, kfunk, mwolff, nalvarez Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

dhaumann added inline comments. INLINE COMMENTS > dfaure wrote in highlighter.h:134 > The -1 special value is documented here, but yeah, special values are bad. > > In practice SpellCheckDecorator calls this with the default value anyway. > > And I guess any GUI will always want to limit this,

D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:79ca6ce4ec6a: Highlighting indexer: Warn about context switch fallthroughContext=#stay (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D9494: Highlighting indexer: Warn about empty attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d84035c61eac: Highlighting indexer: Warn about empty attributes (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

dhaumann accepted this revision. dhaumann added a comment. Good enough :) INLINE COMMENTS > highlighter.cpp:487 > +QStringList suggestions = d->spellchecker->suggest(word); > +if (max != -1 && suggestions.count() > max) { > +suggestions = suggestions.mid(0, max); I am not a

D9494: Highlighting indexer: Warn about empty attributes

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the highlighting indexer to search for attribute="". Referencing an empty

D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY A fallthroughContext="#stay" is always wrong if fallthrough="true" is set, since in this

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added a comment. @neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough. REPOSITORY R39 KTextEditor BRANCH SearchMessages (branched from master) REVISION DETAIL

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added a comment. That could very well be the case. Another possibility would be to simply show an icon, like Qt Creator does it. Or change the text, but I tried to avoid long messages (which will be a possible issue in translations anyways)... Suggestions welcome :-)

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added reviewers: kfunk, mwolff. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added a comment. Example for a wrapping search at bottom, continuing at top: F073: image.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann Cc: #frameworks, kevinapavew,

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann created this revision. dhaumann added reviewers: neundorf, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch uses the "CenterInView" message position instead of "TopInView" and

D9393: MessageInterface: Add CenterInView as additional position

This revision was automatically updated to reflect the committed changes. Closed by commit R39:fc7433321d36: MessageInterface: Add CenterInView as additional position (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9393?vs=24059=24061#toc REPOSITORY R39

D9393: MessageInterface: Add CenterInView as additional position

dhaumann updated this revision to Diff 24059. dhaumann added a comment. - Add @since 5.42 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9393?vs=24058=24059 BRANCH MessageInterface (branched from master) REVISION DETAIL

D9257: MessageInterface: Add CenterInView as additional position

dhaumann abandoned this revision. dhaumann added a comment. Abandoned in favor of followup request: https://phabricator.kde.org/D9393 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9257 To: dhaumann, cullmann, neundorf Cc: #frameworks, kevinapavew, ngraham,

D9393: MessageInterface: Add CenterInView as additional position

dhaumann added a comment. @cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, kevinapavew, ngraham,

D9393: MessageInterface: Add CenterInView as additional position

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the message interface to support CenterInView. This should be binary

D9257: MessageInterface: Add CenterInView as additional position

dhaumann added a comment. ping? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9257 To: dhaumann, cullmann, neundorf Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9217: KUriFilter: don't return an error on non-existing files.

dhaumann added a comment. @dfaure Better push today than one day before release. ;) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi, dhaumann Cc: dhaumann, broulik, #frameworks

D9377: Highlighting indexer: Enable errors

This revision was automatically updated to reflect the committed changes. Closed by commit R216:f521183c4cc2: Highlighting indexer: Enable errors (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9377?vs=24027=24028 REVISION

D9377: Highlighting indexer: Enable errors

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Erros include: - missing contexts - duplicate contexts - missing itemDatas - missing keyword

D9374: Highlighting indexer: report unused itemDatas and missing itemDatas

This revision was automatically updated to reflect the committed changes. Closed by commit R216:412f5a7e705c: Highlighting indexer: report unused itemDatas and missing itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6b9c12981391: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9cdf1bee0dd3: Prolog, RelaxNG, RMarkDown: Fix highlighting issues (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9376?vs=24023=24024#toc REPOSITORY R216 Syntax

D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixRemaining (branched from master) REVISION

D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixMoreXmlFiles (branched from master) REVISION

D9374: Highlighting indexer: report unused itemDatas and missing itemDatas

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With this patch, all issues are revealed, and not only missing itemDatas. TEST PLAN make test

D9373: Haml: Fix invalid and unused itemDatas

This revision was automatically updated to reflect the committed changes. Closed by commit R216:91ca8ca39f66: Haml: Fix invalid and unused itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9373?vs=24017=24018

D9373: Haml: Fix invalid and unused itemDatas

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixHaml (branched from master) REVISION DETAIL

<    4   5   6   7   8   9   10   11   12   13   >