D10747: Implement zwp_linux_dmabuf_v1

fredrik added a comment. In D10747#237235 , @romangg wrote: > Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a du

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik updated this revision to Diff 29832. fredrik added a comment. Rebase on master. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10251?vs=26374&id=29832 REVISION DETAIL https://phabricator.kde.org/D10251 AFFECTED FILES src/dec

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. In D10251#227092 , @broulik wrote: > What's the state of this? Bug 391915 just cropped up There are still some issues with the cubic filter, and I've been distracted by other things lately. I think we should con

D10747: Implement zwp_linux_dmabuf_v1

fredrik updated this revision to Diff 28986. fredrik added a comment. Import the context. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=27735&id=28986 REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES src/client/protocols/li

D10747: Implement zwp_linux_dmabuf_v1

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > linuxdmabuf_v1_interface.h:39 > + > +namespace LinuxDmabuf > +{ Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer etc. instead.

D10747: Implement zwp_linux_dmabuf_v1

fredrik created this revision. fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. Restricted Appl

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. Before and after: F5688790: before-after.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraha

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik created this revision. fredrik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Blit the contents of the window texture

D10173: windowthumbnail: Fix the GLXFBConfig selection code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig selection code (authored by fredrik). REPOSITORY R242 Plasma Fram

D10173: windowthumbnail: Fix the GLXFBConfig selection code

fredrik created this revision. fredrik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Check that the sizes of the color channels i

D10090: Downgrade not finding smb.conf from warning to debug

fredrik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10090 To: aacid, fredrik Cc: #frameworks

Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes

On Monday 06 February 2017, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sysadmin will >

[Differential] [Abandoned] D4228: Add an image/ktx mimetype

fredrik abandoned this revision. fredrik added a comment. Closing as the upstream patch has been pushed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fredrik, #framework

[Differential] [Commented On] D4228: Add an image/ktx mimetype

fredrik added a comment. I've created a bug report in the freedesktop bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99483 I'll leave this revision open until the bug report is closed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL P

[Differential] [Commented On] D4228: Add an image/ktx mimetype

fredrik added a comment. In https://phabricator.kde.org/D4228#78967, @ltoscano wrote: > Was the request submitted to shared-mime-info too? It was not. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Request, 9 lines] D4228: Add an image/ktx mimetype

fredrik created this revision. fredrik added a reviewer: Frameworks. fredrik set the repository for this revision to R244 KCoreAddons. Restricted Application added a project: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 AFFECTED FILES src/mimety

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

texture ID's are silently ignored by glDeleteTextures(). That doesn't mean it's a good idea to do it, since a texture ID can be reused for a different texture after it's been passed to glDeleteTextures(). But regardless, it shouldn't crash as long as the textures poi

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

for WM_CHANGE_STATE as the > create_atoms() function is not yet ported to xcb. I actually have a port of that function that I forgot to push. I should see if I can find that patch. - Fredrik Höglund On May 22, 2014, 6:53 a.m., Martin Gräßlin

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

> On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: > > given the ratio by this property is set (often) and read (rarely), i wonder > > whether we could establish a semi-async functionality, where the client > > sends a message to have the property updated, then syncs, reads and returns > > the

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

multiple outputs. An output represents a section of the screen geometry that's visible on a monitor. The ID returned by activeScreen() is an output ID. The documentation should explain how the active output relates to the primary output, and how the client is expected to use each. - Fr

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? > > Fre

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? The default de

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

ard.kde.org/r/112755/#comment30871> What if the host byte order is not little endian? - Fredrik Höglund On Oct. 24, 2013, 10:22 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

ed to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes to load the images for the theme. - Fredrik Höglund On Oct. 24, 2013, 2:19 p.m., Martin Klap

Re: Review Request 112896: Rework NETWM classes

> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrot

Re: Review Request 112896: Rework NETWM classes

know since we've discussed it many times; that an xcb port of the NETWM classes already exists in a branch. - Fredrik Höglund On Sept. 23, 2013, 1:11 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generat

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. Kevin, please don't take this the wrong way, but it would be enormously helpful

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Sept. 16, 2013, 12:16 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kxutils_p.h, line 49 > > <http://git.reviewboard.kde.org/r/112755/diff/1/?file=189772#file189772line49> > > > > This statement is no longer true. If the pixmap is not an ARGB

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

board.kde.org/r/112755/#comment29676> This statement is no longer true. If the pixmap is not an ARGB32 pixmap, the function will crash. It will also fail if the image byte order doesn't match the CPU byte order, if the mask has the wrong size, or the mask isn't a bitmap. - F

Re: kxerrorhandler duplicate

On Friday 14 June 2013, Benjamin Port wrote: > In the kdeui crumble I'm currently on: KWindowsSystem, there is a task for > ./util/kxerrorhandler.h but KWindowsSystem have already one kxerrorhandler. > So I don't know what I need to do. > The 2 files are really similar only one deprecated construc

Re: What to do with kjs & qkjs ?

On Saturday 15 December 2012, Alexander Neundorf wrote: > Hi, > > for kjs there is also a QT_ONLY option. > In this case the library is named qkjs instead of kjs. kjs doesn't actually link to or use Qt, so it probably doesn't make sense to have this option. The only thing it does is change the na

Re: Fwd: [kdelibs/frameworks] tier1/kidletime/src: Port the native event filtering to XCB, to fix compilation with Qt5.

On Thursday 26 July 2012, David Faure wrote: > On Wednesday 25 July 2012 17:10:57 Fredrik Höglund wrote: > > They use the freedesktop bugzilla, and there's also an xcb mailinglist > > there. > > Actually the bug has been reported to the freedesktop bugzi

Re: Fwd: [kdelibs/frameworks] tier1/kidletime/src: Port the native event filtering to XCB, to fix compilation with Qt5.

On Wednesday 25 July 2012, David Faure wrote: > Hi Fredrik, > I made progress with the port of kidletime to XCB, but I found a bug in XCB... > > xcb/sync.h says (with my comments added about field size) : > > typedef struct xcb_sync_systemcounter_t { > xcb_sync_counter_t counter; /**< */

Re: Porting the NETWM classes to xcb

I have pushed an update to this branch that moves the xcb includes to the .cpp file as suggested by Christoph. I also fixed some 64 vs 32 bit issues discovered by Philipp Knechtges while testing. It's apparently also an issue that some Linux distributions are shipping old versions of xcb that are

Re: xlib plugin is dead (for Qt5)

On Wednesday 28 March 2012, Rick Stockton wrote: > In a merge earlier today, Qt-Project removed the xlib support code form > Qt5. (I was not the Approver, but I did vote "+1" on the change). For > X11 environments, xcb will be it's replacement. Wayland is also a > "primary" platform, but IMO not

Re: Porting the NETWM classes to xcb

On Sunday 25 March 2012, Christoph Feck wrote: > Is it really required to expose xcb headers to applications, that wish > to use the netwm header file? If not, please move to netwm_p.h file. The idea is to eventually replace the Xlib types used in the parameters to the constructors and methods in

Porting the NETWM classes to xcb

ongit.kde.org/clones/kdelibs/fredrik/kdelibs.git netwm-xcb Please review. Fredrik Höglund (32): cmake: Add FindXCB.cmake and FindX11XCB.cmake kdeui: Link to libxcb and libX11-xcb kdeui: Store a pointer to the xcb connection in NETRootInfoPrivate kdeui: Store a pointer to t