Re: Noteworthy changes when porting to C++17

find it more readable then lambdas. And it is optimized out by good compilers (tested on gcc 10) just as lambdas are. std::ranges::all_of(vs, _t::check); versus std::all_of(..., std::mem_fn(_t::check)); versus std::all_of(..., [] (const some_t& t) { return t.check(); }); Cheers, Ivan

Re: Information regarding upcoming Gitlab Migration: clarifications

both sentiments - that projects should have different names and that this is a bit off topic for the gitlab migration. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Update on Status of Gitlab Migration

Hi all, While I do like the invent name, I agree there should be a redirect of some sort from git.kde.org to it. The aforementioned Debian salsa server has one as well - https:// git.debian.org/ - a message stating that the new server is 'salsa.debian.org' Cheers, Ivan -- dr Ivan Čukić i

D28746: Show previews on encrypted filesystems

ivan accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28745: Skipping catching of thumbnails on encrypted filesystems

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28746: Show previews on encrypted filesystems

ivan added inline comments. INLINE COMMENTS > previewjob.cpp:697 > > !currentItem.item.url().adjusted(QUrl::RemoveFilename).toLocalFile().startsWith(thumbRoot)) > -&& !sequenceIndex; > +&& !sequenceIndex && !isEncrypted; > QImage thumb;

D28746: Show previews on encrypted filesystems

ivan added inline comments. INLINE COMMENTS > previewjob.cpp:692 > { > +bool isEncrypted = > encryptedMountsList.findByPath(currentItem.item.url().toLocalFile()); > bool save = bSave && `const` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To:

D28745: Skipping catching of thumbnails on encrypted filesystems

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > thumbnail.cpp:730 > +const auto thumbRootMount = mountsList.findByPath(thumbRoot); > +std::copy_if(mountsList.begin(), mountsList.end(), >

D24401: Use exposed DBus methods to switch activities in CLI

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH cli-nextprev-activity (branched from master) REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D26798: Fix broken SQL query in allResourcesQuery

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D26798 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KApplicationTrader API

:query(...); +1, no need to put everything in an object. > Note that the least-porting-effort solution is self() and trader language, > since the code currently uses KServiceTypeTrader for this. I'm aware I voted for the most-porting-effort solution ;) Cheers, Ivan -- dr Ivan Čukić KDE, i

D26415: Ensure to store resource uri without a trailing slash

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well. REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D26415

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Just add TODO and you are free to push INLINE COMMENTS > meven wrote in resultset.h:78 > `url` makes more sense to me, no need to decorate it, this is idiomatic > KDE/Qt. `toUrl` might make

Re: Framework for encrypted storage for apps

(though, flatpaks could maybe have some solution there as well, not my area) Cheers, Ivan -- dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23736 REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

ivan added inline comments. INLINE COMMENTS > terms.h:106 > + */ > +static Type locations(); > Can we call it `directories` to follow the Qt API? That is the only complaint I have, otherwise thie is quite a nice addition. REPOSITORY R159 KActivities Statistics REVISION

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D23736: Add a Term::Type::files() to filter excluding directories

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Add the same for directories for completeness REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: kde-frameworks-devel,

D23555: Add @since 5.62 for newly added setters

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23555 To: meven, ivan, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23556: Add version requirement to dependency KActivitiesStats

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23556 To: meven, #frameworks, kossebau, ivan Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe,

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Filtering can be done as far as the KAStats is concerned. The question is how to know inside the KIO slave which application requested its services. REPOSITORY R320 KIO Extras BRANCH

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added inline comments. INLINE COMMENTS > kactivities-stats.categories:1 > +org.kde.kactivities.stats KActivities Stats DEFAULT_SEVERITY [WARNING] > IDENTIFIER [KACTIVITY_STAT_LOG] Missed one here > CMakeLists.txt:21 > +HEADER

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Change everything to plural. I agree with @kossebau, though I don't think it will lead to problems in future, so I could say it is bearable dirtyness. INLINE COMMENTS >

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

ivan added inline comments. INLINE COMMENTS > query.h:105 > +void setUrlFilters(const QStringList ); > +void setType(const Terms::Type ); > +void setAgent(const Terms::Agent ); I screwed up the names - plurals vs singulars here as `Agent` can contain several agents - having

D23393: Use special values constants in terms.cpp

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23393 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > We don't have yet set function for Activity, Type, Agent, and Url only add. > Which means we would need to use query.addActivity(QStringList() << ":any")) > sometimes for instance, that is not ideal since it

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > Tried implementing this in D23372 but > @ivan was not found of it because of induced complexity it entails to work > properly. Also, there are `set*` and `add*` member

D23372: Add operator |= for Query Terms

ivan added a comment. You can also use `set*/add*` member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say `set*/add*` is a

D23372: Add operator |= for Query Terms

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. This is something I did have initally in kastats, it was killed because while this is tempting query |= Type(types); it ruins the idea of the chaning API because it can

D22775: Allow date range filtering of resource events using Date Term

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Sorry I missed this one. If I don't react on a ping here, just send me a direct mail. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added a comment. Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel,

D23112: Add a event Spy for GtkFileChooser recent files

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R161 KActivity Manager Service BRANCH arcpatch-D23112 REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n,

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Another tiny change, and I think it is ready to land. Unless someone else sees other issues. INLINE COMMENTS > GtkEventSpy.cpp:126 > + > +if (exec.at(0) ==

D23112: Add a event Spy for GtkFileChooser recent files

ivan added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:68 > +QDateTime visited; > +QList *applications; > + No need for this to be a pointer to a list. Make it just `QList applications`. > GtkEventSpy.cpp:70 > + > +Bookmark(){ > +applications = new QList(); The

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Thanks for geting involved this much! INLINE COMMENTS > GtkEventSpy.cpp:129 > +// remove "'" caracters wrapping the command > +exec = exec.mid(1, exec.size() -2 ); >

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added a reviewer: kossebau. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added a comment. If @kossebau is satisfied, go for it REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan added inline comments. INLINE COMMENTS > resultset.cpp:293 > SELECT > -rl.targettedResource as resource > - , SUM(rsc.cachedScore) as score > - , MIN(rsc.firstUpdate) as firstUpdate > - , MAX(rsc.lastUpdate) as lastUpdate

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Joining with `ResourceEvent` is a problem. At least make it not get joined if the date filter is not present. INLINE COMMENTS > QueryTest.h:53 > void

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentlyused.cpp:140-144 > +if (agentValue.contains(QLatin1Char(','))) { > +query = query | Agent(agentValue.split(QLatin1Char(','))); > +

D22082: WIP Add an ioslave to access KActivityStat data

ivan added a comment. I'd add support for `HighScoredFirst` and `RecentlyCreatedFirst`. Maybe the protocol could be something like "used:/" or something. It should also support getting items for the current activity, or all recently used items. REPOSITORY R159 KActivities Statistics

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D22091 REVISION DETAIL https://phabricator.kde.org/D22091 To: meven, ivan, broulik, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh,

D20938: Add Mounts Backend

ivan added a comment. WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself. It works with 'fuse.*'

D20938: Add Mounts Backend

ivan added a comment. @ngraham I guess that **is** the main point of this patch. I don't think that anyone is against that. :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc:

D20938: Add Mounts Backend

ivan added a comment. I'm torn between two approaches: - doing what you have done, maybe with a customization point - `fusermount -u` by default, something else for specific mount types; - disabling the teardown operation The rationale for the second one: - The users which

D20938: Add Mounts Backend

ivan added a comment. Thanks for working on this. I'd probably call this `fusemounts` backend as it handles only FUSE mounts and nothing else. As for the //teardown// operation, some FUSE backends (cryfs >0.10) have their own unmount commands instead of `fusermount -u`. REPOSITORY

D19979: Don't create thumbnails for encrypted Vaults

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bc42a1b2f913: Dont create thumbnails for encrypted Vaults (authored by ivan). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19979?vs=54673=54678 REVISION DETAIL

D19979: Don't create thumbnails for encrypted Vaults

ivan updated this revision to Diff 54673. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19979?vs=54582=54673 REVISION DETAIL https://phabricator.kde.org/D19979 AFFECTED FILES src/widgets/previewjob.cpp To: ivan, davidedmundson, dfaure Cc: broulik,

D19979: Don't create thumbnails for encrypted Vaults

ivan marked an inline comment as done. ivan added inline comments. INLINE COMMENTS > broulik wrote in previewjob.cpp:307 > Did you profile the impact of this call? I don't think it's cached. Can this > maybe be moved to the thumbnail KIO so it's done out of process? I didn't do any profiling.

D19986: Install .desktop file for kded5

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

ivan edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

ivan retitled this revision from "Don't create thumbnails for encrypted drives (Vaults)" to "Don't create thumbnails for encrypted Vaults". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D19979: Don't create thumbnails for encrypted drives (Vaults)

ivan updated this revision to Diff 54582. ivan added a comment. Incorporated David's advice REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19979?vs=54577=54582 REVISION DETAIL https://phabricator.kde.org/D19979 AFFECTED FILES src/widgets/previewjob.cpp

D19979: Don't create thumbnails for encrypted drives (Vaults)

ivan created this revision. ivan added reviewers: davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ivan requested review of this revision. REVISION SUMMARY This patch makes PreviewJob skip thumbnail generation on fuse.encfs and

D16250: Use lambdas instead of std::bind()

ivan added a comment. @davidedmundson Lambdas are generally faster to compile and execute. `std::bind` can make code less verbose, but that is not the case here. @bruns Well... Qt has quite a few strange guidelines that we don't follow :) REPOSITORY R127 KWayland REVISION

D16250: Use lambdas instead of std::bind()

ivan added a comment. The parentheses are not necessary when a lambda has no arguments. [something]() { ::: } can become: [something] { ::: } KWin uses both of these from what I've seen. Personally, I prefer the second. Otherwise, +1 for the change. REPOSITORY

Re: Password field security and information leaking

t, we could provide a nice pinentry-kde if we wanted that supports the pinentry protocol and adds our own extensions for encrypted communication. Cheers, Ivan dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Password field security and information leaking

all my passwords without any > need to snoop at the transport layer. That is a completely separate issue. KWallet design is broken. > I've been thinking about that for a while and the only solution i've found > is signing the binaries. I agree. It would be nice if someone wanted to work on

Password field security and information leaking

is already compromised and that we can not do anything to protect the user. Thoughts? Cheers, Ivan [1] https://codereview.qt-project.org/#/c/242202/ [2] https://specifications.freedesktop.org/secret-service/index.html dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key

D13980: Honor BUILD_TESTING

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D13980 To: arojas, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: bic in kactivities

Marco, thanks for reverting this. @Laurent The proper change for the constructor should be to make the Private class take the shownStates by value (a sink constructor argument) and for the ActivitiesModel constructor to std::move it when passing to the Private constructor. @All - ` explicit`

Re: [kcoreaddons] src/lib: Revert "Warning--"

Sorry for the noise, saw that the patch was fixed and committed again. Gah...

Re: [kcoreaddons] src/lib: Revert "Warning--"

Hi Ben, Is it possible to have cgit.kde.org show commit hashes in the 'log' tab (for example [1])? As for the Laurent's patch, it looks quite sane, so I guess the failed compilation for other platforms should be investigated further (I've put Laurent in the TO: field because of this). Cheers,

Re: Experimental class in baloo

party plugins or applications to be linked against, then David's comment was right. On Thu, Mar 22, 2018 at 6:49 PM, Ivan Čukić <ivan.cu...@kde.org> wrote: > Hi, > > Is this a class that is supposed to be available in the library (.so > file) - to be used in applications that use ba

Re: Experimental class in baloo

Hi, Is this a class that is supposed to be available in the library (.so file) - to be used in applications that use baloo, or is it only a class in the backend? If it is the second case (which I guess it is since I don't see the symbols exported in libKF5Baloo.so), then this should not be a

Re: D11193: Sonnet : use current hunspell API

You should probably add the sonnet maintainer (or whoever committed the most to the repository in recent months) as the reviewer. Cheers, Ivan On Tue, Mar 13, 2018 at 10:26 AM, René J. V. Bertin wrote: > Silence means acceptance? > -- KDE, ivan.cu...@kde.org,

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. The fix needs to be a bit more complex. We can not really rely on the user to fix the database. The current plan is to have kamd backup the important parts of the database from time to time, and to recreate the database when needed. I'll see whether I can roll

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. @hein This is not really as simple as 'accept without a comment'. I don't mind this patch to be merged, but keep in mind that it just turns users for which plasma crashes (for which we get an explicit message as to why) into users who do not have certain parts

D4906: Fix kactivities-stats into tier3

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. This is a good point. * I'll make this lower again when I remove KConfig from KActivities/imports. *Though, KActivities imports are tier 2 (the KIO dep was removed some time ago -

D4847: KAuth integration in document saving

ivan added subscribers: lbeltrame, ivan. ivan added a comment. @lbeltrame I don't really see 'reasoning' in that report more than something that sounds like 'polkit is a hack to replace suid for setting the system time and time zone'. REPOSITORY R39 KTextEditor REVISION DETAIL

D4633: WIP: Updated folder decrypted and encrypted icons

ivan added a comment. I didn't want to change the current icon that much. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 To: ivan, andreaska, alex-l Cc: #frameworks

D4906: Fix kactivities-stats into tier3

ivan added a comment. View RevisionKActivities is tier 1 even if the metainfo.yaml says otherwise. It only requires boost. So, this should be changed in KActivities, not in KActivitiesStatsREPOSITORYR159 KActivities StatisticsREVISION DETAILhttps://phabricator.kde.org/D4906EMAIL

Re: Differential e-mail subject re-arrangement

> [Differential] D4508: Plasma controls based on QtQuickControls2 [Commented > On] > > I personally find that having a "vertical" line in which all the subjects of > the differential emails start makes it much easier to read. +1 I'd even shorten The 'Differential' part of it to just 'Diff'.

[Differential] [Commented On] D4633: WIP: Updated folder decrypted and encrypted icons

ivan added a comment. Or a bit different: F2501511: icons-again.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan,

[Differential] [Updated] D4633: WIP: Updated folder decrypted and encrypted icons

ivan retitled this revision from "Updated folder decrypted and encrypted icons" to "WIP: Updated folder decrypted and encrypted icons". ivan updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES

[Differential] [Updated, 152 lines] D4633: Updated folder decrypted and encrypted icons

ivan updated this revision to Diff 11410. ivan added a comment. - Small issue with line borders REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4633?vs=11409=11410 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4633 AFFECTED FILES

[Differential] [Updated] D4633: Updated folder decrypted and encrypted icons

ivan updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, alex-l, andreaska Cc: #frameworks

[Differential] [Request, 159 lines] D4633: Updated folder decrypted and encrypted icons

ivan created this revision. ivan added reviewers: alex-l, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The current icons have a nice idea, but the horizontally-cut checkers look a bit like a

[Differential] [Commented On] D4626: Renamed icons for encrypted and decripted folders

ivan added a comment. I will use them, but don't do that just yet - I want to propose some changes to them. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4626 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, alex-l,

[Differential] [Closed] D4626: Renamed icons for encrypted and decripted folders

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b79085c027c0: Renamed icons for encrypted and decripted folders (authored by ivan). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4626?vs=11385=11386#toc REPOSITORY R266 Breeze Icons

[Differential] [Request, 958 lines] D4626: Renamed icons for encrypted and decripted folders

ivan created this revision. ivan added reviewers: alex-l, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since the icons are in places, not in actions, changed the names to imply state, not action.

[Differential] [Request, 799 lines] D4625: Icons for Plasma Vault

ivan created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Merge branch 'master' into ivan/plasmavault-icons REPOSITORY R266 Breeze Icons BRANCH ivan/plasmavault-icons REVISION DETAIL

[Differential] [Closed] D4624: Added arc config file

This revision was automatically updated to reflect the committed changes. Closed by commit R266:bc60e3c2f85f: Added arc config file (authored by ivan). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4624?vs=11382=11383 REVISION DETAIL

[Differential] [Request, 3 lines] D4624: Added arc config file

ivan created this revision. ivan added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Added arc configuration file REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4624 AFFECTED FILES .arcconfig

[Differential] [Accepted] D3850: Pass -fno-operator-names when supported

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Fine by me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES

Re: To C++11 or not?

Hi all, I find it strange (not to say disappointing) that we are even talking about C++11 in 2016. +1 for the proposal. I wanted to start discussions about C++14 (the "bugfix" release of C++), but I'll wait until this discussion is finished. :) Cheers, Ivan

Re: KDE Frameworks & Plasma 5.8 LTS

> 2. We provide KF 5.26.1 This would mean that we should also provide 5.27.1 (and .2, .3) for the distros that use KF 5.27 with the LTS release. I'd love to have distros to **properly update KF** during the 5.8 LTS life, but if we can not get them to do so, I agree that we need to find an

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97992 --- Ship it! Ship It! - Ivan Čukić On Aug. 2, 2016, 5:47

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

ter. Or am I missing something? - Ivan Čukić On Aug. 1, 2016, 3:27 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

Re: Review Request 128466: Rename Checksums tab to Integrity

the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button to calculate ... maybe I should try again and > maybe I should just use

  1   2   3   >