ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.
Change everything to plural.
I agree with @kossebau, though I don't think it will lead to problems in
future, so I could say it is bearable dirtyness.
INLINE COMMENTS
> CMakeLists.txt:22
> + # Generated by macro ecm_qt_declare_logging_category in src/CMakeLists.txt
> + ${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp
> +
plural `stats`
> kactivities-stats.categories:1
> +org.kde.kactivities.stats KActivities Stats DEFAULT_SEVERITY [WARNING]
> IDENTIFIER [KACTIVITY_STAT_LOG]
You mixed singulars and plurals - go for plurals everywhere:
`s/KACTIVITY_STAT_LOG/KACTIVITIES_STATS_LOG/g`
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D22143
To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
