Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

tps://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/60c21962-396e-468e-add9-e7112c49d7ba__firefox.desktop Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92316 --- +1 I'm happy with this change :) - Kåre Särs On Fe

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

> On Feb. 12, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > elseif? > > Andreas Cord-Landwehr wrote: > Sure? I must admit, my Windows compiler foo is not very elaborat

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

> On Feb. 12, 2016, 12:02 a.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > maybe it should be `#ifdef libintl-lite` no? > > Andreas Cord-Landwehr wrote: > Also regarding Kare's comm

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

we get an #ifdef that checks for libintl-lite? - Kåre Särs On Feb. 11, 2016, 7:11 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 127033: Add /../share/hunspell/ to dictionary search path

spelling to work :) It is now possible to add dictionaries to a relocatable /../share/hunspell/ and get spelling to work without depending on LibreOffice installation on Windows. Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

inMetaData::fromDesktopFile()](http://api.kde.org/frameworks-api/frameworks5-apidocs/kcoreaddons/html/classKPluginMetaData.html#ac6e87c110b4743ce1b16044c649838ba) > although any users should probably be using JSON files directly. > > Kåre Särs wrote: >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > > Boudew

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

uot; returns the original URL stripped of it's fileName. For remote files "options()->initialDirectory()" returns the original URL unchanged. - Kåre --- This is an automatically generated e-mail. To repl

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

in Qt instead (and > > this code can be kept with a #ifdef QT_VERSION if you want). > > > > The method is called setDirectory, I expect it to get a directory. > > Kåre Särs wrote: > OK, but what whould I put as QT_VERSION? ;) The bug is present in a

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91545 --- On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote: > > --- &g

Review Request 126876: Fix QFileDialog::openUrl() for remote files

setDirectoy() is called from two places. Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb Diff: https://git.reviewboard.kde.org/r/126876/diff/ Testing --- Kate now happily opens local and remote folders :) Thanks, Kåre Särs

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

s is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126764/#review91214 --- On Jan. 24, 2016, 8:51 p.m., Kåre Särs wrote: > > --- > This i

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

have a leading slash in the Search in files KUrlRequester Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > <https://git.reviewboard.kde.org/r/126735/diff/2/?file=430620#file430620line47> > > > > QStringLiteral with multiple string initializers d

Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

;) Untill it is fixed this is a workaround for this place. Diffs - src/widgets/kurlrequester.cpp 06e9ddb Diff: https://git.reviewboard.kde.org/r/126764/diff/ Testing --- Kate on windows does not now have a leading slash in the Search in files KUrlRequester Thanks, Kåre Särs

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

/r/126618/diff/ Testing --- KTextEditor compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > <https://git.reviewboard.kde.org/r/126735/diff/2/?file=430620#file430620line47> > > > > QStringLiteral with multiple string initializers d

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

to not suggest this change... - Kåre Särs On Jan. 14, 2016, 12:24 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

I'll update the error printout. - Kåre ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126618/#review90496 ---

Re: Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b62e23aaf4e98475f6f2bc190f47eac41abf8b19 by Kåre Särs to branch master. Repository: kxmlgui Description --- Strings that are separated into multiple parts don't work on Windows together

Re: Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 7937b0235e338be08a4ab95c5d526d971bce24e7 by Kåre Särs to branch master. Repository: ktextwidgets Description --- Strings that are separated into multiple parts don't work on Windows tog

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8404d55c95b59c4d885cf248722d89fb902c03ec by Kåre Särs to branch master. Repository: knewstuff Description --- Strings that are separated into multiple parts don't work on Windows together

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 54e7899d499105e9ea4bb4c0955372616bf7c3bb by Kåre Särs to branch master. Repository: ki18n Description --- Strings that are separated into multiple parts don't work on Windows together

Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

122af8 Diff: https://git.reviewboard.kde.org/r/126618/diff/ Testing --- KTextEditor compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- src/kbugreport.cpp b43f3c4 Diff: https://git.reviewboard.kde.org/r/126617/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

arl() with QLatin1String() Diffs - src/widgets/krichtextedit.cpp 805fbe3 Diff: https://git.reviewboard.kde.org/r/126616/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

arrow (8bit) string. (Copy pasted from Patrick Spendrin's RR) Replacing QStringLitearl() with QLatin1String() Diffs (updated) - src/ui/itemsviewdelegate.cpp 8a891ba Diff: https://git.reviewboard.kde.org/r/126615/diff/ Testing --- Compiles again on windows Thanks,

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

.kde.org/r/126615/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

iff: https://git.reviewboard.kde.org/r/126614/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126615: Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

arl() with QLatin1String() Diffs - src/CMakeLists.txt cc60644 src/ui/itemsviewdelegate.cpp 8a891ba Diff: https://git.reviewboard.kde.org/r/126615/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailin

Review Request 126614: Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- src/kuitmarkup.cpp 9831b34 Diff: https://git.reviewboard.kde.org/r/126614/diff/ Testing --- Compiles again on windows Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Dec. 4, 2015, 9:35 a.m., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to > >

Re: Review Request 125784: fix windows compilation of autotests

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 6262ea31841072b988b8f7665a384f03d46490ab by Kåre Särs to branch master. Repository: kio Description --- The #ifdefs skips the new symlink tests but did not prevent the usage of

Review Request 125784: fix windows compilation of autotests

Description --- The #ifdefs skips the new symlink tests but did not prevent the usage of the new function which is #ifdef:ed out Diffs - autotests/jobtest.cpp 4b3598d Diff: https://git.reviewboard.kde.org/r/125784/diff/ Testing --- Compiles on windows again Thanks, Kåre Särs

Re: Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

->directory() of the just deleted m_dialog ;) - Kåre Särs On July 15, 2015, 3:29 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.k

Re: Review Request 123930: WIP: Make the speller dict cache static.

might be a good change, but I'll let people with more experience with sonnet give the thumbs up or down. Meanwhile I wonder why ktexteditor calls m_backgroundChecker->setSpeller(m_speller) on every cal to performSpellCheck(). - Kåre Särs On May 28, 2015, 11:45 p.m., Milian Wol

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

marked as submitted. Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 28f74f1d4c6c0331df957463381d2f2b8936a801 by Kåre Särs to branch master. Repository: sonnet Description --- The curent implementation can

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

copy assignment, but I don't dare to give a "ship it" as I'm not that familiar with the code. - Kåre Särs On maj 19, 2015, 9:49 f.m., Milian Wolff wrote: > > --- > This is an automatically generate

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

the settings automatically on destruction. I'll add comments :) - Kåre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review80631 ---

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

b5c4198 src/core/settings_p.h 0d48889 src/core/speller.cpp 3903b42 src/ui/configwidget.cpp 02f2a26 Diff: https://git.reviewboard.kde.org/r/123341/diff/ Testing (updated) --- Tested with Kate and with the patch the startup time was back to "normal". Two unit tests added. Tha

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

Diff: https://git.reviewboard.kde.org/r/123341/diff/ Testing --- Tested with Kate and with the patch the startup time was back to "normal". Two unit tests added. Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-framew

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

modifying the Sonnet settings? - Kåre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review78846 --- On April 12, 2015, 5:57 p

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

artup time was back to "normal". No test cases :( Thanks, Kåre Särs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

/settings_p.h 0d48889 src/core/speller.cpp 3903b42 src/ui/configwidget.cpp 02f2a26 Diff: https://git.reviewboard.kde.org/r/123341/diff/ Testing --- Tested with Kate and with the patch the startup time was back to "normal". No test cases :( Thanks,

Re: KF 5.6 changelog

On Wednesday 07 January 2015 15:01:39 Jonathan Riddell wrote: > > * Depend on libgit2 0.21.0 rather than unreleased 0.22.0 > > This seems not to be the case, top changelog item in ktexteditor currently > is "Depend on libgit2 v0.22.0 (older version is broken)" > Yes that commit to depend on 0.21

Re: OSX/CI: kate builds to fail on branch master

Hi, Sorry about the missing includes... Hopefully commit 90990abbaf3fef450a353ba2cb245f8def303324 will fix it. /Kåre On Wednesday 22 October 2014 00:10:11 Marko Käning wrote: > [ 86%] Building CXX object > addons/katesql/CMakeFiles/katesqlplugin.dir/exportwizard.cpp.o [ 86%] Built > target kate

Re: What to do with KScanDialog

Hi, On Saturday 31 August 2013 20:48:46 Gilles Caulier wrote: > I don't know exactly (i don't know KSCanDialog in fact, so i cannot > compare). > > Ask to kare Sars who maintain this code. I can respond better than me... > The KScanDialog plugin interface is now implemented by the ksaneplugin i

Re: What to do with KScanDialog

On Sunday 01 September 2013 13:34:50 Martin Koller wrote: > On Saturday 31 August 2013 23:11:57 Kåre Särs wrote: > > I would vote to move it to kde4support and deprecate it. I can volunteer > > to > > port kolourpaint to libksane if needed. > > Hi all, > &

<    1   2