D18499: [KCM Controls GridView] Add remove animation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d8505b807d55: [KCM Controls GridView] Add remove animation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18499?vs=50188=50190

D18499: [KCM Controls GridView] Add remove animation

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is what all the grid KCMs have been doing, so it makes sense to put it

D18487: Reparse background contrast settings when colors changed

broulik added inline comments. INLINE COMMENTS > theme_p.cpp:754 > } > backgroundContrast = cg.readEntry("contrast", _contrast); > backgroundIntensity = cg.readEntry("intensity", _intensity); An alternative approach would be to store those values and then do the

D18487: Reparse background contrast settings when colors changed

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When switching between light and dark system colors, the background contrast might

Re: Power Management and Inhibition by Applications

Hi, I had thought that would only inhibit the screensaver instead of automatic sleep. KScreenLocker (previously KSMServer) that owns the org.freedesktop.ScreenSaver interface tells PowerDevil to keep the screen on when screensaver is inhibited. It makes no sense to prevent the screen from

D18450: Add extractor for AppImage files

broulik added a comment. Cool! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau, #baloo Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

broulik planned changes to this revision. broulik added a comment. There seems to be one issue that when you open a mounted drive directly, you get an "Unmount" entry at the top. Likely because the places are populated after the entry was created. Perhaps the remove codepath needs to

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Rather than relying on the model count (which broke when we added places

D18356: [Plasma Theme] Use new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8c5099140751: [Plasma Theme] Use new connect syntax (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18356?vs=49804=49805

D18356: [Plasma Theme] Use new connect syntax

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Saves some cycles TEST PLAN Saves like 0.6ms on startup here, given the amount of

D18149: Share Plasma::Theme instances between multiple ColorScope

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eac69e04690b: Share Plasma::Theme instances between multiple ColorScope (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: KDE file dialog column resize no longer possible?

Has resizing support been turned off in KF5 maybe, and if so, where and why? Yes, to ensure sane default sizing of the columns, especially as you resize the dialog, which were often too narrow or too wide or otherwise unfitting. Cheers Kai Uwe

D18308: Ignore all non-storage deviceAdded signals from Solid

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > storagedevices.cpp:79 > Entry entry(dev); > if (dev.udi().isEmpty()) > return nullptr; I think you can also move this check up REPOSITORY R293

D18299: ComboBox: fix default delegate

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:58 > +controlRoot.currentIndex = index; > +controlRoot.popup.visible = false; > +} Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a `ComboBox` is recommended as: "This

D18149: Share Plasma::Theme instances between multiple ColorScope

broulik updated this revision to Diff 49537. broulik retitled this revision from "Share Plasma::Theme instances between multiple Svg and ColorScope" to "Share Plasma::Theme instances between multiple ColorScope". broulik edited the test plan for this revision. broulik added a comment. Focus

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik added a comment. > And QSharedDataPointer? For that `Theme` would need to be `QSharedData`, no? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh,

D14661: Force reevaluation of Predicates if interfaces are removed

broulik added a comment. So, looks like adding the device causes us to probe it and that prompts UDisks to close the tray for examination? I lack a CD drive, so I cannot try this. Can you perhaps investigate this issue? :) Easiest could be to check for device type and then in doubt just

D18263: [CopyJob] Provide more descriptive notification header

broulik added a comment. Isn't that done by `emitCopying` et al? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17851: Add Android notification backend

broulik added a comment. Pretty cool! INLINE COMMENTS > notifybyandroid.cpp:79 > +{ > +s_instance = this; > +#if __ANDROID_API__ >= 23 Can there be multiple instances of this `NotifyByAndroid`? > notifybyandroid.cpp:125 > +pixmap.save(, "PNG"); > +auto jIconData =

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik added inline comments. INLINE COMMENTS > apol wrote in colorscope.h:134 > How about using a QSharedPointer? Complained with "QSharedPointer: cannot create a QSharedPointer from a QObject-tracking QWeakPointer" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D17528: Refactor SlaveInterface::calcSpeed

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. We're getting some `SIGFPE` crash reports in this area: Bug 402665 I failed to reproduce them, though. Best is probably to revert this patch because Frameworks release is imminent.

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik added a comment. > Now in multi-thread environment will have problems especially on actualTheme(), no? `ColorScope` is QML-only and should be fine? Not sure about `Svg`, it never mentioned being thread-safe. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D17543: [Dialog] Don't alter mainItem's visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b257029afc3b: [Dialog] Dont alter mainItems visibility (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17543?vs=47458=49147#toc REPOSITORY R242 Plasma Framework

D17542: Reset parentItem when mainItem changes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f4bd4a613187: Reset parentItem when mainItem changes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17542?vs=47457=49146

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Especially since the `Theme` isn't modified in any way but just used to read some

D17681: RFC: Cache translated strings in Job::emit functions

broulik added a comment. > That 6% goes to 0% i guess? Pretty much, goes down to 0.07% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a48a277a8296: Cache translated strings in Job::emit functions (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17681?vs=47828=47874 REVISION

D17680: Port connect of subjob in copyNextFile to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a4905c5994a7: Port connect of subjob in copyNextFile to new connect syntax (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17680?vs=47827=47873

D17678: Use qobject_cast instead of dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d8e4e6fa29c: Use qobject_cast instead of dynamic_cast (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17678?vs=47824=47834 REVISION DETAIL

D17681: RFC: Cache translated strings in Job::emit functions

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17680 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY These are called repeatedly for every single file processed

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17680 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Copied files, total and processed size still correct REPOSITORY

D17678: Use qobject_cast instead of dynamic_cast

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17678 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17678: Use qobject_cast instead of dynamic_cast

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Since `KJob` is a `QObject` we can use the more efficient

D16643: Correct the accept flag of the event object on DragMove

broulik added a comment. I'm not blaming anyone, I'm merely stating that there is a potential issue with this patch that might not have been addressed and needs @bruns further input. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart,

D16643: Correct the accept flag of the event object on DragMove

broulik added a comment. Only if that potential issue with inhibition has been addressed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham,

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

This revision was automatically updated to reflect the committed changes. Closed by commit R241:86e3142f8588: [KFileItem] Fix isLocal check in checkDesktopFile (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17554?vs=47493=47498 REVISION

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

broulik created this revision. broulik added reviewers: dfaure, davidedmundson, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This was accidentally removed in

D17173: Add error value for job owner dying

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

broulik added a comment. Now that `ERR_FILE_TOO_LARGE_FOR_FAT32` is in you can rebase this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

broulik added a comment. The bug report is about checking whether it's writable, you're checking the protocol here, and `file` will always "support writing". This patch could still make sense, though. INLINE COMMENTS > copyjob.cpp:864 > +QPointer that = q; > +emit

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R242 Plasma Framework (Library) BRANCH bluetooth-battery-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17505 To: ndavis, #vdg,

D17543: [Dialog] Don't alter mainItem's visibility

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The item's `visible` property is independent of the window visibility, which

D17542: Reset parentItem when mainItem changes

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise we'll keep piling up custom tooltip items in the dialog. They're

D17518: Adapt favicon test to www.kde.org changes

broulik added a comment. I also thought the favicon was too large for `FavIconJob` to download REPOSITORY R241 KIO BRANCH favicon_test REVISION DETAIL https://phabricator.kde.org/D17518 To: bruns, #frameworks, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark. Also, should it maybe have a "bolt" or something next to it as that's what we normally have for the

D17479: Fix build without phonon

broulik added a reviewer: sitter. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17479 To: heikobecker, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17480: Fix warnings

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D17480 To: apol, #frameworks, mart, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16299: fallback to dnssd service discovery if smb listDir failed on root

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-discovery REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin, broulik Cc: acrouthamel, alexde, bcooksley, ngraham,

D17345: Support Bluetooth batteries

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b983836f05cd: Support Bluetooth batteries (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17345?vs=46834=46837#toc REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D17345: Support Bluetooth batteries

broulik added a dependent revision: D17346: Support Bluetooth batteries. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

broulik added a reviewer: bshah. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

broulik created this revision. broulik added reviewers: Plasma, bruns, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY There's currently no generic Bluetooth device type in UPower,

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

broulik added inline comments. INLINE COMMENTS > filecopyjob.cpp:225 > KIO_ARGS << m_src << m_dest << m_permissions << (qint8)(m_flags & > Overwrite); > -m_copyJob = new DirectCopyJob(slave_url, packedArgs); > +auto job = new DirectCopyJob(slave_url, packedArgs); > +m_copyJob =

D17238: Explicitly create QDateTime with UTC time

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9592e0b69c9: Explicitly create QDateTime with UTC time (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17238?vs=46485=46489 REVISION DETAIL

D17238: Explicitly create QDateTime with UTC time

broulik created this revision. broulik added reviewers: dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise it spends half of the time doing timezone conversions to

D17167: Provide a method of assigning custom default icons for non-XDG dirs

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH snap-support REVISION DETAIL https://phabricator.kde.org/D17206 To: jgrulich, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

broulik added a comment. +1 INLINE COMMENTS > notifybyflatpak.h:40 > public: > +struct PortalIcon { > +QString str; Does this need to be in the header file? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17188 To: jgrulich,

D17173: Add error value for job owner dying

broulik added a comment. +1 INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between > kuiserver and views when the job owner

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

broulik added a comment. Don't know much cmake but still builds fine here with this change, so +1 from me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D17088 To: kossebau, broulik, TheAssassin, azubieta Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss,

D17078: Make it possible to use KAboutData/License/Person from QML

broulik added a comment. You can change default values just fine, it requires re-compilation to use them but no ABI implications. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: broulik, anthonyfieroni,

D17068: actually install the version header

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH install-version REVISION DETAIL https://phabricator.kde.org/D17068 To: sitter, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17067: do not leak resolver in remoteservice

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH master REVISION DETAIL https://phabricator.kde.org/D17067 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16298: prevent avahi signal racing

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH master REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

broulik added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.cpp:26 > + > +#define i18n QString::fromLatin1 > + What's this for? > ktoggleshowmenubaraction.h:49 > + */ > +KToggleShowMenuBarAction(QWidget *window, QObject *parent); > + I know we typically use `window` here

D16301: Remove ComponentInstaller

This revision was automatically updated to reflect the committed changes. Closed by commit R242:38098e96e3d8: Remove ComponentInstaller (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16301?vs=43874=45796 REVISION

D16108: When re-using runners when reloading, reload their configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R308:770f8d64a495: When re-using runners when reloading, reload their configuration (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE

D16885: Delete the correct item in removeDesktop

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16885 To: davidedmundson, #kwin, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

broulik added a comment. Looking good now, +1 REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

broulik added a comment. The header file for `class Permeability` should probably be named `permeability_p.h` to match the other category classes since it's a not exported implementation detail INLINE COMMENTS > unit.h:335 > +/** @since 5.53 */ > +Darcy, > +/** @since 5.53 */

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix-root-icon-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh,

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik added inline comments. INLINE COMMENTS > udisksdevice.cpp:874 > +{ > +if (queryDeviceInterface(Solid::DeviceInterface::StorageAccess)) { > +const UDisks2::StorageAccess accessIface(const_cast(this)); Can you check whether using `isStorageAccess()` is more

D16620: add const to TypeInfo compare operater

broulik added inline comments. INLINE COMMENTS > typeinfo.h:41 > TypeInfo& operator=(const TypeInfo& rhs); > -bool operator==(const TypeInfo& rhs); > +bool operator==(const TypeInfo& rhs) const; > This method is exported so you cannot change cv qualifiers REPOSITORY R286

D16594: Add context to kcmodule connection to lambdas

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D16594 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16529: make libssh module default to the "new" libssh config by default

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16529 To: sitter, broulik, asn Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun,

D16522: [Extractor] Do not check QFile::exists for an empty url

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16522 To: bruns, #baloo, #frameworks, dfaure, apol, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16464: [KSambaShare] Trim trailing / from share path

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH net_usershare REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16427: [solid-hardware5] List icon in device details

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9910ad1473f4: [solid-hardware5] List icon in device details (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16427?vs=44214=44215 REVISION

D16427: [solid-hardware5] List icon in device details

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN udi = '/org/kde/solid/udev/sys/devices/pci:00/:00:01.1/:01:00.0/usb1/1-7'

D16166: Pass the FileIndexerConfig as const to the individual indexers

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16166 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure, broulik Cc: kde-frameworks-devel, ashaposhnikov,

D16387: [sftp] put request chunk debugging into own category

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-trace-level REVISION DETAIL https://phabricator.kde.org/D16387 To: sitter, asn, broulik, ngraham Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh,

D16313: Use QMenu::addSeparator

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_addseparator (branched from master) REVISION DETAIL https://phabricator.kde.org/D16313 To: thsurrel, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

broulik retitled this revision from "[KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob" to "RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame

D16311: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This ensure hovering a broken mount will not freeze the UI. I

D16301: Remove ComponentInstaller

broulik added a comment. > Method InstallPackages Thanks for the insight. In any case, the way the code "works" right now is probably not what we want. It has been unused for years and is unlikely to come back in that form, so we can rm it. If we were to support something like this we

D16301: Remove ComponentInstaller

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When a dataengine failed to load it would ask PackageKit to install it but it's

D16295: Remove PLASMA_NO_KIO

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e92ed94d9d1a: Remove PLASMA_NO_KIO option (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16295?vs=43857=43872 REVISION

D16300: Remove double underscore (__) from header include guards

broulik added a comment. It could have just gone `#pramga once` REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16300 To: kossebau, #kate, cullmann Cc: broulik, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16298: prevent avahi signal racing

broulik added a comment. Not sure if evil or genius ;) Looks sane, as sane as it gets, obviously. INLINE COMMENTS > avahi_listener_p.h:29 > + > +// Assits with listening to Avahi for all signals and then checking if the > +// a given dbus message is meant for us or not. *Assists >

D16295: Remove PLASMA_NO_KIO

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is a remnant of the Active days and didn't even compile. This patch only

D16291: Center icons properly if size doesn't fit

This revision was automatically updated to reflect the committed changes. Closed by commit R302:2699d36365fa: Center icons properly if size doesnt fit (authored by broulik). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16291?vs=43847=43848 REVISION

D16291: Center icons properly if size doesn't fit

broulik updated this revision to Diff 43847. broulik edited the test plan for this revision. broulik added a comment. - Also properly create new pixmap REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16291?vs=43845=43847 REVISION DETAIL

D16291: Center icons properly if size doesn't fit

broulik created this revision. broulik added reviewers: dfaure, cfeck, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When requesting an icon size that cannot be served, the pixmap is

D16272: apply eexist workaround from listDir to stat as well

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D16272 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales,

D16266: [Extractor] Make extractor crash resilient

broulik added inline comments. INLINE COMMENTS > poboiko wrote in filecontentindexer.cpp:75 > Is it OK to use `QObject::connect` inside a `while` loop? Those are not > `Qt::UniqueConnection`, won't they fire multiple times (more and more, > actually)? given `loop` lives on the stack it is

<    4   5   6   7   8   9   10   11   12   13   >