Review Request 124696: Fix (worrying) MSVC warning

2015-08-11 Thread Kevin Funk
Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124542: CMake fixes for Windows build

2015-08-10 Thread Kevin Funk
marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 38265304276e6305f72a7e1a68aa1b4193657820 by Kevin Funk to branch master. Bugs: 348061 https://bugs.kde.org/show_bug.cgi?id=348061 Repository: kdoctools

Re: Review Request 124542: CMake fixes for Windows build

2015-08-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83574 --- @Luigi: Bump? - Kevin Funk On Aug. 6, 2015, 6:37 a.m

Re: Review Request 124542: CMake fixes for Windows build

2015-08-06 Thread Kevin Funk
://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 124577: Fix Windows build

2015-08-01 Thread Kevin Funk
: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp 3e98befadb99dc81e65c7d0586f13bd1b375ad42 Diff: https://git.reviewboard.kde.org/r/124577/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 124577: Fix Windows build

2015-08-01 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit a0fcb7d7ab14f379fabf440491ce40298ec0b540 by Kevin Funk to branch master. Repository: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 --- On July 31, 2015, 7:34 a.m., Kevin Funk wrote

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
e3868fc4f22324d25f680c13609bfb92b8b7c41d Diff: https://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
/124542/#review83249 --- On July 31, 2015, 7:34 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542

Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Install location of myframework_version.h headers

2015-05-13 Thread Kevin Funk
On Monday 04 May 2015 14:11:14 Kevin Funk wrote: On Monday 04 May 2015 13:11:05 David Faure wrote: On Monday 04 May 2015 12:29:39 David Faure wrote: On Monday 04 May 2015 12:23:32 Kevin Funk wrote: The issue could be easily fixed by moving the myframework_version.h into $PREFIX

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Kevin Funk
On May 13, 2015, 6:45 a.m., Kevin Funk wrote: I'd reorder the code: ``` ... include(FeatureSummary) find_package(ECM ...) set_target_properties(ECM ...) feature_summary(...) ... ``` I know that it is a bit harder to script this way , but helps code

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Kevin Funk
) find_package(ECM ...) set_target_properties(ECM ...) feature_summary(...) ... ``` I know that it is a bit harder to script this way , but helps code readability :D - Kevin Funk On May 13, 2015, 12:28 a.m., Jeremy Whiting wrote

Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing

Re: Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
On Monday, May 04, 2015 12:23:32 Kevin Funk wrote: Heya, I'm wondering why, for instance, ktexteditor_version.h is installed to $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. This currently leads to confusing behavior when trying to include this header if two versions

Re: Install location of myframework_version.h headers

2015-05-04 Thread Kevin Funk
On Monday 04 May 2015 13:11:05 David Faure wrote: On Monday 04 May 2015 12:29:39 David Faure wrote: On Monday 04 May 2015 12:23:32 Kevin Funk wrote: The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Correct, this is what

Re: Versioning of Frameworks

2015-04-30 Thread Kevin Funk
On Wednesday, April 29, 2015 21:43:20 David Faure wrote: On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: Use-case: Potential contributor working on KDevelop: - Has KF5 installed from distro packages - KDevelop/KDevPlatform compiled from Git - There's a bug in ktexteditor (tier 3

Re: Versioning of Frameworks

2015-04-29 Thread Kevin Funk
-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-29 Thread Kevin Funk
On April 24, 2015, 3:49 p.m., Kevin Funk wrote: modules/ECMGeneratePriFile.cmake, line 180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180 Just tested the patch myself on sonnet. The test indeed breaks if sonnet is not installed beforehand

Re: Review Request 123452: Expose KJob::capabilities property

2015-04-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79421 --- Ship it! Ship It! - Kevin Funk On April 21, 2015, 4:24

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
On April 24, 2015, 3:49 p.m., Kevin Funk wrote: modules/ECMGeneratePriFile.cmake, line 180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180 Just tested the patch myself on sonnet. The test indeed breaks if sonnet is not installed beforehand

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
`QMAKEPATH` set during the test run imposes another burden on the user, however. What about adding: ``` set_tests_properties(... PROPERTIES ENVIRONMENT QMAKEPATH=${qt_host_data_dir} ``` - Kevin Funk On April 24, 2015, 3:26 p.m., Albert Astals Cid wrote

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
://git.reviewboard.kde.org/r/123491/#comment54298 Rather: `${PRI_TARGET_BASENAME}_test.pro`? (Uses the correct suffix) - Kevin Funk On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote: --- This is an automatically

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-08 Thread Kevin Funk
://git.reviewboard.kde.org/r/123229/#comment53832 You could use http://doc.qt.io/qt-5/qcoreapplication.html#Q_COREAPP_STARTUP_FUNCTION + a queued method invocation to make sure `QApplication` was fully constructed. - Kevin Funk On April 7, 2015, 1:46 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 122910: Introduce KMoreTools

2015-03-15 Thread Kevin Funk
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: src/kmoretools/kmoretools.h, line 412 https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line412 Qt API never returns a this pointer when settings some properties. While not explicitely stated

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

2015-02-18 Thread Kevin Funk
://git.reviewboard.kde.org/r/122613/#comment52572 Just create on the stack? - Kevin Funk On Feb. 17, 2015, 10:29 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5

2015-02-13 Thread Kevin Funk
On Friday 13 February 2015 21:56:42 Ben Cooksley wrote: On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk kf...@kde.org wrote: On Friday 13 February 2015 08:49:10 Marko Käning wrote: Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-13 Thread Kevin Funk
-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 122551: New feature: Open all recent files

2015-02-12 Thread Kevin Funk
session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened. - Kevin Funk On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote: --- This is an automatically

Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-12 Thread Kevin Funk
/kconfigloader.h aadb19a5b266f4c1ccd07d4b05af0dcbd2686bd9 src/gui/kconfigloaderhandler_p.h 1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
--- On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 3:47 p.m

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75879 --- Ship it! LGTM. - Kevin Funk On Feb. 11, 2015, 5:45 p.m

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
On Feb. 11, 2015, 3:35 p.m., Kevin Funk wrote: src/services/kplugininfo.cpp, line 574 https://git.reviewboard.kde.org/r/122514/diff/1/?file=348194#file348194line574 Style: Space after keyword, more below. Wrong line, sorry. But you know what I mean :) - Kevin

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Kevin Funk
* good, though. src/services/kplugininfo.cpp https://git.reviewboard.kde.org/r/122514/#comment52373 Style: Space after keyword, more below. - Kevin Funk On Feb. 10, 2015, 5:18 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Kevin Funk
. Please tell me if it's desired and I'll go ahead. - Kevin Funk On Feb. 11, 2015, 11:19 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539

Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Kevin Funk
1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-09 Thread Kevin Funk
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: -1 You use C-Style casts. Oke, the frameworks coding style doesn't seem to explicitly forbid it (casts are not mentioned), but if i recall correctly we use the Qt style + some of our own which means we should obey the Qt style [1]

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Kevin Funk
/qprocessenvironment.html#systemEnvironment` instead? Looks like you could get rid off the string conversion/parsing here. - Kevin Funk On Feb. 8, 2015, 10:06 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-03 Thread Kevin Funk
giving their +1, too modules/ecm_uninstall.cmake.in https://git.reviewboard.kde.org/r/122359/#comment52112 I'd remove the text inside the condition of `elseif`, `endif` and `endforeach` (I know it is copied code, but still ...) - Kevin Funk On Feb. 3, 2015, 8:19 p.m., Alex Merry wrote

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Kevin Funk
On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible,

Re: Review Request 122105: Fix KgDifficulty saving on app close

2015-01-19 Thread Kevin Funk
()` in order to make sure people don't do that? - Kevin Funk On Jan. 17, 2015, 9:48 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105

Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
'#include moc_basename.cpp' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

2015-01-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121931/#review73523 --- Ship it! Ship It! - Kevin Funk On Jan. 8, 2015, 6:10 p.m

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-06 Thread Kevin Funk
no LIBRARY DESTINATION for shared library target KF5KMahjongglib. --- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-19 Thread Kevin Funk
/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewte st.cpp.o] Error 1 make[1]: *** [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde

Re: Where are my systray icons cont'd

2014-11-28 Thread Kevin Funk
On Thursday 27 November 2014 21:10:10 Kevin Funk wrote: Heya, I'm still missing my beloved systray icons for a few applications in Plasma 5 on Ubuntu 14.10 (using distro provided packages). I have every package installed according to [1] (sni-qt, libindicator*), but still, systray icons

Re: Review Request 121276: KPluginInfo::category() instead of property(X-KDE-PluginInfo-Category)

2014-11-27 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121276/#review71029 --- Ship it! Ship It! - Kevin Funk On Nov. 27, 2014, 6:07 p.m

Where are my systray icons cont'd

2014-11-27 Thread Kevin Funk
] https://developer.pidgin.im/ticket/16456 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-24 Thread Kevin Funk
e1c9f34cf24eb516c540db3288c93ad5bd093df3 src/document/katedocument.cpp aac17c719cbabf78c2135062fe566671713cea02 src/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-19 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-18 Thread Kevin Funk
/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Kevin Funk
--- Use correct version in kbuildsycoca5 executable Diffs - src/kbuildsycoca/kbuildsycoca.cpp 69b142745863218169d7da5a048293d6ab6b1978 Diff: https://git.reviewboard.kde.org/r/121173/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-11 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread Kevin Funk
(); 596-} Worth trying to patch this into QTabBar right away, I think. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Kevin Funk
--- Can't change that now because it would be BIC. Diffs - src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 Diff: https://git.reviewboard.kde.org/r/121082/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m

Replacement for KMimeType::isBinaryData?

2014-10-28 Thread Kevin Funk
Heya, I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is there some? http://lxr.kde.org/ident?v=kf5-qt5_i=isBinaryData_remember=1 shows exactly two users of this function. Worth considering upstreaming to Qt? -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-11 Thread Kevin Funk
/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/#review67849 --- Bump. This is a super trivial patch. :) - Kevin Funk

Review Request 120435: Declare InheritanceChecker before actual use

2014-09-30 Thread Kevin Funk
/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: plasmate fails to build on branch frameworks

2014-09-15 Thread Kevin Funk
-frameworks-devel Note: Plasmate needs to be fixed to work on the current kdevplatform. We've done the invasive KUrl-QUrl port there which of course broke source compatibility. Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks

Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
[1] http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKMimeType.html#a3417e83a30cff614a01a29ca2a615443 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
On Friday 12 September 2014 10:50:36 David Faure wrote: On Friday 12 September 2014 09:39:42 Kevin Funk wrote: Heya, Context: Forward-porting some patches in KDevelop involving KMimeType API. I've just noticed that in Qt5, QMimeDataBase/QMimeType doesn't allow me to retrieve

Re: kio_trash

2014-08-27 Thread Kevin Funk
slave because it's part of different module) Greets [1] http://build.kde.org/view/kdevelop/job/kdevplatform_frameworks_qt5/154/testReport/(root)/TestSuite/test_kdevgit/ -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Kevin Funk
: agreed. Kevin Funk wrote: Yep. I'm also *strongly* in favor of adjusting the code instead of enabling the define. In fact, I thought I've fixed all of KF5. (It isn't?). There are some compile errors in code *using* KF5, which I'm trying to port ASAP. Axel Rasmussen

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-08-05 Thread Kevin Funk
] Is there any reason for it to be there? Diffs - cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Kevin Funk
On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: I would rather change the code. The Qt behaviour was changed for a reason, to prevent accidental use of dangerous behaviour, and I'm not too keen on undoing that move for all software that uses KDECompilerSettings. Sune Vuorela wrote:

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk

Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
--- On July 12, 2014, 9:41 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-08 Thread Kevin Funk
(5, 0, 0) (qglobal.h). That means basic functions such as QString::fromAscii are disabled because they're marked as deprecated since 5.0. Question is: Do we really want to override the default value for QT_DISABLE_DEPRECATED_BEFORE? - Kevin Funk On July 6, 2014, 10:17 p.m., Kevin Funk wrote

Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-06 Thread Kevin Funk
/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/#review57150 --- Ship it! LGTM - Kevin Funk On May 2, 2014, 4:12 p.m

Re: Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
--- On May 2, 2014, 4:10 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951

Re: Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
411c7913193dbbb527edfe3601b91dd1f7af99e6 trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Hitting assertion in kio-trash (KF5KIOCore)

2014-05-02 Thread Kevin Funk
On Wednesday 16 April 2014 21:31:01 Kevin Funk wrote: Hey, While running unit tests from kdevplatform I hit the following assert in trash/trashimpl.cpp (from workspace/kio-extras) Output of the unit test (which attempts to trash some folders): trying to create /home/krf/.local/share

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Kevin Funk
://git.reviewboard.kde.org/r/117695/#comment39333 Early-return? if (!replacetabs) return str; ... - Kevin Funk On April 23, 2014, 8:49 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https

Hitting assertion in kio-trash (KF5KIOCore)

2014-04-16 Thread Kevin Funk
KIO::RenameDialog::suggestName change? Reproducable with: ./plugins/git/tests/kdevgit-test testRemoveEmptyFolder from kdevplatform.git. Greets -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
they're amended alongside of source code changes. Opinions? What do the frameworks devs think about it? Greets [1] http://qt-project.org/doc/qt-5/index.html [2] http://qt-project.org/doc/qt-5/overviews-main.html [3] http://qt-project.org/doc/qt-5/qtexamplesandtutorials.html -- Kevin Funk

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
On Wednesday 09 April 2014 15:42:47 Aleix Pol wrote: On Wed, Apr 9, 2014 at 3:05 PM, Kevin Funk kf...@kde.org wrote: On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: Hello folks, I know that August is months away, but if you want your Frameworks book, now is the time to step

Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/includes/KTextEditor/SearchInterface f7dffc91739e82cceffea35de0632cb19e92ab0a src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e Diff: https://git.reviewboard.kde.org/r/117017/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
--- On March 24, 2014, 10:48 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/ --- (Updated March

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-28 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 21:15:54 schrieb Michael Pyne: On Thu, February 27, 2014 11:35:16 Kevin Funk wrote: Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne: On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: Also, while at it, could we get a truly verbose flag

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-27 Thread Kevin Funk
build kdesrc-build it should install a man page to $KDEDIR/share/man/man1 or thereabouts. I've recently become a big fan of --resume-from (or -after), --stop-before (or -after) and --ignore-modules options myself. And always --pretend. Regards, - Michael Pyne Cheers -- Kevin Funk

Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
. Greets -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: Hey, I get the following compile errors when compiling anything that depends on libKF5XsltKde.a from kdoctools: When compiling kio: [ 53%] Built target kio_file /home/krf/bin/ld: error: /home/krf/devel/install/kf5/lib/x86_64

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 15:24:30 schrieb Kevin Funk: Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: Hey, I get the following compile errors when compiling anything that depends on libKF5XsltKde.a from kdoctools: When compiling kio: [ 53%] Built target

<    1   2   3   4   5   6   >