D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel
hwti added a comment. In D24150#536169 , @dfaure wrote: > I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 by removing the ::exit() call (which

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel
hwti updated this revision to Diff 66633. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24150?vs=66630=66633 REVISION DETAIL https://phabricator.kde.org/D24150 AFFECTED FILES src/ioslaves/file/file.cpp To: hwti, cfeck, dfaure, broulik Cc: aacid, kde-frameworks-devel, LeGast00n,

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel
hwti added a comment. In D24150#536113 , @aacid wrote: > why the void? do you get a warning otherwise? No, but it is used in several places in the repository (and in Qt), so I suppose it might generate one depending on the compiler.

D24150: Fix crash on exit in kio_file

2019-09-22 Thread Loïc Yhuel
hwti created this revision. hwti added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hwti requested review of this revision. REVISION SUMMARY All QTextCodec are deleted by QCoreGlobalData on exit, so they must be allocated on the heap.

D15872: Fix Oxygen background gradient for QML modules

2018-10-01 Thread Loïc Yhuel
hwti created this revision. hwti added reviewers: mart, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hwti requested review of this revision. REVISION SUMMARY We need to make the QQuickWidget transparent, so we see the window background, which can be