D26952: Make tags:/ ioslave not writable

meven created this revision. meven added reviewers: ngraham, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 416819 FIXED-IN: 5.67 REPOSITORY R293 Baloo BRANCH master REVISIO

D26888: work around to fully support the windows backend

meven added inline comments. INLINE COMMENTS > notifybysnore.cpp:165 > > -void NotifyBySnore::notifyDeferred(KNotification* notification) > -{ > +Q_UNUSED(config); > QProcess *proc = new QProcess(); no `;` here REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.k

T11627: Improve KIO asynchronicity

meven added a comment. In T11627#206210 , @broulik wrote: > I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can

D26650: Use KService to look for Filelight

meven added inline comments. INLINE COMMENTS > sitter wrote in kpropertiesdialog.cpp:1114 > I'm pretty sure that isn't true. > > KFilePropsPlugin are the tabs inside the properties dialog. They get > instantiated for each dialog and destroyed when the dialog is destroyed. They > are not persis

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a dependent revision: D26916: Allow to display in the kicker appliation context menu the recently accessed directories. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-deve

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a dependent revision: D26915: Allow to display in the task context menu the recently accessed directories. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n,

D26878: Add missing renamed event when a destination file already existed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fe5913b1346a: Add missing renamed event when a destination file already existed (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74324&id=74

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74324. meven marked 3 inline comments as done. meven added a comment. Clean up + QVERIFY REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74316&id=74324 BRANCH arcpatch-D26878 REVISION DETAIL https://phabricator.

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74316. meven added a comment. Remove a bad unused REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74311&id=74316 BRANCH arcpatch-D26878 REVISION DETAIL https://phabricator.kde.org/D26878 AFFECTED FILES autote

D26897: Fix two warnings, missing Q_FALLTHROUGH

This revision was automatically updated to reflect the committed changes. meven marked an inline comment as done. Closed by commit R241:e6807dea4735: Fix two warnings, missing Q_FALLTHROUGH (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26897?

D26897: Fix two warnings, missing Q_FALLTHROUGH

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26897 AFFECT

D26878: Add missing renamed event when a destination file already existed

meven edited the test plan for this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 To: meven, #frameworks, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74311. meven added a comment. Avoid touching a line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74310&id=74311 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 AFFECTED FILES autotests/job

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74310. meven retitled this revision from "Add missing renamed events when a destination file already existed" to "Add missing renamed event when a destination file already existed". meven added a comment. Add tests, add renamed events when autorename was se

D26878: Add missing renamed events when a destination file already existed

meven retitled this revision from "Add missing renamed event when a destination file already existed" to "Add missing renamed events when a destination file already existed". REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 To: meven, #frameworks, erv

D26878: Add missing renamed event when a destination file already existed

meven retitled this revision from "Add a missing renamed event when a destination file already existed" to "Add missing renamed event when a destination file already existed". meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator

D26878: Add a missing renamed event when a destination file already existed

meven created this revision. meven added reviewers: Frameworks, ervin, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This was missing when a file was being copyied/moved, its destination exi

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3dfa0c1c2f87: KFilePlacesModel: On new profile in recent show only recentlyused:/ based… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74123. meven added a comment. Fix comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74072&id=74123 BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES src/filewidg

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74072. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74071&id=74072 BRANCH arcpatch-D26782 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES src/filewidgets/k

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74071. meven added a comment. Don't add by default 'Modifield Today' and 'Modifield Yesterday' when recentlyused:/ is present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73995&id=74071 BRANCH arcpatch-D26782

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added a task: T12551: Revamp KCM/Component chooser. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

This revision was automatically updated to reflect the committed changes. Closed by commit R309:f10db4e6f0af: Make "Default Applications" in mimeapps.list the preferred applications (authored by meven). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 74002. meven added a comment. Fix indentation issue REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73996&id=74002 BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FILES

D26800: autotests: use local desktop file to avoid relying on konsole

meven added inline comments. INLINE COMMENTS > dfaure wrote in kservicetest.cpp:73 > (to expand on my previous reply: this line ensures that we copy the desktop > files into a test-specific directory) Thanks, did not notice this line and did not know setTestModeEnabled Learning every day... RE

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven marked 6 inline comments as done. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73996. meven added a comment. Add explanatory comment regarding 25 magic number REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73913&id=73996 BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 73995. meven marked an inline comment as done. meven added a comment. Added missing spaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73917&id=73995 BRANCH arcpatch-D26782 REVISION DETAIL https://phabricato

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven added a comment. In D26782#597811 , @ngraham wrote> > But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off. I chose hidden by value just to keep the feature som

D26800: autotests: use local desktop file to avoid relying on konsole

meven added inline comments. INLINE COMMENTS > org.kde.testapp.desktop:6 > +Icon=utilities-terminal > +Terminal=false > +Categories=Qt;KDE;System;TerminalEmulator; Add NoDisplay or testiers will have double konsole, or remove test desktop file on teardown. REPOSITORY R309 KService REVISION

D26781: Fix test since Konsole added icons to its actions

meven abandoned this revision. meven added a comment. In D26781#597778 , @dfaure wrote: > Yep, this would break the test for users of an older konsole, let's ship our own. I'm working on it. All right REPOSITORY R309 KService REVISION

D26798: Fix broken SQL query in allResourcesQuery

This revision was automatically updated to reflect the committed changes. Closed by commit R159:e36497a6734d: Fix broken SQL query in allResourcesQuery (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26798?vs=73976&id=73981

D22717: Add Date term to KActivities Stats to filter on resource event date

meven added inline comments. INLINE COMMENTS > resultset.cpp:399 > +AND from_table.usedActivity = rsc.usedActivity > AND rl.initiatingAgent = rsc.initiatingAgent > Missing table name update fix in D26798

D26798: Fix broken SQL query in allResourcesQuery

meven retitled this revision from "Fix broken SQL query" to "Fix broken SQL query in allResourcesQuery". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D26798 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26798: Fix broken SQL query

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The regression was introduced by D22717 TEST

D26564: Clean kbuildsycoca4 support

meven added a comment. It seemed to In D26564#597474 , @ervin wrote: > I'm wondering if that's the right point in time for this. Wouldn't it be better once we branched KF6? There are still people transitioning from 4 to 5 out there I guess.

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmimeassociations.cpp:104 > More precisely, it assumes that a single mimetype entry doesn't have more > than 25 desktop files associated with it. And even then, what would happen is > that the ordering is wrong after the first 25. I

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmimeassociations.cpp:104 > No. What about my job security? ;-) > > It's half of the +50 from line 86. > > The range 1000-1025 is used by Added Associations, the range 1025-1050 is > used by Default Applications, and so on for the

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven edited the summary of this revision. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

meven added a comment. I think you can abandon this one, because 26690 is fixing this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18778 To: ngraham, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven added a comment. Too bad I missed the boat for KF 5.66 and Plasma 5.18. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 73917. meven added a comment. Clean commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73916&id=73917 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES src/filewidgets/kfilep

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven created this revision. meven added reviewers: ngraham, VDG, Plasma, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The entries timeline:/today and timeline:/yesterday are way less useful t

D26781: Fix test since Konsole added icons to its actions

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Test was unstable since konsole commit : https://cgit.kde.org/konsole.git/commit

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73913. meven added a comment. Simplify implementation of Default Applications parsing, update tests REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73781&id=73913 BRANCH arcpatch-D26690 REVISION DETAIL http

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven planned changes to this revision. meven added a comment. In D26690#596551 , @dfaure wrote: > I'm quite confused by all this. Wouldn't it be enough to do http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ? > The modified unittest p

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven planned changes to this revision. meven added a comment. > Really? that's not what all callers might want. > e.g. for \"free disk space\" calculation we want the real final mountpoint for that path. > If you need something else, it should be a different method, or indeed a flag

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73836. meven marked 3 inline comments as done. meven added a comment. Fix comment issues and improve syntax used REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73831&id=73836 BRANCH arcpatch-D26407 REVISION DETAI

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmountpoint.cpp:443 > Why reuse and assign, compared to just `const QFileInfo fileinfo(parentPath)`? > > (Same for parentPath -- I prefer C++ over C) I expected reviewers to tell to have declaration outside of loops... > dfaure wro

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73831. meven marked 3 inline comments as done. meven added a comment. Use mid/lastIndexOf instead of split/join, use const assign in loop REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73819&id=73831 BRANCH arcpat

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added inline comments. INLINE COMMENTS > dfaure wrote in kmountpoint.cpp:438 > Hmm, what if the symlink *is* the very last component, like your previous > iteration tried to handle? I made the incorrect assumption, I had already checked it > dfaure wrote in kmountpoint.cpp:445 > I don't

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73819. meven marked 3 inline comments as done. meven added a comment. Make the recursive canonical work REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73690&id=73819 BRANCH arcpatch-D26407 REVISION DETAIL https

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added a comment. In D26690#596116 , @ngraham wrote: > Does this fix https://bugs.kde.org/show_bug.cgi?id=403499? Partially I believe, D26557 should have helped too. Currently a file change of m

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

meven added a comment. In D17372#472624 , @dfaure wrote: > Writing into the user's home dir is a "hack". > > There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked.

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73781. meven added a comment. KCM/Component Revamp browser config REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73778&id=73781 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FI

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73778. meven marked 4 inline comments as done. meven added a comment. Review : Add an enum AddServiceFlag REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73679&id=73778 BRANCH master REVISION DETAIL https:/

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

This revision was automatically updated to reflect the committed changes. Closed by commit R295:abd2e496efaa: KCModuleQml: Ensure defaulted is emitted with the current configModule… (authored by meven). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26085?vs=

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73690. meven added a comment. Fix poping .length() > 0 ordering REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73687&id=73690 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407 AFFECTED

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73687. meven marked an inline comment as done. meven added a comment. Check parent dir transitive symlinks, aka manual canonicalPath REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73524&id=73687 BRANCH arcpatch-D2

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73679. meven added a comment. Update code to have a better implementation reusing existant API REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73633&id=73679 BRANCH master REVISION DETAIL https://phabricato

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven retitled this revision from "[WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme" to "Make "Default Applications" in mimeapps.list the preferred applications". meven edited the summary of this revision. REPOSITORY R309 KService REVISION DETA

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven added a comment. In D26690#595221 , @dfaure wrote: > s/Schema/Scheme/ everywhere (method name, commit log) > > I want to deprecate KMimeTypeTrader, this should rather go into the upcoming KApplicationTrader D25698

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven added a comment. I mean here to build consensus then implement about the need for this, then on how to implement it. I think KService should handle building this when parsing mimeapps.list files. And then expose this as `KService::findDefaultSchemeHandler(scheme)` REPOSITORY R3

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven retitled this revision from "Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme" to "[WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme". meven edited the summary of this revision. meven added reviewers:

D26690: Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FILES src/kdeinit/ktoolinvocation

D26650: Use KService to look for Filelight

meven added inline comments. INLINE COMMENTS > broulik wrote in kpropertiesdialog.cpp:1114 > Not sure copying that pointer into the lambda is a good idea? service is a QExplicitlySharedDataPointer in fact, I guess it covers lambda use cases. REPOSITORY R241 KIO REVISION DETAIL https://pha

D26663: Fix doc block in KProtocolInfoFactory

This revision was automatically updated to reflect the committed changes. Closed by commit R241:be69b302f1d7: Fix doc block in KProtocolInfoFactory (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26663?vs=73522&id=73538 REVISION DETAIL https

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. Now we have a small list of potential users of this : plasma-desktop/kcms/kfontinst/lib/Misc.cpp:391 plasma-desktop/kcms/baloo/filteredfoldermodel.cpp:50 plasma-workspace/runners/baloo/baloosearchrunner.cpp:176 plasma-workspace/libnotificationmanager/job_p.cpp:

D26122: Add utility text function KShell::tildeCollapse

This revision was automatically updated to reflect the committed changes. Closed by commit R244:94e6927d2f8c: Add utility text function KShell::tildeCollapse (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=73386&id=73528 REVIS

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a comment. I am thinking about adding some api to check status of nfs, sftp or smb mounts by checking their hostname network reachability, to complement isSlow(), and perhaps then running a stat of the mount with a timeout. This would be kept in a cache with a short duration.

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73524. meven marked 4 inline comments as done. meven added a comment. Address review: Make KMountPoint::Ptr KMountPoint::List::findByPath non-blocking, checking recursively intermediate symlinks REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://pha

D25856: Show IOSlaves that return local files when in local file mode

meven added a comment. In D25856#575125 , @fvogt wrote: > In D25856#575083 , @ngraham wrote: > > > In D25856#575044 , @fvogt wrote: > > > > > IMO this

D26663: Fix doc block in KProtocolInfoFactory

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevented documentation to appear. REPOSITORY R241 KIO BRANCH master REVIS

D26122: Add utility text function KShell::tildeCollapse

meven edited the summary of this revision. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. @apol is it ok with you ? REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

This revision was automatically updated to reflect the committed changes. Closed by commit R241:76470c116640: Allow to handle apps with Terminal=True in their desktop file, handle their… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven added a comment. > OK, scheme-handler replaces most of these uses. I think we should just deprecate "helper protocols" (which either hardcode an exec line or abuse mimetypes) and move it all to the scheme-handler mechanism. I completely agree, we have a standardized way to handle s

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D26557 REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73490. meven added a comment. Remove uncorrect comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73449&id=73490 BRANCH arcpatch-D26557 REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES s

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

This revision was automatically updated to reflect the committed changes. Closed by commit R241:56732facdb3b: KOpenWithDialog: Allow to return a newly created KService created associated to… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26617

D26648: Improved quality of JPEG thumbnails

meven added subscribers: volkov, meven. meven added a comment. Nice first patch @chroniceel ! https://github.com/openwebos/qt/blob/master/src/gui/image/qimagereader.cpp#L1202 is the only use of quality in ImageReader, its default is -1 so it depends on its https://doc.qt.io/qt-5/qimagei

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73449. meven marked 7 inline comments as done. meven added a comment. Address review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73182&id=73449 BRANCH arcpatch-D26557 REVISION DETAIL https://phabricator.kde.

D26623: KEMailSettings: group names in kconfig files should not be localized

meven retitled this revision from "KEMailSettings: key names in kconfig files do not need to be localized" to "KEMailSettings: group names in kconfig files should not be localized". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin Cc:

D26623: KEMailSettings: key names in kconfig files do not need to be localized

meven created this revision. meven added reviewers: Frameworks, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This breaks compatiblity with xdg-email for some locals (i.e french) since it is

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. To reiterate. The use case is to avoid redund

D26122: Add utility text function KShell::tildeCollapse

meven updated this revision to Diff 73386. meven added a comment. Update KF5 version in @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=71898&id=73386 BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 AFFECT

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26617 To: meven, ervin, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven added a comment. 1771412c7cf8a8d07af4fe2687e2a698e409d73b introduced the instanciation of a KService for a created service, only when it was not associated to a mimetype. REPOSITORY R241 KIO REVISION DETAIL

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26617 AFFECTE

D26595: Add network-wireless-hotspot icon

meven added a dependent revision: D26392: Add option to easily configure and start a hotspot. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:213 > Move result of method call into local const variable. The usual > range-for-detaches problem. > > Can you call mimeTypes() instead of serviceTypes() here? I'm trying to slowly > split the two notions, af

D23420: Use solid to check if a KFileItem is located on a network mount

meven abandoned this revision. meven added a comment. Abandoned in favor of D26407 using KMountPoint which does close to the same thing as solid. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73282. meven marked 2 inline comments as done. meven added a comment. Move static variables to KFileItemPrivate::getMountPoints REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73261&id=73282 BRANCH arcpatch-D26407

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven retitled this revision from "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs" to "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73261. meven added a comment. remove a commo in comment, fix @since version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73260&id=73261 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D2640

<    1   2   3   4   5   6   7   8   9   10   >