Re: Review Request 124306: Don't choke on empty QIconItem

> On jul 9, 2015, 2:22 p.m., Mark Gaiser wrote: > > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp, line 138 > > <https://git.reviewboard.kde.org/r/124306/diff/1/?file=383903#file383903line138> > > > > (nitpick) a missing sace. >

Re: Review Request 124306: Don't choke on empty QIconItem

) <https://git.reviewboard.kde.org/r/124306/#comment56650> (nitpick) a missing sace. img = m_... +1 - Mark Gaiser On jul 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

On jul 7, 2015, 7:38 p.m., Martin Klapetek wrote: > > I'm looking at the KNotifications dependency graph here [1] and see that > > KWindowSystem is only required for KCrash. > > So err, can't that one go as well since you removed KService which required > > KCrash which then required KWindowSys

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

doesn't give me that impression. [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/knotifications/html/knotifications-dependencies.html - Mark Gaiser On jul 7, 2015, 7 p.m., Martin Klapetek wrote: > > --- > This i

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review81992 --- A big +1! I like it :) - Mark Gaiser On jul 2, 2015, 12:14

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

} I'm not quite sure though.. I hope someone else can step in since i'm not quite sure if my second comment is correct. - Mark Gaiser On jun 19, 2015, 5:04 p.m., Vishesh Handa wrote: > > --- > This is a

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

:) autotests/krearrangecolumnsproxymodeltest.cpp (line 90) <https://git.reviewboard.kde.org/r/124156/#comment56037> empty line can be removed between the comment and the QCOMPARE... - Mark Gaiser On jun 23, 2015, 9:33 p.m., David Faure

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

I'm writing this for right now, see FatCRM on github) > (*), and only in a possible third case there would be a need for separating > reordering and hiding... > > (*) this reminds me, I wanted to add docu about how to replicate what > QHeaderView does, using this prox

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

> On jun 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 71 > > <https://git.reviewboard.kde.org/r/124156/diff/1/?file=381182#file381182line71> > > > > add line break > > David Faure wrote: > Where, between m

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81704 --- +1 - Mark Gaiser On jun 23, 2015, 12:04 p.m., Martin

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

ool isColumnVisible(int column) Adding the above functionality would make it much more convenient to use in cases where you want to hide/show a column on the fly. - Mark Gaiser On jun 23, 2015, 11:33 a.m., David Faure wrote: > > --

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

tatusnotifieritem.cpp (line 477) <https://git.reviewboard.kde.org/r/124155/#comment56016> ... &name) const Just minor nitpicks. - Mark Gaiser On jun 23, 2015, 10:16 a.m., Martin Klapetek wrote: > > --- > This is an

Re: Review Request 123946: Add api to disable plot grid lines

addition seems wrong to me. It's called "drawHorizontalGrid" now. That's just wrong. A grid isn't horizontal or vertical, it's a grid (it contains both horizontal and vertical lines). A better naming would probably be: drawHorizontalLines or: drawHorizontalGridLines -

Re: Review Request 120267: Don't run kioexec if we are already running it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120267/#review80473 --- Any update on this issue? - Mark Gaiser On okt 4, 2014, 12

Re: Review Request 123735: version of QmlObject with a static engine

c const QQmlEngine ... Prevents changing the pointer later on. src/kdeclarative/qmlobjectsharedengine.cpp (line 75) <https://git.reviewboard.kde.org/r/123735/#comment55049> remove if you decide to use a smart pointer for this one. - Mark Gaiser On mei 12, 2015, 4:12

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80225 --- +1 - Mark Gaiser On mei 11, 2015, 4:55 p.m., Michael

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

> On mei 10, 2015, 10:43 p.m., David Faure wrote: > > src/core/kfileitem.cpp, line 1115 > > > > > > I had the same thought as Milian... but I wonder why I wrote that > > comment. m_strText is the displayName, m

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

eviewboard.kde.org/r/123654/#comment55020> Why change this? The changes in KDirSortFilterProxyModel seem unrelated to the performance improvements in KFileItem. I think it would be best to split them in two seperate RR'

Re: Opinions on KIO Slave side sorting? Possible GSoC project?

On Sun, May 3, 2015 at 12:44 AM, David Faure wrote: > On Thursday 08 January 2015 10:45:13 Mark Gaiser wrote: > > (wow, time flies) > > > The issue i see here is different processes. KIO::listDir is a process, > > KDirListerCache lives in the client process. > >

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

a timely manner. - Mark Gaiser On apr 28, 2015, 8:43 p.m., Lindsay Roberts wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

have an if just a couple lines higher that sends data if there is remaining data. Should this be needed at all? In general i like this idea. So a +1 for the idea, that's not a real +1 :) - Mark Gaiser On apr 29, 2015, 4:28 p.m., Aleix Pol Gonzalez wrote: > > ---

Review Request 123544: kioclient ls: properly construct QUrl.

t; to work again. Again because it worked in the kdelibs version thus this was a regression. Diffs - kioclient/kioclient.cpp 74c9985 Diff: https://git.reviewboard.kde.org/r/123544/diff/ Testing --- kioclient ls works. No need to prefix the path with "file://" anymore.

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79611 --- Could you make a testcase for this? - Mark Gaiser On apr

Re: New framework: KF5Syndication

On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil wrote: > Hi all, > > I'd like to ask for review of another Framework from kdepimlibs: > KF5Syndication > > KF5Syndication is an RSS/Atom parsing library. It also provides API to > fetch > feeds directly from network. > > It's a Tier 3 Framework (depe

Re: Review Request 123101: Only add "/" to path if really necessary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/#review77923 --- +1 - Mark Gaiser On March 22, 2015, 6:05 p.m., Àlex

Re: KF 5.8 changelog

On Fri, Mar 13, 2015 at 4:05 PM, Marco Martin wrote: > On Friday 13 March 2015 10:12:24 David Faure wrote: > > The goal of the CHANGELOG line is to describe the change from the point > of > > view of a developer using the framework, or from the point of view of a > user > > running this code, whi

Re: kio and scheme://

On Sun, Feb 15, 2015 at 8:00 PM, Àlex Fiestas wrote: > On Tuesday 04 November 2014 21:47:36 you wrote: > > On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > > > Hi there > > > > > > There are quite a few places where the following code is found: > > > > > > if (!url.path().endsWith('/'))

Re: KDE Frameworks Sprint

On Thu, Feb 5, 2015 at 7:44 PM, Albert Astals Cid wrote: > El Dimecres, 4 de febrer de 2015, a les 01:33:00, Aleix Pol va escriure: > > Hello, > > Do we want a KDE Frameworks sprint? > > I think it's a great idea. > > > > > I think it could be interesting, at least to recapitulate about the > > f

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review75726 --- +1 - Mark Gaiser On feb 9, 2015, 5:51 p.m., Àlex Fiestas

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

rsions. Cheers [1] http://qt-project.org/wiki/Qt_Coding_Style [2] https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 - Mark Gaiser On Feb. 8, 2015, 11:12 p.m., Jeremy Whiting wrote: > > ---

Re: Review Request 122438: Notiy config leak fix try 2

g/r/122438/#comment52186> Why wait? You can do that now and deprecate this function, right? You just can't remove it till KF6. Same for the other TODO lines you added. - Mark Gaiser On feb 5, 2015, 9:43 a.m., Xuetian

Re: KDE Frameworks Sprint

On Wed, Feb 4, 2015 at 1:33 AM, Aleix Pol wrote: > Hello, > Do we want a KDE Frameworks sprint? > > I think it could be interesting, at least to recapitulate about the > first year of KF5, find what we liked and decide how to keep going. > > Who would be interested? > Me :) I would definitely at

Change in kio[master]: Change how UDSEntry load and save parsing is handled.

Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/352 Change subject: Change how UDSEntry load and save parsing is handled. .. Change how UDSEntry load and save parsing is handled. This

Change in kio[master]: Add listFieldsVecor method.

Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/350 Change subject: Add listFieldsVecor method. .. Add listFieldsVecor method. Internally we store the fields in a QVecotr, but we where

Change in kio[master]: UDSEntry documentation fix.

Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/349 Change subject: UDSEntry documentation fix. .. UDSEntry documentation fix. Change-Id: I57151f76bf086b7d8108391c97dbdaf548e41251 --- M

Change in kio[master]: WIP! Adding SlaveBase newEntry and insertEntryProperty for b...

Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/348 Change subject: WIP! Adding SlaveBase newEntry and insertEntryProperty for big speed improvement in listDir calls. .. WIP! Adding

Re: reviving make uninstall?

On Thu, Jan 29, 2015 at 12:46 PM, Sebastian Kügler wrote: > On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote: > > > It's only used by developers anyways, so why bother? If it makes life > > > simpler > > > for devs, it should be there, no? Normal users who might get confused > by > >

Re: Opinions on KIO Slave side sorting? Possible GSoC project?

On Thu, Jan 8, 2015 at 9:14 AM, David Faure wrote: > On Sunday 04 January 2015 21:37:21 Mark Gaiser wrote: > > Hi, > > > > I was reading back an mailing list thread i started about half a year ago > > [1]. Later on in that thread Aaron suggested a cool idea of

Opinions on KIO Slave side sorting? Possible GSoC project?

Hi, I was reading back an mailing list thread i started about half a year ago [1]. Later on in that thread Aaron suggested a cool idea of "slave side" sorting [2]. At that time i found it cool, but didn't really see a need for it. Dolphin is doing a fine job at sorting anyway, so why would we bot

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

/git.reviewboard.kde.org/r/121747/#comment50680> Coding style. Looks like i owe you a big sorry. Much (or all?) of those coding style issues seem to introduced by... me... Anyhow, looks OK to me. - Mark Gaiser On dec 29,

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

> On dec 11, 2014, 2:27 p.m., Mark Gaiser wrote: > > src/core/kfileitem.cpp, line 255 > > <https://git.reviewboard.kde.org/r/121447/diff/1/?file=332652#file332652line255> > > > > --> add here > > > > } else { > > // Fix f

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

written in comment box :) I think that's about all you'd need to fix this. But if this is accaptable is probably up to David to decide. I'm also not 100% sure that you catch all cases when readUDSEntry(). - Mark Gaiser On dec 11, 2014, 1:22 p.m., Àlex

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

ve + append? Yes, the former will be > faster, but afaik only slightly. Please write a proper benchmark with > QBENCHMARK and use `-perf -perfcounter instr:k`, instead of a bogus QTimer. > Also, you sure this was compiled with optimizations enabled? > > Furthermore, thi

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

On Dec. 10, 2014, 7:40 p.m., Frank Reininghaus wrote: > > As for all the appends that you do on a QVector, you might be able to speed > > them up significantly if you know the size (which you do). > > The reason for that potential speedup is append doing some stuff to > > determine if it can ap

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

y win speed with this in the avarage usecase. Note: for this optimization you have to use "resize" on the QVector, not "reserve". Disclaimer: i know this is most deffinately a micro optimization, but it's fun to play with options

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

tudio since the 2010 release: http://msdn.microsoft.com/en-us/library/vstudio/dd465215%28v=vs.100%29.aspx - Mark Gaiser On nov 30, 2014, 2:11 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. T

Re: [RFC] [kservice] KPluginMetadata indexing

On Thu, Nov 6, 2014 at 4:43 PM, Sebastian Kügler wrote: > On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: >> I'm curious about one thing. Have you done some profiling on the >> current KPluginMetaData to see where the actual hot spot is? >> In case you don&#

Re: [RFC] [kservice] KPluginMetadata indexing

On Thu, Nov 6, 2014 at 3:44 AM, Sebastian Kügler wrote: > Hi all, especially Alex and David, > > tl;dr: > I've done a proof-of-concept implementation of a metadata index for > KPluginTrader::query(), the main entry point when it comes to finding binary > plugins. This index considerably speeds up

Re: OSX/CI: kio-extras builds to fail on branch master

On Sun, Nov 2, 2014 at 8:59 PM, Marko Käning wrote: > Any news on this one??? > > > On 22 Oct 2014, at 00:10 , Marko Käning wrote: > >> On Linux kio-extras seems to build fine, but it doesn’t on OSX: >> >> --- >> >> [92%] Building C object nfs/CMakeFiles/kio_nfs.dir/rpc_nfs3_prot_xdr.c.o >> /User

Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

> On okt 31, 2014, 8:52 a.m., David Faure wrote: > > Hmm, not sure which change in KFileItem you're referring to. But maybe this > > is the change from KMimeType (which used a mode_t argument) to QMimeType > > (which doesn't). We could add some logic in KFileItem to preserve behavior > > compa

Re: Review Request 120508: Port kio_trash_win to KF5

> On okt 5, 2014, 9:19 p.m., Mark Gaiser wrote: > > Could you port the listEntry calls as well? The current port will give > > warnings about that. > > > > All calls with: > > listEntry( entry, false ); > > > > can be replaced with: &g

Re: Review Request 120508: Port kio_trash_win to KF5

will give warnings about that. All calls with: listEntry( entry, false ); can be replaced with: listEntry( entry ); All calls with: listEntry( entry, true ); <-- note the "true" can be removed. - Mark Gaiser On okt 5, 2014, 7:35 p.m., Nicolás

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

. Someone else should give the final ship it since i don't know the consequences it could have. - Mark Gaiser On sep 23, 2014, 8:36 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

> On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

> On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644

Re: Review Request 120208: Link to setWindowModified documentation

g/r/120208/#comment46359> Nitpick: Don't forget the missing period :) - Mark Gaiser On sep 14, 2014, 9:23 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

> On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

ks with the current test cases and those two that Arjun added. - Mark Gaiser On sep 11, 2014, 8:50 a.m., Arjun Ak wrote: > > --- > This is an automatically genera

Re: There's no proper replacement for KIcon

On Wed, Sep 3, 2014 at 10:01 PM, Albert Astals Cid wrote: > El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va escriure: >> On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: >> > Porting guide lies in saying that KIcon should be replaced with >>

Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

as well: emitSignal(QLatin1String("FilesChanged"), QVariantList() << QUrl::toStringList(fileList)); (note the lack of QVariant()) Make sure that works though :) - Mark Gaiser On sep 3, 2014, 4:30 p.m., Vishesh Handa wrote: > >

Re: There's no proper replacement for KIcon

On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: > Porting guide lies in saying that KIcon should be replaced with > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > QIcon::fromTheme doesn't do that. > > Please someone provide a solution for this problem or undepr

Re: Compression of SVG(Z)s in git repositories

On Wed, Sep 3, 2014 at 1:35 PM, Sebastian Kügler wrote: > On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: >> On 09/02/2014 12:48 PM, Martin Gräßlin wrote: >> > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: >> >> On Monday, September 01, 2014 12:59:04 Elias Probst wrote:

braindump: Node.js interface to create kio slaves? (perhaps for gsoc 2015?)

Hi, disclaimer: this is just an idea that might be nice to have in the future. I don't want to make this, i merely had the idea which i want to put out in the open. Perhaps this can evolve into a nice gsoc project for 2015? A few days ago i thought: "hmm, i would like to access my google drive fr

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

g/r/119809/#comment45224> Copy paste error? You miss: @param urls ... (seems to be the current @param) @param flags ... @return ... - Mark Gaiser On aug 16, 2014, 10:40 p.m., David Faure wrote: > > ---

Re: How to promote less mature Frameworks?

On Fri, Aug 15, 2014 at 12:12 AM, Àlex Fiestas wrote: > Hi there > > At the Randa sprint we have discussed a little bit what to do with those > frameworks that are still not mature (for example they can't commit on ABI/API > stability) but they are ready for feedback from third party developers. >

Re: Breeze widget style for KF5

On Mon, Aug 11, 2014 at 12:29 PM, Hugo Pereira Da Costa wrote: > Hi all, > For the last couple of weeks and after discussion with Nuno, Marco, Andrew > and some others, I've worked on implementing most of the ideas from > git://anongit.kde.org/breeze.git (more precisely from the QML demos at > wid

Re: KDE Frameworks 2014 Sprint Dot Article missing

On Fri, Aug 8, 2014 at 9:23 PM, Albert Astals Cid wrote: > El Dilluns, 28 de juliol de 2014, a les 00:48:54, Albert Astals Cid va > escriure: >> Hi guys, please note that the Dot Article of the KDE Frameworks 2014 Sprint >> is missing. >> >> Can someone of the guys that was there write something?

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

tps://git.reviewboard.kde.org/r/119336/#comment43435> Why a timer? Just call doUpdate.. - Mark Gaiser On jul 17, 2014, 8:17 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

> On jul 13, 2014, 11:17 a.m., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > <https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72> > > > > I'm not sure if this is the correct approach either. > > >

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62298 --- Ship it! Ship It! - Mark Gaiser On jul 13, 2014, 8:35 a.m

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

ve more stat calls in this function. Something we should try to prevent. 3. This version and add a new constructor that takes a QFileInfo object - my preference. ... I think we need to wait for David' opinion on this. If David is OK with point 3 then i will create a patch + test

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

> On jul 5, 2014, 11:28 a.m., Mark Gaiser wrote: > > src/kmimetypechooser.cpp, line 64 > > <https://git.reviewboard.kde.org/r/119126/diff/1/?file=287325#file287325line64> > > > > static const QString s_keditfiletypeExecutable = > > QStringLiteral("

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

g/r/119126/#comment42894> static const QString s_keditfiletypeExecutable = QStringLiteral("keditfiletype5"); Then you can just use s_keditfiletypeExecutable directly instead of QString::fromLatin1... which makes the arguments a bit shorter - Mark Gaiser On July 5,

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

> On June 27, 2014, 11:47 p.m., Mark Gaiser wrote: > > src/core/ksharedconfig.cpp, line 91 > > <https://git.reviewboard.kde.org/r/118985/diff/1/?file=285018#file285018line91> > > > > -- slightly unrelated since it wasn't there befo

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

f it's false and isTestModeEnabled is true. Fine, but it's never set back to false again. I don't know if it's an issue at all.. Just something i noticed. The same for the "userWarned" a few lines down. - Mark Gaiser O

Re: kdesrc-build not honoring

On Sat, Jun 7, 2014 at 10:23 PM, David Faure wrote: > On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: >> Hi, >> >> In my kdesrc-buildrc i have: >> global >> ... >> cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo >>

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Re: kdesrc-build not honoring

On Sat, Jun 7, 2014 at 9:40 PM, Mark Gaiser wrote: > Hi, > > In my kdesrc-buildrc i have: > global > ... > cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo > ... > end global > > I use that to compile frameworks. However,

kdesrc-build not honoring

Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets: CMAKE_BUILD_TYPE:STRING=debug So it looks like the above cmake-options line is not b

Re: KIO directory listing - CPU slows down SSD

On Fri, Jun 6, 2014 at 11:10 AM, Aaron J. Seigo wrote: > On Monday, June 2, 2014 20:54:11 Mark Gaiser wrote: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >> > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> >> On Thu, May 29, 2014 at 12:21 AM

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59256 --- Ship it! Makes sense and looks nice! - Mark Gaiser On

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 11:47 PM, Frank Reininghaus wrote: > Hi, > > 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: >> Hi, >> >> 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >>> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >>>> On Thursday, May 29

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 11:39 PM, Frank Reininghaus wrote: > Hi, > > 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >>> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >>>> dolphin on a massive folder. In f

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo >> It's just a hobby for me to optimize it to levels that match raw speed >> (without any KIO). > &g

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

s) or QVector (as it is with this patch). Lookups would then only be required for custom fields. I'm not sure if my changes still make sense after this change lands. I will just have to do some benchmarks and see if the added complexity is worth it. - Mark Gaiser On June 1, 2014, 1:50 p

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

happy. I think this is the way to go and let the GUI format the number how it wants to display it. +1 from me. - Mark Gaiser On May 29, 2014, 5 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. T

Re: KIO directory listing - CPU slows down SSD

On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo wrote: > On Wednesday, May 28, 2014 21:12:43 Mark Gaiser wrote: >> You've written that with the assumption of backwards compatibility. >> It's a nice idea, but why should we even try to remain backwards >> compati

Re: Review Request 118389: Fix Compile for kio/src/core/udsentry.cpp on Mac

ill compile just fine under mac/linux. And if that's the case then i'm very sorry that i didn't spot this when making the constructor. - Mark Gaiser On May 29, 2014, 12:52 p.m., Allen Winter wrote: > > --- > This i

Re: KIO directory listing - CPU slows down SSD

On Wed, May 28, 2014 at 7:33 PM, Aaron J. Seigo wrote: > On Wednesday, May 28, 2014 16:23:31 Mark Gaiser wrote: >> On Wed, May 28, 2014 at 9:59 AM, David Faure wrote: >> > On Wednesday 14 May 2014 12:50:18 Aaron J. Seigo wrote: >> >> * one entry at a time, seria

Re: KIO directory listing - CPU slows down SSD

On Wed, May 28, 2014 at 9:59 AM, David Faure wrote: > On Wednesday 14 May 2014 12:50:18 Aaron J. Seigo wrote: >> * one entry at a time, serialized >> * no changing data once put there >> * no getting the data back out >> >> the class would then just batch up data into its QByteArray and then shunt

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

I looked at this issue and it is introduced by commit: 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. Belonging to this review request: https://git.reviewboard.kde.org/r/118039/ It removes readCheck and writeCheck. I don't know what the intended fix would be for kdelibs4support which impleme

Re: Review Request 118289: Change titlewidget from bold to increased font size

ce it doesn't seem to add much info. You select the "Fonts" in the left menu anyway so it is common sense that you get " settings" in the right pane.. But that's just my opinion for that :) - Mark Gaiser On May 24, 2014, 12:10 a.m., Sebastian Kügler wro

Re: KIO directory listing - CPU slows down SSD

On Wed, May 14, 2014 at 3:31 PM, Mark Gaiser wrote: > On Wed, May 14, 2014 at 12:50 PM, Aaron J. Seigo wrote: >> On Sunday, May 11, 2014 21:57:58 Mark Gaiser wrote: >>> Note: my recent incremental cleanups already made it about a second >>> faster then it used to be. I

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

> On May 14, 2014, 2:13 p.m., Mark Gaiser wrote: > > Ehh.. > > > > Does this mean that there is no way to get the actual byte size anymore? > > > > In that case i think it would be better to introduce a new role: > > "HumanReadableSize" which

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

n the byte version where the view formats it to whatever it wants. This also eases sorting. - Mark Gaiser On May 14, 2014, 2:01 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To re

Re: KIOAccessManagerFactory and QtQuick2

On Wed, May 14, 2014 at 12:09 PM, Marco Martin wrote: > On Tuesday 13 May 2014 18:31:06 Aleix Pol wrote: >> Hi, >> I've been getting some error messages [1] from some QML applications and I >> decided to investigate a bit further. I realized then that most of it was >> coming from the KIOAccessMan

Re: KIO directory listing - CPU slows down SSD

On Wed, May 14, 2014 at 12:50 PM, Aaron J. Seigo wrote: > On Sunday, May 11, 2014 21:57:58 Mark Gaiser wrote: >> Note: my recent incremental cleanups already made it about a second >> faster then it used to be. It used to be around 5.500ms. However, the >> current speed is

Re: KIO directory listing - CPU slows down SSD

On Mon, May 12, 2014 at 1:09 PM, Milian Wolff wrote: > On Monday 12 May 2014 12:34:33 Mark Gaiser wrote: >> On Mon, May 12, 2014 at 10:55 AM, David Faure wrote: >> > On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: >> >> My theoretical solution (and i really ho

Re: KIO directory listing - CPU slows down SSD

On Mon, May 12, 2014 at 10:55 AM, David Faure wrote: > On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: >> My theoretical solution (and i really hope to get feedback on this) is >> to introduce a worker thread in slavebase.cpp. > > First feedback: threads create complexity

Re: KIO directory listing - CPU slows down SSD

On Sun, May 11, 2014 at 10:22 PM, Frank Reininghaus wrote: > Hi Mark, > > 2014-05-11 21:57 GMT+02:00 Mark Gaiser: >> Hi, >> >> I've been playing with KIO speed improvements for quite a while now >> and found some very interesting issues with KIO in combinat

<    1   2   3   4   >